90034 2012-06-26 18:15:07 -0700 Optimize mappings of simple transforms in RenderGeometryMap 2012-06-26 18:31:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin eric koivisto simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 658197 0 simon.fraser 2012-06-26 18:15:07 -0700 We can fall back to simple offsets for transforms that are just translations in RenderGeometryMap, which can be much faster. 658199 1 webkit-bug-importer 2012-06-26 18:16:01 -0700 <rdar://problem/11755979> 658204 2 149657 simon.fraser 2012-06-26 18:23:33 -0700 Created attachment 149657 Patch 658207 3 149657 dino 2012-06-26 18:27:12 -0700 Comment on attachment 149657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149657&action=review > Source/WebCore/ChangeLog:10 > + treat then as offsets. typo: them 658214 4 simon.fraser 2012-06-26 18:31:44 -0700 http://trac.webkit.org/changeset/121306 149657 2012-06-26 18:23:33 -0700 2012-06-26 18:27:12 -0700 Patch bug-90034-20120626182333.patch text/plain 2714 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFjMGZiOTk4NDBiMmQ0 YWNlNGNmNmI3ZmU4YjEzN2NmMWU1OWRmNy4uMmZkM2NjYTBhNDJmNDcyYjhjZjE1NDEwMzdlMjU1 YTM2ODg1YzkzYSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA2LTI2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE9wdGltaXplIG1h cHBpbmdzIG9mIHNpbXBsZSB0cmFuc2Zvcm1zIGluIFJlbmRlckdlb21ldHJ5TWFwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDAzNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRm9yIHRyYW5z Zm9ybXMgdGhhdCBhcmUgaWRlbnRpdHkgb3Igc2ltcGxlIHRyYW5zbGF0aW9ucywgZG9uJ3QKKyAg ICAgICAgZmFsbCBvZmYgdGhlIGZhc3QgcGF0aCBpbiBSZW5kZXJHZW9tZXRyeU1hcDsgd2UgY2Fu IGp1c3QKKyAgICAgICAgdHJlYXQgdGhlbiBhcyBvZmZzZXRzLgorICAgICAgICAKKyAgICAgICAg SW1wcm92ZXMgcGVyZm9ybWFuY2Ugb24gcGFnZXMgd2l0aCBsb3RzIG9mIHRyYW5zbGF0ZVooMCkg ZWxlbWVudHMuCisgICAgICAgIAorICAgICAgICBSZW1vdmUgUmVuZGVyR2VvbWV0cnlNYXBTdGVw OjptYXBQb2ludCgpIGFuZCBtYXBRdWFkKCksIHdoaWNoCisgICAgICAgIHdlcmUgdW51c2VkLgor CisgICAgICAgIE5vIG5ldyB0ZXN0czsgb3B0aW1pemF0aW9uIG9ubHksIGFuZCB0ZXN0ZWQgYnkg YXNzZXJ0aW9ucy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJHZW9tZXRyeU1hcC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHZW9tZXRyeU1hcDo6cHVzaCk6CisKIDIwMTItMDYt MjYgIERhdmUgVGhhcnAgIDxkdGhhcnBAY29kZWF1cm9yYS5vcmc+CiAKICAgICAgICAgaWV0ZXN0 Y2VudGVyL2NzczMvdmFsdWVzYW5kdW5pdHMvdW5pdHMtMDAwLmh0bSBhc3NlcnRzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR2VvbWV0cnlNYXAuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdlb21ldHJ5TWFwLmNwcAppbmRleCBhZjE5YmE0 ZTJmNTQ0MjMwNzMyZjYzMTg3ZWYzOGQ3N2M2Y2VjZjU2Li5hMWY1MGVkMzMzMzBkNTA1MGU2NDY3 YWU3MDdkOTI3MWNkNzQ5M2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyR2VvbWV0cnlNYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJHZW9tZXRyeU1hcC5jcHAKQEAgLTQ2LDI1ICs0Niw2IEBAIHB1YmxpYzoKICAgICB7CiAgICAg fQogICAgICAgICAKLSAgICBGbG9hdFBvaW50IG1hcFBvaW50KGNvbnN0IEZsb2F0UG9pbnQmIHAp IGNvbnN0Ci0gICAgewotICAgICAgICBpZiAoIW1fdHJhbnNmb3JtKQotICAgICAgICAgICAgcmV0 dXJuIHAgKyBtX29mZnNldDsKLSAgICAgICAgCi0gICAgICAgIHJldHVybiBtX3RyYW5zZm9ybS0+ bWFwUG9pbnQocCk7Ci0gICAgfQotICAgIAotICAgIEZsb2F0UXVhZCBtYXBRdWFkKGNvbnN0IEZs b2F0UXVhZCYgcXVhZCkgY29uc3QKLSAgICB7Ci0gICAgICAgIGlmICghbV90cmFuc2Zvcm0pIHsK LSAgICAgICAgICAgIEZsb2F0UXVhZCBxID0gcXVhZDsKLSAgICAgICAgICAgIHEubW92ZShtX29m ZnNldCk7Ci0gICAgICAgICAgICByZXR1cm4gcTsKLSAgICAgICAgfQotICAgICAgICAKLSAgICAg ICAgcmV0dXJuIG1fdHJhbnNmb3JtLT5tYXBRdWFkKHF1YWQpOwotICAgIH0KLSAgICAKICAgICBj b25zdCBSZW5kZXJPYmplY3QqIG1fcmVuZGVyZXI7CiAgICAgTGF5b3V0U2l6ZSBtX29mZnNldDsK ICAgICBPd25QdHI8VHJhbnNmb3JtYXRpb25NYXRyaXg+IG1fdHJhbnNmb3JtOyAvLyBJbmNsdWRl cyBvZmZzZXQgaWYgbm9uLW51bGwuCkBAIC0yMTYsOCArMTk3LDExIEBAIHZvaWQgUmVuZGVyR2Vv bWV0cnlNYXA6OnB1c2goY29uc3QgUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgY29uc3QgVHJhbnNm b3JtYXRpb25NCiAgICAgQVNTRVJUKG1faW5zZXJ0aW9uUG9zaXRpb24gIT0gbm90Rm91bmQpOwog CiAgICAgT3duUHRyPFJlbmRlckdlb21ldHJ5TWFwU3RlcD4gc3RlcCA9IGFkb3B0UHRyKG5ldyBS ZW5kZXJHZW9tZXRyeU1hcFN0ZXAocmVuZGVyZXIsIGFjY3VtdWxhdGluZ1RyYW5zZm9ybSwgaXNO b25Vbmlmb3JtLCBpc0ZpeGVkUG9zaXRpb24sIGhhc1RyYW5zZm9ybSkpOwotICAgIHN0ZXAtPm1f dHJhbnNmb3JtID0gYWRvcHRQdHIobmV3IFRyYW5zZm9ybWF0aW9uTWF0cml4KHQpKTsKLQorICAg IGlmICghdC5pc0ludGVnZXJUcmFuc2xhdGlvbigpKQorICAgICAgICBzdGVwLT5tX3RyYW5zZm9y bSA9IGFkb3B0UHRyKG5ldyBUcmFuc2Zvcm1hdGlvbk1hdHJpeCh0KSk7CisgICAgZWxzZQorICAg ICAgICBzdGVwLT5tX29mZnNldCA9IExheW91dFNpemUodC5lKCksIHQuZigpKTsKKyAgICAKICAg ICBzdGVwSW5zZXJ0ZWQoKnN0ZXAuZ2V0KCkpOwogICAgIG1fbWFwcGluZy5pbnNlcnQobV9pbnNl cnRpb25Qb3NpdGlvbiwgc3RlcC5yZWxlYXNlKCkpOwogfQo=