90029 2012-06-26 17:35:04 -0700 [Chromium] Remove unused build scripts and empty folders for JavaScriptCore w/ gyp 2012-06-27 02:44:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dominicc dominicc abarth webkit.review.bot oldest_to_newest 658151 0 dominicc 2012-06-26 17:35:04 -0700 It seems r119921 (see bug 88510) left Source/WebCore/gyp empty; the folder should be removed. Scripts in Source/JavaScriptCore/gyp appear to be unused and could be removed too. 658163 1 149647 dominicc 2012-06-26 17:42:34 -0700 Created attachment 149647 Patch 658185 2 abarth 2012-06-26 18:02:15 -0700 Thanks. 658269 3 149647 webkit.review.bot 2012-06-26 19:39:18 -0700 Comment on attachment 149647 Patch Rejecting attachment 149647 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: riptCore/gyp/update-info-plist.sh, which does not exist! Applying it anyway. patching file Source/JavaScriptCore/gyp/update-info-plist.sh Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/gyp/update-info-plist.sh.rej patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13087733 658280 4 dominicc 2012-06-26 19:59:35 -0700 I will land this manually. 658501 5 dominicc 2012-06-27 02:44:52 -0700 Committed r121334: <http://trac.webkit.org/changeset/121334> 149647 2012-06-26 17:42:34 -0700 2012-06-26 19:39:18 -0700 Patch bug-90029-20120627094237.patch text/plain 5201 dominicc SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxMzA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA2LTI2ICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSB1bnVzZWQgYnVpbGQgc2NyaXB0cyBhbmQgZW1wdHkg Zm9sZGVycyBmb3IgSmF2YVNjcmlwdENvcmUgdy8gZ3lwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDAyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3lwOiBSZW1vdmVkLgorICAgICAgICAqIGd5cC9n ZW5lcmF0ZS1kZXJpdmVkLXNvdXJjZXMuc2g6IFJlbW92ZWQuCisgICAgICAgICogZ3lwL2dlbmVy YXRlLWR0cmFjZS1oZWFkZXIuc2g6IFJlbW92ZWQuCisgICAgICAgICogZ3lwL3J1bi1pZi1leGlz dHMuc2g6IFJlbW92ZWQuCisgICAgICAgICogZ3lwL3VwZGF0ZS1pbmZvLXBsaXN0LnNoOiBSZW1v dmVkLgorCiAyMDEyLTA2LTI2ICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIFtC bGFja0JlcnJ5XSBBZGQgSlNDIHN0YXRpc3RpY3MgaW50byBhYm91dDptZW1vcnkKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvdXBkYXRlLWluZm8tcGxpc3Quc2gKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC91cGRhdGUtaW5mby1wbGlzdC5zaAkocmV2aXNp b24gMTIxMzAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC91cGRhdGUtaW5mby1wbGlz dC5zaAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICswLDAgQEAKLSMgVG91Y2ggSW5mby5wbGlzdCB0 byBsZXQgWGNvZGUga25vdyBpdCBuZWVkcyB0byBjb3B5IGl0IGludG8gdGhlIGJ1aWx0IHByb2R1 Y3QKLWlmIFtbICIke0NPTkZJR1VSQVRJT059IiAhPSAiUHJvZHVjdGlvbiIgXV07IHRoZW4KLSAg ICB0b3VjaCAiJDEiOwotZmkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJh dGUtZGVyaXZlZC1zb3VyY2VzLnNoCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9neXAvZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoCShyZXZpc2lvbiAxMjEzMDMpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL2dlbmVyYXRlLWRlcml2ZWQtc291cmNlcy5zaAkod29y a2luZyBjb3B5KQpAQCAtMSw5ICswLDAgQEAKLSMhL2Jpbi9zaAotCi1ta2RpciAtcCAiJHtCVUlM VF9QUk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL2RvY3MiCi1jZCAi JHtCVUlMVF9QUk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlIgotCi0v YmluL2xuIC1zZmggIiR7U1JDUk9PVH0vLi4iIEphdmFTY3JpcHRDb3JlCi1leHBvcnQgSmF2YVNj cmlwdENvcmU9IkphdmFTY3JpcHRDb3JlIgotCi1tYWtlIC0tbm8tYnVpbHRpbi1ydWxlcyAtZiAi SmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJjZXMubWFrZSIgLWogYC91c3Ivc2Jpbi9zeXNjdGwg LW4gaHcubmNwdWAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvcnVuLWlmLWV4aXN0 cy5zaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL3J1bi1pZi1leGlz dHMuc2gJKHJldmlzaW9uIDEyMTMwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvcnVu LWlmLWV4aXN0cy5zaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICswLDAgQEAKLSMhL2Jpbi9zaAot Ci1pZiBbIC1mICQxIF07IHRoZW4KLSAgICAkMSB8fCBleGl0ICQ/OwotZmkKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gJ KHJldmlzaW9uIDEyMTMwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUt ZHRyYWNlLWhlYWRlci5zaAkod29ya2luZyBjb3B5KQpAQCAtMSw5ICswLDAgQEAKLSMhL2Jpbi9z aAotCi1UUkFDSU5HX0Q9IiQxL3J1bnRpbWUvVHJhY2luZy5kIjsKLVRSQUNJTkdfSD0iJEJVSUxU X1BST0RVQ1RTX0RJUi9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9UcmFjaW5nRHRyYWNl LmgiOwotCi1pZiBbWyAiJHtIQVZFX0RUUkFDRX0iID0gIjEiICYmICIke1RSQUNJTkdfRH0iIC1u dCAiJHtUUkFDSU5HX0h9IiBdXTsgdGhlbgotICAgIGR0cmFjZSAtaCAtbyAiJHtUUkFDSU5HX0h9 IiAtcyAiJHtUUkFDSU5HX0R9IjsKLWZpOwotCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Z3lwL2dlbmVyYXRlLWRlcml2ZWQtc291cmNlcy5zaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZ3lwL2dlbmVyYXRlLWRlcml2ZWQtc291cmNlcy5zaAkocmV2aXNpb24gMTIx MzAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9nZW5lcmF0ZS1kZXJpdmVkLXNvdXJj ZXMuc2gJKHdvcmtpbmcgY29weSkKQEAgLTEsOSArMCwwIEBACi0jIS9iaW4vc2gKLQotbWtkaXIg LXAgIiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9k b2NzIgotY2QgIiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0 Q29yZSIKLQotL2Jpbi9sbiAtc2ZoICIke1NSQ1JPT1R9Ly4uIiBKYXZhU2NyaXB0Q29yZQotZXhw b3J0IEphdmFTY3JpcHRDb3JlPSJKYXZhU2NyaXB0Q29yZSIKLQotbWFrZSAtLW5vLWJ1aWx0aW4t cnVsZXMgLWYgIkphdmFTY3JpcHRDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UiIC1qIGAvdXNyL3Ni aW4vc3lzY3RsIC1uIGh3Lm5jcHVgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL2dl bmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2d5cC9nZW5lcmF0ZS1kdHJhY2UtaGVhZGVyLnNoCShyZXZpc2lvbiAxMjEzMDMpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gJKHdvcmtp bmcgY29weSkKQEAgLTEsOSArMCwwIEBACi0jIS9iaW4vc2gKLQotVFJBQ0lOR19EPSIkMS9ydW50 aW1lL1RyYWNpbmcuZCI7Ci1UUkFDSU5HX0g9IiRCVUlMVF9QUk9EVUNUU19ESVIvRGVyaXZlZFNv dXJjZXMvSmF2YVNjcmlwdENvcmUvVHJhY2luZ0R0cmFjZS5oIjsKLQotaWYgW1sgIiR7SEFWRV9E VFJBQ0V9IiA9ICIxIiAmJiAiJHtUUkFDSU5HX0R9IiAtbnQgIiR7VFJBQ0lOR19IfSIgXV07IHRo ZW4KLSAgICBkdHJhY2UgLWggLW8gIiR7VFJBQ0lOR19IfSIgLXMgIiR7VFJBQ0lOR19EfSI7Ci1m aTsKLQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9ydW4taWYtZXhpc3RzLnNoCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvcnVuLWlmLWV4aXN0cy5zaAko cmV2aXNpb24gMTIxMzAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9ydW4taWYtZXhp c3RzLnNoCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzAsMCBAQAotIyEvYmluL3NoCi0KLWlmIFsg LWYgJDEgXTsgdGhlbgotICAgICQxIHx8IGV4aXQgJD87Ci1maQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2d5cC91cGRhdGUtaW5mby1wbGlzdC5zaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZ3lwL3VwZGF0ZS1pbmZvLXBsaXN0LnNoCShyZXZpc2lvbiAxMjEzMDMp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL3VwZGF0ZS1pbmZvLXBsaXN0LnNoCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDQgKzAsMCBAQAotIyBUb3VjaCBJbmZvLnBsaXN0IHRvIGxldCBYY29k ZSBrbm93IGl0IG5lZWRzIHRvIGNvcHkgaXQgaW50byB0aGUgYnVpbHQgcHJvZHVjdAotaWYgW1sg IiR7Q09ORklHVVJBVElPTn0iICE9ICJQcm9kdWN0aW9uIiBdXTsgdGhlbgotICAgIHRvdWNoICIk MSI7Ci1maQpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxMzA0KQorKysgU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMTItMDYtMjYg IERvbWluaWMgQ29vbmV5ICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJv bWl1bV0gUmVtb3ZlIHVudXNlZCBidWlsZCBzY3JpcHRzIGFuZCBlbXB0eSBmb2xkZXJzIGZvciBK YXZhU2NyaXB0Q29yZSB3LyBneXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkwMDI5CisKKyAgICAgICAgKiBneXA6IFJlbW92ZWQgZW1wdHkgZGlyLgor CiAyMDEyLTA2LTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IFN0b3AgY2FsbGluZyBub2RlKCkgYW5kIGRlcHJlY2F0ZWRFZGl0aW5nT2Zmc2V0KCkgaW4gY29t cGFyZVBvc2l0aW9ucwo=