90027 2012-06-26 17:02:58 -0700 Add support for preciseTime() to WebKitTestRunner 2012-06-26 18:38:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg fpizlo sam oldest_to_newest 658123 0 mhahnenberg 2012-06-26 17:02:58 -0700 It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree. 658146 1 149642 mhahnenberg 2012-06-26 17:27:23 -0700 Created attachment 149642 Patch 658179 2 149642 darin 2012-06-26 17:58:53 -0700 Comment on attachment 149642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149642&action=review > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:625 > + return JSValueMakeNumber(context, WTF::currentTime()); The WTF prefix should not be needed here. > Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:35 > + object preciseTime(); Don’t we have bindings for double? Why does this have to be done with a general purpose value? Clearly, the terminology is wrong, by the way, because the value will not be an object. 658225 3 mhahnenberg 2012-06-26 18:38:53 -0700 Committed r121308: <http://trac.webkit.org/changeset/121308> 149642 2012-06-26 17:27:23 -0700 2012-06-26 17:58:53 -0700 Patch bug-90027-20120626172722.patch text/plain 3275 mhahnenberg SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyMTMwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTA2LTI2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHByZWNpc2VUaW1lKCkgdG8gV2ViS2l0 VGVzdFJ1bm5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTAwMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJdCB3b3VsZCBiZSBuaWNlIHRvIGJlIGFibGUgdG8gdXNlIHByZWNpc2VUaW1lKCkgaW4gV2Vi S2l0VGVzdFJ1bm5lciBsaWtlIHdlIGNhbiBpbiBEdW1wUmVuZGVyVHJlZS4KKworICAgICAgICAq IFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvTGF5b3V0VGVzdENvbnRy b2xsZXIuaWRsOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5 b3V0VGVzdENvbnRyb2xsZXIuY3BwOiAKKyAgICAgICAgKFdUUjo6TGF5b3V0VGVzdENvbnRyb2xs ZXI6OnByZWNpc2VUaW1lKTogV2UgZ3JhYiB0aGUgY29udGV4dCBmcm9tIHRoZSBtYWluIGZyYW1l LCBidXQKKyAgICAgICAgdGhhdCBzaG91bGRuJ3QgbWF0dGVyIGJlY2F1c2UgdGhlIHRpbWUgc2hv dWxkIGJlIHRoZSBzYW1lIGZvciBhbGwgZnJhbWVzLgorICAgICAgICAoV1RSKToKKyAgICAgICAg KiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmg6 CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcik6CisKIDIwMTItMDYtMjYgIEx1Y2FzIEZv cnNjaGxlciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tPgogCiAgICAgICBUZWFjaCB0aGUgQXBwbGUg cG9ydCBob3cgdG8gYnVpbGQgdGhlIHRlc3QgdG9vbHMgaW4gYnVpbGQtd2Via2l0CkluZGV4OiBU b29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0xheW91dFRlc3RDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMTIxMzAyKQorKysgVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDcgQEAKICNpbmNsdWRlIDxXZWJLaXQyL1dLQnVuZGxl U2NyaXB0V29ybGQuaD4KICNpbmNsdWRlIDxXZWJLaXQyL1dLUmV0YWluUHRyLmg+CiAjaW5jbHVk ZSA8V2ViS2l0Mi9XZWJLaXQyLmg+CisjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAjaW5j bHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+ CiAKQEAgLTYxNyw0ICs2MTgsMTEgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6b3ZlcnJp ZGVQcmVmZQogICAgIFdLQnVuZGxlT3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZvclRlc3RSdW5uZXIo SW5qZWN0ZWRCdW5kbGU6OnNoYXJlZCgpLmJ1bmRsZSgpLCBJbmplY3RlZEJ1bmRsZTo6c2hhcmVk KCkucGFnZUdyb3VwKCksIHRvV0socHJlZmVyZW5jZSkuZ2V0KCksIHZhbHVlKTsKIH0KIAorSlNW YWx1ZVJlZiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6cHJlY2lzZVRpbWUoKQoreworICAgIFdLQnVu ZGxlRnJhbWVSZWYgbWFpbkZyYW1lID0gV0tCdW5kbGVQYWdlR2V0TWFpbkZyYW1lKEluamVjdGVk QnVuZGxlOjpzaGFyZWQoKS5wYWdlKCktPnBhZ2UoKSk7CisgICAgSlNDb250ZXh0UmVmIGNvbnRl eHQgPSBXS0J1bmRsZUZyYW1lR2V0SmF2YVNjcmlwdENvbnRleHQobWFpbkZyYW1lKTsKKyAgICBy ZXR1cm4gSlNWYWx1ZU1ha2VOdW1iZXIoY29udGV4dCwgV1RGOjpjdXJyZW50VGltZSgpKTsKK30K KwogfSAvLyBuYW1lc3BhY2UgV1RSCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCShyZXZp c2lvbiAxMjEzMDIpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xh eW91dFRlc3RDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDcgQEAgcHVi bGljOgogICAgIHZvaWQgZHVtcENoaWxkRnJhbWVzQXNUZXh0KCkgeyBtX3doYXRUb0R1bXAgPSBB bGxGcmFtZXNUZXh0OyB9CiAgICAgdm9pZCB3YWl0VW50aWxEb25lKCk7CiAgICAgdm9pZCBub3Rp ZnlEb25lKCk7CisgICAgSlNWYWx1ZVJlZiBwcmVjaXNlVGltZSgpOwogCiAgICAgLy8gT3RoZXIg ZHVtcGluZy4KICAgICB2b2lkIGR1bXBCYWNrRm9yd2FyZExpc3QoKSB7IG1fc2hvdWxkRHVtcEJh Y2tGb3J3YXJkTGlzdHNGb3JBbGxXaW5kb3dzID0gdHJ1ZTsgfQpJbmRleDogVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29udHJvbGxlci5p ZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9C aW5kaW5ncy9MYXlvdXRUZXN0Q29udHJvbGxlci5pZGwJKHJldmlzaW9uIDEyMTMwMikKKysrIFRv b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvTGF5b3V0VGVzdENv bnRyb2xsZXIuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2ICszMiw3IEBAIG1vZHVsZSBXVFIg ewogICAgICAgICB2b2lkIHdhaXRGb3JQb2xpY3lEZWxlZ2F0ZSgpOwogICAgICAgICB2b2lkIHdh aXRVbnRpbERvbmUoKTsKICAgICAgICAgdm9pZCBub3RpZnlEb25lKCk7CisgICAgICAgIG9iamVj dCBwcmVjaXNlVGltZSgpOwogCiAgICAgICAgIC8vIE90aGVyIGR1bXBpbmcuCiAgICAgICAgIHZv aWQgZHVtcEJhY2tGb3J3YXJkTGlzdCgpOwo=