90024 2012-06-26 16:20:48 -0700 Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test 2012-07-06 22:54:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa darin enrica ojan tony oldest_to_newest 658081 0 rniwa 2012-06-26 16:20:48 -0700 Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test 658083 1 149625 rniwa 2012-06-26 16:21:49 -0700 Created attachment 149625 Patch 658086 2 149625 darin 2012-06-26 16:28:33 -0700 Comment on attachment 149625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149625&action=review > LayoutTests/ChangeLog:8 > + Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way. Unfortunately this test no longer states what the expected result is. That’s a step backwards. Before the test would say PASS or FAIL. Now it just dumps out a tree and you have to know what the expected result is. 658087 3 darin 2012-06-26 16:29:09 -0700 For some reason bugzilla caused the patch to change to review? -- I did not intend to change that or remove Ojan’s review+, just add my comments. 658088 4 149625 darin 2012-06-26 16:29:36 -0700 Comment on attachment 149625 Patch Clearing the review flag. I did not intend to cancel out Ojan’s review+ although I do think there is a missing element to the test now. 658089 5 149625 rniwa 2012-06-26 16:29:59 -0700 Comment on attachment 149625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149625&action=review >> LayoutTests/ChangeLog:8 >> + Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way. > > Unfortunately this test no longer states what the expected result is. That’s a step backwards. Before the test would say PASS or FAIL. Now it just dumps out a tree and you have to know what the expected result is. Yeah, fixing that by improving the test description now. 658090 6 rniwa 2012-06-26 16:31:38 -0700 (In reply to comment #4) > (From update of attachment 149625 [details]) > Clearing the review flag. I did not intend to cancel out Ojan’s review+ although I do think there is a missing element to the test now. I'm revising the test description to "Tests that we don't serialize redundant font-size in typingStyle. There should be no span or style attribute around A or B below." 664341 7 rniwa 2012-07-06 22:54:40 -0700 Fixed in http://trac.webkit.org/changeset/121298. 149625 2012-06-26 16:21:49 -0700 2012-06-26 16:29:59 -0700 Patch bug-90024-20120626162642.patch text/plain 4887 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyMTI5NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTI2ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENvbnZlcnQgZWRpdGluZy9pbnNlcnRpbmcvZm9u dC1zaXplLWNsZWFycy1mcm9tLXR5cGluZy1zdHlsZS5odG1sIHRvIGEgZHVtcC1hcy1tYXJrdXAg dGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAw MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb252 ZXJ0ZWQgYSBzY3JpcHQgdGVzdCB0byBhIGR1bXAtYXMtbWFya3VwIHRlc3QgYmVjYXVzZSB0aGUg dGVzdCByZXN1bHQgY2FuIGJlIHVuZGVyc3Rvb2QgbXVjaCBlYWlzZXIgdGhhdCB3YXkuCisKKyAg ICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9mb250LXNpemUtY2xlYXJzLWZyb20tdHlwaW5nLXN0 eWxlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9mb250LXNpemUt Y2xlYXJzLWZyb20tdHlwaW5nLXN0eWxlLmh0bWw6CisgICAgICAgICogZWRpdGluZy9pbnNlcnRp bmcvc2NyaXB0LXRlc3RzOiBSZW1vdmVkLgorICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL3Nj cmlwdC10ZXN0cy9URU1QTEFURS5odG1sOiBSZW1vdmVkLgorICAgICAgICAqIGVkaXRpbmcvaW5z ZXJ0aW5nL3NjcmlwdC10ZXN0cy9mb250LXNpemUtY2xlYXJzLWZyb20tdHlwaW5nLXN0eWxlLmpz OiBSZW1vdmVkLgorCiAyMDEyLTA2LTI2ICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gSFRNTDUgYXVkaW8vdmlkZW8gdGFncyAtIGxvYWRpbmcg aHR0cCBjb250ZW50IGZyb20gaHR0cHMgcGFnZSBkb2Vzbid0IHRyaWdnZXIgd2FybmluZy4KSW5k ZXg6IExheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2ZvbnQtc2l6ZS1jbGVhcnMtZnJvbS10 eXBpbmctc3R5bGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRp bmcvaW5zZXJ0aW5nL2ZvbnQtc2l6ZS1jbGVhcnMtZnJvbS10eXBpbmctc3R5bGUtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxMjEwNzcpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9m b250LXNpemUtY2xlYXJzLWZyb20tdHlwaW5nLXN0eWxlLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMSwxMSArMSw0IEBACiBUZXN0cyB0aGF0IGZvbnQtc2l6ZSBpbiB0eXBpbmdTdHls ZSBpcyBjb3JyZWN0bHkgY2xlYXJlZC4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNjI3OS4KLQotT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgotCi0KLVBBU1Mg MSBpcyAxCi1QQVNTIDMgaXMgMwotUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQotCi1U RVNUIENPTVBMRVRFCi1CQQorfCA8ZGl2PgorfCAgIGlkPSJ3cmFwcGVyIgorfCAgICJCPCNzZWxl Y3Rpb24tY2FyZXQ+QSIKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2ZvbnQt c2l6ZS1jbGVhcnMtZnJvbS10eXBpbmctc3R5bGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9lZGl0aW5nL2luc2VydGluZy9mb250LXNpemUtY2xlYXJzLWZyb20tdHlwaW5nLXN0eWxl Lmh0bWwJKHJldmlzaW9uIDEyMTA3NykKKysrIExheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5n L2ZvbnQtc2l6ZS1jbGVhcnMtZnJvbS10eXBpbmctc3R5bGUuaHRtbAkod29ya2luZyBjb3B5KQpA QCAtMSwxMiArMSwyNCBAQAotPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRN TC8vRU4iPgorPCFET0NUWVBFIGh0bWw+CiA8aHRtbD4KLTxoZWFkPgotPHNjcmlwdCBzcmM9Ii4u Ly4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KLTwvaGVhZD4K IDxib2R5PgotPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Ci08ZGl2IGlkPSJjb25zb2xlIj48L2Rp dj4KLTxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvZm9udC1zaXplLWNsZWFycy1mcm9tLXR5cGlu Zy1zdHlsZS5qcyI+PC9zY3JpcHQ+Ci08c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvZHVtcC1hcy1tYXJrdXAuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworTWFya3VwLmRlc2Ny aXB0aW9uKCJUZXN0cyB0aGF0IGZvbnQtc2l6ZSBpbiB0eXBpbmdTdHlsZSBpcyBjb3JyZWN0bHkg Y2xlYXJlZC4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjI3 OS4iKTsKKwordmFyIGVkaXRhYmxlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7Citl ZGl0YWJsZS5jb250ZW50RWRpdGFibGUgPSB0cnVlOworZWRpdGFibGUuaW5uZXJIVE1MID0gJzxi cj48ZGl2IGlkPSJ3cmFwcGVyIj5BPC9kaXY+JzsKKworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGls ZChlZGl0YWJsZSk7CitlZGl0YWJsZS5mb2N1cygpOworCit3aW5kb3cuZ2V0U2VsZWN0aW9uKCku c2V0QmFzZUFuZEV4dGVudChlZGl0YWJsZSwgMCwgZWRpdGFibGUsIDApOworZG9jdW1lbnQuZXhl Y0NvbW1hbmQoJ0ZvcndhcmREZWxldGUnLCBmYWxzZSwgZmFsc2UpOworZG9jdW1lbnQuZXhlY0Nv bW1hbmQoJ0luc2VydFRleHQnLCBmYWxzZSwgJ0InKTsKKworTWFya3VwLmR1bXAoZWRpdGFibGUp OworCis8L3NjcmlwdD4KIDwvYm9keT4KIDwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRp bmcvaW5zZXJ0aW5nL3NjcmlwdC10ZXN0cy9URU1QTEFURS5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3NjcmlwdC10ZXN0cy9URU1QTEFURS5odG1sCShy ZXZpc2lvbiAxMjEwNzcpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9zY3JpcHQt dGVzdHMvVEVNUExBVEUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSwxMiArMCwwIEBACi08IURP Q1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Ci08aHRtbD4KLTxoZWFk PgotPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KLTwvaGVhZD4KLTxib2R5PgotPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Ci08ZGl2 IGlkPSJjb25zb2xlIj48L2Rpdj4KLTxzY3JpcHQgc3JjPSJZT1VSX0pTX0ZJTEVfSEVSRSI+PC9z Y3JpcHQ+Ci08c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0 LmpzIj48L3NjcmlwdD4KLTwvYm9keT4KLTwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRp bmcvaW5zZXJ0aW5nL3NjcmlwdC10ZXN0cy9mb250LXNpemUtY2xlYXJzLWZyb20tdHlwaW5nLXN0 eWxlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3Njcmlw dC10ZXN0cy9mb250LXNpemUtY2xlYXJzLWZyb20tdHlwaW5nLXN0eWxlLmpzCShyZXZpc2lvbiAx MjEwNzcpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9zY3JpcHQtdGVzdHMvZm9u dC1zaXplLWNsZWFycy1mcm9tLXR5cGluZy1zdHlsZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMSwx OSArMCwwIEBACi1kZXNjcmlwdGlvbigiVGVzdHMgdGhhdCBmb250LXNpemUgaW4gdHlwaW5nU3R5 bGUgaXMgY29ycmVjdGx5IGNsZWFyZWQuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjYyNzkuIik7Ci0KLXZhciBlZGl0YWJsZSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoJ2RpdicpOwotZWRpdGFibGUuY29udGVudEVkaXRhYmxlID0gdHJ1ZTsKLWVkaXRhYmxl LmlubmVySFRNTCA9ICc8YnI+PGRpdiBpZD0id3JhcHBlciI+QTwvZGl2Pic7Ci0KLWRvY3VtZW50 LmJvZHkuYXBwZW5kQ2hpbGQoZWRpdGFibGUpOwotZWRpdGFibGUuZm9jdXMoKTsKLQotd2luZG93 LmdldFNlbGVjdGlvbigpLnNldEJhc2VBbmRFeHRlbnQoZWRpdGFibGUsIDAsIGVkaXRhYmxlLCAw KTsKLWRvY3VtZW50LmV4ZWNDb21tYW5kKCdGb3J3YXJkRGVsZXRlJywgZmFsc2UsIGZhbHNlKTsK LWRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRUZXh0JywgZmFsc2UsICdCJyk7Ci0KLS8vIFRo ZSBmb3J3YXJkIGRlbGV0ZSBsZWF2ZXMgdGhlIGN1cnNvciBpbiB0aGUgIndyYXBwZXIiIGRpdi4K LS8vIEFmdGVyIHR5cGluZywgdGhlcmUgc2hvdWxkIGJlIGV4YWN0bHkgb25lIHRleHRub2RlIGlu IHRoZSB3cmFwcGVyIGRpdi4KLXNob3VsZEJlKFN0cmluZyh3cmFwcGVyLmNoaWxkTm9kZXMubGVu Z3RoKSwgJzEnKTsKLXNob3VsZEJlKFN0cmluZyh3cmFwcGVyLmZpcnN0Q2hpbGQubm9kZVR5cGUp LCAnMycpOwotCi12YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK