90013 2012-06-26 14:15:30 -0700 [Chromium] Decrease the number of conditional blocks in features.gypi 2012-06-26 17:06:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89944 1 peter peter abarth rniwa webkit.review.bot oldest_to_newest 657978 0 peter 2012-06-26 14:15:30 -0700 [Chromium] Decrease the number of conditional blocks in features.gypi 657988 1 149606 peter 2012-06-26 14:20:45 -0700 Created attachment 149606 Patch 657996 2 peter 2012-06-26 14:27:22 -0700 While it's not strictly blocking 89944, labeling it as such so it's clear where this comes from. I also added a comment to the conditional since the differences between Android and non-Android are still rather big :(. 658131 3 149606 webkit.review.bot 2012-06-26 17:06:35 -0700 Comment on attachment 149606 Patch Clearing flags on attachment: 149606 Committed r121304: <http://trac.webkit.org/changeset/121304> 658132 4 webkit.review.bot 2012-06-26 17:06:41 -0700 All reviewed patches have been landed. Closing bug. 149606 2012-06-26 14:20:45 -0700 2012-06-26 17:06:35 -0700 Patch bug-90013-20120626142045.patch text/plain 2604 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY5OGFiYmVhNDRlYzRmNGNmNmYyZmU3ODdiZDNiYzRmMTA3ZjEwYmYuLjg3MjZjMGVhYzhkMTVi Njc5YzRjMDhjZTBkMDg5ZWQ0OTM2MTdkNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDYtMjYgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRGVjcmVhc2UgdGhlIG51bWJlciBvZiBjb25k aXRpb25hbCBibG9ja3MgaW4gZmVhdHVyZXMuZ3lwaQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAwMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb25zb2xpZGF0ZSB0d28gQW5kcm9pZC1zcGVjaWZpYyBh bmQgYWNjZWxlcmF0ZWQtY29tcG9zaXRpbmctc3BlY2lmaWMKKyAgICAgICAgY29uZGl0aW9uYWwg YmxvY2tzIGludG8gb3RoZXIgYmxvY2tzIHdoaWNoIHNlcnZlIGFuIGlkZW50aWNhbCBwdXJwb3Nl LgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0wNi0yNSAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIFdlYkxh eWVyIEFQSSBmb3Igc2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L2ZlYXR1cmVzLmd5cGkgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKaW5k ZXggNGUyNzk2NzMyZTg2MzJlZmM0ZGEyN2Y5ZjgxOWEyZjU4OGViMTFiMS4uY2FhNDFkYWUzN2Fh ODM5NzNkYThmNjQxNTk1YTBmOTU5MjdmZTI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9mZWF0dXJlcy5neXBpCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVy ZXMuZ3lwaQpAQCAtMTM3LDYgKzEzNyw3IEBACiAgICAgICAgICAgJ0VOQUJMRV9DQUxFTkRBUl9Q SUNLRVI9MCcsCiAgICAgICAgICAgJ0VOQUJMRV9GT05UX0JPT1NUSU5HPTEnLAogICAgICAgICAg ICdFTkFCTEVfSU5QVVRfU1BFRUNIPTAnLAorICAgICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9D T0xPUj0wJywKICAgICAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUU9MScsCiAgICAg ICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FTE9DQUw9MScsCiAgICAgICAgICAgJ0VO QUJMRV9JTlBVVF9UWVBFX01PTlRIPTEnLApAQCAtMTU3LDExICsxNTgsMTIgQEAKICAgICAgICAg ICAnV1RGX1VTRV9OQVRJVkVfRlVMTFNDUkVFTl9WSURFTz0xJywKICAgICAgICAgXSwKICAgICAg ICAgJ2VuYWJsZV90b3VjaF9pY29uX2xvYWRpbmcnOiAxLAotICAgICAgfSwgeworICAgICAgfSwg eyAjIE9TIT0iYW5kcm9pZCIKICAgICAgICAgJ2ZlYXR1cmVfZGVmaW5lcyc6IFsKICAgICAgICAg ICAnRU5BQkxFX0NBTEVOREFSX1BJQ0tFUj0xJywKICAgICAgICAgICAnRU5BQkxFX0ZPTlRfQk9P U1RJTkc9MCcsCiAgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9TUEVFQ0g9MScsCisgICAgICAgICAg J0VOQUJMRV9JTlBVVF9UWVBFX0NPTE9SPTEnLAogICAgICAgICAgICdFTkFCTEVfSkFWQVNDUklQ VF9JMThOX0FQST0xJywKICAgICAgICAgICAnRU5BQkxFX0xFR0FDWV9OT1RJRklDQVRJT05TPTEn LAogICAgICAgICAgICdFTkFCTEVfTUVESUFfQ0FQVFVSRT0wJywKQEAgLTE3NCwyNCArMTc2LDEx IEBACiAgICAgICAgICAgJ0VOQUJMRV9XRUJfQVVESU89MScsCiAgICAgICAgIF0sCiAgICAgICB9 XSwKLSAgICAgIFsnT1M9PSJhbmRyb2lkIicsIHsKLSAgICAgICAgJ2ZlYXR1cmVfZGVmaW5lcyc6 IFsKLSAgICAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfQ09MT1I9MCcsCi0gICAgICAgIF0sCi0g ICAgICB9LCB7Ci0gICAgICAgICdmZWF0dXJlX2RlZmluZXMnOiBbCi0gICAgICAgICAgJ0VOQUJM RV9JTlBVVF9UWVBFX0NPTE9SPTEnLAotICAgICAgICBdLAotICAgICAgfV0sCiAgICAgICBbJ3Vz ZV9hY2NlbGVyYXRlZF9jb21wb3NpdGluZz09MScsIHsKICAgICAgICAgJ2ZlYXR1cmVfZGVmaW5l cyc6IFsKLSAgICAgICAgICAnV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORz0xJywKICAg ICAgICAgICAnRU5BQkxFXzNEX1JFTkRFUklORz0xJywKLSAgICAgICAgXSwKLSAgICAgIH1dLAot ICAgICAgWyd1c2VfYWNjZWxlcmF0ZWRfY29tcG9zaXRpbmc9PTEnLCB7Ci0gICAgICAgICdmZWF0 dXJlX2RlZmluZXMnOiBbCiAgICAgICAgICAgJ0VOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVM9 MScsCisgICAgICAgICAgJ1dURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkc9MScsCiAgICAg ICAgIF0sCiAgICAgICB9XSwKICAgICAgICMgTWFjIE9TIFggdXNlcyBBY2NlbGVyYXRlLmZyYW1l d29yayBGRlQgYnkgZGVmYXVsdCBpbnN0ZWFkIG9mIEZGbXBlZy4K