90010 2012-06-26 13:44:51 -0700 Fix platform picker change handler in garden-o-matic 2012-06-26 14:22:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dglazkov simon.fraser webkit.review.bot oldest_to_newest 657944 0 ojan 2012-06-26 13:44:51 -0700 Fix platform picker change handler in garden-o-matic 657958 1 149601 ojan 2012-06-26 13:57:37 -0700 Created attachment 149601 Patch 657959 2 149602 ojan 2012-06-26 13:58:05 -0700 Created attachment 149602 Patch 657965 3 149602 simon.fraser 2012-06-26 14:04:33 -0700 Comment on attachment 149602 Patch Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac. 657972 4 abarth 2012-06-26 14:08:48 -0700 > Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac. Presumably you want to be able to select things other than the zeroth option, right? 657974 5 simon.fraser 2012-06-26 14:12:17 -0700 (In reply to comment #4) > > Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac. > > Presumably you want to be able to select things other than the zeroth option, right? No, selectedOptions is a collection of the options that are selected (in the case of a dropdown, just the checked one). 657976 6 abarth 2012-06-26 14:14:48 -0700 > No, selectedOptions is a collection of the options that are selected (in the case of a dropdown, just the checked one). Ah, I misread the diff. 657979 7 149602 simon.fraser 2012-06-26 14:15:34 -0700 Comment on attachment 149602 Patch OK, now we understand that selectedOptions was rolled out via bug 88749. 657990 8 ojan 2012-06-26 14:22:16 -0700 Committed r121287: <http://trac.webkit.org/changeset/121287> 149601 2012-06-26 13:57:37 -0700 2012-06-26 13:58:02 -0700 Patch bug-90010-20120626135737.patch text/plain 2691 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmY4OTY4MjJiNjc2YjA3MGZkOTE0YWM0NjM3YmVjMDky Y2Y5MWE3Yi4uYmMyODJiYmFiYzVmYzQ2MTc1NmM3ZDk2NDY0ODdiMDEzYzQ4NDA3OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA2LTI2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgRml4IHBsYXRmb3JtIHBpY2tlciBjaGFuZ2UgaGFuZGxlciBpbiBnYXJkZW4tby1tYXRpYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAwMTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJl cy9zY3JpcHRzL3VpLmpzOgorICAgICAgICBUaGUgb2xkIGNvZGUgbmV2ZXIgd29ya2VkLiBUaGlz IGlzIGhhcmQgdG8gdGVzdCBiZWNhdXNlIGNoYW5nZSBoYW5kbGVycyByZXF1aXJlCisgICAgICAg IGEgdXNlci1pbml0aWF0ZWQgYWN0aW9uIGFuZCB0aGUgY29kZSBpcyBjaGFuZ2luZyB0aGUgd2lu ZG93J3MgbG9jYXRpb24sIHdoaWNoIHdvdWxkCisgICAgICAgIG5hdmlnYXRlIHRoZSB0ZXN0IHBh Z2UuCisKKwkqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL1Rlc3RGYWlsdXJlcy9zdHlsZXMvb25lYmFyLmNzczoKKyAgICAgICAgRml4IHRoZSBD U1Mgc28gaXQgZG9lc24ndCBjYXVzZSB0aGUgdGFic3RyaXAgdG8gYmUgZGlzY29ubmVjdGVkIGZy b20gdGhlIHRhYnMgb24gTGludXgKKyAgICAgICAgZHVlIHRvIHRoZSBsYXJnZSBtYXJnaW4tYm90 dG9tLgorCiAyMDEyLTA2LTI2ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50 b3NAaW50ZWwuY29tPgogCiAgICAgICAgIHdlYmtpdHB5OiBNYWtlIHdlYmtpdC1wYXRjaCBwYXRj aGVzLXRvLXJldmlldyB1c2VmdWwKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRz L3VpLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanMKaW5kZXggZjA5ZmUyOTE1Njg1 OTlmMzgyMjYxODE4ZDlkNmM5Yjk0MGJhMWE1ZS4uNWQzYjhmMzY2MjA3MjcxYWRhOWQzYThiMGZh ZjY1MTI4ODRiOWQ1MCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanMK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanMKQEAgLTExMiw4ICsxMTIsOCBAQCB1 aS5vbmViYXIgPSBiYXNlLmV4dGVuZHMoJ2RpdicsIHsKICAgICAgICAgfSk7CiAgICAgICAgIAog ICAgICAgICBwbGF0Zm9ybVNlbGVjdC5hZGRFdmVudExpc3RlbmVyKCdjaGFuZ2UnLCBmdW5jdGlv bigpIHsKLSAgICAgICAgICAgIHdpbmRvdy5sb2NhdGlvbi5zZWFyY2ggPSAnP3BsYXRmb3JtPScg KyBwbGF0Zm9ybVNlbGVjdC5zZWxlY3RlZE9wdGlvbnNbMF0uX3BsYXRmb3JtOwotICAgICAgICB9 LCBmYWxzZSk7CisgICAgICAgICAgICB3aW5kb3cubG9jYXRpb24uc2VhcmNoID0gJz9wbGF0Zm9y bT0nICsgcGxhdGZvcm1TZWxlY3Qub3B0aW9uc1twbGF0Zm9ybVNlbGVjdC5zZWxlY3RlZEluZGV4 XS5fcGxhdGZvcm07CisgICAgICAgIH0pOwogICAgICAgICAKICAgICAgICAgcGxhdGZvcm1TZWxl Y3Quc2VsZWN0ZWRJbmRleCA9IGN1cnJlbnRQbGF0Zm9ybUluZGV4OwogICAgIH0sCmRpZmYgLS1n aXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9UZXN0RmFpbHVyZXMvc3R5bGVzL29uZWJhci5jc3MgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMv c3R5bGVzL29uZWJhci5jc3MKaW5kZXggMTZhYWMxMWY0YTJkZjgxOGYzNDk5ZTc1NTllMjUzMWVk NDJkMzlhOS4uY2E2YjU5NTExN2E3ZmY4OGFmYmI4OTZjOGU5OThkNTgyNjM4NTkxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvVGVzdEZhaWx1cmVzL3N0eWxlcy9vbmViYXIuY3NzCisrKyBiL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWls dXJlcy9zdHlsZXMvb25lYmFyLmNzcwpAQCAtNDMsNyArNDMsOCBAQAogCiAjb25lYmFyICNwbGF0 Zm9ybS1waWNrZXIgewogICAgIGZsb2F0OiByaWdodDsKLSAgICBtYXJnaW46IDhweDsKKyAgICBt YXJnaW4tdG9wOiA4cHg7CisgICAgbWFyZ2luLXJpZ2h0OiA4cHg7CiAgICAgZm9udC1zaXplOiBs YXJnZXI7CiB9CiAK 149602 2012-06-26 13:58:05 -0700 2012-06-26 14:15:33 -0700 Patch bug-90010-20120626135805.patch text/plain 2698 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmY4OTY4MjJiNjc2YjA3MGZkOTE0YWM0NjM3YmVjMDky Y2Y5MWE3Yi4uNTJkN2QyMjE4Yzc0ZjA3MDhkOTllZmM0Zjk1MTI1MGQzMzlmN2UzMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA2LTI2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgRml4IHBsYXRmb3JtIHBpY2tlciBjaGFuZ2UgaGFuZGxlciBpbiBnYXJkZW4tby1tYXRpYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAwMTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJl cy9zY3JpcHRzL3VpLmpzOgorICAgICAgICBUaGUgb2xkIGNvZGUgbmV2ZXIgd29ya2VkLiBUaGlz IGlzIGhhcmQgdG8gdGVzdCBiZWNhdXNlIGNoYW5nZSBoYW5kbGVycyByZXF1aXJlCisgICAgICAg IGEgdXNlci1pbml0aWF0ZWQgYWN0aW9uIGFuZCB0aGUgY29kZSBpcyBjaGFuZ2luZyB0aGUgd2lu ZG93J3MgbG9jYXRpb24sIHdoaWNoIHdvdWxkCisgICAgICAgIG5hdmlnYXRlIHRoZSB0ZXN0IHBh Z2UuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc3R5bGVzL29uZWJhci5jc3M6CisgICAgICAgIEZp eCB0aGUgQ1NTIHNvIGl0IGRvZXNuJ3QgY2F1c2UgdGhlIHRhYnN0cmlwIHRvIGJlIGRpc2Nvbm5l Y3RlZCBmcm9tIHRoZSB0YWJzIG9uIExpbnV4CisgICAgICAgIGR1ZSB0byB0aGUgbGFyZ2UgbWFy Z2luLWJvdHRvbS4KKwogMjAxMi0wNi0yNiAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlh Z28uc2FudG9zQGludGVsLmNvbT4KIAogICAgICAgICB3ZWJraXRweTogTWFrZSB3ZWJraXQtcGF0 Y2ggcGF0Y2hlcy10by1yZXZpZXcgdXNlZnVsCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMv c2NyaXB0cy91aS5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpLmpzCmluZGV4IGYwOWZl MjkxNTY4NTk5ZjM4MjI2MTgxOGQ5ZDZjOWI5NDBiYTFhNWUuLjVkM2I4ZjM2NjIwNzI3MWFkYTlk M2E4YjBmYWY2NTEyODg0YjlkNTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRz L3VpLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpLmpzCkBAIC0xMTIsOCArMTEy LDggQEAgdWkub25lYmFyID0gYmFzZS5leHRlbmRzKCdkaXYnLCB7CiAgICAgICAgIH0pOwogICAg ICAgICAKICAgICAgICAgcGxhdGZvcm1TZWxlY3QuYWRkRXZlbnRMaXN0ZW5lcignY2hhbmdlJywg ZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICB3aW5kb3cubG9jYXRpb24uc2VhcmNoID0gJz9wbGF0 Zm9ybT0nICsgcGxhdGZvcm1TZWxlY3Quc2VsZWN0ZWRPcHRpb25zWzBdLl9wbGF0Zm9ybTsKLSAg ICAgICAgfSwgZmFsc2UpOworICAgICAgICAgICAgd2luZG93LmxvY2F0aW9uLnNlYXJjaCA9ICc/ cGxhdGZvcm09JyArIHBsYXRmb3JtU2VsZWN0Lm9wdGlvbnNbcGxhdGZvcm1TZWxlY3Quc2VsZWN0 ZWRJbmRleF0uX3BsYXRmb3JtOworICAgICAgICB9KTsKICAgICAgICAgCiAgICAgICAgIHBsYXRm b3JtU2VsZWN0LnNlbGVjdGVkSW5kZXggPSBjdXJyZW50UGxhdGZvcm1JbmRleDsKICAgICB9LApk aWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3N0eWxlcy9vbmViYXIuY3NzIGIvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZh aWx1cmVzL3N0eWxlcy9vbmViYXIuY3NzCmluZGV4IDE2YWFjMTFmNGEyZGY4MThmMzQ5OWU3NTU5 ZTI1MzFlZDQyZDM5YTkuLmNhNmI1OTUxMTdhN2ZmODhhZmJiODk2YzhlOTk4ZDU4MjYzODU5MWMg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zdHlsZXMvb25lYmFyLmNzcworKysgYi9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvc3R5bGVzL29uZWJhci5jc3MKQEAgLTQzLDcgKzQzLDggQEAKIAogI29uZWJh ciAjcGxhdGZvcm0tcGlja2VyIHsKICAgICBmbG9hdDogcmlnaHQ7Ci0gICAgbWFyZ2luOiA4cHg7 CisgICAgbWFyZ2luLXRvcDogOHB4OworICAgIG1hcmdpbi1yaWdodDogOHB4OwogICAgIGZvbnQt c2l6ZTogbGFyZ2VyOwogfQogCg==