90006 2012-06-26 13:11:28 -0700 [chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor 2012-06-27 07:55:35 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rjkroege rjkroege aelias danakj jamesr webkit.review.bot wjmaclean oldest_to_newest 657904 0 rjkroege 2012-06-26 13:11:28 -0700 The patch for https://bugs.webkit.org/show_bug.cgi?id=88916 added code mis-positioned with respect to an assert such that the assert fires incorrectly when reducing the deviceScaleFactor. 657913 1 149594 rjkroege 2012-06-26 13:19:17 -0700 Created attachment 149594 Patch 657919 2 149594 danakj 2012-06-26 13:26:26 -0700 Comment on attachment 149594 Patch LGTM 657940 3 149594 jamesr 2012-06-26 13:43:14 -0700 Comment on attachment 149594 Patch R=me is someone working on removing applyDefault...InCompositor() ? 657989 4 danakj 2012-06-26 14:22:02 -0700 It needs to be renamed to applyDeviceScale... instead of applyDefaultDeviceScale... but the removal process is quite fuzzy in my mind, as I'm not sure what that would mean for Android right now. 658602 5 149594 webkit.review.bot 2012-06-27 07:55:30 -0700 Comment on attachment 149594 Patch Clearing flags on attachment: 149594 Committed r121342: <http://trac.webkit.org/changeset/121342> 658603 6 webkit.review.bot 2012-06-27 07:55:35 -0700 All reviewed patches have been landed. Closing bug. 149594 2012-06-26 13:19:17 -0700 2012-06-27 07:55:30 -0700 Patch bug-90006-20120626161916.patch text/plain 2223 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhkMzU4OTgzYjgzZjM4YmE4MjBiODMxMWQyNTEyZjNlZDZiMGIyZmQuLjUwYTcxN2Y5MzA3MWFk MzZkNTFkZTZmMjhkNTg2N2IzOWNkNzE2MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMjYgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gb3V0LW9mLW9yZGVyIGFzc2VydCBpbiBX ZWJWaWV3SW1wbCBzZXREZXZpY2VTY2FsZUZhY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAwMDYKKworICAgICAgICBUaGUgYXNzZXJ0IGluIFdl YlZpZXdJbXBsOjpzZXREZXZpY2VTY2FsZUZhY3RvciBzaG91bGQgdGVzdCBmb3Igbm9uLXNjYWxp bmcKKyAgICAgICAgYWZ0ZXIgd2UgaGF2ZSBzZXQgYm90aCBtX0RldmljZVNjYWxlSW5Db21wb3Np dG9yIGFuZCBwYWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCkKKyAgICAgICAgaW5zdGVhZCBvZiBp biBiZXR3ZWVuLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6 OnNldERldmljZVNjYWxlRmFjdG9yKToKKwogMjAxMi0wNi0yNiAgSnVuIE11a2FpICA8bXVrYWlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFsbG93IHVzaW5nIDxpbnB1dCB0eXBlPSJjb2xvciI+ IFVJIGluIENocm9tZU9TLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwCmluZGV4IDAyZGI2M2U4MDA0MDI2YTdkODRlZTg5MjE2OTBlM2YxOTJhODkwNzAuLjZhZDE5 MjczMWE0YWNiNTRlZmQ0OWQwNTBiMWJmY2Y1OGVlOTlmNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTI1NDQsMTYgKzI1NDQsMTYgQEAgdm9pZCBX ZWJWaWV3SW1wbDo6c2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQgc2NhbGVGYWN0b3IpCiAKICAg ICBwYWdlKCktPnNldERldmljZVNjYWxlRmFjdG9yKHNjYWxlRmFjdG9yKTsKIAorICAgIGlmICgh bV9sYXllclRyZWVWaWV3LmlzTnVsbCgpICYmIG1fd2ViU2V0dGluZ3MtPmFwcGx5RGVmYXVsdERl dmljZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yKCkpIHsKKyAgICAgICAgbV9kZXZpY2VTY2FsZUlu Q29tcG9zaXRvciA9IHBhZ2UoKS0+ZGV2aWNlU2NhbGVGYWN0b3IoKTsKKyAgICAgICAgbV9sYXll clRyZWVWaWV3LnNldERldmljZVNjYWxlRmFjdG9yKG1fZGV2aWNlU2NhbGVJbkNvbXBvc2l0b3Ip OworICAgIH0KICAgICBpZiAobV9kZXZpY2VTY2FsZUluQ29tcG9zaXRvciAhPSAxKSB7CiAgICAg ICAgIC8vIERvbid0IGFsbG93IHBhZ2Ugc2NhbGluZyB3aGVuIGNvbXBvc2l0b3Igc2NhbGluZyBp cyBiZWluZyB1c2VkLAogICAgICAgICAvLyBhcyB0aGV5IGFyZSBjdXJyZW50bHkgaW5jb21wYXRp YmxlLiBUaGlzIG1lYW5zIHRoZSBkZXZpY2VTY2FsZQogICAgICAgICAvLyBuZWVkcyB0byBtYXRj aCB0aGUgb25lIGluIHRoZSBjb21wb3NpdG9yLgogICAgICAgICBBU1NFUlQoc2NhbGVGYWN0b3Ig PT0gbV9kZXZpY2VTY2FsZUluQ29tcG9zaXRvcik7CiAgICAgfQotICAgIGlmICghbV9sYXllclRy ZWVWaWV3LmlzTnVsbCgpICYmIG1fd2ViU2V0dGluZ3MtPmFwcGx5RGVmYXVsdERldmljZVNjYWxl RmFjdG9ySW5Db21wb3NpdG9yKCkpIHsKLSAgICAgICAgbV9kZXZpY2VTY2FsZUluQ29tcG9zaXRv ciA9IHBhZ2UoKS0+ZGV2aWNlU2NhbGVGYWN0b3IoKTsKLSAgICAgICAgbV9sYXllclRyZWVWaWV3 LnNldERldmljZVNjYWxlRmFjdG9yKG1fZGV2aWNlU2NhbGVJbkNvbXBvc2l0b3IpOwotICAgIH0K IH0KIAogYm9vbCBXZWJWaWV3SW1wbDo6aXNGaXhlZExheW91dE1vZGVFbmFibGVkKCkgY29uc3QK