89994 2012-06-26 10:56:16 -0700 [v8] Clean up generated Dictionary-handling code 2012-06-26 16:02:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk abarth arv haraken japhet jochen webkit.review.bot oldest_to_newest 657725 0 adamk 2012-06-26 10:56:16 -0700 [v8] Clean up generated Dictionary-handling code 657730 1 149561 adamk 2012-06-26 10:58:12 -0700 Created attachment 149561 Patch 657812 2 149561 arv 2012-06-26 11:53:13 -0700 Comment on attachment 149561 Patch LGTM 658069 3 149561 webkit.review.bot 2012-06-26 16:02:20 -0700 Comment on attachment 149561 Patch Clearing flags on attachment: 149561 Committed r121295: <http://trac.webkit.org/changeset/121295> 658070 4 webkit.review.bot 2012-06-26 16:02:25 -0700 All reviewed patches have been landed. Closing bug. 149561 2012-06-26 10:58:12 -0700 2012-06-26 16:02:20 -0700 Patch bug-89994-20120626105812.patch text/plain 3795 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwOTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA1ZjI1ZTkyYTFmN2Q0 ZDM4NzUzZjRhYTYwNjdhMDE1ODM0YTU2My4uNGZkNDRlZjhhYmUzMWNmMzJhZDg1YWUwYWNlNzc1 YzYyMDJlMmUwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTI2ICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFt2OF0gQ2xlYW4gdXAgZ2Vu ZXJhdGVkIERpY3Rpb25hcnktaGFuZGxpbmcgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk5OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IsIHNvIG5vIG5ldyB0 ZXN0cy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgor ICAgICAgICAoR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2spOgorICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGVzdE9ialY4 SW50ZXJuYWw6Om9wdGlvbnNPYmplY3RDYWxsYmFjayk6CisKIDIwMTItMDYtMjEgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2xhbmcgYnVpbGQgZml4LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpp bmRleCBhOTI5ODlhNTJkZDY1ZGY0N2NmZWE0OTAyZWM5ZjY4NjdlZjE5OGQzLi4yNTRlYzkzOTZi YjQyNzExZmNlMTZiZTEwNTAxMjFkZjZmZWVjYjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMTcyNCwxMyArMTcyNCw4 IEBAIHN1YiBHZW5lcmF0ZVBhcmFtZXRlcnNDaGVjawogICAgICAgICAgICAgJHBhcmFtZXRlckNo ZWNrU3RyaW5nIC49ICIgICAgRVhDRVBUSU9OX0JMT0NLKCRuYXRpdmVUeXBlLCAkcGFyYW1ldGVy TmFtZSwgIiAuCiAgICAgICAgICAgICAgICAgIEpTVmFsdWVUb05hdGl2ZSgkcGFyYW1ldGVyLCAi TUFZQkVfTUlTU0lOR19QQVJBTUVURVIoYXJncywgJHBhcmFtSW5kZXgsICRwYXJhbWV0ZXJEZWZh dWx0UG9saWN5KSIsICJhcmdzLkdldElzb2xhdGUoKSIpIC4gIik7XG4iOwogICAgICAgICAgICAg aWYgKCRuYXRpdmVUeXBlIGVxICdEaWN0aW9uYXJ5JykgewotICAgICAgICAgICAgICAgJHBhcmFt ZXRlckNoZWNrU3RyaW5nIC49ICIgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPiAkcGFyYW1JbmRleCAm JiAhJHBhcmFtZXRlck5hbWUuaXNVbmRlZmluZWRPck51bGwoKSAmJiAhJHBhcmFtZXRlck5hbWUu aXNPYmplY3QoKSkge1xuIjsKLSAgICAgICAgICAgICAgIGlmIChAeyRmdW5jdGlvbi0+cmFpc2Vz RXhjZXB0aW9uc30pIHsKLSAgICAgICAgICAgICAgICAgICAkcGFyYW1ldGVyQ2hlY2tTdHJpbmcg Lj0gIiAgICAgICAgZWMgPSBUWVBFX01JU01BVENIX0VSUjtcbiI7Ci0gICAgICAgICAgICAgICAg ICAgJHBhcmFtZXRlckNoZWNrU3RyaW5nIC49ICIgICAgICAgIFY4UHJveHk6OnNldERPTUV4Y2Vw dGlvbihlYywgYXJncy5HZXRJc29sYXRlKCkpO1xuIjsKLSAgICAgICAgICAgICAgIH0KLSAgICAg ICAgICAgICAgICRwYXJhbWV0ZXJDaGVja1N0cmluZyAuPSAiICAgICAgICByZXR1cm4gVjhQcm94 eTo6dGhyb3dUeXBlRXJyb3IoXCJOb3QgYW4gb2JqZWN0LlwiKTtcbiI7Ci0gICAgICAgICAgICAg ICAkcGFyYW1ldGVyQ2hlY2tTdHJpbmcgLj0gIiAgICB9XG4iOworICAgICAgICAgICAgICAgJHBh cmFtZXRlckNoZWNrU3RyaW5nIC49ICIgICAgaWYgKCEkcGFyYW1ldGVyTmFtZS5pc1VuZGVmaW5l ZE9yTnVsbCgpICYmICEkcGFyYW1ldGVyTmFtZS5pc09iamVjdCgpKVxuIjsKKyAgICAgICAgICAg ICAgICRwYXJhbWV0ZXJDaGVja1N0cmluZyAuPSAiICAgICAgICByZXR1cm4gVjhQcm94eTo6dGhy b3dUeXBlRXJyb3IoXCJOb3QgYW4gb2JqZWN0LlwiLCBhcmdzLkdldElzb2xhdGUoKSk7XG4iOwog ICAgICAgICAgICAgfQogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHAKaW5kZXggZGQyZTZmNDg5YWU2Nzdh MmFkNDVmYjJkMTc5YmRjNDNjNGI4NzFjNi4uNDBiOGQ5ZGJkNzY5Y2QyOTA4YmEzMzlkYjQ4Y2Zk NjBhMzBiMWRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L1Y4L1Y4VGVzdE9iai5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHAKQEAgLTExNTAsMTcgKzExNTAsMTUgQEAgc3RhdGljIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBvcHRpb25zT2JqZWN0Q2FsbGJhY2soY29uc3Qgdjg6OkFyZ3Vt ZW50cyYgYXJncykKICAgICAgICAgcmV0dXJuIFY4UHJveHk6OnRocm93Tm90RW5vdWdoQXJndW1l bnRzRXJyb3IoYXJncy5HZXRJc29sYXRlKCkpOwogICAgIFRlc3RPYmoqIGltcCA9IFY4VGVzdE9i ajo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7CiAgICAgRVhDRVBUSU9OX0JMT0NLKERpY3Rpb25h cnksIG9vLCBNQVlCRV9NSVNTSU5HX1BBUkFNRVRFUihhcmdzLCAwLCBEZWZhdWx0SXNVbmRlZmlu ZWQpKTsKLSAgICBpZiAoYXJncy5MZW5ndGgoKSA+IDAgJiYgIW9vLmlzVW5kZWZpbmVkT3JOdWxs KCkgJiYgIW9vLmlzT2JqZWN0KCkpIHsKLSAgICAgICAgcmV0dXJuIFY4UHJveHk6OnRocm93VHlw ZUVycm9yKCJOb3QgYW4gb2JqZWN0LiIpOwotICAgIH0KKyAgICBpZiAoIW9vLmlzVW5kZWZpbmVk T3JOdWxsKCkgJiYgIW9vLmlzT2JqZWN0KCkpCisgICAgICAgIHJldHVybiBWOFByb3h5Ojp0aHJv d1R5cGVFcnJvcigiTm90IGFuIG9iamVjdC4iLCBhcmdzLkdldElzb2xhdGUoKSk7CiAgICAgaWYg KGFyZ3MuTGVuZ3RoKCkgPD0gMSkgewogICAgICAgICBpbXAtPm9wdGlvbnNPYmplY3Qob28pOwog ICAgICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7CiAgICAgfQogICAgIEVYQ0VQ VElPTl9CTE9DSyhEaWN0aW9uYXJ5LCBvb28sIE1BWUJFX01JU1NJTkdfUEFSQU1FVEVSKGFyZ3Ms IDEsIERlZmF1bHRJc1VuZGVmaW5lZCkpOwotICAgIGlmIChhcmdzLkxlbmd0aCgpID4gMSAmJiAh b29vLmlzVW5kZWZpbmVkT3JOdWxsKCkgJiYgIW9vby5pc09iamVjdCgpKSB7Ci0gICAgICAgIHJl dHVybiBWOFByb3h5Ojp0aHJvd1R5cGVFcnJvcigiTm90IGFuIG9iamVjdC4iKTsKLSAgICB9Cisg ICAgaWYgKCFvb28uaXNVbmRlZmluZWRPck51bGwoKSAmJiAhb29vLmlzT2JqZWN0KCkpCisgICAg ICAgIHJldHVybiBWOFByb3h5Ojp0aHJvd1R5cGVFcnJvcigiTm90IGFuIG9iamVjdC4iLCBhcmdz LkdldElzb2xhdGUoKSk7CiAgICAgaW1wLT5vcHRpb25zT2JqZWN0KG9vLCBvb28pOwogICAgIHJl dHVybiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4oKTsKIH0K