89991 2012-06-26 10:24:06 -0700 [BlackBerry] Use new method to create socket handle 2012-08-21 16:53:00 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 liachen webkit-unassigned joenotcharles mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 657696 0 liachen 2012-06-26 10:24:06 -0700 NetworkStreamFactory::createSocketStream() has been removed, use createNetworkStreeam() instead, this simplify the interface. 700734 1 159687 liachen 2012-08-21 07:36:25 -0700 Created attachment 159687 Patch for 89991 700735 2 liachen 2012-08-21 07:37:10 -0700 +Yong, Rob, Joe. 700740 3 159687 rwlbuis 2012-08-21 07:40:35 -0700 Comment on attachment 159687 Patch for 89991 LGTM. 701310 4 159687 webkit.review.bot 2012-08-21 16:52:57 -0700 Comment on attachment 159687 Patch for 89991 Clearing flags on attachment: 159687 Committed r126223: <http://trac.webkit.org/changeset/126223> 701311 5 webkit.review.bot 2012-08-21 16:53:00 -0700 All reviewed patches have been landed. Closing bug. 159687 2012-08-21 07:36:25 -0700 2012-08-21 16:52:57 -0700 Patch for 89991 89991.patch text/plain 2039 liachen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZWIxMDY2Li43NTk3ZjgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDgtMjEgIExpYW5naHVpIENoZW4gIDxsaWFjaGVuQHJpbS5jb20+CisKKyAgICAg ICAgW0JsYWNrQmVycnldIFVzZSBuZXcgbWV0aG9kIHRvIGNyZWF0ZSBzb2NrZXQgaGFuZGxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk5MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUg d2F5IHRvIGNyZWF0ZSBTb2NrZXRTdHJlYW0gYXMgdGhlIHBsYXRmb3JtIEFQSSBoYXMgY2hhbmdl ZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgbm8gY2hhbmdlIG9mIGJlaGF2aW91ciwganVz dCBBUEkgY2hhbmdlIGFkYXB0YXRpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2Js YWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTb2NrZXRTdHJlYW1IYW5kbGU6OlNvY2tldFN0cmVhbUhhbmRsZSk6CisKIDIwMTItMDgt MjAgIFRvbSBTZXBleiAgPHRzZXBlekBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgWFNTQXVkaXRv ciB0b28gdG9sZXJhbnQgb2YgaW5qZWN0ZWQgZGF0YTogVVJMcyBmcm9tIG90aGVyICJob3N0bGVz cyIgc2NoZW1lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv YmxhY2tiZXJyeS9Tb2NrZXRTdHJlYW1IYW5kbGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9Tb2NrZXRTdHJlYW1IYW5kbGVCbGFja0Jl cnJ5LmNwcAppbmRleCA1NWEyOTVmLi5mN2Q3MDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlQmxhY2tCZXJy eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Nv Y2tldFN0cmVhbUhhbmRsZUJsYWNrQmVycnkuY3BwCkBAIC02NSwxNyArNjUsMTUgQEAgU29ja2V0 U3RyZWFtSGFuZGxlOjpTb2NrZXRTdHJlYW1IYW5kbGUoY29uc3QgU3RyaW5nJiBncm91cE5hbWUs IGNvbnN0IEtVUkwmIHVybCwKICAgICAvLyBDcmVhdGUgYSBwbGF0Zm9ybSBzb2NrZXQgc3RyZWFt CiAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdvcmtTdHJlYW1GYWN0b3J5KiBmYWN0b3J5 ID0gcGFnZS0+Y2hyb21lKCktPnBsYXRmb3JtUGFnZUNsaWVudCgpLT5uZXR3b3JrU3RyZWFtRmFj dG9yeSgpOwogICAgIEFTU0VSVChmYWN0b3J5KTsKLSAgICBtX3NvY2tldFN0cmVhbSA9IGFkb3B0 UHRyKGZhY3RvcnktPmNyZWF0ZVNvY2tldFN0cmVhbShwbGF5ZXJJZCkpOwotICAgIEFTU0VSVCht X3NvY2tldFN0cmVhbSk7Ci0gICAgbV9zb2NrZXRTdHJlYW0tPnNldExpc3RlbmVyKHRoaXMpOwog CiAgICAgLy8gT3BlbiB0aGUgc29ja2V0CiAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdv cmtSZXF1ZXN0IHJlcXVlc3Q7CiAgICAgUmVhZE9ubHlMYXRpbjFTdHJpbmcgbGF0aW4xVVJMKHVy bC5zdHJpbmcoKSk7CiAgICAgcmVxdWVzdC5zZXRSZXF1ZXN0VXJsKGxhdGluMVVSTC5kYXRhKCks IGxhdGluMVVSTC5sZW5ndGgoKSwgIkNPTk5FQ1QiLCA3KTsKKyAgICBtX3NvY2tldFN0cmVhbSA9 IGFkb3B0UHRyKGZhY3RvcnktPmNyZWF0ZU5ldHdvcmtTdHJlYW0ocmVxdWVzdCwgcGxheWVySWQp KTsKKyAgICBBU1NFUlQobV9zb2NrZXRTdHJlYW0pOwogCi0gICAgbV9zb2NrZXRTdHJlYW0tPnNl dFJlcXVlc3QocmVxdWVzdCk7Ci0KKyAgICBtX3NvY2tldFN0cmVhbS0+c2V0TGlzdGVuZXIodGhp cyk7CiAgICAgbV9zb2NrZXRTdHJlYW0tPnN0cmVhbU9wZW4oKTsKIH0KIAo=