89982 2012-06-26 08:35:40 -0700 On Mac, autocorrection sometimes fails to take place in Safari. 2012-07-11 15:50:59 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 90056 1 jiapu.mail jiapu.mail adele darin ddavidso enrica jeffrey+webkit morrita rniwa webkit.review.bot oldest_to_newest 657624 0 jiapu.mail 2012-06-26 08:35:40 -0700 This bug was introduced months ago, when spelling checking related code was being moved around. I haven't been able to nail down exactly which commit. <rdar://problem/11740064> 657635 1 149540 jiapu.mail 2012-06-26 09:05:40 -0700 Created attachment 149540 Patch. 657719 2 149540 darin 2012-06-26 10:54:03 -0700 Comment on attachment 149540 Patch. Can we make a regression test for this? What prevents this from getting reintroduced next time someone refactors? 657720 3 darin 2012-06-26 10:54:32 -0700 (In reply to comment #2) > Can we make a regression test for this? Oh, I see your comment now. There is a regression test for this, but it’s turned off! 657793 4 149540 webkit.review.bot 2012-06-26 11:39:15 -0700 Comment on attachment 149540 Patch. Clearing flags on attachment: 149540 Committed r121271: <http://trac.webkit.org/changeset/121271> 657794 5 webkit.review.bot 2012-06-26 11:39:26 -0700 All reviewed patches have been landed. Closing bug. 658042 6 jeffrey+webkit 2012-06-26 15:32:07 -0700 This change has been causing test regressions in Safari on many editing, selection, pasteboard and spell checking tests. 658473 7 rniwa 2012-06-27 02:08:21 -0700 This patch caused 12+ tests to fail on Lion: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r121275%20(405)/results.html 658474 8 rniwa 2012-06-27 02:08:35 -0700 I think we need to roll this patch out. 658485 9 webkit.review.bot 2012-06-27 02:20:01 -0700 Re-opened since this is blocked by 90056 658714 10 149774 jiapu.mail 2012-06-27 11:00:27 -0700 Created attachment 149774 Revised patch. 663165 11 149774 rniwa 2012-07-04 14:24:42 -0700 Comment on attachment 149774 Revised patch. View in context: https://bugs.webkit.org/attachment.cgi?id=149774&action=review > Source/WebCore/ChangeLog:5 > + Bug 89982 - On Mac, autocorrection sometimes fails to take place in Safari. > + > + On Mac, autocorrection sometimes fails to take place in Safari. What's up with this? Please fix it before landing the patch. 667161 12 jiapu.mail 2012-07-11 15:50:59 -0700 Manually landed after fixing the minor ChangeLog issue pointed by Ryosuke. <http://trac.webkit.org/changeset/122380> 149540 2012-06-26 09:05:40 -0700 2012-06-27 11:00:23 -0700 Patch. bug-89982-20120626090538.patch text/plain 1991 jiapu.mail U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRlNzA2N2I4YmViZjgx ZTA2MGEzNjFlNmJhMzE5YjE4OWU4OTNmMS4uOGY3YTU3NTg4MWNlOWUwZmUwNTY4ODQzZDFhMmQ0 NWJlOTk4ODlmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTI2ICBKaWEg UHUgIDxqcHVAYXBwbGUuY29tPgorCisgICAgICAgIE9uIE1hYywgYXV0b2NvcnJlY3Rpb24gc29t ZXRpbWVzIGZhaWxzIHRvIHRha2UgcGxhY2UgaW4gU2FmYXJpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk5ODIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGlzdGluZyB0ZXN0IHdhcyB0dXJuZWQgb2Zm IGR1ZSB0byBpbnRlcm1pdHRlbnQgZmFpbHVyZSwgd2hpY2ggaXMgY2F1c2VkIGJ5IGF1dG9jb3Jy ZWN0aW9uIHJlc3VsdCBkZXBlbmRpbmcgb24gdXNlciBkYXRhCisgICAgICAgIHRoYXQgbWF5IGJl IGFsdGVyZWQgYnkgcHJldmlvdXMgdGVzdCBydW5zLiBIb3BlZnVsbHkgd2UgY2FuIHR1cm4gdGhl IHRlc3QgYmFjayBvbiBvbmNlIHdlIGhhdmUgYSB3YXkgdG8gbWFrZSBhdXRvY29ycmVjdGlvbgor ICAgICAgICBiZWhhdmUgY29uc2lzdGVudGx5LgorCisgICAgICAgIEJhc2ljYWxseSB3ZSBzaG91 bGQgY2hlY2sgdGhlIHZhbHVlIG9mIHNob3VsZENoZWNrRm9yQ29ycmVjdGlvbiwgbm90IHNob3Vs ZFNob3dDb3JyZWN0aW9uUGFuZWwsIHRvIGRldGVybWluZSBpZiB3ZSBzaG91bGQKKyAgICAgICAg ZWFybHkgcmV0dXJuIGluIG1hcmtBbmRSZXBsYWNlRm9yKCkuIAorCisgICAgICAgICogZWRpdGlu Zy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjptYXJrQW5kUmVwbGFjZUZv cik6CisKIDIwMTItMDYtMjUgIEFsbGFuIFhhdmllciAgPGFsbGFuLnhhdmllckB1bmRlZmluZWRs dGQuY28udWs+CiAKICAgICAgICAgW0dUS10gQWRkIGdyYXBodml6IGRlYnVnIG91dHB1dCBmb3Ig dGhlIGdzdHJlYW1lciB2aWRlbyBwaXBlbGluZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvRWRpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcApp bmRleCA4NWNhYjEzM2I1OWJjZDI4YmQ5MTAxYTY0NTU0Nzg4ZmNiNTY2YzBhLi40NGU2YTBkZDI3 YWMzZDcwZTEzZDNiYjRhZTgzN2M4NDFkZGFkMTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0VkaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3Iu Y3BwCkBAIC0yMDg1LDcgKzIwODUsNyBAQCB2b2lkIEVkaXRvcjo6bWFya0FuZFJlcGxhY2VGb3Io UGFzc1JlZlB0cjxTcGVsbENoZWNrUmVxdWVzdD4gcmVxdWVzdCwgY29uc3QgVmVjdAogICAgICAg ICAgICAgaWYgKHJlc3VsdC0+dHlwZSA9PSBUZXh0Q2hlY2tpbmdUeXBlTGluayAmJiBzZWxlY3Rp b25PZmZzZXQgPiByZXN1bHRMb2NhdGlvbiArIHJlc3VsdExlbmd0aCArIDEpCiAgICAgICAgICAg ICAgICAgY29udGludWU7CiAKLSAgICAgICAgICAgIGlmICghKHNob3VsZFBlcmZvcm1SZXBsYWNl bWVudCB8fCBzaG91bGRTaG93Q29ycmVjdGlvblBhbmVsIHx8IHNob3VsZE1hcmtMaW5rKSB8fCAh ZG9SZXBsYWNlbWVudCkKKyAgICAgICAgICAgIGlmICghKHNob3VsZFBlcmZvcm1SZXBsYWNlbWVu dCB8fCBzaG91bGRDaGVja0ZvckNvcnJlY3Rpb24gfHwgc2hvdWxkTWFya0xpbmspIHx8ICFkb1Jl cGxhY2VtZW50KQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgICAgICBTdHJp bmcgcmVwbGFjZWRTdHJpbmcgPSBwbGFpblRleHQocmFuZ2VUb1JlcGxhY2UuZ2V0KCkpOwo= 149774 2012-06-27 11:00:27 -0700 2012-07-04 14:24:42 -0700 Revised patch. bug-89982-20120627110025.patch text/plain 2901 jiapu.mail U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2YjRjZDgzYzUxODAz ODk4MzBjMGRkMDZmMTI0MmRlOWZhZDBhMy4uNTQwNmY0N2RiZmM3NmJiZDc4MjNkNThhYTNjY2Zm NjFjZTE4NmEwMiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTI3ICBKaWEg UHUgIDxqcHVAYXBwbGUuY29tPgorCisgICAgICAgIEJ1ZyA4OTk4MiAtIE9uIE1hYywgYXV0b2Nv cnJlY3Rpb24gc29tZXRpbWVzIGZhaWxzIHRvIHRha2UgcGxhY2UgaW4gU2FmYXJpLgorCisgICAg ICAgIE9uIE1hYywgYXV0b2NvcnJlY3Rpb24gc29tZXRpbWVzIGZhaWxzIHRvIHRha2UgcGxhY2Ug aW4gU2FmYXJpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODk5ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZSBzaG91bGQgY2hlY2sgdGhlIHZhbHVlIG9mIHNob3VsZENoZWNrRm9yQ29ycmVjdGlvbiwg bm90IHNob3VsZFNob3dDb3JyZWN0aW9uUGFuZWwsIHRvIGRldGVybWluZSBpZiB3ZSBzaG91bGQK KyAgICAgICAgZWFybHkgcmV0dXJuIGluIG1hcmtBbmRSZXBsYWNlRm9yKCkuIEFsc28sIHNpbmNl IHdlIGRvbid0IHdhbnQgYXV0b2NvcnJlY3Rpb24gdG8gaGFwcGVuIHdoZW4gd2Ugb25seSBjaGFu Z2Ugc2VsZWN0aW9uLAorICAgICAgICBub3QgdGhlIGNvbnRlbnQsIHNvIHdlIHNob3VsZG4ndCBz ZXQgVGV4dENoZWNraW5nVHlwZUNvcnJlY3Rpb24gZmxhZyBpbiBtYXJrTWlzc3BlbGxpbmdzQW5k QmFkR3JhbW1hcigpIGFzIHRoaXMgZnVuY3Rpb24KKyAgICAgICAgaXMgdHJpZ2dlcmVkIG9ubHkg Ynkgc2VsZWN0aW9uIGNoYW5nZS4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6bWFya0FuZFJlcGxhY2VGb3IpOgorICAgICAgICAoV2Vi Q29yZTo6RWRpdG9yOjptYXJrTWlzc3BlbGxpbmdzQW5kQmFkR3JhbW1hcik6CisKIDIwMTItMDYt MjcgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEhU TUxTdHlsZUVsZW1lbnQ6OnJlbW92ZWRGcm9tIHNlZW1zIGluY29ycmVjdC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRWRpdG9yLmNwcAppbmRleCBjMzA0M2I1MDQ4ZDFmMjk2NmZkMWZlN2Y0MWZmNGFkOTAzNTE5 NmEzLi45ZjMzMjk5YzI3MTU5NWQzNzcwNTFiOTUzOGUyZTQ0ZmUyMTkyY2ZmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9FZGl0b3IuY3BwCkBAIC0yMDg1LDcgKzIwODUsNyBAQCB2b2lkIEVkaXRvcjo6bWFy a0FuZFJlcGxhY2VGb3IoUGFzc1JlZlB0cjxTcGVsbENoZWNrUmVxdWVzdD4gcmVxdWVzdCwgY29u c3QgVmVjdAogICAgICAgICAgICAgaWYgKHJlc3VsdC0+dHlwZSA9PSBUZXh0Q2hlY2tpbmdUeXBl TGluayAmJiBzZWxlY3Rpb25PZmZzZXQgPiByZXN1bHRMb2NhdGlvbiArIHJlc3VsdExlbmd0aCAr IDEpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgICAgIGlmICghKHNob3Vs ZFBlcmZvcm1SZXBsYWNlbWVudCB8fCBzaG91bGRTaG93Q29ycmVjdGlvblBhbmVsIHx8IHNob3Vs ZE1hcmtMaW5rKSB8fCAhZG9SZXBsYWNlbWVudCkKKyAgICAgICAgICAgIGlmICghKHNob3VsZFBl cmZvcm1SZXBsYWNlbWVudCB8fCBzaG91bGRDaGVja0ZvckNvcnJlY3Rpb24gfHwgc2hvdWxkTWFy a0xpbmspIHx8ICFkb1JlcGxhY2VtZW50KQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAg ICAgICAgICAgICBTdHJpbmcgcmVwbGFjZWRTdHJpbmcgPSBwbGFpblRleHQocmFuZ2VUb1JlcGxh Y2UuZ2V0KCkpOwpAQCAtMjE4OCw3ICsyMTg4LDkgQEAgdm9pZCBFZGl0b3I6Om1hcmtNaXNzcGVs bGluZ3NBbmRCYWRHcmFtbWFyKGNvbnN0IFZpc2libGVTZWxlY3Rpb24mIHNwZWxsaW5nU2VsZWMK ICAgICBpZiAodW5pZmllZFRleHRDaGVja2VyRW5hYmxlZCgpKSB7CiAgICAgICAgIGlmICghaXND b250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoKSkKICAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgVGV4dENoZWNraW5nVHlwZU1hc2sgdGV4dENoZWNraW5nT3B0aW9ucyA9IFRleHRDaGVj a2luZ1R5cGVTcGVsbGluZyB8IFRleHRDaGVja2luZ1R5cGVDb3JyZWN0aW9uOworCisgICAgICAg IC8vIG1hcmtNaXNzcGVsbGluZ3NBbmRCYWRHcmFtbWFyKCkgaXMgdHJpZ2dlcmVkIGJ5IHNlbGVj dGlvbiBjaGFuZ2UsIGluIHdoaWNoIGNhc2Ugd2UgY2hlY2sgc3BlbGxpbmcgYW5kIGdyYW1tYXIs IGJ1dCBkb24ndCBhdXRvY29ycmVjdCBtaXNzcGVsbGluZ3MuCisgICAgICAgIFRleHRDaGVja2lu Z1R5cGVNYXNrIHRleHRDaGVja2luZ09wdGlvbnMgPSBUZXh0Q2hlY2tpbmdUeXBlU3BlbGxpbmc7 CiAgICAgICAgIGlmIChtYXJrR3JhbW1hciAmJiBpc0dyYW1tYXJDaGVja2luZ0VuYWJsZWQoKSkK ICAgICAgICAgICAgIHRleHRDaGVja2luZ09wdGlvbnMgfD0gVGV4dENoZWNraW5nVHlwZUdyYW1t YXI7CiAgICAgICAgIG1hcmtBbGxNaXNzcGVsbGluZ3NBbmRCYWRHcmFtbWFySW5SYW5nZXModGV4 dENoZWNraW5nT3B0aW9ucywgc3BlbGxpbmdTZWxlY3Rpb24udG9Ob3JtYWxpemVkUmFuZ2UoKS5n ZXQoKSwgZ3JhbW1hclNlbGVjdGlvbi50b05vcm1hbGl6ZWRSYW5nZSgpLmdldCgpKTsK