89980 2012-06-26 07:36:05 -0700 Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs 2012-06-27 04:35:43 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov cmarcelo hyatt kling koivisto macpherson menard oliver webkit.review.bot oldest_to_newest 657596 0 apavlov 2012-06-26 07:36:05 -0700 Currently, the first font_face alternative explicitly consumes a '}' and maybe_space following it. This entirely agrees with http://www.w3.org/TR/1998/REC-CSS2-19980512/grammar.html but not with http://www.w3.org/TR/CSS21/syndata.html#parsing-errors, the "Unexpected end of style sheet." item, which says the following: "User agents must close all open constructs (for example: blocks, parentheses, brackets, rules, strings, and comments) at the end of the style sheet. For example: @media screen { p:before { content: 'Hello would be treated the same as: @media screen { p:before { content: 'Hello'; } } in a conformant UA." All other block_valid_rule's use either save_block or closing_brace, so an unexpected end of style sheet works fine for them - but not for @font-face. 657609 1 149532 apavlov 2012-06-26 07:58:48 -0700 Created attachment 149532 Patch 658529 2 149532 webkit.review.bot 2012-06-27 04:35:23 -0700 Comment on attachment 149532 Patch Clearing flags on attachment: 149532 Committed r121337: <http://trac.webkit.org/changeset/121337> 658531 3 webkit.review.bot 2012-06-27 04:35:43 -0700 All reviewed patches have been landed. Closing bug. 149532 2012-06-26 07:58:48 -0700 2012-06-27 04:35:22 -0700 Patch bug-89980-20120626185847.patch text/plain 4122 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBjMTUwZjY2NDg0ZGQw ZWQzZjg4YThhNzNjOTQyZDYwNWUwZWE3ZC4uMzMyN2RjN2JmMGE2ZDNjZjRmMzExNTYyNGNiY2Zj NTY4ODE2MjBhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTI2ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVW5leHBlY3Rl ZCBlbmQgb2Ygc3R5bGUgc2hlZXQgaW4gQGZvbnQtZmFjZSBydWxlIGRpc2NhcmRzIGl0IHJhdGhl ciB0aGFuIGNsb3NlcyBhbGwgb3BlbiBjb25zdHJ1Y3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUgImNsb3NpbmdfYnJhY2UiIGF0IHRoZSBl bmQgb2YgZm9udF9mYWNlIHJhdGhlciB0aGFuIHRoZSBleHBsaWNpdCAiJ30nIG1heWJlX3NwYWNl Ii4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9mb250LWZhY2UtdW5leHBlY3RlZC1lbmQuaHRt bAorCisgICAgICAgICogY3NzL0NTU0dyYW1tYXIueToKKwogMjAxMi0wNi0yNSAgQWxleGFuZGVy IFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFtTdHlsZXNdIENhbm5vdCB2aXN1YWxseSBzZXQgY2FyZXQgYmVmb3JlIHRoZSBmaXJzdCBDU1Mg cHJvcGVydHkgbmFtZSBjaGFyYWN0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NHcmFtbWFyLnkgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55CmluZGV4IDdhZGNj MzdiY2MzZWEwOTIyY2ViYmFlYzlhNDFhY2EwMjUzMDg5ZTQuLjJiYTAyMzk3NGE3OWVhMjFjOWQ0 NTU4YWRjNGE4YTIwZDkxYjBjZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NH cmFtbWFyLnkKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQpAQCAtMTAxLDcg KzEwMSw3IEBAIHN0YXRpYyBpbnQgY3NzeXlsZXgoWVlTVFlQRSogeXlsdmFsLCB2b2lkKiBwYXJz ZXIpCiAKICV9CiAKLSVleHBlY3QgNjMKKyVleHBlY3QgNjIKIAogJW5vbmFzc29jIExPV0VTVF9Q UkVDCiAKQEAgLTc4OSw3ICs3ODksNyBAQCBtYXJnaW5fc3ltIDoKIAogZm9udF9mYWNlOgogICAg IEZPTlRfRkFDRV9TWU0gbWF5YmVfc3BhY2UKLSAgICAneycgbWF5YmVfc3BhY2UgZGVjbGFyYXRp b25fbGlzdCAnfScgIG1heWJlX3NwYWNlIHsKKyAgICAneycgbWF5YmVfc3BhY2UgZGVjbGFyYXRp b25fbGlzdCBjbG9zaW5nX2JyYWNlIHsKICAgICAgICAgJCQgPSBzdGF0aWNfY2FzdDxDU1NQYXJz ZXIqPihwYXJzZXIpLT5jcmVhdGVGb250RmFjZVJ1bGUoKTsKICAgICB9CiAgICAgfCBGT05UX0ZB Q0VfU1lNIGVycm9yIGludmFsaWRfYmxvY2sgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDM5YmM3NTA0MjNiMDEzZTRjODRj ZTQ1ZGI1NmM1MmIzYzM5NDIyMmMuLjViZWJhNWU5ZTcxYmUzYWE4YzYyZjI2ZWI0NjFiYWY0NzM5 NDc4ZTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNi0yNiAgQWxleGFuZGVyIFBhdmxv diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFVuZXhwZWN0ZWQgZW5kIG9mIHN0 eWxlIHNoZWV0IGluIEBmb250LWZhY2UgcnVsZSBkaXNjYXJkcyBpdCByYXRoZXIgdGhhbiBjbG9z ZXMgYWxsIG9wZW4gY29uc3RydWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODk5ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZhc3QvY3NzL2ZvbnQtZmFjZS11bmV4cGVjdGVkLWVuZC1leHBlY3Rl ZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9mb250LWZhY2UtdW5leHBlY3RlZC1l bmQuaHRtbDogQWRkZWQuCisKIDIwMTItMDYtMjUgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xl LmNvbT4KIAogICAgICAgICBGaXggcmV3aW5kaW5nIG9mIFNWRyBhbmltYXRpb25zCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9mb250LWZhY2UtdW5leHBlY3RlZC1lbmQtZXhwZWN0 ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2ZvbnQtZmFjZS11bmV4cGVjdGVkLWVuZC1l eHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY0NTIxMzhjM2RjOTA3MzE1MDc2Y2M0OTQxMDY0NGFl MTNhNWMxOTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9mb250LWZh Y2UtdW5leHBlY3RlZC1lbmQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE0IEBACis8c3R5bGU+ CisgICAgQGZvbnQtZmFjZSB7CisgICAgICAgIGZvbnQtZmFtaWx5OiBhaGVtLWZhbWlseTsKKyAg ICAgICAgc3JjOiB1cmwoLi4vLi4vcmVzb3VyY2VzL0FoZW0ub3RmKTsKKyAgICB9Cis8L3N0eWxl PgorPHA+CisgICAgVGVzdCBmb3IgPGk+PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg5OTgwIj5odHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODk5ODA8L2E+IFVuZXhwZWN0ZWQgZW5kIG9mIHN0eWxlIHNoZWV0IGluIEBmb250LWZh Y2UgcnVsZSBkaXNjYXJkcyBpdCByYXRoZXIgdGhhbiBjbG9zZXMgYWxsIG9wZW4gY29uc3RydWN0 czwvaT4uCis8L3A+Cis8cD5DaGVjayBpZiBhIEBmb250LWZhY2UgcnVsZSB3aXRob3V0IGEgY2xv c2luZyBicmFjZSBpcyBhY2NlcHRlZC48L3A+Cis8c3BhbiBzdHlsZT0iZm9udC1mYW1pbHk6IGFo ZW0tZmFtaWx5Ij4wMTIzNDU2Nzg5QUJDREVGPC9zcGFuPgorPHNjcmlwdD4KKyAgICBkb2N1bWVu dC5ib2R5Lm9mZnNldFRvcDsKKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9jc3MvZm9udC1mYWNlLXVuZXhwZWN0ZWQtZW5kLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nz cy9mb250LWZhY2UtdW5leHBlY3RlZC1lbmQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZTY2ODgyMDE1MTU4 M2QyOWQ1YzEyNTdmNmZmY2E2ZjQxYjk4OTFlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9jc3MvZm9udC1mYWNlLXVuZXhwZWN0ZWQtZW5kLmh0bWwKQEAgLTAsMCArMSwxNCBA QAorPHN0eWxlPgorICAgIEBmb250LWZhY2UgeworICAgICAgICBmb250LWZhbWlseTogYWhlbS1m YW1pbHk7CisgICAgICAgIHNyYzogdXJsKC4uLy4uL3Jlc291cmNlcy9BaGVtLm90Zik7CisgICAg LyogVGhlIEBmb250LWZhY2UgcnVsZSBoYXMgbm8gY2xvc2luZyBicmFjZSwgc28gdGhlIHN0eWxl IHNoZWV0IGlzIHRlcm1pbmF0ZWQgdW5leHBlY3RlZGx5LiAqLworPC9zdHlsZT4KKzxwPgorICAg IFRlc3QgZm9yIDxpPjxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04OTk4MCI+aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5OTgw PC9hPiBVbmV4cGVjdGVkIGVuZCBvZiBzdHlsZSBzaGVldCBpbiBAZm9udC1mYWNlIHJ1bGUgZGlz Y2FyZHMgaXQgcmF0aGVyIHRoYW4gY2xvc2VzIGFsbCBvcGVuIGNvbnN0cnVjdHM8L2k+LgorPC9w PgorPHA+Q2hlY2sgaWYgYSBAZm9udC1mYWNlIHJ1bGUgd2l0aG91dCBhIGNsb3NpbmcgYnJhY2Ug aXMgYWNjZXB0ZWQuPC9wPgorPHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OiBhaGVtLWZhbWlseSI+ MDEyMzQ1Njc4OUFCQ0RFRjwvc3Bhbj4KKzxzY3JpcHQ+CisgICAgZG9jdW1lbnQuYm9keS5vZmZz ZXRUb3A7Cis8L3NjcmlwdD4K