89979 2012-06-26 07:03:23 -0700 [Chromium] Tests still crashing for Linux Release as well. 2012-07-03 01:18:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mstarzinger webkit-unassigned webkit.review.bot oldest_to_newest 657587 0 mstarzinger 2012-06-26 07:03:23 -0700 [Chromium] Tests still crashing for Linux Release as well. 657589 1 149529 mstarzinger 2012-06-26 07:09:50 -0700 Created attachment 149529 Patch 657590 2 mstarzinger 2012-06-26 07:12:45 -0700 We still see these two tests failing for Linux Release as well (not only Linux Debug) for integration builders on the V8 waterfall. http://build.chromium.org/p/client.v8/builders/Webkit%20Linux/builds/4337 http://build.chromium.org/p/client.v8/builders/Webkit%20Linux%2064/builds/4324 657629 3 rniwa 2012-06-26 08:47:39 -0700 Huh? Please don't assign me to bugs. 657781 4 mstarzinger 2012-06-26 11:30:39 -0700 Sorry for that, I am not (yet) familiar with the WebKit workflow. 657942 5 149529 tony 2012-06-26 13:43:54 -0700 Comment on attachment 149529 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149529&action=review You might want to coordinate with the webkit gardener rather than going through a full code review for this type of change. > LayoutTests/platform/chromium/TestExpectations:3422 > BUGCR121442 LINUX DEBUG : plugins/iframe-shims.html = CRASH > +BUGCR121442 LINUX RELEASE : plugins/iframe-shims.html = PASS CRASH Does the test sometimes pass? It would be good to have that information as a comment on the bug, e.g., a link to the flakiness dashboard. A stack trace on the bug is also useful). 659656 6 mstarzinger 2012-06-28 11:42:55 -0700 (In reply to comment #5) > You might want to coordinate with the webkit gardener rather than going through a full code review for this type of change. Thanks for the hint. I will contact the WebKit gardener instead of uploading a patch myself next time. > > LayoutTests/platform/chromium/TestExpectations:3422 > > BUGCR121442 LINUX DEBUG : plugins/iframe-shims.html = CRASH > > +BUGCR121442 LINUX RELEASE : plugins/iframe-shims.html = PASS CRASH > > Does the test sometimes pass? It would be good to have that information as a comment on the bug, e.g., a link to the flakiness dashboard. A stack trace on the bug is also useful). It consistently passes on Chromium buildbots and when run locally on my machine, but it consistently crashes on the V8 buildbots (for Linux Release). The relevant information (link to V8 buildbots and flakiness dashboard) is on the Chromium issue tracker. 662038 7 149529 webkit.review.bot 2012-07-03 01:17:59 -0700 Comment on attachment 149529 Patch Clearing flags on attachment: 149529 Committed r121738: <http://trac.webkit.org/changeset/121738> 662039 8 webkit.review.bot 2012-07-03 01:18:03 -0700 All reviewed patches have been landed. Closing bug. 149529 2012-06-26 07:09:50 -0700 2012-07-03 01:17:58 -0700 Patch bug-89979-20120626160949.patch text/plain 1838 mstarzinger SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyMTI2MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2LTI2ICBNaWNoYWVsIFN0YXJ6aW5n ZXIgIDxtc3RhcnppbmdlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBUZXN0 cyBzdGlsbCBjcmFzaGluZyBmb3IgTGludXggUmVsZWFzZSBhcyB3ZWxsLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk5NzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rl c3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMDYtMjYgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xl LmNvbT4KIAogICAgICAgICBGaXggYnVnIHdoZXJlIGFuaW1hdGlvbnMgZmFpbGVkIHRvIHN0YXJ0 CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlv bnMJKHJldmlzaW9uIDEyMTEyNikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rl c3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTMwOTksOCArMzA5OSw3IEBAIEJVR1dL NzczMTQgV0lOIE1BQyA6IGZhc3QvZXZlbnRzL3RvdWNoL3MKIEJVR1dLNzczMjQgV0lOIE1BQyBE RUJVRyBTTE9XIDogZmFzdC9qcy9kZmctaW50MzJhcnJheS5odG1sID0gUEFTUwogCiAvLyBDUkFT SCBjb21lcyBmcm9tIEJVR0NSMTIxNDQyCi1CVUdXSzc3Mzk3IExJTlVYIERFQlVHIDogcGx1Z2lu cy9jcmFzaC1yZXN0b3JpbmctcGx1Z2luLXBhZ2UtZnJvbS1wYWdlLWNhY2hlLmh0bWwgPSBUSU1F T1VUIENSQVNICi1CVUdXSzc3Mzk3IExJTlVYIFJFTEVBU0UgOiBwbHVnaW5zL2NyYXNoLXJlc3Rv cmluZy1wbHVnaW4tcGFnZS1mcm9tLXBhZ2UtY2FjaGUuaHRtbCA9IFRJTUVPVVQKK0JVR1dLNzcz OTcgTElOVVggOiBwbHVnaW5zL2NyYXNoLXJlc3RvcmluZy1wbHVnaW4tcGFnZS1mcm9tLXBhZ2Ut Y2FjaGUuaHRtbCA9IFRJTUVPVVQgQ1JBU0gKIEJVR1dLNzczOTcgV0lOIE1BQyA6IHBsdWdpbnMv Y3Jhc2gtcmVzdG9yaW5nLXBsdWdpbi1wYWdlLWZyb20tcGFnZS1jYWNoZS5odG1sID0gVElNRU9V VAogCiAvLyBTdGFydGVkIGNyYXNoaW5nIGF0IFdLIHIxMDY0MjIuCkBAIC0zNDIwLDYgKzM0MTks NyBAQCBCVUdXSzgyNzc2IFNLSVAgOiBzdG9yYWdlL2luZGV4ZWRkYi9wZW5kCiBCVUdXSyBXSU4g UkVMRUFTRSA6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVkaXJlY3QtY3Jvc3Mtb3JpZ2lu LXBvc3QuaHRtbCA9IFBBU1MgVEVYVAogCiBCVUdDUjEyMTQ0MiBMSU5VWCBERUJVRyA6IHBsdWdp bnMvaWZyYW1lLXNoaW1zLmh0bWwgPSBDUkFTSAorQlVHQ1IxMjE0NDIgTElOVVggUkVMRUFTRSA6 IHBsdWdpbnMvaWZyYW1lLXNoaW1zLmh0bWwgPSBQQVNTIENSQVNICiAKIEJVR1dLODMyMTkgTElP TiA6IGZvbnRzL2N1cnNpdmUuaHRtbCA9IFBBU1MgSU1BR0UrVEVYVAogQlVHV0s4MzMyNCBXSU4g REVCVUcgOiBmYXN0L2pzL2Nyb3NzLWdsb2JhbC1vYmplY3QtaW5saW5lLWdsb2JhbC12YXIuaHRt bCA9IFBBU1MgVEVYVAo=