89976 2012-06-26 06:40:27 -0700 [EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory() 2012-06-26 16:40:20 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 657572 0 cdumez 2012-06-26 06:40:27 -0700 listDirectory in fileSystemEfl.cpp is currently using POSIX C functions to list the directory. Using eina_file_ls() would make the code much shorter and more maintainable. 657573 1 149524 cdumez 2012-06-26 06:44:24 -0700 Created attachment 149524 Patch 658099 2 149524 webkit.review.bot 2012-06-26 16:40:13 -0700 Comment on attachment 149524 Patch Clearing flags on attachment: 149524 Committed r121300: <http://trac.webkit.org/changeset/121300> 658100 3 webkit.review.bot 2012-06-26 16:40:20 -0700 All reviewed patches have been landed. Closing bug. 149524 2012-06-26 06:44:24 -0700 2012-06-26 16:40:13 -0700 Patch 89976_listDirectory.patch text/plain 2956 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0N2E4ZDQ4Li4xYTVlODYwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDYtMjYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBVc2UgZWluYV9maWxlX2xzKCkgaW4gRUZMIGltcGxlbWVu dGF0aW9uIG9mIEZpbGVTeXN0ZW0gbGlzdERpcmVjdG9yeSgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk3NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJld3JpdGUgRUZMIGltcGxlbWVudGF0aW9uIG9m IEZpbGVzeXN0ZW0gbGlzdERpcmVjdG9yeSgpIGluIG9yZGVyIHRvCisgICAgICAgIHVzZSBlaW5h X2ZpbGVfbHMoKSBpbnN0ZWFkIG9mIFBPU0lYIEMgZnVuY3Rpb25zLiBUaGlzIHJlc3VsdHMgaW4K KyAgICAgICAgc2hvcnRlciBjb2RlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVoYXZpb3Ig aGFzIG5vdCBjaGFuZ2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1FZmwu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6bGlzdERpcmVjdG9yeSk6CisKIDIwMTItMDYtMjYgIFRh aWp1IFRzdWlraSAgPHR6aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEFkZCByZXF1ZXN0TWV0YWRhdGEgY29tbWFuZCBhbmQgbWV0YWRhdGFSZWNlaXZlZCBldmVudCB0 byBGaWxlU3lzdGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvRmls ZVN5c3RlbUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVm bC5jcHAKaW5kZXggZDRhZGIxNi4uYzZiZmYxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1FZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcApAQCAtODYsNTAgKzg2LDE5IEBAIFN0cmluZyBob21l RGlyZWN0b3J5UGF0aCgpCiAKIFZlY3RvcjxTdHJpbmc+IGxpc3REaXJlY3RvcnkoY29uc3QgU3Ry aW5nJiBwYXRoLCBjb25zdCBTdHJpbmcmIGZpbHRlcikKIHsKLSAgICBWZWN0b3I8U3RyaW5nPiBl bnRyaWVzOwotICAgIENTdHJpbmcgY3BhdGggPSBwYXRoLnV0ZjgoKTsKKyAgICBWZWN0b3I8U3Ry aW5nPiBtYXRjaGluZ0VudHJpZXM7CiAgICAgQ1N0cmluZyBjZmlsdGVyID0gZmlsdGVyLnV0Zjgo KTsKLSAgICBjaGFyIGZpbGVQYXRoW1BBVEhfTUFYXTsKLSAgICBjaGFyKiBmaWxlTmFtZTsKLSAg ICBzaXplX3QgZmlsZU5hbWVTcGFjZTsKLSAgICBESVIqIGRpcjsKKyAgICBjb25zdCBjaGFyICpm X25hbWU7CiAKLSAgICBpZiAoY3BhdGgubGVuZ3RoKCkgKyBOQU1FX01BWCA+PSBzaXplb2YoZmls ZVBhdGgpKQotICAgICAgICByZXR1cm4gZW50cmllczsKLSAgICAvLyBsb29wIGludmFyaWFudDog ZGlyZWN0b3J5IHBhcnQgKyAnLycKLSAgICBtZW1jcHkoZmlsZVBhdGgsIGNwYXRoLmRhdGEoKSwg Y3BhdGgubGVuZ3RoKCkpOwotICAgIGZpbGVOYW1lID0gZmlsZVBhdGggKyBjcGF0aC5sZW5ndGgo KTsKLSAgICBpZiAoY3BhdGgubGVuZ3RoKCkgPiAwICYmIGZpbGVQYXRoW2NwYXRoLmxlbmd0aCgp IC0gMV0gIT0gJy8nKSB7Ci0gICAgICAgIGZpbGVOYW1lWzBdID0gJy8nOwotICAgICAgICBmaWxl TmFtZSsrOworICAgIEVpbmFfSXRlcmF0b3IqIGl0ID0gZWluYV9maWxlX2xzKHBhdGgudXRmOCgp LmRhdGEoKSk7CisgICAgRUlOQV9JVEVSQVRPUl9GT1JFQUNIKGl0LCBmX25hbWUpIHsKKyAgICAg ICAgaWYgKCFmbm1hdGNoKGNmaWx0ZXIuZGF0YSgpLCBmX25hbWUsIDApKQorICAgICAgICAgICAg bWF0Y2hpbmdFbnRyaWVzLmFwcGVuZChTdHJpbmc6OmZyb21VVEY4KGZfbmFtZSkpOworICAgICAg ICBlaW5hX3N0cmluZ3NoYXJlX2RlbChmX25hbWUpOwogICAgIH0KLSAgICBmaWxlTmFtZVNwYWNl ID0gc2l6ZW9mKGZpbGVQYXRoKSAtIChmaWxlTmFtZSAtIGZpbGVQYXRoKSAtIDE7CisgICAgZWlu YV9pdGVyYXRvcl9mcmVlKGl0KTsKIAotICAgIGRpciA9IG9wZW5kaXIoY3BhdGguZGF0YSgpKTsK LSAgICBpZiAoIWRpcikKLSAgICAgICAgcmV0dXJuIGVudHJpZXM7Ci0KLSAgICBzdHJ1Y3QgZGly ZW50KiBkZTsKLSAgICB3aGlsZSAoZGUgPSByZWFkZGlyKGRpcikpIHsKLSAgICAgICAgc2l6ZV90 IG5hbWVMZW47Ci0gICAgICAgIGlmIChkZS0+ZF9uYW1lWzBdID09ICcuJykgewotICAgICAgICAg ICAgaWYgKGRlLT5kX25hbWVbMV0gPT0gJ1wwJykKLSAgICAgICAgICAgICAgICBjb250aW51ZTsK LSAgICAgICAgICAgIGlmIChkZS0+ZF9uYW1lWzFdID09ICcuJyAmJiBkZS0+ZF9uYW1lWzJdID09 ICdcMCcpCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIH0KLSAgICAgICAgaWYg KGZubWF0Y2goY2ZpbHRlci5kYXRhKCksIGRlLT5kX25hbWUsIDApKQotICAgICAgICAgICAgY29u dGludWU7Ci0KLSAgICAgICAgbmFtZUxlbiA9IHN0cmxlbihkZS0+ZF9uYW1lKTsKLSAgICAgICAg aWYgKG5hbWVMZW4gPj0gZmlsZU5hbWVTcGFjZSkKLSAgICAgICAgICAgIGNvbnRpbnVlOyAvLyBt YXliZSBhc3NlcnQ/IGl0IHNob3VsZCBuZXZlciBoYXBwZW4gYW55d2F5Li4uCi0KLSAgICAgICAg bWVtY3B5KGZpbGVOYW1lLCBkZS0+ZF9uYW1lLCBuYW1lTGVuICsgMSk7Ci0gICAgICAgIGVudHJp ZXMuYXBwZW5kKGZpbGVQYXRoKTsKLSAgICB9Ci0gICAgY2xvc2VkaXIoZGlyKTsKLSAgICByZXR1 cm4gZW50cmllczsKKyAgICByZXR1cm4gbWF0Y2hpbmdFbnRyaWVzOwogfQogCiB9Cg==