89972 2012-06-26 04:57:27 -0700 [EFL] Use Eina_Module API instead of dlopen in PluginPackageEfl 2012-06-28 13:56:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 657502 0 cdumez 2012-06-26 04:57:27 -0700 PluginPackageEfl is currently using the POSIX dlopen() / dlsym() / dlclose() although EFL has helpers for this in Eina_Module. We should use Eina_Module instead. 657507 1 149509 cdumez 2012-06-26 05:01:23 -0700 Created attachment 149509 Patch 658061 2 149509 rakuco 2012-06-26 15:56:50 -0700 Comment on attachment 149509 Patch Looks good. I'd drop the changes to the way m_loadCount is increased just to make the patch touch as little code as possible, but that's not a blocker. 658379 3 cdumez 2012-06-26 23:26:59 -0700 (In reply to comment #2) > (From update of attachment 149509 [details]) > Looks good. I'd drop the changes to the way m_loadCount is increased just to make the patch touch as little code as possible, but that's not a blocker. The m_loadCount change is still in the same function and it is a harmless change. I don't think it is worth writing another patch for this change and this seemed like a good opportunity to fix it. 659728 4 149509 tonikitoo 2012-06-28 13:03:20 -0700 Comment on attachment 149509 Patch I wish we actually had a Unix or Posix file for this, where Gtk, EFl and BlckaBerry could share some code. 659789 5 149509 webkit.review.bot 2012-06-28 13:56:45 -0700 Comment on attachment 149509 Patch Clearing flags on attachment: 149509 Committed r121467: <http://trac.webkit.org/changeset/121467> 659790 6 webkit.review.bot 2012-06-28 13:56:49 -0700 All reviewed patches have been landed. Closing bug. 149509 2012-06-26 05:01:23 -0700 2012-06-28 13:56:45 -0700 Patch 89972_plugin_einamodule.patch text/plain 4697 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0N2E4ZDQ4Li4wMDUzYjMzIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMDYtMjYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBVc2UgRWluYV9Nb2R1bGUgQVBJIGluc3RlYWQgb2YgZGxv cGVuIGluIFBsdWdpblBhY2thZ2VFZmwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg5OTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXNlIGNvbnZlbmllbmNlIGhlbHBlcnMgaW4gRWluYV9Nb2R1bGUgdG8g bG9hZCBwbHVnaW5zIGluc3RlYWQKKyAgICAgICAgb2YgUE9TSVggZGxvcGVuKCkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBiZWhhdmlvciBoYXMgbm90IGNoYW5nZWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9GaWxlU3lzdGVtLmg6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp1bmxvYWRNb2R1 bGUpOgorICAgICAgICAqIHBsdWdpbnMvZWZsL1BsdWdpblBhY2thZ2VFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6bG9hZCk6CisKIDIwMTItMDYtMjYgIFRhaWp1IFRz dWlraSAgPHR6aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBy ZXF1ZXN0TWV0YWRhdGEgY29tbWFuZCBhbmQgbWV0YWRhdGFSZWNlaXZlZCBldmVudCB0byBGaWxl U3lzdGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgKaW5kZXggYjNjMjU5YS4uYTZi M2E2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZVN5c3RlbS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVTeXN0ZW0uaApAQCAtNzEsNiArNzEsMTAg QEAgdHlwZWRlZiBzdHJ1Y3QgX0dGaWxlSU9TdHJlYW0gR0ZpbGVJT1N0cmVhbTsKIHR5cGVkZWYg c3RydWN0IF9HTW9kdWxlIEdNb2R1bGU7CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEVGTCkKK3R5 cGVkZWYgc3RydWN0IF9FaW5hX01vZHVsZSBFaW5hX01vZHVsZTsKKyNlbmRpZgorCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIC8vIFBsYXRmb3JtTW9kdWxlCkBAIC03OCw2ICs4Miw4IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIHR5cGVkZWYgSE1PRFVMRSBQbGF0Zm9ybU1vZHVsZTsKICNlbGlmIFBM QVRGT1JNKEdUSykKIHR5cGVkZWYgR01vZHVsZSogUGxhdGZvcm1Nb2R1bGU7CisjZWxpZiBQTEFU Rk9STShFRkwpCit0eXBlZGVmIEVpbmFfTW9kdWxlKiBQbGF0Zm9ybU1vZHVsZTsKICNlbGlmIFBM QVRGT1JNKFFUKQogI2lmIGRlZmluZWQoUV9XU19NQUMpCiB0eXBlZGVmIENGQnVuZGxlUmVmIFBs YXRmb3JtTW9kdWxlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0Zp bGVTeXN0ZW1FZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1F ZmwuY3BwCmluZGV4IGQ0YWRiMTYuLjk5OTkwYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgYm9vbCB1bmxvYWRN b2R1bGUoUGxhdGZvcm1Nb2R1bGUgbW9kdWxlKQogICAgIC8vIGNhdXRpb24sIGNsb3NpbmcgaGFu ZGxlIHdpbGwgbWFrZSBtZW1vcnkgdmFuaXNoIGFuZCBhbnkgcmVtYWluaW5nCiAgICAgLy8gdGlt ZXIsIGlkbGVyLCB0aHJlYWRzIG9yIGFueSBvdGhlciBsZWZ0LW92ZXIgd2lsbCBjcmFzaCwKICAg ICAvLyBtYXliZSBqdXN0IGlnbm9yZSB0aGlzIGlzIGEgc2FmZXIgc29sdXRpb24/Ci0gICAgcmV0 dXJuICFkbGNsb3NlKG1vZHVsZSk7CisgICAgcmV0dXJuIGVpbmFfbW9kdWxlX2ZyZWUobW9kdWxl KTsKIH0KIAogU3RyaW5nIGhvbWVEaXJlY3RvcnlQYXRoKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsdWdpbnMvZWZsL1BsdWdpblBhY2thZ2VFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUv cGx1Z2lucy9lZmwvUGx1Z2luUGFja2FnZUVmbC5jcHAKaW5kZXggN2I5NTBkMy4uNTc1M2VkNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9lZmwvUGx1Z2luUGFja2FnZUVmbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9lZmwvUGx1Z2luUGFja2FnZUVmbC5jcHAK QEAgLTExMSwzMyArMTExLDMzIEBAIHVpbnQxNl90IFBsdWdpblBhY2thZ2U6Ok5QVmVyc2lvbigp IGNvbnN0CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6bG9hZCgpCiB7Ci0gICAgY2hhciogZXJybXNn OwotCiAgICAgaWYgKG1faXNMb2FkZWQpIHsKLSAgICAgICAgbV9sb2FkQ291bnQrKzsKKyAgICAg ICAgKyttX2xvYWRDb3VudDsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCi0gICAgbV9t b2R1bGUgPSBkbG9wZW4obV9wYXRoLnV0ZjgoKS5kYXRhKCksIFJUTERfTEFaWSB8IFJUTERfTE9D QUwpOwotICAgIGlmICgoZXJybXNnID0gZGxlcnJvcigpKSkgewotICAgICAgICBFSU5BX0xPR19X QVJOKCIlcyBub3QgbG9hZGVkOiAlcyIsIG1fcGF0aC51dGY4KCkuZGF0YSgpLCBlcnJtc2cpOwor ICAgIG1fbW9kdWxlID0gZWluYV9tb2R1bGVfbmV3KG1fcGF0aC51dGY4KCkuZGF0YSgpKTsKKyAg ICBpZiAoIW1fbW9kdWxlKSB7CisgICAgICAgIEVJTkFfTE9HX1dBUk4oIiVzIG5vdCBsb2FkZWQ6 IGVpbmFfbW9kdWxlX25ldygpIGZhaWxlZCIsIG1fcGF0aC51dGY4KCkuZGF0YSgpKTsKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgIH0KKyAgICBpZiAoIWVpbmFfbW9kdWxlX2xvYWQobV9tb2R1 bGUpKSB7CisgICAgICAgIGNvbnN0IGNoYXIqIGVycm9yTWVzc2FnZSA9IGVpbmFfZXJyb3JfbXNn X2dldChlaW5hX2Vycm9yX2dldCgpKTsKKyAgICAgICAgRUlOQV9MT0dfV0FSTigiJXMgbm90IGxv YWRlZDogJXMiLCBtX3BhdGgudXRmOCgpLmRhdGEoKSwgZXJyb3JNZXNzYWdlID8gZXJyb3JNZXNz YWdlIDogIk5vbmUiKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAogICAgIG1faXNM b2FkZWQgPSB0cnVlOwogCi0gICAgTlBfSW5pdGlhbGl6ZUZ1bmNQdHIgaW5pdGlhbGl6ZTsKLSAg ICBOUEVycm9yIGVycjsKLQotICAgIGluaXRpYWxpemUgPSByZWludGVycHJldF9jYXN0PE5QX0lu aXRpYWxpemVGdW5jUHRyPihkbHN5bShtX21vZHVsZSwgIk5QX0luaXRpYWxpemUiKSk7Ci0gICAg aWYgKChlcnJtc2cgPSBkbGVycm9yKCkpKSB7Ci0gICAgICAgIEVJTkFfTE9HX0VSUigiQ291bGQg bm90IGdldCBzeW1ib2wgTlBfSW5pdGlhbGl6ZTogJXMiLCBlcnJtc2cpOworICAgIE5QX0luaXRp YWxpemVGdW5jUHRyIGluaXRpYWxpemUgPSByZWludGVycHJldF9jYXN0PE5QX0luaXRpYWxpemVG dW5jUHRyPihlaW5hX21vZHVsZV9zeW1ib2xfZ2V0KG1fbW9kdWxlLCAiTlBfSW5pdGlhbGl6ZSIp KTsKKyAgICBpZiAoIWluaXRpYWxpemUpIHsKKyAgICAgICAgRUlOQV9MT0dfRVJSKCJDb3VsZCBu b3QgZ2V0IHN5bWJvbCBOUF9Jbml0aWFsaXplIik7CiAgICAgICAgIGdvdG8gYWJvcnQ7CiAgICAg fQogCi0gICAgbV9OUFBfU2h1dGRvd24gPSByZWludGVycHJldF9jYXN0PE5QUF9TaHV0ZG93blBy b2NQdHI+KGRsc3ltKG1fbW9kdWxlLCAiTlBfU2h1dGRvd24iKSk7Ci0gICAgaWYgKChlcnJtc2cg PSBkbGVycm9yKCkpKSB7Ci0gICAgICAgIEVJTkFfTE9HX0VSUigiQ291bGQgbm90IGdldCBzeW1i b2wgTlBfU2h1dGRvd246ICVzIiwgZXJybXNnKTsKKyAgICBtX05QUF9TaHV0ZG93biA9IHJlaW50 ZXJwcmV0X2Nhc3Q8TlBQX1NodXRkb3duUHJvY1B0cj4oZWluYV9tb2R1bGVfc3ltYm9sX2dldCht X21vZHVsZSwgIk5QX1NodXRkb3duIikpOworICAgIGlmICghbV9OUFBfU2h1dGRvd24pIHsKKyAg ICAgICAgRUlOQV9MT0dfRVJSKCJDb3VsZCBub3QgZ2V0IHN5bWJvbCBOUF9TaHV0ZG93biIpOwog ICAgICAgICBnb3RvIGFib3J0OwogICAgIH0KIApAQCAtMTQ3LDE0ICsxNDcsMTQgQEAgYm9vbCBQ bHVnaW5QYWNrYWdlOjpsb2FkKCkKICAgICBpbml0aWFsaXplQnJvd3NlckZ1bmNzKCk7CiAKICNp ZiBkZWZpbmVkKFhQX1VOSVgpCi0gICAgZXJyID0gaW5pdGlhbGl6ZSgmbV9icm93c2VyRnVuY3Ms ICZtX3BsdWdpbkZ1bmNzKTsKKyAgICBOUEVycm9yIGVyciA9IGluaXRpYWxpemUoJm1fYnJvd3Nl ckZ1bmNzLCAmbV9wbHVnaW5GdW5jcyk7CiAjZWxzZQotICAgIGVyciA9IGluaXRpYWxpemUoJm1f YnJvd3NlckZ1bmNzKTsKKyAgICBOUEVycm9yIGVyciA9IGluaXRpYWxpemUoJm1fYnJvd3NlckZ1 bmNzKTsKICNlbmRpZgogICAgIGlmIChlcnIgIT0gTlBFUlJfTk9fRVJST1IpCiAgICAgICAgIGdv dG8gYWJvcnQ7CiAKLSAgICBtX2xvYWRDb3VudCsrOworICAgICsrbV9sb2FkQ291bnQ7CiAgICAg cmV0dXJuIHRydWU7CiAKIGFib3J0Ogo=