89969 2012-06-26 04:12:49 -0700 [BlackBerry] Selection items show as garbage for non-ascii characters. 2012-06-28 21:20:36 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned haizhang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 657488 0 jasonliuwebkit 2012-06-26 04:12:49 -0700 Go to www.meituan.com, on the left up conner, there's a selection . click on the selection to bring up the selection dialog. All the option items which are in Chinese are displayed as garbage. 658345 1 149682 jasonliuwebkit 2012-06-26 22:44:42 -0700 Created attachment 149682 Patch 658447 2 149703 jasonliuwebkit 2012-06-27 01:25:20 -0700 Created attachment 149703 Patch 658582 3 149703 yong.li.webkit 2012-06-27 07:03:58 -0700 Comment on attachment 149703 Patch Is this internally reviewed? 658596 4 haizhang 2012-06-27 07:37:38 -0700 (In reply to comment #3) > (From update of attachment 149703 [details]) > Is this internally reviewed? Looks fine to me. 658622 5 149703 rwlbuis 2012-06-27 08:26:24 -0700 Comment on attachment 149703 Patch Would it be possible to have an automated test for this? 659079 6 jasonliuwebkit 2012-06-27 18:52:34 -0700 (In reply to comment #5) > (From update of attachment 149703 [details]) > Would it be possible to have an automated test for this? Each porting has a different implementation for popUp dialog. So it is hard to write a automated test. 659716 7 tonikitoo 2012-06-28 12:52:23 -0700 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 149703 [details] [details]) > > Would it be possible to have an automated test for this? > > Each porting has a different implementation for popUp dialog. > So it is hard to write a automated test. I would as for a manual test, but not sure people actually run it :s 660092 8 jasonliuwebkit 2012-06-28 20:22:39 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (From update of attachment 149703 [details] [details] [details]) > > > Would it be possible to have an automated test for this? > > > > Each porting has a different implementation for popUp dialog. > > So it is hard to write a automated test. > > I would as for a manual test, but not sure people actually run it :s Would you approve this patch? : ) 660118 9 149703 webkit.review.bot 2012-06-28 21:20:32 -0700 Comment on attachment 149703 Patch Clearing flags on attachment: 149703 Committed r121516: <http://trac.webkit.org/changeset/121516> 660119 10 webkit.review.bot 2012-06-28 21:20:36 -0700 All reviewed patches have been landed. Closing bug. 149682 2012-06-26 22:44:42 -0700 2012-06-27 01:25:09 -0700 Patch bug-89969-20120627134439.patch text/plain 3195 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyYjhmZTdiN2U0YzhjMDU0MTU2MTVlYTAyNjlmM2U3ZmJhYWM4ZTQ2Li5lMjc5Y2ExNTlm M2E3NzU5YTJkNGYxYTFlZDY3NGJjNjQ2NjM0NDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNi0yNiAgSmFzb24gTGl1ICA8amFzb24ubGl1 QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gU2VsZWN0aW9uIGl0 ZW1zIHNob3cgYXMgZ2FyYmFnZSBmb3Igbm9uLWFzY2lpIGNoYXJhY3RlcnMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk2OQorCisgICAgICAgIEFk ZCBjaGFyc2V0IHV0Zi04IHRvIHRoZSBzZWxlY3QgcG9wdXAncyBwYWdlLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvU2Vs ZWN0UG9wdXBDbGllbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0UG9wdXBDbGllbnQ6 OmdlbmVyYXRlSFRNTCk6CisKIDIwMTItMDYtMjYgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlA dG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgZ2VzdHVyZSBT d2lwZURvd24gdG8gZXhpdCBmdWxsc2NyZWVuIGZvciBib3RoIHZpZGVvIGFuZCBwbHVnaW4uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0 UG9wdXBDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L1NlbGVjdFBvcHVwQ2xpZW50LmNwcAppbmRleCBmMzBkMDFlZDYwNGZjZDEzZTUzN2E3NmFjOGQy Y2QwYTc3NTkyZjY2Li42YjRmZWY1NDQ3NzVkNmZhMTBhNDgzMTdkOGMzY2YxNDQyN2Y2NGFiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0 UG9wdXBDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3Vw cG9ydC9TZWxlY3RQb3B1cENsaWVudC5jcHAKQEAgLTY1LDcgKzY1LDcgQEAgdm9pZCBTZWxlY3RQ b3B1cENsaWVudDo6Z2VuZXJhdGVIVE1MKGJvb2wgbXVsdGlwbGUsIGludCBzaXplLCBjb25zdCBT Y29wZUFycmF5PEIKICAgICBjb25zdCBpbnQqIGl0ZW1UeXBlLCBib29sKiBzZWxlY3RlZHMpCiB7 CiAgICAgU3RyaW5nQnVpbGRlciBzb3VyY2U7Ci0gICAgc291cmNlLmFwcGVuZCgiPGh0bWw+PGhl YWQ+PHN0eWxlPlxuIik7CisgICAgc291cmNlLmFwcGVuZCgiPGh0bWw+PGhlYWQ+PG1ldGEgaHR0 cC1lcXVpdj1cIkNvbnRlbnQtVHlwZVwiIGNvbnRlbnQ9XCJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRm LThcIi8+PHN0eWxlPlxuIik7CiAgICAgLy8gSW5jbHVkZSBDU1MgZmlsZS4KICAgICBzb3VyY2Uu YXBwZW5kKHBvcHVwQ29udHJvbEJsYWNrQmVycnlDc3MsCiAgICAgICAgICAgICBzaXplb2YocG9w dXBDb250cm9sQmxhY2tCZXJyeUNzcykpOwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdl TG9nCmluZGV4IDcyYTc0ODZiZjY2YjQzZGU1M2E4YjA1NmEwYzA1YzM2MjY5YTA0ZjEuLmFkNjVm OGY2YzMzN2UzZWE5ZDNmYjg2NzI2YWRiNTY4NGUzYjQxN2YgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxv ZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNi0yNiAgSmFzb24gTGl1 ICA8amFzb24ubGl1QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0g U2VsZWN0aW9uIGl0ZW1zIHNob3cgYXMgZ2FyYmFnZSBmb3Igbm9uLWFzY2lpIGNoYXJhY3RlcnMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk2OQor CisgICAgICAgIEFkZCBjaGFyc2V0IHV0Zi04IHRvIHRoZSBzZWxlY3QgcG9wdXAncyBwYWdlLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWFudWFs VGVzdHMvYmxhY2tiZXJyeS9zZWxlY3QtcG9wdXAtaXRlbXMtdW5pY29kZS1kaXNwbGF5Lmh0bWw6 IEFkZGVkLgorCiAyMDEyLTA2LTI1ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5v a2lhLmNvbT4KIAogICAgICAgICBbUXRdIE1ha2UgaXQgcG9zc2libGUgdG8gYnVpbGQgV2ViS2l0 IHdpdGhvdXQgUXRXaWRnZXRzCmRpZmYgLS1naXQgYS9NYW51YWxUZXN0cy9ibGFja2JlcnJ5L3Nl bGVjdC1wb3B1cC1pdGVtcy11bmljb2RlLWRpc3BsYXkuaHRtbCBiL01hbnVhbFRlc3RzL2JsYWNr YmVycnkvc2VsZWN0LXBvcHVwLWl0ZW1zLXVuaWNvZGUtZGlzcGxheS5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjVkZmJiNjBkYTMzNWM0NzgzZTIzOWViMjFjNmRhYzVkZjg0NzZmYTEKLS0tIC9kZXYvbnVsbAor KysgYi9NYW51YWxUZXN0cy9ibGFja2JlcnJ5L3NlbGVjdC1wb3B1cC1pdGVtcy11bmljb2RlLWRp c3BsYXkuaHRtbApAQCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICA8 Ym9keT4KKyAgICA8cD5UaGlzIHRlc3QgaWYgd2UgY2FuIHNob3cgdW5pY29kZSBjb3JyZWN0bHku IEl0IGlzIGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODk5NjkiPmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk2OTwv YT48L3A+CisgICAgPHA+CisgICAgICBJZiB5b3UgY2FuIHNlZSBjaGluZXNlKOWMl+S6rCwg5r6z 6ZeoKSBhZnRlciBwcmVzc2luZyB0aGUgZHJvcGxpc3QsIHRoaXMgdGVzdCBwYXNzZXMuCisgICA8 L3A+CisgICAgPHNlbGVjdD4KKyAgICAgICAgPG9wdGlvbiBzZWxlY3RlZD0ic2VsZWN0ZWQiPuWM l+S6rDwvb3B0aW9uPgorICAgICAgICA8b3B0aW9uPlNoZW5ZYW5nPC9vcHRpb24+CisgICAgICAg IDxvcHRpb24+5r6z6ZeoPC9vcHRpb24+CisgICAgPC9zZWxlY3Q+CisgIDwvYm9keT4KKzwvaHRt bD4K 149703 2012-06-27 01:25:20 -0700 2012-06-28 21:20:32 -0700 Patch bug-89969-20120627162519.patch text/plain 3197 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyYjhmZTdiN2U0YzhjMDU0MTU2MTVlYTAyNjlmM2U3ZmJhYWM4ZTQ2Li5lMjc5Y2ExNTlm M2E3NzU5YTJkNGYxYTFlZDY3NGJjNjQ2NjM0NDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNi0yNiAgSmFzb24gTGl1ICA8amFzb24ubGl1 QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gU2VsZWN0aW9uIGl0 ZW1zIHNob3cgYXMgZ2FyYmFnZSBmb3Igbm9uLWFzY2lpIGNoYXJhY3RlcnMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk2OQorCisgICAgICAgIEFk ZCBjaGFyc2V0IHV0Zi04IHRvIHRoZSBzZWxlY3QgcG9wdXAncyBwYWdlLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvU2Vs ZWN0UG9wdXBDbGllbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0UG9wdXBDbGllbnQ6 OmdlbmVyYXRlSFRNTCk6CisKIDIwMTItMDYtMjYgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlA dG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgZ2VzdHVyZSBT d2lwZURvd24gdG8gZXhpdCBmdWxsc2NyZWVuIGZvciBib3RoIHZpZGVvIGFuZCBwbHVnaW4uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0 UG9wdXBDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L1NlbGVjdFBvcHVwQ2xpZW50LmNwcAppbmRleCBmMzBkMDFlZDYwNGZjZDEzZTUzN2E3NmFjOGQy Y2QwYTc3NTkyZjY2Li4xNWYxYTc2N2JmMzY3YjExMWYxODYxY2ZjOWI5ZDdmYmQ1MGY5NDJiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0 UG9wdXBDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3Vw cG9ydC9TZWxlY3RQb3B1cENsaWVudC5jcHAKQEAgLTY1LDcgKzY1LDcgQEAgdm9pZCBTZWxlY3RQ b3B1cENsaWVudDo6Z2VuZXJhdGVIVE1MKGJvb2wgbXVsdGlwbGUsIGludCBzaXplLCBjb25zdCBT Y29wZUFycmF5PEIKICAgICBjb25zdCBpbnQqIGl0ZW1UeXBlLCBib29sKiBzZWxlY3RlZHMpCiB7 CiAgICAgU3RyaW5nQnVpbGRlciBzb3VyY2U7Ci0gICAgc291cmNlLmFwcGVuZCgiPGh0bWw+PGhl YWQ+PHN0eWxlPlxuIik7CisgICAgc291cmNlLmFwcGVuZCgiPGh0bWw+PGhlYWQ+PG1ldGEgaHR0 cC1lcXVpdj1cIkNvbnRlbnQtVHlwZVwiIGNvbnRlbnQ9XCJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRG LThcIi8+PHN0eWxlPlxuIik7CiAgICAgLy8gSW5jbHVkZSBDU1MgZmlsZS4KICAgICBzb3VyY2Uu YXBwZW5kKHBvcHVwQ29udHJvbEJsYWNrQmVycnlDc3MsCiAgICAgICAgICAgICBzaXplb2YocG9w dXBDb250cm9sQmxhY2tCZXJyeUNzcykpOwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdl TG9nCmluZGV4IDcyYTc0ODZiZjY2YjQzZGU1M2E4YjA1NmEwYzA1YzM2MjY5YTA0ZjEuLmFkNjVm OGY2YzMzN2UzZWE5ZDNmYjg2NzI2YWRiNTY4NGUzYjQxN2YgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxv ZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNi0yNiAgSmFzb24gTGl1 ICA8amFzb24ubGl1QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0g U2VsZWN0aW9uIGl0ZW1zIHNob3cgYXMgZ2FyYmFnZSBmb3Igbm9uLWFzY2lpIGNoYXJhY3RlcnMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk2OQor CisgICAgICAgIEFkZCBjaGFyc2V0IHV0Zi04IHRvIHRoZSBzZWxlY3QgcG9wdXAncyBwYWdlLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWFudWFs VGVzdHMvYmxhY2tiZXJyeS9zZWxlY3QtcG9wdXAtaXRlbXMtdW5pY29kZS1kaXNwbGF5Lmh0bWw6 IEFkZGVkLgorCiAyMDEyLTA2LTI1ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5v a2lhLmNvbT4KIAogICAgICAgICBbUXRdIE1ha2UgaXQgcG9zc2libGUgdG8gYnVpbGQgV2ViS2l0 IHdpdGhvdXQgUXRXaWRnZXRzCmRpZmYgLS1naXQgYS9NYW51YWxUZXN0cy9ibGFja2JlcnJ5L3Nl bGVjdC1wb3B1cC1pdGVtcy11bmljb2RlLWRpc3BsYXkuaHRtbCBiL01hbnVhbFRlc3RzL2JsYWNr YmVycnkvc2VsZWN0LXBvcHVwLWl0ZW1zLXVuaWNvZGUtZGlzcGxheS5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjU4MmU3NmIxZTRlZWRlNDZiOGQ2YjAxOTYwZGYzOGE3MDFkNTVhNTgKLS0tIC9kZXYvbnVsbAor KysgYi9NYW51YWxUZXN0cy9ibGFja2JlcnJ5L3NlbGVjdC1wb3B1cC1pdGVtcy11bmljb2RlLWRp c3BsYXkuaHRtbApAQCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICA8 Ym9keT4KKyAgICA8cD5UaGlzIHRlc3RzIGlmIHdlIGNhbiBzaG93IHVuaWNvZGUgY29ycmVjdGx5 LiBJdCBpcyBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg5OTY5Ij5odHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk5Njku PC9hPjwvcD4KKyAgICA8cD4KKyAgICAgIElmIHlvdSBjYW4gc2VlIGNoaW5lc2Uo5YyX5LqsLCDm vrPpl6gpIGFmdGVyIHByZXNzaW5nIHRoZSBkcm9wbGlzdCwgdGhpcyB0ZXN0IHBhc3Nlcy4KKyAg IDwvcD4KKyAgICA8c2VsZWN0PgorICAgICAgICA8b3B0aW9uIHNlbGVjdGVkPSJzZWxlY3RlZCI+ 5YyX5LqsPC9vcHRpb24+CisgICAgICAgIDxvcHRpb24+U2hlbllhbmc8L29wdGlvbj4KKyAgICAg ICAgPG9wdGlvbj7mvrPpl6g8L29wdGlvbj4KKyAgICA8L3NlbGVjdD4KKyAgPC9ib2R5PgorPC9o dG1sPgo=