89951 2012-06-26 00:01:50 -0700 Refactoring: Simplify FormController interface 2012-06-26 00:55:33 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89950 1 tkent tkent haraken morrita oldest_to_newest 657332 0 tkent 2012-06-26 00:01:50 -0700 Refactoring: Remove FormController::hasStateForNewFormElements 657344 1 149470 tkent 2012-06-26 00:28:25 -0700 Created attachment 149470 Patch 657350 2 149470 haraken 2012-06-26 00:36:28 -0700 Comment on attachment 149470 Patch Looks OK. 657372 3 tkent 2012-06-26 00:55:06 -0700 Thanks! 657373 4 tkent 2012-06-26 00:55:33 -0700 Committed r121235: <http://trac.webkit.org/changeset/121235> 149470 2012-06-26 00:28:25 -0700 2012-06-26 00:36:28 -0700 Patch bug-89951-20120626162824.patch text/plain 4416 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRlMDJmZGU2NzM3N2Zh YWUyNDhkZmI0OTZhYTk0MTU1NzY1NDA4OS4uZWRjNjNhY2NiNGVhMDAyODE3MDI4N2QyNDk0Yzdm N2UwMjIxYTI5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA2LTI2ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWZhY3RvcmluZzogU2lt cGxpZnkgRm9ybUNvbnRyb2xsZXIgaW50ZXJmYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTk1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIC0gUmVtb3ZlIEZvcm1Db250cm9sbGVyOjpoYXNTdGF0ZUZv ck5ld0Zvcm1FbGVtZW50cygpCisgICAgICAgICAgdGFrZVN0YXRlRm9yRm9ybUVsZW1lbnQoKSBj YW4gY2hlY2sgdGhlIGVtcHRpbmVzcywgYW5kIHJldHVybiBhbiBlbXB0eQorICAgICAgICAgIEZv cm1Db250cm9sU3RhdGUuCisKKyAgICAgICAgLSBDaGFuZ2UgdGhlIGFyZ3VtZW50IG9mIHRha2VT dGF0ZUZvckZvcm1FbGVtZW50KCkKKyAgICAgICAgICBQYXNzaW5nIGp1c3Qgb25lIEhUTUxGb3Jt Q29udHJvbEVsZW1lbnRXaXRoU3RhdGUgb2JqZWN0IGluc3RlYWQgb2YgdHdvCisgICAgICAgICAg QXRvbWljU3RyaW5nSW1wbC4gVGhpcyBpcyBhIHByZXBhcmF0aW9uIHRvIHVzZQorICAgICAgICAg IEhUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRoU3RhdGU6OmZvcm0oKSBpbiBGb3JtQ29udHJvbGxl ci4KKworICAgICAgICBObyBuZXcgdGVzdHMuIEp1c3QgYSByZWZhY3RvcmluZy4KKworICAgICAg ICAqIGh0bWwvRm9ybUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9ybUNvbnRy b2xsZXI6OnRha2VTdGF0ZUZvckZvcm1FbGVtZW50KToKKyAgICAgICAgKiBodG1sL0Zvcm1Db250 cm9sbGVyLmg6CisgICAgICAgIChGb3JtQ29udHJvbGxlcik6CisgICAgICAgICogaHRtbC9IVE1M Rm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxG b3JtQ29udHJvbEVsZW1lbnRXaXRoU3RhdGU6OmZpbmlzaFBhcnNpbmdDaGlsZHJlbik6CisKIDIw MTItMDYtMjUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgR2V0 IHJpZCBvZiBmaXJzdEl0ZW0gYW5kIG5leHRJdGVtIGZyb20gSFRNTENvbGxlY3Rpb24KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9Gb3JtQ29udHJvbGxlci5jcHAKaW5kZXggMzFjNzc2MzQzY2IzYzZmZmJjMWY1 NWEyZTI0MjY0N2Q4Njk0ZDljMS4uODcxOTQ0M2I0ZGIxMmM3ZjZkM2ZjNjU5MDliOWNiYWU4OGJi NWIzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29udHJvbGxlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29udHJvbGxlci5jcHAKQEAgLTEzOCwxNSAr MTM4LDEyIEBAIHZvaWQgRm9ybUNvbnRyb2xsZXI6OnNldFN0YXRlRm9yTmV3Rm9ybUVsZW1lbnRz KGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBzdGF0ZVZlY3RvCiAgICAgICAgIG1fc3RhdGVGb3JOZXdG b3JtRWxlbWVudHMuY2xlYXIoKTsKIH0KIAotYm9vbCBGb3JtQ29udHJvbGxlcjo6aGFzU3RhdGVG b3JOZXdGb3JtRWxlbWVudHMoKSBjb25zdAotewotICAgIHJldHVybiAhbV9zdGF0ZUZvck5ld0Zv cm1FbGVtZW50cy5pc0VtcHR5KCk7Ci19Ci0KLUZvcm1Db250cm9sU3RhdGUgRm9ybUNvbnRyb2xs ZXI6OnRha2VTdGF0ZUZvckZvcm1FbGVtZW50KEF0b21pY1N0cmluZ0ltcGwqIG5hbWUsIEF0b21p Y1N0cmluZ0ltcGwqIHR5cGUpCitGb3JtQ29udHJvbFN0YXRlIEZvcm1Db250cm9sbGVyOjp0YWtl U3RhdGVGb3JGb3JtRWxlbWVudChjb25zdCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRl JiBjb250cm9sKQogeworICAgIGlmIChtX3N0YXRlRm9yTmV3Rm9ybUVsZW1lbnRzLmlzRW1wdHko KSkKKyAgICAgICAgcmV0dXJuIEZvcm1Db250cm9sU3RhdGUoKTsKICAgICB0eXBlZGVmIEZvcm1F bGVtZW50U3RhdGVNYXA6Oml0ZXJhdG9yIEl0ZXJhdG9yOwotICAgIEl0ZXJhdG9yIGl0ID0gbV9z dGF0ZUZvck5ld0Zvcm1FbGVtZW50cy5maW5kKEZvcm1FbGVtZW50S2V5KG5hbWUsIHR5cGUpKTsK KyAgICBJdGVyYXRvciBpdCA9IG1fc3RhdGVGb3JOZXdGb3JtRWxlbWVudHMuZmluZChGb3JtRWxl bWVudEtleShjb250cm9sLm5hbWUoKS5pbXBsKCksIGNvbnRyb2wudHlwZSgpLmltcGwoKSkpOwog ICAgIGlmIChpdCA9PSBtX3N0YXRlRm9yTmV3Rm9ybUVsZW1lbnRzLmVuZCgpKQogICAgICAgICBy ZXR1cm4gRm9ybUNvbnRyb2xTdGF0ZSgpOwogICAgIEFTU0VSVChpdC0+c2Vjb25kLnNpemUoKSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Zvcm1Db250cm9sbGVyLmggYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0Zvcm1Db250cm9sbGVyLmgKaW5kZXggZmE1NDYzYjhhZTM3Njc0NjAx M2FmYmZjODk1ZGFmZDcwNmQyZmU5YS4uODQxNTY5NTNlMGIwZDZjMTYxMzc4MjgzYjhmMjA4ZDcz M2E5YmVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29udHJvbGxlci5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuaApAQCAtMTI1LDggKzEy NSw3IEBAIHB1YmxpYzoKICAgICBWZWN0b3I8U3RyaW5nPiBmb3JtRWxlbWVudHNTdGF0ZSgpIGNv bnN0OwogICAgIC8vIFRoaXMgc2hvdWxkIGJlIGNhbGxsZWQgb25seSBieSBEb2N1bWVudDo6c2V0 U3RhdGVGb3JOZXdGb3JtRWxlbWVudHMoKS4KICAgICB2b2lkIHNldFN0YXRlRm9yTmV3Rm9ybUVs ZW1lbnRzKGNvbnN0IFZlY3RvcjxTdHJpbmc+Jik7Ci0gICAgYm9vbCBoYXNTdGF0ZUZvck5ld0Zv cm1FbGVtZW50cygpIGNvbnN0OwotICAgIEZvcm1Db250cm9sU3RhdGUgdGFrZVN0YXRlRm9yRm9y bUVsZW1lbnQoQXRvbWljU3RyaW5nSW1wbCogbmFtZSwgQXRvbWljU3RyaW5nSW1wbCogdHlwZSk7 CisgICAgRm9ybUNvbnRyb2xTdGF0ZSB0YWtlU3RhdGVGb3JGb3JtRWxlbWVudChjb25zdCBIVE1M Rm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlJik7CiAKICAgICB2b2lkIHJlZ2lzdGVyRm9ybUVs ZW1lbnRXaXRoRm9ybUF0dHJpYnV0ZShGb3JtQXNzb2NpYXRlZEVsZW1lbnQqKTsKICAgICB2b2lk IHVucmVnaXN0ZXJGb3JtRWxlbWVudFdpdGhGb3JtQXR0cmlidXRlKEZvcm1Bc3NvY2lhdGVkRWxl bWVudCopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xF bGVtZW50V2l0aFN0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9s RWxlbWVudFdpdGhTdGF0ZS5jcHAKaW5kZXggYTg4NGVlMWJkYzlhNzY4MTg2YTQ0YmQxMWFhNDZi MWNjNTk1M2M1OS4uMjI5NDBlMGQ2NjFmNzA5ZjUyYjE5NDYzZDhhYzBkNjZmYjk5M2QyNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0 YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnRX aXRoU3RhdGUuY3BwCkBAIC03NywxMiArNzcsOSBAQCB2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1l bnRXaXRoU3RhdGU6OmZpbmlzaFBhcnNpbmdDaGlsZHJlbigpCiAgICAgaWYgKCFzaG91bGRTYXZl QW5kUmVzdG9yZUZvcm1Db250cm9sU3RhdGUoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgRG9j dW1lbnQqIGRvYyA9IGRvY3VtZW50KCk7Ci0gICAgaWYgKGRvYy0+Zm9ybUNvbnRyb2xsZXIoKS0+ aGFzU3RhdGVGb3JOZXdGb3JtRWxlbWVudHMoKSkgewotICAgICAgICBGb3JtQ29udHJvbFN0YXRl IHN0YXRlID0gZG9jLT5mb3JtQ29udHJvbGxlcigpLT50YWtlU3RhdGVGb3JGb3JtRWxlbWVudChu YW1lKCkuaW1wbCgpLCB0eXBlKCkuaW1wbCgpKTsKLSAgICAgICAgaWYgKHN0YXRlLnZhbHVlU2l6 ZSgpID4gMCkKLSAgICAgICAgICAgIHJlc3RvcmVGb3JtQ29udHJvbFN0YXRlKHN0YXRlKTsKLSAg ICB9CisgICAgRm9ybUNvbnRyb2xTdGF0ZSBzdGF0ZSA9IGRvY3VtZW50KCktPmZvcm1Db250cm9s bGVyKCktPnRha2VTdGF0ZUZvckZvcm1FbGVtZW50KCp0aGlzKTsKKyAgICBpZiAoc3RhdGUudmFs dWVTaXplKCkgPiAwKQorICAgICAgICByZXN0b3JlRm9ybUNvbnRyb2xTdGF0ZShzdGF0ZSk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYmNvcmUK