89944 2012-06-25 22:36:34 -0700 Enables <input type="color"> for ChromeOS 2012-06-26 14:27:22 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 90013 0 mukai webkit-unassigned keishi tkent webkit.review.bot oldest_to_newest 657298 0 mukai 2012-06-25 22:36:34 -0700 http://crrev.com/144111 added the UI of <input type="color"> for ChromeOS, so now we can set ENABLE_INPUT_TYPE_COLOR for ChromeOS too. 657304 1 149460 mukai 2012-06-25 22:53:18 -0700 Created attachment 149460 Patch 657306 2 149460 tkent 2012-06-25 23:02:20 -0700 Comment on attachment 149460 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149460&action=review > Source/WebKit/chromium/features.gypi:177 > - ['OS=="android" or chromeos==1', { > + ['OS=="android"', { Did you confirm the following steps? 1. build with unmodified features.gypi 2. Modify features.gypi, and run gyp 3. build again 4. the build succeeds I'm afraid this change requires clobber build for every ChromeOS developers. 657360 3 mukai 2012-06-26 00:42:05 -0700 I've done what you pointed during my development actually, but repeated just in case, and successfully built the binary with the color chooser UI in step 4. gyp_chromium and make/ninja catch the change and rebuilt the whole WebKit in step 3. 657363 4 tkent 2012-06-26 00:43:39 -0700 Ok, thanks! 657377 5 149460 webkit.review.bot 2012-06-26 00:59:23 -0700 Comment on attachment 149460 Patch Clearing flags on attachment: 149460 Committed r121237: <http://trac.webkit.org/changeset/121237> 657378 6 webkit.review.bot 2012-06-26 00:59:27 -0700 All reviewed patches have been landed. Closing bug. 657943 7 149460 peter 2012-06-26 13:44:28 -0700 Comment on attachment 149460 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149460&action=review >> Source/WebKit/chromium/features.gypi:177 >> + ['OS=="android"', { > > Did you confirm the following steps? > 1. build with unmodified features.gypi > 2. Modify features.gypi, and run gyp > 3. build again > 4. the build succeeds > > I'm afraid this change requires clobber build for every ChromeOS developers. This already landed, but a nit nonetheless: there is an OS==android section just above here, it'd have been better to consolidate this define in there. I'll upload a patch to do so. 149460 2012-06-25 22:53:18 -0700 2012-06-26 13:44:28 -0700 Patch bug-89944-20120626145318.patch text/plain 1271 mukai U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhhNmYxMzRlYTAyOWQ4YzRhZGY3MjNiM2IyNzA0MDhmZTU3YmIzYmEuLjNmN2ZhNjBjZDFhZjgw YjVjZGFhNGQ1YTkzOTEwYjM0YjVjMGU0ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDYtMjUgIEp1biBNdWthaSAgPG11a2FpQGNocm9taXVtLm9y Zz4KKworICAgICAgICBBbGxvdyB1c2luZyA8aW5wdXQgdHlwZT0iY29sb3IiPiBVSSBpbiBDaHJv bWVPUy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5 OTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0 cDovL2NycmV2LmNvbS8xNDQxMTEgYWRkcyB0aGUgVUkgb2YgPGlucHV0IHR5cGU9ImNvbG9yIj4g Zm9yCisgICAgICAgIENocm9tZU9TLCBzbyBub3cgd2UgY2FuIHNldCBpdHMgZmxhZyB0b28uCisK KyAgICAgICAgKiBmZWF0dXJlcy5neXBpOgorCiAyMDEyLTA2LTIzICBLd2FuZyBZdWwgU2VvICA8 c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgW2Nocm9taXVtXSBSZXR1cm4gaGFzIHZh bHVlLCBpbiBmdW5jdGlvbiByZXR1cm5pbmcgdm9pZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJl cy5neXBpCmluZGV4IGJmMTJlZTE3YWEyYTRjZWYxMTI3YmZmNDQ5ZDYyY2ZjYjEwZjZjYTEuLjRl Mjc5NjczMmU4NjMyZWZjNGRhMjdmOWY4MTlhMmY1ODhlYjExYjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkKQEAgLTE3NCw3ICsxNzQsNyBAQAogICAgICAgICAgICdFTkFCTEVf V0VCX0FVRElPPTEnLAogICAgICAgICBdLAogICAgICAgfV0sCi0gICAgICBbJ09TPT0iYW5kcm9p ZCIgb3IgY2hyb21lb3M9PTEnLCB7CisgICAgICBbJ09TPT0iYW5kcm9pZCInLCB7CiAgICAgICAg ICdmZWF0dXJlX2RlZmluZXMnOiBbCiAgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0NPTE9S PTAnLAogICAgICAgICBdLAo=