89932 2012-06-25 18:19:53 -0700 JavaScript resources have low priority when SVG is enabled 2012-06-26 11:43:14 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psolanki psolanki benjamin ddkilzer japhet jochen psolanki webkit.review.bot oldest_to_newest 657112 0 psolanki 2012-06-25 18:19:53 -0700 The following change made it so that JavaScript resources have low priority. https://bugs.webkit.org/show_bug.cgi?id=12499 http://trac.webkit.org/changeset/108785 The problematic part is --- a/Source/WebCore/loader/cache/CachedResource.cpp +++ b/Source/WebCore/loader/cache/CachedResource.cpp @@ -61,6 +61,10 @@ static ResourceLoadPriority defaultPriorityForResourceType(CachedResource::Type #endif return ResourceLoadPriorityHigh; case CachedResource::Script: +#if ENABLE(SVG) + case CachedResource::SVGDocumentResource: + return ResourceLoadPriorityLow; +#endif case CachedResource::FontResource: case CachedResource::RawResource: return ResourceLoadPriorityMedium; CachedResource::Script now returns ResourceLoadPriorityLow instead of ResourceLoadPriorityMedium when SVG is enabled. 657116 1 psolanki 2012-06-25 18:20:44 -0700 <rdar://problem/11741325> 657295 2 149456 psolanki 2012-06-25 22:30:02 -0700 Created attachment 149456 Patch 657308 3 psolanki 2012-06-25 23:06:19 -0700 Committed r121231: <http://trac.webkit.org/changeset/121231> 657797 4 149456 darin 2012-06-26 11:41:48 -0700 Comment on attachment 149456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149456&action=review > Source/WebCore/ChangeLog:9 > + r108785 inadvertently lowered the priority of JavaScript resources. Fix the code so we set It was not r108785. Looking to find out when this regressed. 657802 5 149456 darin 2012-06-26 11:43:14 -0700 Comment on attachment 149456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149456&action=review >> Source/WebCore/ChangeLog:9 >> + r108785 inadvertently lowered the priority of JavaScript resources. Fix the code so we set > > It was not r108785. Looking to find out when this regressed. Sorry, my bad, it was r108785 exactly as Pratik said. My apologies for the misleading comment. 149456 2012-06-25 22:30:02 -0700 2012-06-26 11:43:14 -0700 Patch bug-89932-20120625223001.patch text/plain 2301 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBmZDJmNWVlN2IyYTc0 NjBkYmEzMGJjZGIyZjRmZjUxYTE0YjFjNC4uZWVhMmMwZmY5ZjkzZTVmNDE2MzI0N2Y4MmJhZTg5 NDE2ZDUxZjA1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTI1ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBKYXZhU2NyaXB0IHJl c291cmNlcyBoYXZlIGxvdyBwcmlvcml0eSB3aGVuIFNWRyBpcyBlbmFibGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTkzMgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTE3NDEzMjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgcjEwODc4NSBpbmFkdmVydGVudGx5IGxvd2VyZWQgdGhlIHByaW9yaXR5 IG9mIEphdmFTY3JpcHQgcmVzb3VyY2VzLiBGaXggdGhlIGNvZGUgc28gd2Ugc2V0CisgICAgICAg IHRoZSBjb3JyZWN0IHByaW9yaXR5IGZvciBzY3JpcHRzLiBBbHNvLCBtb3ZlIHRoZSBjb2RlIHNv IHRoYXQgYWxsIGlmZGVmcyBhcmUgdG9nZXRoZXIgYXQgdGhlCisgICAgICAgIGJvdHRvbSB0byBt YWtlIGl0IGEgYml0IGVhc2llciB0byByZWFkLi4KKworICAgICAgICAqIGxvYWRlci9jYWNoZS9D YWNoZWRSZXNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpkZWZhdWx0UHJpb3JpdHlGb3JS ZXNvdXJjZVR5cGUpOgorCiAyMDEyLTA2LTI1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTIxMTQ1LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKaW5kZXggY2Q1YmQy MzM2ZjlkMWUzZDE3Mjg5YjM3ZGQ5NjBhZTNkMmFhOWVlYS4uMzk5OGVmZDMyNjMzM2ZhYjIyYTUz ZGM0ZmRhNDAyMmY4ZTM5OGI1NCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2Nh Y2hlL0NhY2hlZFJlc291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv Q2FjaGVkUmVzb3VyY2UuY3BwCkBAIC01NiwyMCArNTYsMjEgQEAgc3RhdGljIFJlc291cmNlTG9h ZFByaW9yaXR5IGRlZmF1bHRQcmlvcml0eUZvclJlc291cmNlVHlwZShDYWNoZWRSZXNvdXJjZTo6 VHlwZQogewogICAgIHN3aXRjaCAodHlwZSkgewogICAgICAgICBjYXNlIENhY2hlZFJlc291cmNl OjpDU1NTdHlsZVNoZWV0OgotI2lmIEVOQUJMRShYU0xUKQotICAgICAgICBjYXNlIENhY2hlZFJl c291cmNlOjpYU0xTdHlsZVNoZWV0OgotI2VuZGlmCiAgICAgICAgICAgICByZXR1cm4gUmVzb3Vy Y2VMb2FkUHJpb3JpdHlIaWdoOwogICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpTY3JpcHQ6 Ci0jaWYgRU5BQkxFKFNWRykKLSAgICAgICAgY2FzZSBDYWNoZWRSZXNvdXJjZTo6U1ZHRG9jdW1l bnRSZXNvdXJjZToKLSAgICAgICAgICAgIHJldHVybiBSZXNvdXJjZUxvYWRQcmlvcml0eUxvdzsK LSNlbmRpZgogICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpGb250UmVzb3VyY2U6CiAgICAg ICAgIGNhc2UgQ2FjaGVkUmVzb3VyY2U6OlJhd1Jlc291cmNlOgogICAgICAgICAgICAgcmV0dXJu IFJlc291cmNlTG9hZFByaW9yaXR5TWVkaXVtOwogICAgICAgICBjYXNlIENhY2hlZFJlc291cmNl OjpJbWFnZVJlc291cmNlOgogICAgICAgICAgICAgcmV0dXJuIFJlc291cmNlTG9hZFByaW9yaXR5 TG93OworI2lmIEVOQUJMRShYU0xUKQorICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpYU0xT dHlsZVNoZWV0OgorICAgICAgICAgICAgcmV0dXJuIFJlc291cmNlTG9hZFByaW9yaXR5SGlnaDsK KyNlbmRpZgorI2lmIEVOQUJMRShTVkcpCisgICAgICAgIGNhc2UgQ2FjaGVkUmVzb3VyY2U6OlNW R0RvY3VtZW50UmVzb3VyY2U6CisgICAgICAgICAgICByZXR1cm4gUmVzb3VyY2VMb2FkUHJpb3Jp dHlMb3c7CisjZW5kaWYKICNpZiBFTkFCTEUoTElOS19QUkVGRVRDSCkKICAgICAgICAgY2FzZSBD YWNoZWRSZXNvdXJjZTo6TGlua1ByZWZldGNoOgogICAgICAgICAgICAgcmV0dXJuIFJlc291cmNl TG9hZFByaW9yaXR5VmVyeUxvdzsK