89931 2012-06-25 18:01:00 -0700 [chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements 2012-06-26 09:24:39 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh abarth agl brettw dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 657090 0 shawnsingh 2012-06-25 18:01:00 -0700 Some places in chromium code are using "#ifdef WEBKIT_IMPLEMENTATION" instead of "#if WEBKIT_IMPLEMENTATION". WEBKIT_IMPLEMENTATION is defined as 0 in WebCommon.h if that symbol is not already defined. This means that #ifdef may be incorrect depending on what gets included. Its probably a good idea to fix this now, to avoid build headaches later. Patch coming in a moment; Also cc'ing people who originally wrote those #ifdef statements, just in case they are actually correct for some reason? 657093 1 149413 shawnsingh 2012-06-25 18:04:47 -0700 Created attachment 149413 Patch 657096 2 webkit.review.bot 2012-06-25 18:06:46 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 657099 3 149413 jamesr 2012-06-25 18:11:14 -0700 Comment on attachment 149413 Patch Thanks for fixing this - we've had some real bugs due to this in the past, I believe. We should probably add a style check for this - could you file a bug to track that? (Tools/Scripts/webkitpy/style/checkers/cpp.py if you're feeling super ambitious :) ). 657642 4 149413 webkit.review.bot 2012-06-26 09:24:00 -0700 Comment on attachment 149413 Patch Clearing flags on attachment: 149413 Committed r121264: <http://trac.webkit.org/changeset/121264> 657643 5 webkit.review.bot 2012-06-26 09:24:39 -0700 All reviewed patches have been landed. Closing bug. 149413 2012-06-25 18:04:47 -0700 2012-06-26 09:23:49 -0700 Patch bug-89931-20120625180447.patch text/plain 2653 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDkxZWUyMWI1ZDYxNzI4MjI2YzdhYzA5YzBkMWEyMTQwYTM5ZTgxZmMuLjE3MWQwOGU5ODNhZDc2 OTRiNjQxYzIxZTg5MTViNTE2ZjUwZTZkYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMDYtMjUgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggaW5jb3JyZWN0ICNpZmRlZiBXRUJL SVRfSU1QTEVNRU5UQVRJT04gc3RhdGVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk5MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXRUJLSVRfSU1QTEVNRU5UQVRJT04gaXMgZGVmaW5lZCBhcyBl aXRoZXIgMCBvciAxLCBzbyB0aGUgdXNhZ2Ugb2YKKyAgICAgICAgI2lmZGVmIG9yICNpZiBoYXZl IGRpZmZlcmVudCBiZWhhdmlvci4gVGhlcmUgYXJlIHNvbWUgcGxhY2VzIGluCisgICAgICAgIHRo ZSBjb2RlIHRoYXQgdXNlICIjaWZkZWYgV0VCS0lUX0lNTFBFTUVOVEFUSU9OIiwgYnV0IHRoZXkg c2hvdWxkCisgICAgICAgIGFjdHVhbGx5IGJlICIjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OIi4g VGhpcyBwYXRjaCBmaXhlcyB0aG9zZQorICAgICAgICAjaWZkZWYgc3RhdGVtZW50cy4KKworICAg ICAgICAqIHB1YmxpYy9XZWJUZXh0UnVuLmg6CisgICAgICAgIChXZWJUZXh0UnVuKToKKyAgICAg ICAgKiBwdWJsaWMvbGludXgvV2ViRm9udFJlbmRlclN0eWxlLmg6CisKIDIwMTItMDYtMjUgIEth dXNhbHlhIE1hZGh1c3VkaGFuYW4gIDxrbWFkaHVzdUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W0Nocm9taXVtXSBBZGQgYSBjaHJvbWl1bS13ZWJraXQgQVBJIHRvIGNyZWF0ZSBhIHNlcmlhbGl6 YWJsZSBmaWxlIHN5c3RlbS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYlRleHRSdW4uaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlRleHRS dW4uaAppbmRleCBiN2E1N2FlNjk0ZmRhY2IwOWY4NGNlMWY4ZDNhMjZmM2NlZWYwNWIwLi5iYWNm ZTMxYWQzODQyZDAzMmRjOTgyNDk3ZDE2OGY3MDhmY2UyMDg0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJUZXh0UnVuLmgKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViVGV4dFJ1bi5oCkBAIC0zMyw3ICszMyw3IEBACiAKICNpbmNsdWRl ICJwbGF0Zm9ybS9XZWJTdHJpbmcuaCIKIAotI2lmZGVmIFdFQktJVF9JTVBMRU1FTlRBVElPTgor I2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogbmFtZXNwYWNlIFdlYkNvcmUgeyBjbGFzcyBUZXh0 UnVuOyB9CiAjZW5kaWYKIApAQCAtNTYsNyArNTYsNyBAQCBzdHJ1Y3QgV2ViVGV4dFJ1biB7CiAg ICAgYm9vbCBydGw7CiAgICAgYm9vbCBkaXJlY3Rpb25hbE92ZXJyaWRlOwogCi0jaWZkZWYgV0VC S0lUX0lNUExFTUVOVEFUSU9OCisjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAgICAgLy8gVGhl IHJlc3VsdGluZyBXZWJDb3JlOjpUZXh0UnVuIHdpbGwgcmVmZXIgdG8gdGhlIHRleHQgaW4gdGhp cwogICAgIC8vIHN0cnVjdCwgc28gInRoaXMiIG11c3Qgb3V0bGl2ZSB0aGUgV2ViQ29yZSB0ZXh0 IHJ1bi4KICAgICBvcGVyYXRvciBXZWJDb3JlOjpUZXh0UnVuKCkgY29uc3Q7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9saW51eC9XZWJGb250UmVuZGVyU3R5bGUu aCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL2xpbnV4L1dlYkZvbnRSZW5kZXJTdHls ZS5oCmluZGV4IDc4YTg1OTE2ZTJmOTJiM2U1ZTBiZjE4Y2VlZjE5ODczM2JiMjMwYjkuLmY0ODU4 ZjNlY2I0YmJjZmUzODZkZjkzMTU2MGVhZTRmYTAxMGM5OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL2xpbnV4L1dlYkZvbnRSZW5kZXJTdHlsZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL2xpbnV4L1dlYkZvbnRSZW5kZXJTdHlsZS5oCkBA IC01MCw3ICs1MCw3IEBAIHN0cnVjdCBXRUJLSVRfRVhQT1JUIFdlYkZvbnRSZW5kZXJTdHlsZSB7 CiAgICAgY2hhciB1c2VTdWJwaXhlbFJlbmRlcmluZzsgLy8gdXNlIHN1YnBpeGVsIHJlbmRlcmlu ZyAocGFydGlhbGx5LWZpbGxlZCBwaXhlbHMpCiAgICAgY2hhciB1c2VTdWJwaXhlbFBvc2l0aW9u aW5nOyAvLyB1c2Ugc3VicGl4ZWwgcG9zaXRpb25pbmcgKGZyYWN0aW9uYWwgWCBwb3NpdGlvbnMg Zm9yIGdseXBocykKIAotI2lmZGVmIFdFQktJVF9JTVBMRU1FTlRBVElPTgorI2lmIFdFQktJVF9J TVBMRU1FTlRBVElPTgogICAgIC8vIFRyYW5zbGF0ZXMgdGhlIG1lbWJlcnMgb2YgdGhpcyBzdHJ1 Y3QgdG8gYSBGb250UmVuZGVyU3R5bGUKICAgICB2b2lkIHRvRm9udFJlbmRlclN0eWxlKFdlYkNv cmU6OkZvbnRSZW5kZXJTdHlsZSopOwogI2VuZGlmCg==