89922 2012-06-25 16:59:34 -0700 [chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels 2012-06-25 21:15:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj cc-bugs enne jamesr piman webkit.review.bot wjmaclean zlieber oldest_to_newest 657021 0 danakj 2012-06-25 16:59:34 -0700 [chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels 657051 1 149404 danakj 2012-06-25 17:23:37 -0700 Created attachment 149404 Patch Our histograms will be super skewed on hidpi devices without this, so I'd like to backport this to m21. 657063 2 149404 enne 2012-06-25 17:33:29 -0700 Comment on attachment 149404 Patch R=me. 657224 3 149404 webkit.review.bot 2012-06-25 20:31:14 -0700 Comment on attachment 149404 Patch Rejecting attachment 149404 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: esting/gmock --revision 405 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 113. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' Died at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2529. Full output: http://queues.webkit.org/results/13100286 657229 4 149404 danakj 2012-06-25 20:39:00 -0700 Comment on attachment 149404 Patch trying again 657251 5 149404 webkit.review.bot 2012-06-25 21:15:13 -0700 Comment on attachment 149404 Patch Clearing flags on attachment: 149404 Committed r121224: <http://trac.webkit.org/changeset/121224> 657252 6 webkit.review.bot 2012-06-25 21:15:17 -0700 All reviewed patches have been landed. Closing bug. 149404 2012-06-25 17:23:37 -0700 2012-06-25 21:15:12 -0700 Patch bug-89922-20120625202337.patch text/plain 4137 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWY3Yzc0MDlkZWY4N2Ew MmRkNTZkNWUzODc4NDgwZjU0MDExZmI1OS4uZTcxYzAyNjQ3ZWIxMTQ3MjJiNTJkZjM3YjBmZTIz MzZkZDMzYzk4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA2LTI1ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQ0NP dmVyZHJhd01ldHJpY3Mgc2hvdWxkIHVzZSB0aGUgZGV2aWNlVmlld3BvcnRTaXplIHRvIGNvdW50 IGFjdHVhbCBwaXhlbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg5OTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ092ZXJkcmF3TWV0cmljcy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDQ092ZXJkcmF3TWV0cmljczo6cmVjb3JkTWV0cmljc0lu dGVybmFsKToKKwogMjAxMi0wNi0yNSAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW1NoYWRvd10gRXhlY3V0aW5nIEl0YWxpYyBhbmQgSW5zZXJ0VW5v cmRlcmVkTGlzdCBpbiBTaGFkb3cgRE9NIGNhdXNlcyBhIGNyYXNoCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ092ZXJkcmF3TWV0cmlj cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ092 ZXJkcmF3TWV0cmljcy5jcHAKaW5kZXggN2I1N2M4OWIxMjIxMGQxZTY3NjZlNDdjNThmYzZlOWI1 NDZlNzMxNi4uMGNjMmZhNWVjNjE2YTAwNDc3ODI2MTU4OTYwYmQwMTc4ODdlM2RkOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NPdmVy ZHJhd01ldHJpY3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDT3ZlcmRyYXdNZXRyaWNzLmNwcApAQCAtMTMxLDkgKzEzMSw5IEBAIHRlbXBs YXRlPHR5cGVuYW1lIExheWVyVHJlZUhvc3RUeXBlPgogdm9pZCBDQ092ZXJkcmF3TWV0cmljczo6 cmVjb3JkTWV0cmljc0ludGVybmFsKE1ldHJpY3NUeXBlIG1ldHJpY3NUeXBlLCBjb25zdCBMYXll clRyZWVIb3N0VHlwZSogbGF5ZXJUcmVlSG9zdCkgY29uc3QKIHsKICAgICAvLyBUaGlzIGdpdmVz IGFwcHJveGltYXRlbHkgMTB4IHRoZSBwZXJjZW50YWdlIG9mIHBpeGVscyB0byBmaWxsIHRoZSB2 aWV3cG9ydCBvbmNlLgotICAgIGZsb2F0IG5vcm1hbGl6YXRpb24gPSAxMDAwLmYgLyAobGF5ZXJU cmVlSG9zdC0+dmlld3BvcnRTaXplKCkud2lkdGgoKSAqIGxheWVyVHJlZUhvc3QtPnZpZXdwb3J0 U2l6ZSgpLmhlaWdodCgpKTsKKyAgICBmbG9hdCBub3JtYWxpemF0aW9uID0gMTAwMC5mIC8gKGxh eWVyVHJlZUhvc3QtPmRldmljZVZpZXdwb3J0U2l6ZSgpLndpZHRoKCkgKiBsYXllclRyZWVIb3N0 LT5kZXZpY2VWaWV3cG9ydFNpemUoKS5oZWlnaHQoKSk7CiAgICAgLy8gVGhpcyBnaXZlcyBhcHBy b3hpbWF0ZWx5IDEwMHggdGhlIHBlcmNlbnRhZ2Ugb2YgdGlsZXMgdG8gZmlsbCB0aGUgdmlld3Bv cnQgb25jZSwgaWYgYWxsIHRpbGVzIHdlcmUgMjU2eDI1Ni4KLSAgICBmbG9hdCB0aWxlTm9ybWFs aXphdGlvbiA9IDEwMDAwLmYgLyAobGF5ZXJUcmVlSG9zdC0+dmlld3BvcnRTaXplKCkud2lkdGgo KSAvIDI1Ni5mICogbGF5ZXJUcmVlSG9zdC0+dmlld3BvcnRTaXplKCkuaGVpZ2h0KCkgLyAyNTYu Zik7CisgICAgZmxvYXQgdGlsZU5vcm1hbGl6YXRpb24gPSAxMDAwMC5mIC8gKGxheWVyVHJlZUhv c3QtPmRldmljZVZpZXdwb3J0U2l6ZSgpLndpZHRoKCkgLyAyNTYuZiAqIGxheWVyVHJlZUhvc3Qt PmRldmljZVZpZXdwb3J0U2l6ZSgpLmhlaWdodCgpIC8gMjU2LmYpOwogCiAgICAgc3dpdGNoICht ZXRyaWNzVHlwZSkgewogICAgIGNhc2UgRHJhd2luZ1RvU2NyZWVuOgpAQCAtMTQyLDggKzE0Miw4 IEBAIHZvaWQgQ0NPdmVyZHJhd01ldHJpY3M6OnJlY29yZE1ldHJpY3NJbnRlcm5hbChNZXRyaWNz VHlwZSBtZXRyaWNzVHlwZSwgY29uc3QgTGF5CiAgICAgICAgIFdlYktpdDo6UGxhdGZvcm06OmN1 cnJlbnQoKS0+aGlzdG9ncmFtQ3VzdG9tQ291bnRzKCJSZW5kZXJlcjQucGl4ZWxDb3VudEN1bGxl ZF9EcmF3Iiwgc3RhdGljX2Nhc3Q8aW50Pihub3JtYWxpemF0aW9uICogbV9waXhlbHNDdWxsZWRG b3JEcmF3aW5nKSwgMTAwLCAxMDAwMDAwLCA1MCk7CiAKICAgICAgICAgewotICAgICAgICAgICAg VFJBQ0VfQ09VTlRFUl9JRDEoIndlYmtpdCIsICJEcmF3UGl4ZWxzQ3VsbGVkIiwgbGF5ZXJUcmVl SG9zdCwgbV9waXhlbHNDdWxsZWRGb3JEcmF3aW5nKTsKLSAgICAgICAgICAgIFRSQUNFX0VWRU5U Migid2Via2l0IiwgIkNDT3ZlcmRyYXdNZXRyaWNzIiwgIlBpeGVsc0RyYXduT3BhcXVlIiwgbV9w aXhlbHNEcmF3bk9wYXF1ZSwgIlBpeGVsc0RyYXduVHJhbnNsdWNlbnQiLCBtX3BpeGVsc0RyYXdu VHJhbnNsdWNlbnQpOworICAgICAgICAgICAgVFJBQ0VfQ09VTlRFUl9JRDEoImNjIiwgIkRyYXdQ aXhlbHNDdWxsZWQiLCBsYXllclRyZWVIb3N0LCBtX3BpeGVsc0N1bGxlZEZvckRyYXdpbmcpOwor ICAgICAgICAgICAgVFJBQ0VfRVZFTlQyKCJjYyIsICJDQ092ZXJkcmF3TWV0cmljcyIsICJQaXhl bHNEcmF3bk9wYXF1ZSIsIG1fcGl4ZWxzRHJhd25PcGFxdWUsICJQaXhlbHNEcmF3blRyYW5zbHVj ZW50IiwgbV9waXhlbHNEcmF3blRyYW5zbHVjZW50KTsKICAgICAgICAgfQogICAgICAgICBicmVh azsKICAgICBjYXNlIFVwZGF0ZUFuZENvbW1pdDoKQEAgLTE1MywxMiArMTUzLDEyIEBAIHZvaWQg Q0NPdmVyZHJhd01ldHJpY3M6OnJlY29yZE1ldHJpY3NJbnRlcm5hbChNZXRyaWNzVHlwZSBtZXRy aWNzVHlwZSwgY29uc3QgTGF5CiAgICAgICAgIFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+ aGlzdG9ncmFtQ3VzdG9tQ291bnRzKCJSZW5kZXJlcjQudGlsZUNvdW50Q3VsbGVkX1VwbG9hZCIs IHN0YXRpY19jYXN0PGludD4odGlsZU5vcm1hbGl6YXRpb24gKiBtX3RpbGVzQ3VsbGVkRm9yVXBs b2FkKSwgMTAwLCAxMDAwMDAwMCwgNTApOwogCiAgICAgICAgIHsKLSAgICAgICAgICAgIFRSQUNF X0NPVU5URVJfSUQxKCJ3ZWJraXQiLCAiVXBsb2FkVGlsZXNDdWxsZWQiLCBsYXllclRyZWVIb3N0 LCBtX3RpbGVzQ3VsbGVkRm9yVXBsb2FkKTsKLSAgICAgICAgICAgIFRSQUNFX0VWRU5UMigid2Vi a2l0IiwgIkNDT3ZlcmRyYXdNZXRyaWNzIiwgIlBpeGVsc1VwbG9hZGVkT3BhcXVlIiwgbV9waXhl bHNVcGxvYWRlZE9wYXF1ZSwgIlBpeGVsc1VwbG9hZGVkVHJhbnNsdWNlbnQiLCBtX3BpeGVsc1Vw bG9hZGVkVHJhbnNsdWNlbnQpOworICAgICAgICAgICAgVFJBQ0VfQ09VTlRFUl9JRDEoImNjIiwg IlVwbG9hZFRpbGVzQ3VsbGVkIiwgbGF5ZXJUcmVlSG9zdCwgbV90aWxlc0N1bGxlZEZvclVwbG9h ZCk7CisgICAgICAgICAgICBUUkFDRV9FVkVOVDIoImNjIiwgIkNDT3ZlcmRyYXdNZXRyaWNzIiwg IlBpeGVsc1VwbG9hZGVkT3BhcXVlIiwgbV9waXhlbHNVcGxvYWRlZE9wYXF1ZSwgIlBpeGVsc1Vw bG9hZGVkVHJhbnNsdWNlbnQiLCBtX3BpeGVsc1VwbG9hZGVkVHJhbnNsdWNlbnQpOwogICAgICAg ICB9CiAgICAgICAgIHsKICAgICAgICAgICAgIC8vIFRoaXMgbXVzdCBiZSBpbiBhIGRpZmZlcmVu dCBzY29wZSB0aGFuIHRoZSBUUkFDRV9FVkVOVDIgYWJvdmUuCi0gICAgICAgICAgICBUUkFDRV9F VkVOVDEoIndlYmtpdCIsICJDQ092ZXJkcmF3UGFpbnRNZXRyaWNzIiwgIlBpeGVsc1BhaW50ZWQi LCBtX3BpeGVsc1BhaW50ZWQpOworICAgICAgICAgICAgVFJBQ0VfRVZFTlQxKCJjYyIsICJDQ092 ZXJkcmF3UGFpbnRNZXRyaWNzIiwgIlBpeGVsc1BhaW50ZWQiLCBtX3BpeGVsc1BhaW50ZWQpOwog ICAgICAgICB9CiAgICAgICAgIGJyZWFrOwogICAgIH0K