89909 2012-06-25 14:20:45 -0700 [Qt] Enable grid layout LayoutTests 2012-06-26 02:12:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony ossy webkit.review.bot oldest_to_newest 656854 0 tony 2012-06-25 14:20:45 -0700 [Qt] Enable grid layout LayoutTests 656864 1 149358 tony 2012-06-25 14:28:39 -0700 Created attachment 149358 Patch 657420 2 149358 ossy 2012-06-26 02:06:04 -0700 Comment on attachment 149358 Patch LGTM, r=me. Thanks for the fix. 657426 3 149358 webkit.review.bot 2012-06-26 02:12:16 -0700 Comment on attachment 149358 Patch Clearing flags on attachment: 149358 Committed r121241: <http://trac.webkit.org/changeset/121241> 657427 4 webkit.review.bot 2012-06-26 02:12:20 -0700 All reviewed patches have been landed. Closing bug. 149358 2012-06-25 14:28:39 -0700 2012-06-26 02:12:16 -0700 Patch bug-89909-20120625142849.patch text/plain 6768 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGQ4YTFlNWMxMTUy YTczNTVjZjFlMzBlZjY2NGY1ODYwODQwZGRmZDYuLjhlYjdjMWRiNGZlNTFiNzMwZTdiYzhhNmE4 OThiMDVmMDNjODg4YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDYt MjUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBbUXRdIEVuYWJs ZSBncmlkIGxheW91dCBMYXlvdXRUZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODk5MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVzZSB0ZXN0cyBwYXNzLCB3ZSBqdXN0IG5lZWQgdG8gaG9vayB1 cCB0aGUgb3ZlcnJpZGVQcmVmZXJlbmNlLgorCisgICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5j cHA6CisgICAgICAgIChRV2ViU2V0dGluZ3NQcml2YXRlOjphcHBseSk6CisgICAgICAgIChRV2Vi U2V0dGluZ3M6OlFXZWJTZXR0aW5ncyk6CisgICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5oOiBB ZGQgZW51bSB2YWx1ZSBmb3IgQ1NTIGdyaWQgbGF5b3V0CisKIDIwMTItMDYtMjMgIFNoZXJpZmYg Qm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIxMjEwNTguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9x d2Vic2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcApp bmRleCBkMjUxNDE3MjBkMzA3ZDk2ZWNlYzE1YzY5YmE2MTBhMGMxOTI4YzQzLi5hNTQwZGMzNWYx OTEzODM3NmEzMjlmNTg4NzhkMzExMTAwOGVjMDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJz ZXR0aW5ncy5jcHAKQEAgLTE3NCw2ICsxNzQsOSBAQCB2b2lkIFFXZWJTZXR0aW5nc1ByaXZhdGU6 OmFwcGx5KCkKICAgICAgICAgdmFsdWUgPSBhdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6 Q1NTUmVnaW9uc0VuYWJsZWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbG9i YWwtPmF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpDU1NSZWdpb25zRW5hYmxlZCkpOwog ICAgICAgICBzZXR0aW5ncy0+c2V0Q1NTUmVnaW9uc0VuYWJsZWQodmFsdWUpOworICAgICAgICB2 YWx1ZSA9IGF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpDU1NHcmlkTGF5b3V0RW5hYmxl ZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0cmlidXRlcy52 YWx1ZShRV2ViU2V0dGluZ3M6OkNTU0dyaWRMYXlvdXRFbmFibGVkKSk7CisgICAgICAgIHNldHRp bmdzLT5zZXRDU1NHcmlkTGF5b3V0RW5hYmxlZCh2YWx1ZSk7CiAKICAgICAgICAgdmFsdWUgPSBh dHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6SHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2xvYmFsLT5hdHRyaWJ1dGVzLnZhbHVl KFFXZWJTZXR0aW5nczo6SHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkKSk7CkBAIC01MjIsNiArNTI1 LDcgQEAgUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MoKQogICAgIGQtPmF0dHJpYnV0ZXMuaW5z ZXJ0KFFXZWJTZXR0aW5nczo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQsIHRydWUpOwog ICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6V2ViR0xFbmFibGVkLCBmYWxz ZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpDU1NSZWdpb25zRW5h YmxlZCwgZmFsc2UpOworICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6Q1NT R3JpZExheW91dEVuYWJsZWQsIGZhbHNlKTsKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2Vi U2V0dGluZ3M6Okh5cGVybGlua0F1ZGl0aW5nRW5hYmxlZCwgZmFsc2UpOwogICAgIGQtPmF0dHJp YnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkLCBmYWxz ZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpGcmFtZUZsYXR0ZW5p bmdFbmFibGVkLCBmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vi c2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oCmluZGV4IDBh ZWU1MjViMGRlNGEzNTc2NmUyNWUzZjgxYTNkYzVlMzdjYWUzMDAuLjJlMDczNTZmMjFhODI2MmY1 ZWEwYTc1MGJjY2I2M2U3YjliNzdmOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQXBp L3F3ZWJzZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5o CkBAIC03OCw3ICs3OCw4IEBAIHB1YmxpYzoKICAgICAgICAgSmF2YXNjcmlwdENhbkNsb3NlV2lu ZG93cywKICAgICAgICAgV2ViR0xFbmFibGVkLAogICAgICAgICBDU1NSZWdpb25zRW5hYmxlZCwK LSAgICAgICAgSHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkCisgICAgICAgIEh5cGVybGlua0F1ZGl0 aW5nRW5hYmxlZCwKKyAgICAgICAgQ1NTR3JpZExheW91dEVuYWJsZWQKICAgICB9OwogICAgIGVu dW0gV2ViR3JhcGhpYyB7CiAgICAgICAgIE1pc3NpbmdJbWFnZUdyYXBoaWMsCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjU2M2Y4ZTkxODgwOWVj NzY3MDY1ZDMyYjY2MDVjYWQ4MTExZDk3Ny4uOGYyZjU4NDEwYjUxY2E3M2JlMzNiZmE0NzI5ZWNi MmI0Y2MyYjk4NyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTI1ICBUb255IENoYW5nICA8dG9ueUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW1F0XSBFbmFibGUgZ3JpZCBsYXlvdXQgTGF5b3V0VGVzdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5OTA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2UgdGVz dHMgcGFzcywgd2UganVzdCBuZWVkIHRvIGhvb2sgdXAgdGhlIG92ZXJyaWRlUHJlZmVyZW5jZS4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6V2ViUGFnZTo6cmVzZXRTZXR0aW5ncyk6IFJlc2V0IGdyaWQgbGF5b3V0 IGFuZCByZWdpb25zIGJldHdlZW4gdGVzdHMuCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQv TGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxl cjo6b3ZlcnJpZGVQcmVmZXJlbmNlKTogQWRkIFdlYktpdENTU0dyaWRMYXlvdXRFbmFibGVkLgor CiAyMDEyLTA2LTI1ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4K IAogICAgICAgICBbUXRdIEZpeCBXaW4zMiBkZWJ1ZyBidWlsZApkaWZmIC0tZ2l0IGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcAppbmRleCA3NjQzOTRiYzI0YzYzZDU5YjFiYTUw OWYyYzI5MTE3ZTVlNmMzNzVmLi45ZDBhZTYyYWM4ZWEwMTRmNDRjOTAxODFhMDI2MzhjMTgwNDFh MmQ4IDEwMDc1NQotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0 LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcApA QCAtMTg5LDYgKzE4OSw4IEBAIHZvaWQgV2ViUGFnZTo6cmVzZXRTZXR0aW5ncygpCiAgICAgc2V0 dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0Q2FuQWNjZXNz Q2xpcGJvYXJkKTsKICAgICBzZXR0aW5ncygpLT5yZXNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6 OkF1dG9Mb2FkSW1hZ2VzKTsKICAgICBzZXR0aW5ncygpLT5yZXNldEF0dHJpYnV0ZShRV2ViU2V0 dGluZ3M6Olpvb21UZXh0T25seSk7CisgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdl YlNldHRpbmdzOjpDU1NSZWdpb25zRW5hYmxlZCk7CisgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRy aWJ1dGUoUVdlYlNldHRpbmdzOjpDU1NHcmlkTGF5b3V0RW5hYmxlZCk7CiAKICAgICBtX2RydC0+ bGF5b3V0VGVzdENvbnRyb2xsZXIoKS0+c2V0Q2FyZXRCcm93c2luZ0VuYWJsZWQoZmFsc2UpOwog ICAgIG1fZHJ0LT5sYXlvdXRUZXN0Q29udHJvbGxlcigpLT5zZXRBdXRob3JBbmRVc2VyU3R5bGVz RW5hYmxlZCh0cnVlKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91 dFRlc3RDb250cm9sbGVyUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVz dENvbnRyb2xsZXJRdC5jcHAKaW5kZXggNzY4OWQ1YjRiYWE0ZDlkNDQ0ZTM2NmVhYmVkYjFlODll ZTkwODA5NS4uYjhmOTk4OTQ3MWJhODIzNjllYzI3YTFmM2RjNjJhMzI2Y2YwODZmYyAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAK KysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAK QEAgLTY2OSw2ICs2NjksOCBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpvdmVycmlkZVBy ZWZlcmVuY2UoY29uc3QgUVN0cmluZyYgbmFtZSwgY29uc3QgUVZhcmlhbgogICAgICAgICBzZXR0 aW5ncy0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6V2ViR0xFbmFibGVkLCB2YWx1ZS50b0Jv b2woKSk7CiAgICAgZWxzZSBpZiAobmFtZSA9PSAiV2ViS2l0Q1NTUmVnaW9uc0VuYWJsZWQiKQog ICAgICAgICBzZXR0aW5ncy0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6Q1NTUmVnaW9uc0Vu YWJsZWQsIHZhbHVlLnRvQm9vbCgpKTsKKyAgICBlbHNlIGlmIChuYW1lID09ICJXZWJLaXRDU1NH cmlkTGF5b3V0RW5hYmxlZCIpCisgICAgICAgIHNldHRpbmdzLT5zZXRBdHRyaWJ1dGUoUVdlYlNl dHRpbmdzOjpDU1NHcmlkTGF5b3V0RW5hYmxlZCwgdmFsdWUudG9Cb29sKCkpOwogICAgIGVsc2Ug aWYgKG5hbWUgPT0gIldlYktpdEh5cGVybGlua0F1ZGl0aW5nRW5hYmxlZCIpCiAgICAgICAgIHNl dHRpbmdzLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpIeXBlcmxpbmtBdWRpdGluZ0VuYWJs ZWQsIHZhbHVlLnRvQm9vbCgpKTsKICAgICBlbHNlIGlmIChuYW1lID09ICJXZWJLaXRIaXhpZTc2 V2ViU29ja2V0UHJvdG9jb2xFbmFibGVkIikKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmMTE0ZGYyMDI2YjQzODBjNTliM2I4 ZGRiYTNjZDBlN2FlYzI5M2YyLi45ZWMyODExZDY1ZDc5MGMwNDZjZmU4YzZjYWVkNTAyNWYzMzhj NGIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMjUgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KKworICAgICAgICBbUXRdIEVuYWJsZSBncmlkIGxheW91dCBMYXlvdXRU ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk5 MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL3F0L1NraXBwZWQ6IEVuYWJsZSBmYXN0L2Nzcy1ncmlkLWxheW91dCB0ZXN0cy4KKwog MjAxMi0wNi0yNSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNv bT4KIAogICAgICAgICBbUXRdIFVuc2tpcCAzRCB0cmFuc2Zvcm0gdGVzdHMuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZAppbmRleCBjMzg5YTk4NTgwOWZlOGIwODY4Yjc3NWJiYzNmM2EyNjcyNDUwNTM4 Li45MTRjZWE1ZTMzNjMyZDMzYzRjOGQxNzliMjQwOWZjMTVjNGI1NDAwIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L3F0L1NraXBwZWQKQEAgLTE1Niw5ICsxNTYsNiBAQCBzdmcvY3VzdG9tL21hbnVhbGx5LXBhcnNl ZC1lbWJlZGRlZC1zdmctYWxsb3dlZC1pbi1kYXNoYm9hcmQuaHRtbAogc3ZnL2N1c3RvbS9tYW51 YWxseS1wYXJzZWQtc3ZnLWFsbG93ZWQtaW4tZGFzaGJvYXJkLmh0bWwKIHN2Zy9jdXN0b20vc3Zn LWFsbG93ZWQtaW4tZGFzaGJvYXJkLW9iamVjdC5odG1sCiAKLSMgQ1NTIEdyaWQgTGF5b3V0IGlz IG5vdCB5ZXQgZW5hYmxlZC4gaHR0cDovL3dlYmtpdC5vcmcvYi82MDczMQotZmFzdC9jc3MtZ3Jp ZC1sYXlvdXQKLQogIyA8c3R5bGUgc2NvcGVkPiBpcyBub3QgeWV0IGVuYWJsZWQuIGh0dHA6Ly93 ZWJraXQub3JnL2IvNDkxNDIKIGZhc3QvY3NzL3N0eWxlLXNjb3BlZAogIyBDU1MgUmVnaW9ucyB0 ZXN0cyBmb3IgcmVnaW9uIHN0eWxpbmcgYW5kIHNjb3BlZCBzdHlsZXMK