89895 2012-06-25 11:12:35 -0700 IndexedDB: Stub out new onSuccess() handler for chromium 2012-06-25 15:10:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alecflett alecflett abarth dglazkov fishd jamesr jsbell tkent+wkapi webkit.review.bot oldest_to_newest 656730 0 alecflett 2012-06-25 11:12:35 -0700 IndexedDB: Stub out new onSuccess() handler for chromium 656733 1 149327 alecflett 2012-06-25 11:14:32 -0700 Created attachment 149327 Patch 656734 2 alecflett 2012-06-25 11:15:46 -0700 jsbell - quick review - I am working backwards from the get() in order to ultimately make putInternal() safe, as we discussed. 656736 3 webkit.review.bot 2012-06-25 11:17:31 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 656777 4 jsbell 2012-06-25 12:05:46 -0700 lgtm 656912 5 149327 webkit.review.bot 2012-06-25 15:09:53 -0700 Comment on attachment 149327 Patch Clearing flags on attachment: 149327 Committed r121185: <http://trac.webkit.org/changeset/121185> 656913 6 webkit.review.bot 2012-06-25 15:10:10 -0700 All reviewed patches have been landed. Closing bug. 149327 2012-06-25 11:14:32 -0700 2012-06-25 15:09:53 -0700 Patch bug-89895-20120625111432.patch text/plain 6000 alecflett U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhhNmYxMzRlYTAyOWQ4YzRhZGY3MjNiM2IyNzA0MDhmZTU3YmIzYmEuLmEzMzI1ZjUzODZhOGQz NjkyZjM4YTU5OTE1NmMzMmE3MWJmOTBjZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTItMDYtMjUgIEFsZWMgRmxldHQgIDxhbGVjZmxldHRAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogU3R1YiBvdXQgbmV3IG9uU3VjY2VzcygpIGhh bmRsZXIgZm9yIGNocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04OTg5NQorCisgICAgICAgIFRoaXMgaXMgdGhlIGNocm9taXVtIHNpZGUgb2Yg YSByZWZhY3RvciB3aGljaCB3aWxsCisgICAgICAgIGludHJvZHVjZSBhbiBvblN1Y2Nlc3MoKSBt ZXRob2Qgd2hpY2ggaW5jbHVkZXMgdGhlIHJhdworICAgICAgICBTZXJpYWxpemVkU2NyaXB0VmFs dWUgdG8gdGhlIGZyb250ZW5kLCBzbyB0aGUgcHJpbWFyeUtleQorICAgICAgICBpbmplY3Rpb24g Y2FuIGhhcHBlbiBpbiB0aGUgZnJvbnQgZW5kLCByYXRoZXIgdGhhbgorICAgICAgICB0aGUgVjgg aGVscGVyIHByb2Nlc3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBwdWJsaWMvV2ViSURCQ2FsbGJhY2tzLmg6CisgICAgICAgIChXZWJLaXQpOgor ICAgICAgICAoV2ViS2l0OjpXZWJJREJDYWxsYmFja3M6Om9uU3VjY2Vzcyk6CisgICAgICAgICog c3JjL0lEQkNhbGxiYWNrc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6SURCQ2FsbGJhY2tz UHJveHk6Om9uU3VjY2Vzcyk6CisgICAgICAgICogc3JjL0lEQkNhbGxiYWNrc1Byb3h5Lmg6Cisg ICAgICAgIChJREJDYWxsYmFja3NQcm94eSk6CisgICAgICAgICogc3JjL1dlYklEQkNhbGxiYWNr c0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJDYWxsYmFja3NJbXBsOjpvblN1Y2Nl c3MpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViSURCQ2FsbGJhY2tzSW1w bC5oOgorICAgICAgICAoV2ViSURCQ2FsbGJhY2tzSW1wbCk6CisKIDIwMTItMDYtMjMgIEt3YW5n IFl1bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBbY2hyb21pdW1dIFJl dHVybiBoYXMgdmFsdWUsIGluIGZ1bmN0aW9uIHJldHVybmluZyB2b2lkCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkNhbGxiYWNrcy5oCmluZGV4IDMxZDY2NWI0YmJj MGFlOThiNjhhYjllNTIwOTg2NDg1N2YyNzAzM2UuLmE2M2MwYmM5ZWU2YzRjYWYyZDY3ZDk1ZTVk MDBhMTFjOWZjZDgyOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYklEQkNhbGxiYWNrcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YklEQkNhbGxiYWNrcy5oCkBAIC0zNiw2ICszNiw3IEBAIGNsYXNzIFdlYklEQkN1cnNvcjsKIGNs YXNzIFdlYklEQkRhdGFiYXNlOwogY2xhc3MgV2ViSURCRGF0YWJhc2VFcnJvcjsKIGNsYXNzIFdl YklEQktleTsKK2NsYXNzIFdlYklEQktleVBhdGg7CiBjbGFzcyBXZWJJREJJbmRleDsKIGNsYXNz IFdlYklEQk9iamVjdFN0b3JlOwogY2xhc3MgV2ViSURCVHJhbnNhY3Rpb247CkBAIC01NCw2ICs1 NSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKGNvbnN0IFdlYklEQktl eSYpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIG9u U3VjY2VzcyhXZWJJREJUcmFuc2FjdGlvbiopIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgp OyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhjb25zdCBXZWJTZXJpYWxpemVkU2NyaXB0 VmFsdWUmKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQorICAgIHZpcnR1YWwgdm9p ZCBvblN1Y2Nlc3MoY29uc3QgV2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlJiwgY29uc3QgV2ViSURC S2V5JiwgY29uc3QgV2ViSURCS2V5UGF0aCYpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgp OyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzc1dpdGhDb250aW51YXRpb24oKSB7IFdFQktJ VF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkJsb2NrZWQoKSB7 IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nl c3NXaXRoUHJlZmV0Y2goY29uc3QgV2ViVmVjdG9yPFdlYklEQktleT4mIGtleXMsIGNvbnN0IFdl YlZlY3RvcjxXZWJJREJLZXk+JiBwcmltYXJ5S2V5cywgY29uc3QgV2ViVmVjdG9yPFdlYlNlcmlh bGl6ZWRTY3JpcHRWYWx1ZT4mIHZhbHVlcykgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7 IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lEQkNhbGxiYWNrc1By b3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lEQkNhbGxiYWNrc1Byb3h5LmNw cAppbmRleCBkMGU3NTQ4NWEzNTI4NTkzMWE4ZGE3YzVkOTQzYjI5OWM1NjE0Njk5Li5hNTQ0MTg5 YjY2OGY0NGVkODE0ZDRjNzIyODA3MTQwM2MyN2I5N2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9JREJDYWxsYmFja3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvSURCQ2FsbGJhY2tzUHJveHkuY3BwCkBAIC05NCw2ICs5NCwxMCBAQCB2 b2lkIElEQkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nlc3MoUGFzc1JlZlB0cjxTZXJpYWxpemVkU2Ny aXB0VmFsdWU+IHNlcmlhbGl6ZWRTYwogICAgIG1fY2FsbGJhY2tzLT5vblN1Y2Nlc3MoV2ViU2Vy aWFsaXplZFNjcmlwdFZhbHVlKHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSkpOwogfQogCit2b2lkIElE QkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nlc3MoUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFs dWU+IHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSwgUGFzc1JlZlB0cjxJREJLZXk+IGtleSwgY29uc3Qg SURCS2V5UGF0aCYga2V5UGF0aCkKK3sKKyAgICBtX2NhbGxiYWNrcy0+b25TdWNjZXNzKHNlcmlh bGl6ZWRTY3JpcHRWYWx1ZSwga2V5LCBrZXlQYXRoKTsKK30KIHZvaWQgSURCQ2FsbGJhY2tzUHJv eHk6Om9uU3VjY2Vzc1dpdGhDb250aW51YXRpb24oKQogewogICAgIG1fY2FsbGJhY2tzLT5vblN1 Y2Nlc3NXaXRoQ29udGludWF0aW9uKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9JREJDYWxsYmFja3NQcm94eS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv SURCQ2FsbGJhY2tzUHJveHkuaAppbmRleCAzMzMzNTFmZGI5YThhNTk0MDE5YTIyZjczMmNiNzVl NDlkNTdmNzExLi5kYjMwNTY1NTBiMmIyZTE3ZTJlMzBkZGVmNzllOWRkMjljMjVmZmJkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJDYWxsYmFja3NQcm94eS5oCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lEQkNhbGxiYWNrc1Byb3h5LmgKQEAgLTUy LDYgKzUyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoUGFzc1JlZlB0 cjxXZWJDb3JlOjpJREJLZXk+KTsKICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKFBhc3NSZWZQ dHI8V2ViQ29yZTo6SURCVHJhbnNhY3Rpb25CYWNrZW5kSW50ZXJmYWNlPik7CiAgICAgdmlydHVh bCB2b2lkIG9uU3VjY2VzcyhQYXNzUmVmUHRyPFdlYkNvcmU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZT4pOworICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoUGFzc1JlZlB0cjxXZWJDb3JlOjpTZXJp YWxpemVkU2NyaXB0VmFsdWU+LCBQYXNzUmVmUHRyPFdlYkNvcmU6OklEQktleT4sIGNvbnN0IFdl YkNvcmU6OklEQktleVBhdGgmKTsKICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzV2l0aENvbnRp bnVhdGlvbigpOwogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3NXaXRoUHJlZmV0Y2goY29uc3Qg VmVjdG9yPFJlZlB0cjxXZWJDb3JlOjpJREJLZXk+ID4mIGtleXMsIGNvbnN0IFZlY3RvcjxSZWZQ dHI8V2ViQ29yZTo6SURCS2V5PiA+JiBwcmltYXJ5S2V5cywgY29uc3QgVmVjdG9yPFJlZlB0cjxX ZWJDb3JlOjpTZXJpYWxpemVkU2NyaXB0VmFsdWU+ID4mIHZhbHVlcyk7CiAgICAgdmlydHVhbCB2 b2lkIG9uQmxvY2tlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViSURCQ2FsbGJhY2tzSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJ REJDYWxsYmFja3NJbXBsLmNwcAppbmRleCAxYTgyYTYzZDgyZDdlNTdlYjk3YTMxMDg0MTVmN2M4 YzI3YjAxMTk4Li4zMTI2NmIxYTMxOGEyNDFjYmI1NDQ5ZjMxYmQwYjk2NDIwN2M3YzMwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJDYWxsYmFja3NJbXBsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJDYWxsYmFja3NJbXBsLmNw cApAQCAtOTAsNiArOTAsMTMgQEAgdm9pZCBXZWJJREJDYWxsYmFja3NJbXBsOjpvblN1Y2Nlc3Mo Y29uc3QgV2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlJiBzZXJpYWxpemVkU2MKICAgICBtX2NhbGxi YWNrcy0+b25TdWNjZXNzKHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSk7CiB9CiAKK3ZvaWQgV2ViSURC Q2FsbGJhY2tzSW1wbDo6b25TdWNjZXNzKGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSYg c2VyaWFsaXplZFNjcmlwdFZhbHVlLCBjb25zdCBXZWJJREJLZXkmIGtleSwgY29uc3QgV2ViSURC S2V5UGF0aCYga2V5UGF0aCkKK3sKKyAgICAvLyBGSVhNRTogcHJveHkgdG8gdGhlIDMtcGFyYW1l dGVyIHZlcnNpb24gd2hlbiBpbnRlcmZhY2UgbGFuZHM6CisgICAgLy8gbV9jYWxsYmFja3MtPm9u U3VjY2VzcyhzZXJpYWxpemVkU2NyaXB0VmFsdWUsIGtleSwga2V5UGF0aCk7KTsKKyAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKK30KKwogdm9pZCBXZWJJREJDYWxsYmFja3NJbXBsOjpvblN1Y2Nl c3NXaXRoQ29udGludWF0aW9uKCkKIHsKICAgICBtX2NhbGxiYWNrcy0+b25TdWNjZXNzV2l0aENv bnRpbnVhdGlvbigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi SURCQ2FsbGJhY2tzSW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSURCQ2Fs bGJhY2tzSW1wbC5oCmluZGV4IGJlODU0MWI3MGM1ZmIyNzRhZGIyMTZhOWY0MTdhZTRmZjQ2ZTFj MzguLjdiMDIxNjM1OWQ1NmQ4MTg2OTVmZTk3M2EwMTgyYWZiNTEyNTAxNjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQkNhbGxiYWNrc0ltcGwuaAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJDYWxsYmFja3NJbXBsLmgKQEAgLTQ4LDYg KzQ4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoY29uc3QgV2ViSURC S2V5Jik7CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2VzcyhXZWJJREJUcmFuc2FjdGlvbiopOwog ICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoY29uc3QgV2ViU2VyaWFsaXplZFNjcmlwdFZhbHVl Jik7CisgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhjb25zdCBXZWJTZXJpYWxpemVkU2NyaXB0 VmFsdWUmLCBjb25zdCBXZWJJREJLZXkmLCBjb25zdCBXZWJJREJLZXlQYXRoJik7CiAgICAgdmly dHVhbCB2b2lkIG9uU3VjY2Vzc1dpdGhDb250aW51YXRpb24oKTsKICAgICB2aXJ0dWFsIHZvaWQg b25CbG9ja2VkKCk7CiAK