89892 2012-06-25 10:24:57 -0700 Compilation failure in StyleResolver.cpp (clang) 2012-07-16 00:11:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst cmarcelo macpherson menard webkit.review.bot oldest_to_newest 656684 0 mkwst 2012-06-25 10:24:57 -0700 Currently, compilation via ninja/clang is throwing errors in StyleResolver and CSSParser like the following: ../../third_party/WebKit/Source/WebCore/css/StyleResolver.cpp:3392:13: error: enumeration value 'CSSPropertyVariable' not handled in switch [-Werror,-Wswitch] switch (id) { 656687 1 149317 mkwst 2012-06-25 10:31:03 -0700 Created attachment 149317 Patch 656709 2 149317 menard 2012-06-25 10:53:15 -0700 Comment on attachment 149317 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149317&action=review > Source/WebCore/css/CSSParser.cpp:2634 > +#endif It is misleading to put it there as per comment above : // These properties should be handled before in isValidKeywordPropertyAndValue(). And CSSPropertyVariable is not handled there. So it will ASSERT which is incorrect. You better make a case somewhere else, and return false, add a FIXME : Implement me. > Source/WebCore/css/StyleResolver.cpp:4281 > +#endif Ditto there. Incorrect. 656713 3 mkwst 2012-06-25 10:57:01 -0700 (In reply to comment #2) > (From update of attachment 149317 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=149317&action=review > > > Source/WebCore/css/CSSParser.cpp:2634 > > +#endif > > It is misleading to put it there as per comment above : > > // These properties should be handled before in isValidKeywordPropertyAndValue(). > > And CSSPropertyVariable is not handled there. So it will ASSERT which is incorrect. > > You better make a case somewhere else, and return false, add a FIXME : Implement me. Thanks for the review. I figured that ASSERTing was better than just returning false (since I have no idea what the correct behavior is), but I'll add the additional case and track down the original author for implementation details. 656719 4 149324 mkwst 2012-06-25 11:03:09 -0700 Created attachment 149324 Patch 656720 5 mkwst 2012-06-25 11:04:50 -0700 New patch; macpherson@chromium.org looks like the original author, and is on CC. 656722 6 149324 mkwst 2012-06-25 11:05:42 -0700 Comment on attachment 149324 Patch Ignore this, it fails. 656724 7 149325 mkwst 2012-06-25 11:07:59 -0700 Created attachment 149325 Patch 656743 8 menard 2012-06-25 11:25:13 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 149317 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=149317&action=review > > > > > Source/WebCore/css/CSSParser.cpp:2634 > > > +#endif > > > > It is misleading to put it there as per comment above : > > > > // These properties should be handled before in isValidKeywordPropertyAndValue(). > > > > And CSSPropertyVariable is not handled there. So it will ASSERT which is incorrect. > > > > You better make a case somewhere else, and return false, add a FIXME : Implement me. > > Thanks for the review. I figured that ASSERTing was better than just returning false (since I have no idea what the correct behavior is), but I'll add the additional case and track down the original author for implementation details. Well ASSERTing is a bit rude. It if returns false then the CSS declaration will be dropped but at least I can continue using the browser :). 656745 9 149333 mkwst 2012-06-25 11:27:25 -0700 Created attachment 149333 Patch 656748 10 mkwst 2012-06-25 11:28:40 -0700 (In reply to comment #9) > Created an attachment (id=149333) [details] > Patch New patch moves the `case` up above the "all the rest + svg" block. 656981 11 149333 webkit.review.bot 2012-06-25 16:16:01 -0700 Comment on attachment 149333 Patch Clearing flags on attachment: 149333 Committed r121192: <http://trac.webkit.org/changeset/121192> 656982 12 webkit.review.bot 2012-06-25 16:16:16 -0700 All reviewed patches have been landed. Closing bug. 657104 13 macpherson 2012-06-25 18:13:51 -0700 Weird that these showed up in clang but not my regular variables build. In both cases this code should be unreachable. Thanks for the fixes. 657109 14 mkwst 2012-06-25 18:18:08 -0700 (In reply to comment #13) > Weird that these showed up in clang but not my regular variables build. In both cases this code should be unreachable. Thanks for the fixes. If it really is unreachable, can you throw up a patch to trigger the ASSERT (basically the first patch on this bug, I suppose)? I wasn't sure what the behavior should be, and Alexis suggested that special-casing it was appropriate. If we don't need that case, we can just fold it into the big block o' case statements. :) 657163 15 macpherson 2012-06-25 19:09:17 -0700 Reopening to attach new patch. 657164 16 149426 macpherson 2012-06-25 19:09:23 -0700 Created attachment 149426 Patch 657172 17 macpherson 2012-06-25 19:18:01 -0700 I also ran tests locally with CSS_VARIABLES enabled to make sure the code really is unreachable. 662599 18 macpherson 2012-07-03 17:23:45 -0700 Ping for r+? 669486 19 149426 rniwa 2012-07-13 15:18:34 -0700 Comment on attachment 149426 Patch ok. 670138 20 149426 webkit.review.bot 2012-07-16 00:11:17 -0700 Comment on attachment 149426 Patch Clearing flags on attachment: 149426 Committed r122700: <http://trac.webkit.org/changeset/122700> 670139 21 webkit.review.bot 2012-07-16 00:11:22 -0700 All reviewed patches have been landed. Closing bug. 149317 2012-06-25 10:31:03 -0700 2012-06-25 11:03:01 -0700 Patch bug-89892-20120625193103.patch text/plain 2190 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkzNTg3ZTBlMWViNTNh MmE0NTA4YzE4ZjI4M2M5ZjNmNDUxMzQyNS4uOTAxYWNiMGE5MTgzMzBhYmJlM2I5YTJiOTMzNzNk M2NiZTM2NGE0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTI1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5jb20+CisKKyAgICAgICAgRml4aW5nIGNvbXBpbGF0aW9u IGZhaWx1cmUgaW4gU3R5bGVSZXNvbHZlci5jcHAvQ1NTUGFyc2VyLmNwcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4OTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgQ1NTUHJvcGVydHlWYXJp YWJsZSB0byBzd2l0Y2ggc3RhdGVtZW50cyBpbiBDU1NQYXJzZXIgYW5kCisgICAgICAgIFN0eWxl UmVzb2x2ZXIgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyB1bmRlciBuaW5qYS9jbGFuZy4KKwor ICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2Vy OjpwYXJzZVZhbHVlKToKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpjb2xsZWN0TWF0Y2hpbmdSdWxlc0Zvckxpc3QpOgor CiAyMDEyLTA2LTI0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTIxMTA2LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcAppbmRleCA2Mzc4MzU5NmIzMjdjMzdkNzRjOTI2NDcyZmE2NDQ4NGExZTE1NDIy Li4yOWQ4MzI0MWMwMmQzYjY4Yjk4NzM2ZjBjY2UxNzU4OWZjNTQyMWI0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUGFyc2VyLmNwcApAQCAtMjYyOSw2ICsyNjI5LDkgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNl VmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQogICAgIGNhc2UgQ1NT UHJvcGVydHlUZXh0VHJhbnNmb3JtOgogICAgIGNhc2UgQ1NTUHJvcGVydHlUZXh0VW5kZXJsaW5l TW9kZToKICAgICBjYXNlIENTU1Byb3BlcnR5VGV4dFVuZGVybGluZVN0eWxlOgorI2lmIEVOQUJM RShDU1NfVkFSSUFCTEVTKQorICAgIGNhc2UgQ1NTUHJvcGVydHlWYXJpYWJsZToKKyNlbmRpZgog ICAgIGNhc2UgQ1NTUHJvcGVydHlWaXNpYmlsaXR5OgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJr aXRBcHBlYXJhbmNlOgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCYWNrZmFjZVZpc2liaWxp dHk6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggNzEwNjg4NDI1NjU3ZThh MGQ4ZjhkN2QyNDJjN2M4NTk2MzE5MWM5OS4uNzNkZjQ3YzM5OTlhODBiZjcyODEwNzU1N2I0Zjc2 MzBkZTBkMTYyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtNDI3Niw2 ICs0Mjc2LDkgQEAgdm9pZCBTdHlsZVJlc29sdmVyOjphcHBseVByb3BlcnR5KENTU1Byb3BlcnR5 SUQgaWQsIENTU1ZhbHVlKiB2YWx1ZSkKICAgICBjYXNlIENTU1Byb3BlcnR5VG9wOgogICAgIGNh c2UgQ1NTUHJvcGVydHlVbmljb2RlQmlkaToKICAgICBjYXNlIENTU1Byb3BlcnR5VmVydGljYWxB bGlnbjoKKyNpZiBFTkFCTEUoQ1NTX1ZBUklBQkxFUykKKyAgICBjYXNlIENTU1Byb3BlcnR5VmFy aWFibGU6CisjZW5kaWYKICAgICBjYXNlIENTU1Byb3BlcnR5VmlzaWJpbGl0eToKICAgICBjYXNl IENTU1Byb3BlcnR5V2Via2l0QW5pbWF0aW9uRGVsYXk6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdl YmtpdEFuaW1hdGlvbkRpcmVjdGlvbjoK 149324 2012-06-25 11:03:09 -0700 2012-06-25 11:07:52 -0700 Patch bug-89892-20120625200308.patch text/plain 2386 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkzNTg3ZTBlMWViNTNh MmE0NTA4YzE4ZjI4M2M5ZjNmNDUxMzQyNS4uN2FlYzQzZDY2YjhhNDA2NzcxOTgxMjAyYzQxNzI5 MjAzYjFiM2MxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTI1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5jb20+CisKKyAgICAgICAgRml4aW5nIGNvbXBpbGF0aW9u IGZhaWx1cmUgaW4gU3R5bGVSZXNvbHZlci5jcHAvQ1NTUGFyc2VyLmNwcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4OTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgQ1NTUHJvcGVydHlWYXJp YWJsZSB0byBzd2l0Y2ggc3RhdGVtZW50cyBpbiBDU1NQYXJzZXIgYW5kCisgICAgICAgIFN0eWxl UmVzb2x2ZXIgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyB1bmRlciBuaW5qYS9jbGFuZy4gSSd2 ZQorICAgICAgICBhZGRlZCBib3RoIGFzIG5ldyBjYXNlcyB0byB0aGUgc3dpdGNoZXMsIHdpdGgg RklYTUUgY29tbWVudHMgZm9yCisgICAgICAgIGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICog Y3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFs dWUpOgorICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlN0eWxlUmVzb2x2ZXI6OmNvbGxlY3RNYXRjaGluZ1J1bGVzRm9yTGlzdCk6CisKIDIwMTItMDYt MjQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjExMDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CmluZGV4IDYzNzgzNTk2YjMyN2MzN2Q3NGM5MjY0NzJmYTY0NDg0YTFlMTU0MjIuLmUyOGU5NzRi YTgwYjk2NWM5MzMwMDg5YjFmOTNhYmFkYjFkNDg4NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCkBAIC0yNzAxLDYgKzI3MDEsMTMgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NT UHJvcGVydHlJRCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQogICAgICAgICAvLyBUaGVzZSBwcm9w ZXJ0aWVzIHNob3VsZCBiZSBoYW5kbGVkIGJlZm9yZSBpbiBpc1ZhbGlkS2V5d29yZFByb3BlcnR5 QW5kVmFsdWUoKS4KICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVy biBmYWxzZTsKKworI2lmIEVOQUJMRShDU1NfVkFSSUFCTEVTKQorICAgIGNhc2UgQ1NTUHJvcGVy dHlWYXJpYWJsZToKKyAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGhhdmUgYW4gYWN0dWFs IGltcGxlbWVudGF0aW9uLgorICAgICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKKwogI2lmIEVO QUJMRShTVkcpCiAgICAgZGVmYXVsdDoKICAgICAgICAgcmV0dXJuIHBhcnNlU1ZHVmFsdWUocHJv cElkLCBpbXBvcnRhbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVz b2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDcx MDY4ODQyNTY1N2U4YTBkOGY4ZDdkMjQyYzdjODU5NjMxOTFjOTkuLmEyYTI0YWNiMTQ0ODEzNGZm YWI3NTYyZGRkNTZmODZiYjdmYjI5NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5j cHAKQEAgLTQ0MTksNiArNDQxOSwxMyBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVy dHkoQ1NTUHJvcGVydHlJRCBpZCwgQ1NTVmFsdWUqIHZhbHVlKQogICAgIGNhc2UgQ1NTUHJvcGVy dHlab29tOgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuOwor CisjaWYgRU5BQkxFKENTU19WQVJJQUJMRVMpCisgICAgY2FzZSBDU1NQcm9wZXJ0eVZhcmlhYmxl OgorICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgaGF2ZSBhbiBhY3R1YWwgaW1wbGVtZW50 YXRpb24uCisgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorCiAjaWYgRU5BQkxFKFNWRykK ICAgICBkZWZhdWx0OgogICAgICAgICAvLyBUcnkgdGhlIFNWRyBwcm9wZXJ0aWVzCg== 149325 2012-06-25 11:07:59 -0700 2012-06-25 11:27:17 -0700 Patch bug-89892-20120625200758.patch text/plain 2380 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkzNTg3ZTBlMWViNTNh MmE0NTA4YzE4ZjI4M2M5ZjNmNDUxMzQyNS4uN2FlYzQzZDY2YjhhNDA2NzcxOTgxMjAyYzQxNzI5 MjAzYjFiM2MxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTI1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5jb20+CisKKyAgICAgICAgRml4aW5nIGNvbXBpbGF0aW9u IGZhaWx1cmUgaW4gU3R5bGVSZXNvbHZlci5jcHAvQ1NTUGFyc2VyLmNwcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4OTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgQ1NTUHJvcGVydHlWYXJp YWJsZSB0byBzd2l0Y2ggc3RhdGVtZW50cyBpbiBDU1NQYXJzZXIgYW5kCisgICAgICAgIFN0eWxl UmVzb2x2ZXIgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyB1bmRlciBuaW5qYS9jbGFuZy4gSSd2 ZQorICAgICAgICBhZGRlZCBib3RoIGFzIG5ldyBjYXNlcyB0byB0aGUgc3dpdGNoZXMsIHdpdGgg RklYTUUgY29tbWVudHMgZm9yCisgICAgICAgIGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICog Y3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFs dWUpOgorICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlN0eWxlUmVzb2x2ZXI6OmNvbGxlY3RNYXRjaGluZ1J1bGVzRm9yTGlzdCk6CisKIDIwMTItMDYt MjQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjExMDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CmluZGV4IDYzNzgzNTk2YjMyN2MzN2Q3NGM5MjY0NzJmYTY0NDg0YTFlMTU0MjIuLmUyOGU5NzRi YTgwYjk2NWM5MzMwMDg5YjFmOTNhYmFkYjFkNDg4NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCkBAIC0yNzAxLDYgKzI3MDEsMTMgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NT UHJvcGVydHlJRCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQogICAgICAgICAvLyBUaGVzZSBwcm9w ZXJ0aWVzIHNob3VsZCBiZSBoYW5kbGVkIGJlZm9yZSBpbiBpc1ZhbGlkS2V5d29yZFByb3BlcnR5 QW5kVmFsdWUoKS4KICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVy biBmYWxzZTsKKworI2lmIEVOQUJMRShDU1NfVkFSSUFCTEVTKQorICAgIGNhc2UgQ1NTUHJvcGVy dHlWYXJpYWJsZToKKyAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGhhdmUgYW4gYWN0dWFs IGltcGxlbWVudGF0aW9uLgorICAgICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKKwogI2lmIEVO QUJMRShTVkcpCiAgICAgZGVmYXVsdDoKICAgICAgICAgcmV0dXJuIHBhcnNlU1ZHVmFsdWUocHJv cElkLCBpbXBvcnRhbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVz b2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDcx MDY4ODQyNTY1N2U4YTBkOGY4ZDdkMjQyYzdjODU5NjMxOTFjOTkuLjk2ZGJmOWYzNDA1ZDk3YmNh MDhmYWMxMmE4OWZmNDRmYmZlN2ZlYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5j cHAKQEAgLTQ0MTksNiArNDQxOSwxMyBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVy dHkoQ1NTUHJvcGVydHlJRCBpZCwgQ1NTVmFsdWUqIHZhbHVlKQogICAgIGNhc2UgQ1NTUHJvcGVy dHlab29tOgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuOwor CisjaWYgRU5BQkxFKENTU19WQVJJQUJMRVMpCisgICAgY2FzZSBDU1NQcm9wZXJ0eVZhcmlhYmxl OgorICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgaGF2ZSBhbiBhY3R1YWwgaW1wbGVtZW50 YXRpb24uCisgICAgICAgIHJldHVybjsKKyNlbmRpZgorCiAjaWYgRU5BQkxFKFNWRykKICAgICBk ZWZhdWx0OgogICAgICAgICAvLyBUcnkgdGhlIFNWRyBwcm9wZXJ0aWVzCg== 149333 2012-06-25 11:27:25 -0700 2012-06-25 19:09:10 -0700 Patch bug-89892-20120625202724.patch text/plain 2394 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkzNTg3ZTBlMWViNTNh MmE0NTA4YzE4ZjI4M2M5ZjNmNDUxMzQyNS4uN2FlYzQzZDY2YjhhNDA2NzcxOTgxMjAyYzQxNzI5 MjAzYjFiM2MxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTI1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5jb20+CisKKyAgICAgICAgRml4aW5nIGNvbXBpbGF0aW9u IGZhaWx1cmUgaW4gU3R5bGVSZXNvbHZlci5jcHAvQ1NTUGFyc2VyLmNwcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4OTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgQ1NTUHJvcGVydHlWYXJp YWJsZSB0byBzd2l0Y2ggc3RhdGVtZW50cyBpbiBDU1NQYXJzZXIgYW5kCisgICAgICAgIFN0eWxl UmVzb2x2ZXIgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyB1bmRlciBuaW5qYS9jbGFuZy4gSSd2 ZQorICAgICAgICBhZGRlZCBib3RoIGFzIG5ldyBjYXNlcyB0byB0aGUgc3dpdGNoZXMsIHdpdGgg RklYTUUgY29tbWVudHMgZm9yCisgICAgICAgIGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICog Y3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFs dWUpOgorICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlN0eWxlUmVzb2x2ZXI6OmNvbGxlY3RNYXRjaGluZ1J1bGVzRm9yTGlzdCk6CisKIDIwMTItMDYt MjQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjExMDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CmluZGV4IDYzNzgzNTk2YjMyN2MzN2Q3NGM5MjY0NzJmYTY0NDg0YTFlMTU0MjIuLjgzZDYyZTk4 ZmI5MmNhZWY0ZGY2ZWVlOWNiZDY5MWZmZGJmYjE2MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCkBAIC0yNTkzLDYgKzI1OTMsMTEgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NT UHJvcGVydHlJRCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQogICAgICAgICBtX3ZhbHVlTGlzdC0+ bmV4dCgpOwogICAgICAgICBicmVhazsKICNlbmRpZgorI2lmIEVOQUJMRShDU1NfVkFSSUFCTEVT KQorICAgIGNhc2UgQ1NTUHJvcGVydHlWYXJpYWJsZToKKyAgICAgICAgLy8gRklYTUU6IFRoaXMg c2hvdWxkIGhhdmUgYW4gYWN0dWFsIGltcGxlbWVudGF0aW9uLgorICAgICAgICByZXR1cm4gZmFs c2U7CisjZW5kaWYKICAgICBjYXNlIENTU1Byb3BlcnR5Qm9yZGVyQm90dG9tU3R5bGU6CiAgICAg Y2FzZSBDU1NQcm9wZXJ0eUJvcmRlckNvbGxhcHNlOgogICAgIGNhc2UgQ1NTUHJvcGVydHlCb3Jk ZXJMZWZ0U3R5bGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggNzEwNjg4 NDI1NjU3ZThhMGQ4ZjhkN2QyNDJjN2M4NTk2MzE5MWM5OS4uNmIyYjljZjQ1MzBiNjdkZjA1YmZi N2I0N2EwODVjMDNjNmMwOGI0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl UmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApA QCAtNDE1OCw3ICs0MTU4LDExIEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6YXBwbHlQcm9wZXJ0eShD U1NQcm9wZXJ0eUlEIGlkLCBDU1NWYWx1ZSogdmFsdWUpCiAgICAgICAgIG1fc3R5bGUtPnNldEdy aWRJdGVtUm93KHJvdyk7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0KKyNpZiBFTkFCTEUoQ1NT X1ZBUklBQkxFUykKKyAgICBjYXNlIENTU1Byb3BlcnR5VmFyaWFibGU6CisgICAgICAgIC8vIEZJ WE1FOiBUaGlzIHNob3VsZCBoYXZlIGFuIGFjdHVhbCBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAg cmV0dXJuOworI2VuZGlmCiAgICAgLy8gVGhlc2UgcHJvcGVydGllcyBhcmUgaW1wbGVtZW50ZWQg aW4gdGhlIFN0eWxlQnVpbGRlciBsb29rdXAgdGFibGUuCiAgICAgY2FzZSBDU1NQcm9wZXJ0eUJh Y2tncm91bmRBdHRhY2htZW50OgogICAgIGNhc2UgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ2xpcDoK 149426 2012-06-25 19:09:23 -0700 2012-07-16 00:11:16 -0700 Patch bug-89892-20120626120921.patch text/plain 3290 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE4Y2MzMjM3NzQ3NjJl ZGEzZDA5YmU1YzQwOGI2YTNiZmM1ZTcyZi4uZjE2ZDgwOTIzZWYxYTIwY2VmMGFhMDg4ZWIxZmI2 MDExNmI0MzdmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTI1ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb21waWxh dGlvbiBmYWlsdXJlIGluIFN0eWxlUmVzb2x2ZXIuY3BwIChjbGFuZykKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5ODkyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGF0Y2ggYWRkcyBhc3NlcnRpb25zIHRo YXQgdW5yZWFjaGFibGUgY29kZSBpcyBpbiBmYWN0IG5vdCByZWFjaGVkLgorCisgICAgICAgIENv dmVyZWQgYnkgZmFzdC9jc3MvdmFyaWFibGVzIHRlc3RzLgorCisgICAgICAgICogY3NzL0NTU1Bh cnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOgorICAg ICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVz b2x2ZXI6OmNvbGxlY3RNYXRjaGluZ1J1bGVzRm9yTGlzdCk6CisKIDIwMTItMDYtMjUgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFVz ZSBXZWJHcmFwaGljc0NvbnRleHQzRCBpbiBjb21wb3NpdG9yIGltcGxlbWVudGF0aW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGEyY2NiNzdhNmY2MjNkNDg5NzA1ZWFkZjkyNmVhMDdl ZDRlMWRiNTkuLjQ0NTM3ZjA4ZTcxYzM1OTEzNWUzYzYxZTkwMmFkNTk2NTI2NzJlMDggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0xNjQ0LDYgKzE2NDQsNyBAQCBib29sIENTU1BhcnNl cjo6cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9vbCBpbXBvcnRhbnQpCiAgICAg ICAgIG1fdmFsdWVMaXN0LT5uZXh0KCk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KKyAg ICBBU1NFUlQocHJvcElkICE9IENTU1Byb3BlcnR5VmFyaWFibGUpOwogI2VuZGlmCiAKICAgICBp ZiAoaXNLZXl3b3JkUHJvcGVydHlJRChwcm9wSWQpKSB7CkBAIC0yNjYzLDExICsyNjY0LDYgQEAg Ym9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wSWQsIGJvb2wgaW1w b3J0YW50KQogICAgICAgICBtX3ZhbHVlTGlzdC0+bmV4dCgpOwogICAgICAgICBicmVhazsKICNl bmRpZgotI2lmIEVOQUJMRShDU1NfVkFSSUFCTEVTKQotICAgIGNhc2UgQ1NTUHJvcGVydHlWYXJp YWJsZToKLSAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGhhdmUgYW4gYWN0dWFsIGltcGxl bWVudGF0aW9uLgotICAgICAgICByZXR1cm4gZmFsc2U7Ci0jZW5kaWYKICAgICBjYXNlIENTU1By b3BlcnR5Qm9yZGVyQm90dG9tU3R5bGU6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUJvcmRlckNvbGxh cHNlOgogICAgIGNhc2UgQ1NTUHJvcGVydHlCb3JkZXJMZWZ0U3R5bGU6CkBAIC0yNzA0LDYgKzI3 MDAsOSBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwg Ym9vbCBpbXBvcnRhbnQpCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVRleHRUcmFuc2Zvcm06CiAgICAg Y2FzZSBDU1NQcm9wZXJ0eVRleHRVbmRlcmxpbmVNb2RlOgogICAgIGNhc2UgQ1NTUHJvcGVydHlU ZXh0VW5kZXJsaW5lU3R5bGU6CisjaWYgRU5BQkxFKENTU19WQVJJQUJMRVMpCisgICAgY2FzZSBD U1NQcm9wZXJ0eVZhcmlhYmxlOgorI2VuZGlmCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVZpc2liaWxp dHk6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEFwcGVhcmFuY2U6CiAgICAgY2FzZSBDU1NQ cm9wZXJ0eVdlYmtpdEJhY2tmYWNlVmlzaWJpbGl0eToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29s dmVyLmNwcAppbmRleCAyYTA3N2RkNjFjYTY2ZGU2ODdkYmMxZjM4MjY2ZDkzMzYyYWY4MWFlLi44 YmUyNTFiZDJmNGM0MGQ5MGM5NDcyZDM3M2FlN2IzZmE0YjM4YzY0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUmVzb2x2ZXIuY3BwCkBAIC00MTYwLDExICs0MTYwLDYgQEAgdm9pZCBTdHlsZVJlc29s dmVyOjphcHBseVByb3BlcnR5KENTU1Byb3BlcnR5SUQgaWQsIENTU1ZhbHVlKiB2YWx1ZSkKICAg ICAgICAgbV9zdHlsZS0+c2V0R3JpZEl0ZW1Sb3cocm93KTsKICAgICAgICAgcmV0dXJuOwogICAg IH0KLSNpZiBFTkFCTEUoQ1NTX1ZBUklBQkxFUykKLSAgICBjYXNlIENTU1Byb3BlcnR5VmFyaWFi bGU6Ci0gICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBoYXZlIGFuIGFjdHVhbCBpbXBsZW1l bnRhdGlvbi4KLSAgICAgICAgcmV0dXJuOwotI2VuZGlmCiAgICAgLy8gVGhlc2UgcHJvcGVydGll cyBhcmUgaW1wbGVtZW50ZWQgaW4gdGhlIFN0eWxlQnVpbGRlciBsb29rdXAgdGFibGUuCiAgICAg Y2FzZSBDU1NQcm9wZXJ0eUJhY2tncm91bmRBdHRhY2htZW50OgogICAgIGNhc2UgQ1NTUHJvcGVy dHlCYWNrZ3JvdW5kQ2xpcDoKQEAgLTQyODEsNiArNDI3Niw5IEBAIHZvaWQgU3R5bGVSZXNvbHZl cjo6YXBwbHlQcm9wZXJ0eShDU1NQcm9wZXJ0eUlEIGlkLCBDU1NWYWx1ZSogdmFsdWUpCiAgICAg Y2FzZSBDU1NQcm9wZXJ0eVRleHRUcmFuc2Zvcm06CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVRvcDoK ICAgICBjYXNlIENTU1Byb3BlcnR5VW5pY29kZUJpZGk6CisjaWYgRU5BQkxFKENTU19WQVJJQUJM RVMpCisgICAgY2FzZSBDU1NQcm9wZXJ0eVZhcmlhYmxlOgorI2VuZGlmCiAgICAgY2FzZSBDU1NQ cm9wZXJ0eVZlcnRpY2FsQWxpZ246CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVZpc2liaWxpdHk6CiAg ICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEFuaW1hdGlvbkRlbGF5Ogo=