89877 2012-06-25 07:13:58 -0700 [EFL][WK2] Missing ViewIsFocused flag in viewStateDidChange call inside of _ewk_view_smart_focus_out() function. 2012-07-03 08:40:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 p.roguski p.roguski eric g.czajkowski gyuyoung.kim kenneth lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 656540 0 p.roguski 2012-06-25 07:13:58 -0700 WebPageProxy::ViewIsFocused flag needs to be added to WebPageProxy::ViewFocusStateChange() call inside of _ewk_view_smart_focus_out(). Omitting this flag will prevent ViewFocusStateChange() from sending Messages::WebPage::SetFocused(bool): void WebPageProxy::viewStateDidChange(ViewStateFlags flags) { if (!isValid()) return; if (flags & ViewIsFocused) process()->send(Messages::WebPage::SetFocused(m_pageClient->isViewFocused()), m_pageID); /* ... */ } 658570 1 149739 p.roguski 2012-06-27 06:37:14 -0700 Created attachment 149739 Patch adding missing flag to viewStateDidChange call 661485 2 g.czajkowski 2012-07-02 07:30:04 -0700 LGTM. We need to send a message to WebProcess - SetFocused(false) on focus out. We are doing the same in WK1 directly on FocusController object: http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.cpp#L560 662246 3 149739 webkit.review.bot 2012-07-03 08:40:17 -0700 Comment on attachment 149739 Patch adding missing flag to viewStateDidChange call Clearing flags on attachment: 149739 Committed r121770: <http://trac.webkit.org/changeset/121770> 662247 4 webkit.review.bot 2012-07-03 08:40:22 -0700 All reviewed patches have been landed. Closing bug. 149739 2012-06-27 06:37:14 -0700 2012-07-03 08:40:17 -0700 Patch adding missing flag to viewStateDidChange call addmissingflag.patch text/plain 1519 p.roguski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNDFiNDFkLi5lMjliMzRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDYtMjcgIFBpb3RyIFJvZ3Vza2kgIDxwLnJvZ3Vza2lAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF1bV0syXSBBZGRlZCBtaXNzaW5nIFdlYlBhZ2VQcm94eTo6Vmlld0lzRm9j dXNlZCBmbGFnIHRvIFdlYlBhZ2VQcm94eTo6dmlld1N0YXRlRGlkQ2hhbmdlKCkKKyAgICAgICAg Y2FsbCBpbiBfZXdrX3ZpZXdfc21hcnRfZm9jdXNfb3V0KCkgZnVuY3Rpb24uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTg3NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsdGhvdWdoIG5hbWUgb2YgdGhl IGZsYWcgc3VnZ2VzdCBpdCBzaG91bGQgYmUgdXNlZCBvbmx5IG9uIGZvY3VzIGluLAorICAgICAg ICBvbWl0dGluZyBpdCBpbiBjYXNlIG9mIGZvY3VzIG91dCB3aWxsIHByZXZlbnQgV2ViUGFnZVBy b3h5Ojp2aWV3U3RhdGVEaWRDaGFuZ2UoKQorICAgICAgICBmcm9tIHNlbmRpbmcgTWVzc2FnZXM6 OldlYlBhZ2U6OlNldEZvY3VzZWQoZmFsc2UpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X3NtYXJ0X2ZvY3VzX291dCk6CisK IDIwMTItMDYtMjcgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAg ICAgICBbR3RrXSBBZGQgc3VwcG9ydCBmb3IgdGhlIEdhbWVwYWQgQVBJCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggZmUzODRlMy4uNjAyYzY4 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApA QCAtMTIyLDcgKzEyMiw3IEBAIHN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X3NtYXJ0X2ZvY3Vz X291dChFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEpCiB7CiAgICAgRVdLX1ZJRVdfUFJJ Vl9HRVRfT1JfUkVUVVJOKHNtYXJ0RGF0YSwgcHJpdiwgZmFsc2UpCiAKLSAgICBwcml2LT5wYWdl Q2xpZW50LT5wYWdlKCktPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdXaW5k b3dJc0FjdGl2ZSk7CisgICAgcHJpdi0+cGFnZUNsaWVudC0+cGFnZSgpLT52aWV3U3RhdGVEaWRD aGFuZ2UoV2ViUGFnZVByb3h5OjpWaWV3SXNGb2N1c2VkIHwgV2ViUGFnZVByb3h5OjpWaWV3V2lu ZG93SXNBY3RpdmUpOwogICAgIHJldHVybiB0cnVlOwogfQogCg==