89866 2012-06-25 04:19:20 -0700 Add static qualifier to GraphicsContext3D::extractImageData. 2012-06-25 08:41:03 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89867 0 dongseong.hwang webkit-unassigned kbr mrobinson noam webkit.review.bot oldest_to_newest 656469 0 dongseong.hwang 2012-06-25 04:19:20 -0700 GraphicsContext3D::extractImageData does not use member variables. Each platform Accelerated-compositing implementation can use this method in order to get pixel data of an Image or ImageBuffer object. 656470 1 149271 dongseong.hwang 2012-06-25 04:21:06 -0700 Created attachment 149271 patch 656472 2 webkit.review.bot 2012-06-25 04:25:15 -0700 Attachment 149271 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/GraphicsContext3D.h:570: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/GraphicsContext3D.h:891: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 656477 3 149274 dongseong.hwang 2012-06-25 04:34:10 -0700 Created attachment 149274 patch v.2 656486 4 dongseong.hwang 2012-06-25 04:42:03 -0700 I amended Texmap to use GraphicsContext3D::extractImageData in Bug 89867. 656515 5 noam 2012-06-25 06:16:00 -0700 I think this is fine. mrobinson/kbr, any issue with this? 656574 6 mrobinson 2012-06-25 08:26:09 -0700 This seems like a reasonable change to me. 656576 7 149274 kbr 2012-06-25 08:27:15 -0700 Comment on attachment 149274 patch v.2 Seems fine as long as it compiles. 656579 8 149274 noam 2012-06-25 08:27:44 -0700 Comment on attachment 149274 patch v.2 LGTM 656588 9 149274 webkit.review.bot 2012-06-25 08:40:57 -0700 Comment on attachment 149274 patch v.2 Clearing flags on attachment: 149274 Committed r121159: <http://trac.webkit.org/changeset/121159> 656589 10 webkit.review.bot 2012-06-25 08:41:03 -0700 All reviewed patches have been landed. Closing bug. 149271 2012-06-25 04:21:06 -0700 2012-06-25 04:34:10 -0700 patch 0001-Add-static-qualifier-to-GraphicsContext3D-extractIma.patch text/plain 4999 dongseong.hwang RnJvbSA0ZDcxYzVmMWM2YTI0Nzc5MzlkM2I2YjQ4YmEzZGNiYjU1MWYwMjdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IE1vbiwgMjUgSnVuIDIwMTIgMTc6MjI6NTcgKzA5MDAKU3ViamVjdDogW1BBVENI XSBBZGQgc3RhdGljIHF1YWxpZmllciB0byBHcmFwaGljc0NvbnRleHQzRDo6ZXh0cmFjdEltYWdl RGF0YS4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTg2NgoKR3Jh cGhpY3NDb250ZXh0M0Q6OmV4dHJhY3RJbWFnZURhdGEgZG9lcyBub3QgdXNlIG1lbWJlciB2YXJp YWJsZXMuCkVhY2ggcGxhdGZvcm0gQWNjZWxlcmF0ZWQtY29tcG9zaXRpbmcgaW1wbGVtZW50YXRp b24gY2FuIHVzZSB0aGlzIG1ldGhvZCBpbgpvcmRlciB0byBnZXQgcGl4ZWwgZGF0YSBvZiBhbiBJ bWFnZSBvciBJbWFnZUJ1ZmZlciBvYmplY3QuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIC4uLi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmggIHwgICAxNCArKysr KysrLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA2MzU4MzU5NS4uMmYxZTAwMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDIxIEBACiAyMDEyLTA2LTI1ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkx MDAubmV0PgogCisgICAgICAgIEFkZCBzdGF0aWMgcXVhbGlmaWVyIHRvIEdyYXBoaWNzQ29udGV4 dDNEOjpleHRyYWN0SW1hZ2VEYXRhLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODk4NjYKKworICAgICAgICBHcmFwaGljc0NvbnRleHQzRDo6ZXh0cmFj dEltYWdlRGF0YSBkb2VzIG5vdCB1c2UgbWVtYmVyIHZhcmlhYmxlcy4KKyAgICAgICAgRWFjaCBw bGF0Zm9ybSBBY2NlbGVyYXRlZC1jb21wb3NpdGluZyBpbXBsZW1lbnRhdGlvbiBjYW4gdXNlIHRo aXMgbWV0aG9kIGluCisgICAgICAgIG9yZGVyIHRvIGdldCBwaXhlbCBkYXRhIG9mIGFuIEltYWdl IG9yIEltYWdlQnVmZmVyIG9iamVjdC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgdGhlcmUncyBubyBjaGFuZ2Ugb24g Y29kZSBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29u dGV4dDNELmg6CisgICAgICAgIChHcmFwaGljc0NvbnRleHQzRCk6CisKKzIwMTItMDYtMjUgIEh1 YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CisKICAgICAgICAgW1F0XSBB dm9pZCBhIGRlZXAgY29weSBvZiBRSW1hZ2UgaW4gR3JhcGhpY3NDb250ZXh0M0Q6OmdldEltYWdl RGF0YS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5 ODY1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzQ29udGV4dDNELmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5oCmluZGV4IGI2YzFiNjQuLjcyN2RhYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaApAQCAtNTU1LDcg KzU1NSw3IEBAIHB1YmxpYzoKICAgICAvLyByZXR1cm4gdGhlIHN1Z2dlc3RlZCBHTCBlcnJvciBp bmRpY2F0aW5nIHRoZSBjYXVzZSBvZiB0aGUgZmFpbHVyZToKICAgICAvLyAgIElOVkFMSURfVkFM VUUgaWYgd2lkdGgvaGVpZ2h0IGlzIG5lZ2F0aXZlIG9yIG92ZXJmbG93IGhhcHBlbnMuCiAgICAg Ly8gICBJTlZBTElEX0VOVU0gaWYgZm9ybWF0L3R5cGUgaXMgaWxsZWdhbC4KLSAgICBHQzNEZW51 bSBjb21wdXRlSW1hZ2VTaXplSW5CeXRlcyhHQzNEZW51bSBmb3JtYXQsCisgICAgc3RhdGljIEdD M0RlbnVtIGNvbXB1dGVJbWFnZVNpemVJbkJ5dGVzKEdDM0RlbnVtIGZvcm1hdCwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHQzNEZW51bSB0eXBlLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIEdDM0RzaXplaSB3aWR0aCwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBHQzNEc2l6ZWkgaGVpZ2h0LApAQCAtNTY3LDcgKzU2Nyw3 IEBAIHB1YmxpYzoKICAgICAvLyBwYWNraW5nIHRoZSBwaXhlbCBkYXRhIGFjY29yZGluZyB0byB0 aGUgZ2l2ZW4gZm9ybWF0IGFuZCB0eXBlLAogICAgIC8vIGFuZCBvYmV5aW5nIHRoZSBmbGlwWSwg cHJlbXVsdGlwbHlBbHBoYSwgYW5kIGlnbm9yZUdhbW1hQW5kQ29sb3JQcm9maWxlCiAgICAgLy8g ZmxhZ3MuIFJldHVybnMgdHJ1ZSB1cG9uIHN1Y2Nlc3MuCi0gICAgYm9vbCBleHRyYWN0SW1hZ2VE YXRhKEltYWdlKiBpbWFnZSwKKyAgICBzdGF0aWMgYm9vbCBleHRyYWN0SW1hZ2VEYXRhKEltYWdl KiBpbWFnZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgR0MzRGVudW0gZm9ybWF0LAogICAg ICAgICAgICAgICAgICAgICAgICAgICBHQzNEZW51bSB0eXBlLAogICAgICAgICAgICAgICAgICAg ICAgICAgICBib29sIGZsaXBZLApAQCAtNTc5LDcgKzU3OSw3IEBAIHB1YmxpYzoKICAgICAvLyBw YWNraW5nIHRoZSBwaXhlbCBkYXRhIGFjY29yZGluZyB0byB0aGUgZ2l2ZW4gZm9ybWF0IGFuZCB0 eXBlLAogICAgIC8vIGFuZCBvYmV5aW5nIHRoZSBmbGlwWSBhbmQgcHJlbXVsdGlwbHlBbHBoYSBm bGFncy4gUmV0dXJucyB0cnVlCiAgICAgLy8gdXBvbiBzdWNjZXNzLgotICAgIGJvb2wgZXh0cmFj dEltYWdlRGF0YShJbWFnZURhdGEqLAorICAgIHN0YXRpYyBib29sIGV4dHJhY3RJbWFnZURhdGEo SW1hZ2VEYXRhKiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgR0MzRGVudW0gZm9ybWF0LAog ICAgICAgICAgICAgICAgICAgICAgICAgICBHQzNEZW51bSB0eXBlLAogICAgICAgICAgICAgICAg ICAgICAgICAgICBib29sIGZsaXBZLApAQCAtNTkxLDcgKzU5MSw3IEBAIHB1YmxpYzoKICAgICAv LyBJZiB0aGUgZGF0YSBpcyBub3QgdGlnaHRseSBwYWNrZWQgYWNjb3JkaW5nIHRvIHRoZSBwYXNz ZWQKICAgICAvLyB1bnBhY2tBbGlnbm1lbnQsIHRoZSBvdXRwdXQgZGF0YSB3aWxsIGJlIHRpZ2h0 bHkgcGFja2VkLgogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiBzdWNjZXNzZnVsLCBmYWxzZSBpZiBh bnkgZXJyb3Igb2NjdXJyZWQuCi0gICAgYm9vbCBleHRyYWN0VGV4dHVyZURhdGEodW5zaWduZWQg aW50IHdpZHRoLCB1bnNpZ25lZCBpbnQgaGVpZ2h0LAorICAgIHN0YXRpYyBib29sIGV4dHJhY3RU ZXh0dXJlRGF0YSh1bnNpZ25lZCBpbnQgd2lkdGgsIHVuc2lnbmVkIGludCBoZWlnaHQsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgR0MzRGVudW0gZm9ybWF0LCBHQzNEZW51bSB0eXBlLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCB1bnBhY2tBbGlnbm1lbnQs CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBmbGlwWSwgYm9vbCBwcmVtdWx0aXBs eUFscGhhLApAQCAtNTk5LDcgKzU5OSw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBWZWN0b3I8dWludDhfdD4mIGRhdGEpOwogCiAgICAgLy8gRmxpcHMgdGhlIGdpdmVu IGltYWdlIGRhdGEgdmVydGljYWxseSwgaW4tcGxhY2UuCi0gICAgdm9pZCBmbGlwVmVydGljYWxs eSh2b2lkKiBpbWFnZURhdGEsCisgICAgc3RhdGljIHZvaWQgZmxpcFZlcnRpY2FsbHkodm9pZCog aW1hZ2VEYXRhLAogICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHdpZHRoLAog ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGhlaWdodCwKICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBieXRlc1BlclBpeGVsLApAQCAtODg4LDcgKzg4OCw3 IEBAIHB1YmxpYzoKICAgICAvLwogICAgIC8vIE5vIHZlcnRpY2FsIGZsaXAgb2YgdGhlIGltYWdl IGRhdGEgaXMgcGVyZm9ybWVkIGJ5IHRoaXMKICAgICAvLyBtZXRob2QuCi0gICAgYm9vbCBnZXRJ bWFnZURhdGEoSW1hZ2UqIGltYWdlLAorICAgIHN0YXRpYyBib29sIGdldEltYWdlRGF0YShJbWFn ZSogaW1hZ2UsCiAgICAgICAgICAgICAgICAgICAgICAgR0MzRGVudW0gZm9ybWF0LAogICAgICAg ICAgICAgICAgICAgICAgIEdDM0RlbnVtIHR5cGUsCiAgICAgICAgICAgICAgICAgICAgICAgYm9v bCBwcmVtdWx0aXBseUFscGhhLApAQCAtOTA5LDcgKzkwOSw3IEBAIHB1YmxpYzoKICAgICAvLyBB IHNvdXJjZVVucGFja0FsaWdubWVudCBvZiB6ZXJvIGluZGljYXRlcyB0aGF0IHRoZSBzb3VyY2UK ICAgICAvLyBkYXRhIGlzIHRpZ2h0bHkgcGFja2VkLiBOb24temVybyB2YWx1ZXMgbWF5IHRha2Ug YSBzbG93IHBhdGguCiAgICAgLy8gRGVzdGluYXRpb24gZGF0YSB3aWxsIGhhdmUgbm8gZ2FwcyBi ZXR3ZWVuIHJvd3MuCi0gICAgYm9vbCBwYWNrUGl4ZWxzKGNvbnN0IHVpbnQ4X3QqIHNvdXJjZURh dGEsCisgICAgc3RhdGljIGJvb2wgcGFja1BpeGVscyhjb25zdCB1aW50OF90KiBzb3VyY2VEYXRh LAogICAgICAgICAgICAgICAgICAgICBTb3VyY2VEYXRhRm9ybWF0IHNvdXJjZURhdGFGb3JtYXQs CiAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCB3aWR0aCwKICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgaW50IGhlaWdodCwKLS0gCjEuNy45LjUKCg== 149274 2012-06-25 04:34:10 -0700 2012-06-25 08:40:57 -0700 patch v.2 0001-Add-static-qualifier-to-GraphicsContext3D-extractIma.patch text/plain 5042 dongseong.hwang RnJvbSBlYTQyNWIzYmZmNWRiMDcyNjgxOTQ2OGRiN2U5ZTZkNmNiY2RkZjIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IE1vbiwgMjUgSnVuIDIwMTIgMTc6MjI6NTcgKzA5MDAKU3ViamVjdDogW1BBVENI XSBBZGQgc3RhdGljIHF1YWxpZmllciB0byBHcmFwaGljc0NvbnRleHQzRDo6ZXh0cmFjdEltYWdl RGF0YS4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTg2NgoKR3Jh cGhpY3NDb250ZXh0M0Q6OmV4dHJhY3RJbWFnZURhdGEgZG9lcyBub3QgdXNlIG1lbWJlciB2YXJp YWJsZXMuCkVhY2ggcGxhdGZvcm0gQWNjZWxlcmF0ZWQtY29tcG9zaXRpbmcgaW1wbGVtZW50YXRp b24gY2FuIHVzZSB0aGlzIG1ldGhvZCBpbgpvcmRlciB0byBnZXQgcGl4ZWwgZGF0YSBvZiBhbiBJ bWFnZSBvciBJbWFnZUJ1ZmZlciBvYmplY3QuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIC4uLi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmggIHwgICAxNCArKysr KysrLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCBlMWUyNzdiLi5lMGVhN2EyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUg KzEsMjEgQEAKIDIwMTItMDYtMjUgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEw MC5uZXQ+CiAKKyAgICAgICAgQWRkIHN0YXRpYyBxdWFsaWZpZXIgdG8gR3JhcGhpY3NDb250ZXh0 M0Q6OmV4dHJhY3RJbWFnZURhdGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04OTg2NgorCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNEOjpleHRyYWN0 SW1hZ2VEYXRhIGRvZXMgbm90IHVzZSBtZW1iZXIgdmFyaWFibGVzLgorICAgICAgICBFYWNoIHBs YXRmb3JtIEFjY2VsZXJhdGVkLWNvbXBvc2l0aW5nIGltcGxlbWVudGF0aW9uIGNhbiB1c2UgdGhp cyBtZXRob2QgaW4KKyAgICAgICAgb3JkZXIgdG8gZ2V0IHBpeGVsIGRhdGEgb2YgYW4gSW1hZ2Ug b3IgSW1hZ2VCdWZmZXIgb2JqZWN0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGVyZSdzIG5vIGNoYW5nZSBvbiBj b2RlIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250 ZXh0M0QuaDoKKyAgICAgICAgKEdyYXBoaWNzQ29udGV4dDNEKToKKworMjAxMi0wNi0yNSAgSHVh bmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKwogICAgICAgICBbVGV4bWFw XSBSZW1vdmUgcGxhdGZvcm0gc3BlY2lmaWMgY29kZSBpbiBCaXRtYXBJbWFnZUdMOjp1cGRhdGVD b250ZW50cyBieSB1c2luZwogICAgICAgICBHcmFwaGljc0NvbnRleHQzRDo6ZXh0cmFjdEltYWdl RGF0YS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5 ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0M0QuaAppbmRleCBiNmMxYjY0Li5kYmQ5ZGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKQEAgLTU1NSw3ICs1 NTUsNyBAQCBwdWJsaWM6CiAgICAgLy8gcmV0dXJuIHRoZSBzdWdnZXN0ZWQgR0wgZXJyb3IgaW5k aWNhdGluZyB0aGUgY2F1c2Ugb2YgdGhlIGZhaWx1cmU6CiAgICAgLy8gICBJTlZBTElEX1ZBTFVF IGlmIHdpZHRoL2hlaWdodCBpcyBuZWdhdGl2ZSBvciBvdmVyZmxvdyBoYXBwZW5zLgogICAgIC8v ICAgSU5WQUxJRF9FTlVNIGlmIGZvcm1hdC90eXBlIGlzIGlsbGVnYWwuCi0gICAgR0MzRGVudW0g Y29tcHV0ZUltYWdlU2l6ZUluQnl0ZXMoR0MzRGVudW0gZm9ybWF0LAorICAgIHN0YXRpYyBHQzNE ZW51bSBjb21wdXRlSW1hZ2VTaXplSW5CeXRlcyhHQzNEZW51bSBmb3JtYXQsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgR0MzRGVudW0gdHlwZSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBHQzNEc2l6ZWkgd2lkdGgsCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgR0MzRHNpemVpIGhlaWdodCwKQEAgLTU2Nyw3ICs1NjcsNyBA QCBwdWJsaWM6CiAgICAgLy8gcGFja2luZyB0aGUgcGl4ZWwgZGF0YSBhY2NvcmRpbmcgdG8gdGhl IGdpdmVuIGZvcm1hdCBhbmQgdHlwZSwKICAgICAvLyBhbmQgb2JleWluZyB0aGUgZmxpcFksIHBy ZW11bHRpcGx5QWxwaGEsIGFuZCBpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZQogICAgIC8vIGZs YWdzLiBSZXR1cm5zIHRydWUgdXBvbiBzdWNjZXNzLgotICAgIGJvb2wgZXh0cmFjdEltYWdlRGF0 YShJbWFnZSogaW1hZ2UsCisgICAgc3RhdGljIGJvb2wgZXh0cmFjdEltYWdlRGF0YShJbWFnZSos CiAgICAgICAgICAgICAgICAgICAgICAgICAgIEdDM0RlbnVtIGZvcm1hdCwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgR0MzRGVudW0gdHlwZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg Ym9vbCBmbGlwWSwKQEAgLTU3OSw3ICs1NzksNyBAQCBwdWJsaWM6CiAgICAgLy8gcGFja2luZyB0 aGUgcGl4ZWwgZGF0YSBhY2NvcmRpbmcgdG8gdGhlIGdpdmVuIGZvcm1hdCBhbmQgdHlwZSwKICAg ICAvLyBhbmQgb2JleWluZyB0aGUgZmxpcFkgYW5kIHByZW11bHRpcGx5QWxwaGEgZmxhZ3MuIFJl dHVybnMgdHJ1ZQogICAgIC8vIHVwb24gc3VjY2Vzcy4KLSAgICBib29sIGV4dHJhY3RJbWFnZURh dGEoSW1hZ2VEYXRhKiwKKyAgICBzdGF0aWMgYm9vbCBleHRyYWN0SW1hZ2VEYXRhKEltYWdlRGF0 YSosCiAgICAgICAgICAgICAgICAgICAgICAgICAgIEdDM0RlbnVtIGZvcm1hdCwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgR0MzRGVudW0gdHlwZSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgYm9vbCBmbGlwWSwKQEAgLTU5MSw3ICs1OTEsNyBAQCBwdWJsaWM6CiAgICAgLy8gSWYgdGhl IGRhdGEgaXMgbm90IHRpZ2h0bHkgcGFja2VkIGFjY29yZGluZyB0byB0aGUgcGFzc2VkCiAgICAg Ly8gdW5wYWNrQWxpZ25tZW50LCB0aGUgb3V0cHV0IGRhdGEgd2lsbCBiZSB0aWdodGx5IHBhY2tl ZC4KICAgICAvLyBSZXR1cm5zIHRydWUgaWYgc3VjY2Vzc2Z1bCwgZmFsc2UgaWYgYW55IGVycm9y IG9jY3VycmVkLgotICAgIGJvb2wgZXh0cmFjdFRleHR1cmVEYXRhKHVuc2lnbmVkIGludCB3aWR0 aCwgdW5zaWduZWQgaW50IGhlaWdodCwKKyAgICBzdGF0aWMgYm9vbCBleHRyYWN0VGV4dHVyZURh dGEodW5zaWduZWQgaW50IHdpZHRoLCB1bnNpZ25lZCBpbnQgaGVpZ2h0LAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIEdDM0RlbnVtIGZvcm1hdCwgR0MzRGVudW0gdHlwZSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgdW5wYWNrQWxpZ25tZW50LAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGJvb2wgZmxpcFksIGJvb2wgcHJlbXVsdGlwbHlBbHBoYSwK QEAgLTU5OSw3ICs1OTksNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg VmVjdG9yPHVpbnQ4X3Q+JiBkYXRhKTsKIAogICAgIC8vIEZsaXBzIHRoZSBnaXZlbiBpbWFnZSBk YXRhIHZlcnRpY2FsbHksIGluLXBsYWNlLgotICAgIHZvaWQgZmxpcFZlcnRpY2FsbHkodm9pZCog aW1hZ2VEYXRhLAorICAgIHN0YXRpYyB2b2lkIGZsaXBWZXJ0aWNhbGx5KHZvaWQqIGltYWdlRGF0 YSwKICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCB3aWR0aCwKICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBoZWlnaHQsCiAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgYnl0ZXNQZXJQaXhlbCwKQEAgLTg4OCw3ICs4ODgsNyBAQCBwdWJs aWM6CiAgICAgLy8KICAgICAvLyBObyB2ZXJ0aWNhbCBmbGlwIG9mIHRoZSBpbWFnZSBkYXRhIGlz IHBlcmZvcm1lZCBieSB0aGlzCiAgICAgLy8gbWV0aG9kLgotICAgIGJvb2wgZ2V0SW1hZ2VEYXRh KEltYWdlKiBpbWFnZSwKKyAgICBzdGF0aWMgYm9vbCBnZXRJbWFnZURhdGEoSW1hZ2UqLAogICAg ICAgICAgICAgICAgICAgICAgIEdDM0RlbnVtIGZvcm1hdCwKICAgICAgICAgICAgICAgICAgICAg ICBHQzNEZW51bSB0eXBlLAogICAgICAgICAgICAgICAgICAgICAgIGJvb2wgcHJlbXVsdGlwbHlB bHBoYSwKQEAgLTkwOSw3ICs5MDksNyBAQCBwdWJsaWM6CiAgICAgLy8gQSBzb3VyY2VVbnBhY2tB bGlnbm1lbnQgb2YgemVybyBpbmRpY2F0ZXMgdGhhdCB0aGUgc291cmNlCiAgICAgLy8gZGF0YSBp cyB0aWdodGx5IHBhY2tlZC4gTm9uLXplcm8gdmFsdWVzIG1heSB0YWtlIGEgc2xvdyBwYXRoLgog ICAgIC8vIERlc3RpbmF0aW9uIGRhdGEgd2lsbCBoYXZlIG5vIGdhcHMgYmV0d2VlbiByb3dzLgot ICAgIGJvb2wgcGFja1BpeGVscyhjb25zdCB1aW50OF90KiBzb3VyY2VEYXRhLAorICAgIHN0YXRp YyBib29sIHBhY2tQaXhlbHMoY29uc3QgdWludDhfdCogc291cmNlRGF0YSwKICAgICAgICAgICAg ICAgICAgICAgU291cmNlRGF0YUZvcm1hdCBzb3VyY2VEYXRhRm9ybWF0LAogICAgICAgICAgICAg ICAgICAgICB1bnNpZ25lZCBpbnQgd2lkdGgsCiAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVk IGludCBoZWlnaHQsCi0tIAoxLjcuOS41Cgo=