89859 2012-06-25 00:39:48 -0700 Remove responseBlob field from XMLHttpResponse.idl 2012-06-25 09:56:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kinuko kinuko abarth eric mihaip ojan webkit.review.bot oldest_to_newest 656432 0 kinuko 2012-06-25 00:39:48 -0700 Remove XMLHttpResponse.responseBlob from XMLHttpResponse.idl, which has only been exposed for a very limited time (since r120574) but probably should not have been done so since XHR2 spec no longer has the field. A quick search also showed that no one seems to be using the field. 656438 1 149262 kinuko 2012-06-25 01:09:01 -0700 Created attachment 149262 Patch 656622 2 149262 eric 2012-06-25 09:22:45 -0700 Comment on attachment 149262 Patch I'm surprised I didn't add any testing. I'm also surprised this is being removed... but OK. 656629 3 abarth 2012-06-25 09:32:23 -0700 I wonder if we should research why this was removed from the spec. Is there another way of getting a blob out of an XHR? I know there are some plans to use XHR and Blobs in Chrome apps to store things like images in IndedDB for offline viewing. We might want to check with Mihai to be on the safe side. 656631 4 mihaip 2012-06-25 09:34:55 -0700 (In reply to comment #3) > I wonder if we should research why this was removed from the spec. Is there another way of getting a blob out of an XHR? > > I know there are some plans to use XHR and Blobs in Chrome apps to store things like images in IndedDB for offline viewing. We might want to check with Mihai to be on the safe side. You can still get a blob by setting the responseType to 'blob' and checking the .response property. This patch LGTM as far as apps are concerned. 656633 5 149262 abarth 2012-06-25 09:35:58 -0700 Comment on attachment 149262 Patch Ok. That sounds like a nicer API anyway, which is probably why it was removed from the spec. Thanks! 656650 6 149262 webkit.review.bot 2012-06-25 09:56:39 -0700 Comment on attachment 149262 Patch Clearing flags on attachment: 149262 Committed r121161: <http://trac.webkit.org/changeset/121161> 656651 7 webkit.review.bot 2012-06-25 09:56:46 -0700 All reviewed patches have been landed. Closing bug. 149262 2012-06-25 01:09:01 -0700 2012-06-25 09:56:39 -0700 Patch bug-89859-20120625170900.patch text/plain 1854 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA2Y2QyMDE0NTQwNDZk ZmY3YzdkYWZlMWIzZGJkMzliN2RkNjgyZC4uYzc4YTVhNjdlOWIxOTE3ZjliMDkwNmVmNjcyZmQ4 ZThmMTliZDM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTI1ICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgcmVzcG9u c2VCbG9iIGZpZWxkIGZyb20gWE1MSHR0cFJlc3BvbnNlLmlkbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4NTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgWE1MSHR0cFJlc3BvbnNlLnJlc3Bv bnNlQmxvYiBmcm9tIFhNTEh0dHBSZXNwb25zZS5pZGwsIHdoaWNoCisgICAgICAgIGhhcyBvbmx5 IGJlZW4gZXhwb3NlZCBmb3IgYSB2ZXJ5IGxpbWl0ZWQgdGltZSAoc2luY2UgcjEyMDU3NCkgYnV0 CisgICAgICAgIHByb2JhYmx5IHNob3VsZCBub3QgaGF2ZSBiZWVuIGRvbmUgc28gc2luY2UgWEhS MiBzcGVjIG5vIGxvbmdlciBoYXMKKyAgICAgICAgdGhlIGZpZWxkLiAgQSBxdWljayBzZWFyY2gg YWxzbyBzaG93ZWQgdGhhdCBubyBvbmUgc2VlbXMgdG8gYmUgdXNpbmcgdGhlIGZpZWxkLgorCisg ICAgICAgIChNb3JlIGNvbnRleHQ6IHRoZSBmaWVsZCB3YXMgYWRkZWQgbG9uZyB0aW1lIGFnbyB3 aXRoIGEgcnVudGltZSBndWFyZAorICAgICAgICB3aGljaCBoYWQgbmV2ZXIgYmVlbiBlbmFibGVk IHVudGlsIHRoZSBndWFyZCB3YXMgcmVtb3ZlZCBpbiByMTIwNTc0CisgICAgICAgIHRvIHJlbW92 ZSBYSFJfUkVTUE9OU0VfQkxPQiBvbiBhbGwgcGxhdGZvcm1zLikKKworICAgICAgICBObyBuZXcg dGVzdHMgYXMgbm8gdGVzdHMgdXNlIHRoaXMgZmllbGQuCisKKyAgICAgICAgKiB4bWwvWE1MSHR0 cFJlcXVlc3QuaWRsOiBSZW1vdmVkIHJlc3BvbnNlQmxvYiBmaWVsZC4KKwogMjAxMi0wNi0yNCAg RnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IGNvbXBpbGUgZXJyb3IgZml4IG9mIENocm9taXVtIFdpbiBSZWxlYXNlLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3ht bC9YTUxIdHRwUmVxdWVzdC5pZGwKaW5kZXggMDQ1Mzk4MTk0OTI4MDM5M2UzM2IzOWYzYjVkOTI2 YjE4YjZiNmZhZS4uMDk1ZjRkYzVjZjRmMmJhZGM5Yjk0NWIwNGE3ZWM4OTQzOWQzN2M1MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCkBAIC05Myw4ICs5Myw2IEBAIG1vZHVs ZSB4bWwgewogICAgICAgICAgICAgZ2V0dGVyIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgICAg ICByZWFkb25seSBhdHRyaWJ1dGUgRG9jdW1lbnQgcmVzcG9uc2VYTUwKICAgICAgICAgICAgIGdl dHRlciByYWlzZXMoRE9NRXhjZXB0aW9uKTsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEJs b2IgcmVzcG9uc2VCbG9iCi0gICAgICAgICAgICBnZXR0ZXIgcmFpc2VzKERPTUV4Y2VwdGlvbik7 CiAKICAgICAgICAgYXR0cmlidXRlIERPTVN0cmluZyByZXNwb25zZVR5cGUKICAgICAgICAgICAg IHNldHRlciByYWlzZXMoRE9NRXhjZXB0aW9uKTsK