89858 2012-06-25 00:37:19 -0700 [GTK] Test /webkit2/WebKitWebView/permission-requests fails due to a runtime warning 2012-06-25 01:42:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 656431 0 cgarcia 2012-06-25 00:37:19 -0700 It doesn't happen in the bots, though, so I guess it's a bug in some versions of geoclue. /webkit2/WebKitWebView/permission-requests: ** (Programs/WebKit2APITests/TestWebKitWebView:26401): WARNING **: Metadata for error domain "geoclue-error-quark" already registered We don't register any error quark for geolocation errors, so this is a geoclue issue. Warnings are critical by default when running unit tests, so we need make them not critical for this particular test case to make it pass. 656433 1 149260 cgarcia 2012-06-25 00:42:45 -0700 Created attachment 149260 Patch 656434 2 webkit.review.bot 2012-06-25 00:47:03 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 656436 3 149260 xan.lopez 2012-06-25 00:53:13 -0700 Comment on attachment 149260 Patch r=me 656440 4 cgarcia 2012-06-25 01:42:58 -0700 Committed r121143: <http://trac.webkit.org/changeset/121143> 149260 2012-06-25 00:42:45 -0700 2012-06-25 00:53:13 -0700 Patch test-non-fatal-warning.diff text/plain 2028 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YWYwZTQ3Li5hY2Q0NzU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMDYtMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9wZXJtaXNzaW9u LXJlcXVlc3RzIGZhaWxzIGR1ZSB0byBhIHJ1bnRpbWUgd2FybmluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3Rz L1Rlc3RXZWJLaXRXZWJWaWV3LmNwcDoKKyAgICAgICAgKHRlc3RXZWJWaWV3UGVybWlzc2lvblJl cXVlc3RzKTogTWFrZSBydW50aW1lIHdhcm5pbmdzIG5vbi1mYXRhbAorICAgICAgICBmb3IgdGVz dCAvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L3Blcm1pc3Npb24tcmVxdWVzdHMuCisKIDIwMTItMDYt MjQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJ T04ocjEyMDMyOSk6IEludGVybWl0dGVudCBXZWJQcm9jZXNzIHNodXRkb3ducyBkdWUgdG8gb3V0 LW9mLWxpbmUgRGlkUmVjZWl2ZUV2ZW50IG1lc3NhZ2VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdFdlYlZpZXcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdFdlYlZpZXcuY3Bw CmluZGV4IGM3NDBjMGQuLjNlMTk0YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0V2ViVmlldy5jcHAKQEAgLTU1 NSw2ICs1NTUsMTAgQEAgc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdNb3VzZVRhcmdldChVSUNsaWVu dFRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAKIHN0YXRpYyB2b2lkIHRlc3RXZWJWaWV3UGVy bWlzc2lvblJlcXVlc3RzKFVJQ2xpZW50VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKIHsKKyAg ICAvLyBTb21lIHZlcnNpb25zIG9mIGdlb2NsdWUgZ2l2ZSBhIHJ1bnRpbWUgd2FybmluZyBiZWNh dXNlIGl0IHRyaWVzCisgICAgLy8gdG8gcmVnaXN0ZXIgdGhlIGVycm9yIHF1YXJrIHR3aWNlLiBT ZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5ODU4LgorICAgIC8v IE1ha2Ugd2FybmluZ3Mgbm9uLWZhdGFsIGZvciB0aGlzIHRlc3QgdG8gbWFrZSBpdCBwYXNzLgor ICAgIHRlc3QtPnJlbW92ZUxvZ0ZhdGFsRmxhZyhHX0xPR19MRVZFTF9XQVJOSU5HKTsKICAgICB0 ZXN0LT5zaG93SW5XaW5kb3dBbmRXYWl0VW50aWxNYXBwZWQoKTsKICAgICBzdGF0aWMgY29uc3Qg Y2hhciogZ2VvbG9jYXRpb25SZXF1ZXN0SFRNTCA9CiAgICAgICAgICI8aHRtbD4iCkBAIC01ODcs NiArNTkxLDcgQEAgc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdQZXJtaXNzaW9uUmVxdWVzdHMoVUlD bGllbnRUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAgIC8vIENoZWNrIHRoYXQgd2UgZGlk IG5vdCBnZXQgdGhlIFBFUk1JU1NJT05fREVOSUVEIGVycm9yIG5vdy4KICAgICByZXN1bHQgPSB3 ZWJraXRfd2ViX3ZpZXdfZ2V0X3RpdGxlKHRlc3QtPm1fd2ViVmlldyk7CiAgICAgZ19hc3NlcnRf Y21wc3RyKHJlc3VsdCwgIT0sICIxIik7CisgICAgdGVzdC0+YWRkTG9nRmF0YWxGbGFnKEdfTE9H X0xFVkVMX1dBUk5JTkcpOwogfQogCiBzdGF0aWMgdm9pZCB0ZXN0V2ViVmlld1pvb21MZXZlbChX ZWJWaWV3VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikK