89856 2012-06-24 23:44:24 -0700 ASSERT(m_wheelEventHandlerCount > 0) can fire 2012-06-25 10:39:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth eric jonlee simon.fraser webkit.review.bot oldest_to_newest 656413 0 abarth 2012-06-24 23:44:24 -0700 ASSERT(m_wheelEventHandlerCount > 0) can fire 656414 1 149249 abarth 2012-06-24 23:48:24 -0700 Created attachment 149249 Patch 656570 2 149249 eric 2012-06-25 08:17:04 -0700 Comment on attachment 149249 Patch Wow. Why do we need to do this bookkeeping for wheel/mouse events? 656614 3 abarth 2012-06-25 09:17:01 -0700 > Wow. Why do we need to do this bookkeeping for wheel/mouse events? I'm not sure. I'll investigate before landing. 656640 4 149249 abarth 2012-06-25 09:46:30 -0700 Comment on attachment 149249 Patch It's used by the fast scrolling code, presumably to know whether the fast scrolling code can eat these events and scroll fast. 656696 5 149249 webkit.review.bot 2012-06-25 10:39:32 -0700 Comment on attachment 149249 Patch Clearing flags on attachment: 149249 Committed r121166: <http://trac.webkit.org/changeset/121166> 656697 6 webkit.review.bot 2012-06-25 10:39:46 -0700 All reviewed patches have been landed. Closing bug. 149249 2012-06-24 23:48:24 -0700 2012-06-25 10:39:30 -0700 Patch bug-89856-20120624234823.patch text/plain 5954 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA2Y2QyMDE0NTQwNDZk ZmY3YzdkYWZlMWIzZGJkMzliN2RkNjgyZC4uZjZkZmNmZWFhMDE5NGZlZTgwZjk2NTU4MWVlNmM0 YzVkZjY2MWNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA2LTI0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQVNTRVJUKG1fd2hlZWxFdmVu dEhhbmRsZXJDb3VudCA+IDApIGNhbiBmaXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04OTg1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdoZW4gYSBub2RlIHdpdGggYSB3aGVlbCBvciBhIHRvdWNoIGV2 ZW50IGlzIG1vdmVkIGZyb20gb25lIGRvY3VtZW50IHRvCisgICAgICAgIGFub3RoZXIsIHRoZSBk aWRBZGRNdW1ibGUvZGlkUmVtb3ZlTXVtYmxlIGNhbGxzIGRvIG5vdCBiYWxhbmNlIGJlY2F1c2UK KyAgICAgICAgdGhleSdyZSBjYWxsZWQgb24gZGlmZmVyZW50IGRvY3VtZW50cy4gVGhpcyBwYXRj aCB0d2lkZGxlcyB0aGUgY291bnRzCisgICAgICAgIGFwcHJvcHJpYXRlbHkgaW4gdGhhdCBjYXNl LgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL21vdmUtZWxlbWVudC13aXRoLXdoZWVsLWFu ZC10b3VjaC1ldmVudC1saXN0ZW5lcnMuaHRtbAorCisgICAgICAgICogZG9tL0V2ZW50TmFtZXMu aDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50TmFtZXM6OmlzVG91Y2hFdmVudFR5cGUpOgorICAg ICAgICAoRXZlbnROYW1lcyk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudE5hbWVzOjp0b3VjaEV2 ZW50TmFtZXMpOgorICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5v ZGU6OmRpZE1vdmVUb05ld0RvY3VtZW50KToKKwogMjAxMi0wNi0yNCAgRnVtaXRvc2hpIFVrYWkg IDx1a2FpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGNvbXBpbGUgZXJyb3Ig Zml4IG9mIENocm9taXVtIFdpbiBSZWxlYXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0V2ZW50TmFtZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudE5hbWVzLmgKaW5kZXgg MzA1NmQ0YTM5OTE4MjJhYjY0NTBiOTczMjgyMmJhOWJmOThjNWVhNS4uNTk4YmNkZGU1MTE0YWVh YTA3NTNjOTQ3MmM5ZjFhMTViYWIxZDMxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0V2ZW50TmFtZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnROYW1lcy5oCkBAIC0y NTEsNyArMjUxLDIxIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBpbmxpbmUgYm9v bCBpc1RvdWNoRXZlbnRUeXBlKGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlKSBjb25zdAog ICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gZXZlbnRUeXBlID09IHRvdWNoc3RhcnRFdmVu dCB8fCBldmVudFR5cGUgPT0gdG91Y2htb3ZlRXZlbnQgfHwgZXZlbnRUeXBlID09IHRvdWNoZW5k RXZlbnQgfHwgZXZlbnRUeXBlID09IHRvdWNoY2FuY2VsRXZlbnQ7CisgICAgICAgICAgICByZXR1 cm4gZXZlbnRUeXBlID09IHRvdWNoc3RhcnRFdmVudAorICAgICAgICAgICAgICAgIHx8IGV2ZW50 VHlwZSA9PSB0b3VjaG1vdmVFdmVudAorICAgICAgICAgICAgICAgIHx8IGV2ZW50VHlwZSA9PSB0 b3VjaGVuZEV2ZW50CisgICAgICAgICAgICAgICAgfHwgZXZlbnRUeXBlID09IHRvdWNoY2FuY2Vs RXZlbnQ7CisgICAgICAgIH0KKworICAgICAgICBWZWN0b3I8QXRvbWljU3RyaW5nPiB0b3VjaEV2 ZW50TmFtZXMoKSBjb25zdAorICAgICAgICB7CisgICAgICAgICAgICBWZWN0b3I8QXRvbWljU3Ry aW5nPiBuYW1lczsKKyAgICAgICAgICAgIG5hbWVzLnJlc2VydmVDYXBhY2l0eSg0KTsKKyAgICAg ICAgICAgIG5hbWVzLmFwcGVuZCh0b3VjaHN0YXJ0RXZlbnQpOworICAgICAgICAgICAgbmFtZXMu YXBwZW5kKHRvdWNobW92ZUV2ZW50KTsKKyAgICAgICAgICAgIG5hbWVzLmFwcGVuZCh0b3VjaGVu ZEV2ZW50KTsKKyAgICAgICAgICAgIG5hbWVzLmFwcGVuZCh0b3VjaGNhbmNlbEV2ZW50KTsKKyAg ICAgICAgICAgIHJldHVybiBuYW1lczsKICAgICAgICAgfQogICAgIH07CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNw cAppbmRleCA3NDQ2Y2ZhMDQwMTEzMmQ5NmM0ZTc1NjYzMWQ0M2U1YTg0YmU2ZWZlLi5hZTM5NDVi ZTVkMGMwZGVkOGRlY2YwMGM1OTlkNGYyODIzMTkxMDYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC0y MzA5LDYgKzIzMDksMjEgQEAgdm9pZCBOb2RlOjpkaWRNb3ZlVG9OZXdEb2N1bWVudChEb2N1bWVu dCogb2xkRG9jdW1lbnQpCiAKICAgICAvLyBGSVhNRTogRXZlbnQgbGlzdGVuZXIgdHlwZXMgZm9y IHRoaXMgbm9kZSBzaG91bGQgYmUgc2V0IG9uIHRoZSBuZXcgb3duZXIgZG9jdW1lbnQgaGVyZS4K IAorICAgIGNvbnN0IEV2ZW50TGlzdGVuZXJWZWN0b3ImIHdoZWVsTGlzdGVuZXJzID0gZ2V0RXZl bnRMaXN0ZW5lcnMoZXZlbnROYW1lcygpLm1vdXNld2hlZWxFdmVudCk7CisgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCB3aGVlbExpc3RlbmVycy5zaXplKCk7ICsraSkgeworICAgICAgICBvbGRE b2N1bWVudC0+ZGlkUmVtb3ZlV2hlZWxFdmVudEhhbmRsZXIoKTsKKyAgICAgICAgZG9jdW1lbnQo KS0+ZGlkQWRkV2hlZWxFdmVudEhhbmRsZXIoKTsKKyAgICB9CisKKyAgICBWZWN0b3I8QXRvbWlj U3RyaW5nPiB0b3VjaEV2ZW50TmFtZXMgPSBldmVudE5hbWVzKCkudG91Y2hFdmVudE5hbWVzKCk7 CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB0b3VjaEV2ZW50TmFtZXMuc2l6ZSgpOyArK2kp IHsKKyAgICAgICAgY29uc3QgRXZlbnRMaXN0ZW5lclZlY3RvciYgbGlzdGVuZXJzID0gZ2V0RXZl bnRMaXN0ZW5lcnModG91Y2hFdmVudE5hbWVzW2ldKTsKKyAgICAgICAgZm9yIChzaXplX3QgaiA9 IDA7IGogPCBsaXN0ZW5lcnMuc2l6ZSgpOyArK2opIHsKKyAgICAgICAgICAgIG9sZERvY3VtZW50 LT5kaWRSZW1vdmVUb3VjaEV2ZW50SGFuZGxlcigpOworICAgICAgICAgICAgZG9jdW1lbnQoKS0+ ZGlkQWRkVG91Y2hFdmVudEhhbmRsZXIoKTsKKyAgICAgICAgfQorICAgIH0KKwogI2lmIEVOQUJM RShNVVRBVElPTl9PQlNFUlZFUlMpCiAgICAgaWYgKFZlY3RvcjxPd25QdHI8TXV0YXRpb25PYnNl cnZlclJlZ2lzdHJhdGlvbj4gPiogcmVnaXN0cnkgPSBtdXRhdGlvbk9ic2VydmVyUmVnaXN0cnko KSkgewogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHJlZ2lzdHJ5LT5zaXplKCk7ICsr aSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IGFjZjVkZWIyNTU4MjQyZWQyOWJjMWYxY2IxNWUyY2Q5NzdlM2ZmZWQuLmEz N2EyM2E4ZTY4Zjc4ZWI5ZGVhNWM2MzJiNmYzYWVmMmRhOWQyOTggMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NyBAQAorMjAxMi0wNi0yNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAg ICAgIEFTU0VSVChtX3doZWVsRXZlbnRIYW5kbGVyQ291bnQgPiAwKSBjYW4gZmlyZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4NTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHdoYXQgaGFwcGVu cyB3aGVuIHdlIG1vdmUgYSBub2RlIHdpdGggd2hlZWwgYW5kL29yIHRvdWNoIGV2ZW50cworICAg ICAgICBmcm9tIG9uZSBkb2N1bWVudCB0byBhbm90aGVyLiBQcmlvciB0byB0aGlzIHBhdGNoLCB0 aGlzIHRlc3QgdHJpZ2dlcnMKKyAgICAgICAgQVNTRVJUKG1fd2hlZWxFdmVudEhhbmRsZXJDb3Vu dCA+IDApIGluIERvY3VtZW50LmNwcC4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL21vdmUtZWxl bWVudC13aXRoLXdoZWVsLWFuZC10b3VjaC1ldmVudC1saXN0ZW5lcnMtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9tb3ZlLWVsZW1lbnQtd2l0aC13aGVlbC1hbmQt dG91Y2gtZXZlbnQtbGlzdGVuZXJzLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA2LTI0ICBKb29uZSBI dXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLL0VGTCBn YXJkZW5pbmcgYWZ0ZXIgcjEyMTEyMS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZl bnRzL21vdmUtZWxlbWVudC13aXRoLXdoZWVsLWFuZC10b3VjaC1ldmVudC1saXN0ZW5lcnMtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbW92ZS1lbGVtZW50LXdpdGgtd2hl ZWwtYW5kLXRvdWNoLWV2ZW50LWxpc3RlbmVycy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzNm MTMyYjU5MjQ2NTU2NDhjMjk5NDkxOTlkOTUzYjQ5MDlmNzQ5YgotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL21vdmUtZWxlbWVudC13aXRoLXdoZWVsLWFuZC10b3Vj aC1ldmVudC1saXN0ZW5lcnMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorIFRoaXMgdGVz dCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvbW92ZS1lbGVtZW50LXdpdGgtd2hlZWwtYW5kLXRvdWNoLWV2ZW50LWxpc3Rl bmVycy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbW92ZS1lbGVtZW50LXdpdGgtd2hl ZWwtYW5kLXRvdWNoLWV2ZW50LWxpc3RlbmVycy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk4Njk0MWE4NmFl YmMxNGFlY2FlNTA1ZjM4NTI2MmExNTE2MDI0MzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9tb3ZlLWVsZW1lbnQtd2l0aC13aGVlbC1hbmQtdG91Y2gtZXZlbnQt bGlzdGVuZXJzLmh0bWwKQEAgLTAsMCArMSwyMSBAQAorPGlmcmFtZSBzcmM9ImRhdGE6dGV4dC9o dG1sLDxkaXYgaWQ9Zm9vPjwvZGl2PiI+PC9pZnJhbWU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50 ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitmdW5jdGlvbiBkb05v dGhpbmcoKSB7Cit9CisKK2FkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbigpIHsKKyAg ICB2YXIgZWxlbWVudCA9IGZyYW1lc1swXS5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZm9vIik7 CisKKyAgICBlbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNld2hlZWwiLCBkb05vdGhpbmcs IGZhbHNlKTsKKyAgICBlbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoInRvdWNoc3RhcnQiLCBkb05v dGhpbmcsIGZhbHNlKTsKKworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZWxlbWVudCk7 CisKKyAgICBlbGVtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoIm1vdXNld2hlZWwiLCBkb05vdGhp bmcsIGZhbHNlKTsKKyAgICBlbGVtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoInRvdWNoc3RhcnQi LCBkb05vdGhpbmcsIGZhbHNlKTsKK30sIGZhbHNlKTsKKzwvc2NyaXB0PgorVGhpcyB0ZXN0IHBh c3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLgo=