89846 2012-06-24 20:00:47 -0700 fill=freeze animations cannot be rewound 2012-06-25 03:31:26 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89687 1 pdr pdr koivisto webkit.review.bot zimmermann oldest_to_newest 656339 0 149226 pdr 2012-06-24 20:00:47 -0700 Created attachment 149226 Testcase If an SVG animation containing fill=freeze is rewound using setTimeout(), we fail to reset to the base animated value. Because of how we handle accumulating multiple animations, this can only be hit if there are at least 2 animations. See the attached testcase for an example. 656346 1 149228 pdr 2012-06-24 20:16:31 -0700 Created attachment 149228 Fix rewinding of SVG animations 656445 2 149228 zimmermann 2012-06-25 02:36:34 -0700 Comment on attachment 149228 Fix rewinding of SVG animations Woha, great catch! r=me. 656458 3 149228 webkit.review.bot 2012-06-25 03:31:22 -0700 Comment on attachment 149228 Fix rewinding of SVG animations Clearing flags on attachment: 149228 Committed r121146: <http://trac.webkit.org/changeset/121146> 656459 4 webkit.review.bot 2012-06-25 03:31:26 -0700 All reviewed patches have been landed. Closing bug. 149226 2012-06-24 20:00:47 -0700 2012-06-24 20:00:47 -0700 Testcase animate-reset-freeze.html text/html 1517 pdr PCFET0NUWVBFIEhUTUw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPCEtLQogICAgICAgIFRl c3QgZm9yIFdLKioqKio6IHJlc2V0dGluZyBhbiBhbmltYXRpb24gc2hvdWxkIG5vdCBiZSBhZmZl Y3RlZCBieSBleGlzdGluZyBmaWxsPWZyZWV6ZSBhbmltYXRpb25zLgogICAgICAgIElmIHRoaXMg dGVzdCBwYXNzZXMsIG9ubHkgdGhlIHdvcmQgIlBBU1MiIHdpbGwgYmUgdmlzaWJsZS4KICAgICAg ICAtLT4KICAgICAgICA8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVz dC1wcmUuanMiPjwvc2NyaXB0PgogICAgPC9oZWFkPgogICAgPGJvZHk+CiAgICAgICAgPHN2ZyBp ZD0ic3ZnIiB3aWR0aD0iNTAwIiBoZWlnaHQ9IjUwMCI+CiAgICAgICAgICAgIDxyZWN0IHg9IjAi IHk9IjAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJyZWQiLz4KICAgICAgICAgICAg PHJlY3QgaWQ9InJlY3QiIHg9IjAiIHk9IjAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxs PSJibHVlIj4KICAgICAgICAgICAgICAgIDxzZXQgYXR0cmlidXRlTmFtZT0ieCIgdG89IjEwMCIg YmVnaW49IjRzIiBmaWxsPSJmcmVlemUiPjwvc2V0PgogICAgICAgICAgICAgICAgPHNldCBhdHRy aWJ1dGVOYW1lPSJ4IiB0bz0iMjAwIiBiZWdpbj0iMXMiIGR1cj0iMXMiIGZpbGw9ImZyZWV6ZSI+ CiAgICAgICAgICAgIDwvcmVjdD4KICAgICAgICA8L3N2Zz4KICAgICAgICA8c2NyaXB0PgogICAg ICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICAgICAgICAgICAgIHRlc3RSdW5u ZXIud2FpdFVudGlsRG9uZSgpOwogICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCk7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIHZhciBzdmcgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnc3ZnJyk7CiAgICAgICAgICAgIHZhciByZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3JlY3QnKTsKICAgICAgICAgICAgc3ZnLnBhdXNlQW5pbWF0aW9ucygpOwogICAgICAg ICAgICBzdmcuc2V0Q3VycmVudFRpbWUoMTAwKTsKCiAgICAgICAgICAgIHNldFRpbWVvdXQoZnVu Y3Rpb24oKSB7CiAgICAgICAgICAgICAgICBzdmcuc2V0Q3VycmVudFRpbWUoMCk7CiAgICAgICAg ICAgICAgICBpZiAocmVjdC54LmFuaW1WYWwudmFsdWUgIT0gMCkKICAgICAgICAgICAgICAgICAg ICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICJGQUlMOiByZWN0LnguYW5pbVZhbC52YWx1ZSB3 YXMgIiArIHJlY3QueC5hbmltVmFsLnZhbHVlICsgIiwgZXhwZWN0ZWQgMCI7CiAgICAgICAgICAg ICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAi UEFTUyI7CgogICAgICAgICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogICAgICAgICAg ICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwogICAgICAgICAgICB9LCAxKTsKICAg ICAgICA8L3NjcmlwdD4KICAgIDwvYm9keT4KPC9odG1sPgo= 149228 2012-06-24 20:16:31 -0700 2012-06-25 03:31:21 -0700 Fix rewinding of SVG animations 89846.1.patch text/plain 4551 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTEzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTI0ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IHJld2luZGluZyBvZiBTVkcg YW5pbWF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODk4NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICByMTE2NDUxIGludHJvZHVjZWQgYW4gb3B0aW1pemF0aW9uIHRvIG9ubHkgY2xlYXIgbm9uLWZy ZWV6ZSBhbmltYXRpb25zIHdoZW4KKyAgICAgICAgY2FsbGluZyBzZXRDdXJyZW50VGltZSAodmlh IHJlc2V0KCkpLiBUaGlzIGNhdXNlcyBmaWxsPWZyZWV6ZSBhbmltYXRpb25zIHRvCisgICAgICAg IG5vdCBjbGVhciB3aGljaCBicmVha3MgcmV3aW5kaW5nIG9mIGFuIGFuaW1hdGlvbi4KKworICAg ICAgICBJbiB0aGUgcHJlc2VuY2Ugb2YgbXVsdGlwbGUgYW5pbWF0aW9ucywgd2UgcmVzZXQgdGhl IGZpcnN0IGFuaW1hdGlvbiB0byB0aGUKKyAgICAgICAgYmFzZSB2YWx1ZSBhbmQgYWNjdW11bGF0 ZSBhbGwgcmVzdWx0cyBpbnRvIHRoYXQ7IHRoaXMgbWFza2VkIHRoZSBwcm9ibGVtIGJlY2F1c2UK KyAgICAgICAgMiBhbmltYXRpb25zIHdlcmUgcmVxdWlyZWQgdG8gaGl0IHRoZSBidWcgKG91ciB0 ZXN0cyBwcmltYXJpbHkgY292ZXIganVzdCAxKS4KKworICAgICAgICBUZXN0OiBzdmcvYW5pbWF0 aW9ucy9hbmltYXRlLXJlc2V0LWZyZWV6ZS5odG1sCisKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9u L1NWR1NNSUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1NNSUxFbGVtZW50Ojpy ZXNldCk6CisKIDIwMTItMDYtMjQgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+ CiAKICAgICAgICAgTm9kZVJlbmRlcmluZ0NvbnRleHQ6OkF0dGFjaGluZ1BoYXNlIGlzIHJlZHVu ZGFudC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVs ZW1lbnQuY3BwCShyZXZpc2lvbiAxMjA5MDYpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0 aW9uL1NWR1NNSUxFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc4LDkgKzE3OCw3IEBA IHN0YXRpYyBpbmxpbmUgdm9pZCBjbGVhclRpbWVzV2l0aER5bmFtaWMKIAogdm9pZCBTVkdTTUlM RWxlbWVudDo6cmVzZXQoKQogewotICAgIC8vIERvbid0IGNsZWFyIHRoZSBhbmltYXRlZCB0eXBl IGlmIHdlJ3JlIGZyb3plbiwgb25seSB0YWtlIGFjdGlvbiBoZXJlIGlmIHdlJ3JlIGFjdGl2ZS4K LSAgICBpZiAobV9hY3RpdmVTdGF0ZSA9PSBBY3RpdmUpCi0gICAgICAgIGNsZWFyQW5pbWF0ZWRU eXBlKG1fdGFyZ2V0RWxlbWVudCk7CisgICAgY2xlYXJBbmltYXRlZFR5cGUobV90YXJnZXRFbGVt ZW50KTsKIAogICAgIG1fYWN0aXZlU3RhdGUgPSBJbmFjdGl2ZTsKICAgICBtX2lzV2FpdGluZ0Zv ckZpcnN0SW50ZXJ2YWwgPSB0cnVlOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxMTMxKQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTIt MDYtMjQgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xlLmNvbT4KKworICAgICAgICBGaXggcmV3 aW5kaW5nIG9mIFNWRyBhbmltYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04OTg0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1yZXNldC1mcmVlemUtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdmcvYW5pbWF0aW9ucy9hbmltYXRlLXJlc2V0 LWZyZWV6ZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wNi0yMSAgS2VudCBUYW11cmEgIDx0a2VudEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgU2VsZWN0ZWQgb3B0aW9uIGlzIG5vdCByZXN0b3JlZCBj b3JyZWN0bHkKSW5kZXg6IExheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2FuaW1hdGUtcmVzZXQt ZnJlZXplLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvYW5pbWF0 aW9ucy9hbmltYXRlLXJlc2V0LWZyZWV6ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLXJlc2V0LWZyZWV6ZS1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL3N2 Zy9hbmltYXRpb25zL2FuaW1hdGUtcmVzZXQtZnJlZXplLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1yZXNldC1mcmVlemUuaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2FuaW1hdGUtcmVzZXQtZnJlZXpl Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDEgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0 bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDwhLS0KKyAgICAgICAgVGVzdCBmb3IgV0s4OTg0Njog QW5pbWF0aW9ucyBzaG91bGQgYmUgcmV3aW5kYWJsZSBldmVuIHdpdGggZXhpc3RpbmcgZmlsbD1m cmVlemUgYW5pbWF0aW9ucy4KKyAgICAgICAgSWYgdGhpcyB0ZXN0IHBhc3Nlcywgb25seSB0aGUg d29yZCAiUEFTUyIgd2lsbCBiZSB2aXNpYmxlLgorICAgICAgICAtLT4KKyAgICAgICAgPHNjcmlw dCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KyAgICA8L2hlYWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxzdmcgaWQ9InN2ZyIgd2lkdGg9IjUw MCIgaGVpZ2h0PSI1MDAiPgorICAgICAgICAgICAgPHJlY3QgeD0iMCIgeT0iMCIgd2lkdGg9IjEw MCIgaGVpZ2h0PSIxMDAiIGZpbGw9InJlZCIvPgorICAgICAgICAgICAgPHJlY3QgaWQ9InJlY3Qi IHg9IjAiIHk9IjAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJibHVlIj4KKyAgICAg ICAgICAgICAgICA8c2V0IGF0dHJpYnV0ZU5hbWU9IngiIHRvPSIxMDAiIGJlZ2luPSI0cyIgZmls bD0iZnJlZXplIj48L3NldD4KKyAgICAgICAgICAgICAgICA8c2V0IGF0dHJpYnV0ZU5hbWU9Ingi IHRvPSIyMDAiIGJlZ2luPSIxcyIgZHVyPSIxcyIgZmlsbD0iZnJlZXplIj4KKyAgICAgICAgICAg IDwvcmVjdD4KKyAgICAgICAgPC9zdmc+CisgICAgICAgIDxzY3JpcHQ+CisgICAgICAgICAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLndhaXRV bnRpbERvbmUoKTsKKyAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAg ICAgICAgICAgIH0KKworICAgICAgICAgICAgdmFyIHN2ZyA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdzdmcnKTsKKyAgICAgICAgICAgIHZhciByZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3JlY3QnKTsKKyAgICAgICAgICAgIHN2Zy5wYXVzZUFuaW1hdGlvbnMoKTsKKyAgICAgICAg ICAgIHN2Zy5zZXRDdXJyZW50VGltZSgxMDApOworCisgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1 bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIHN2Zy5zZXRDdXJyZW50VGltZSgwKTsKKyAgICAg ICAgICAgICAgICBpZiAocmVjdC54LmFuaW1WYWwudmFsdWUgIT0gMCkKKyAgICAgICAgICAgICAg ICAgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiRkFJTDogcmVjdC54LmFuaW1WYWwudmFs dWUgd2FzICIgKyByZWN0LnguYW5pbVZhbC52YWx1ZSArICIsIGV4cGVjdGVkIDAiOworICAgICAg ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5pbm5lckhU TUwgPSAiUEFTUyI7CisKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisg ICAgICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAg fSwgMSk7CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvYm9keT4KKzwvaHRtbD4K