89823 2012-06-23 22:53:27 -0700 Remove unused constant timeWithoutMouseMovementBeforeHidingControls 2012-06-25 11:56:42 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyul webkit-unassigned darin dbates eric.carlson feature-media-reviews jer.noble webkit.review.bot oldest_to_newest 656166 0 skyul 2012-06-23 22:53:27 -0700 After r87692, timeWithoutMouseMovementBeforeHidingControls is not used anymore. 656167 1 149185 skyul 2012-06-23 22:55:41 -0700 Created attachment 149185 Patch 656714 2 dbates 2012-06-25 11:01:48 -0700 For completeness, the patch for bug #61717 moved the HTMLMediaElement code to MediaControlRootElement. In particular, the function startHideFullscreenControlsTimer() in HTMLMediaElement.cpp (which was the only function that referenced timeWithoutMouseMovementBeforeHidingControls in HTMLMediaElement.cpp) was moved to MediaControlRootElement.cpp, but the constant timeWithoutMouseMovementBeforeHidingControls in HTMLMediaElement.cpp wasn't removed. 656716 3 149185 dbates 2012-06-25 11:02:06 -0700 Comment on attachment 149185 Patch r=me 656771 4 149185 webkit.review.bot 2012-06-25 11:56:37 -0700 Comment on attachment 149185 Patch Clearing flags on attachment: 149185 Committed r121173: <http://trac.webkit.org/changeset/121173> 656772 5 webkit.review.bot 2012-06-25 11:56:42 -0700 All reviewed patches have been landed. Closing bug. 149185 2012-06-23 22:55:41 -0700 2012-06-25 11:56:37 -0700 Patch bug-89823-20120624145536.patch text/plain 1409 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhjYzk3Nzg1MmQ2NmMz OWYyNDg5OTBiYWY4YWM4YmEwMzhkM2U0OS4uNWFjMTk5ZjQxMTlhMDJlMGU1ODQ1ODhjZTMxNGQz ODc0ZGI2ZTExMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTIzICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBjb25zdGFudCB0aW1lV2l0aG91dE1vdXNlTW92ZW1lbnRCZWZvcmVIaWRpbmdDb250cm9scwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4MjMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciByODc2 OTIsIHRpbWVXaXRob3V0TW91c2VNb3ZlbWVudEJlZm9yZUhpZGluZ0NvbnRyb2xzIGlzIG5vdCB1 c2VkIGFueW1vcmUuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZSk6CisKIDIwMTItMDYtMjMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgSW5zZXJ0aW5nIG5vZGVzIGlzIHNsb3cgZHVlIHRvIE5vZGU6Om5v dGlmeU5vZGVMaXN0c0F0dHJpYnV0ZUNoYW5nZWQgKDIwJSspCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCBiY2M4N2ZlMGNjMGMzNzEwMDc4NmUzYmM5MDQ1ZTll ZTZmMWU2ZWU5Li5mZGRjNDI4OTNlYmQwMDNlMGE1NWRkYjdmMmM4NzU4NjVlN2E5NDdmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI3MDgsOCArMjcwOCw2 IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6ZW5kU2NydWJiaW5nKCkKIC8vICIxNSB0byAyNTBt cyIsIHdlIGNob29zZSB0aGUgc2xvd2VzdCBmcmVxdWVuY3kKIHN0YXRpYyBjb25zdCBkb3VibGUg bWF4VGltZXVwZGF0ZUV2ZW50RnJlcXVlbmN5ID0gMC4yNTsKIAotc3RhdGljIGNvbnN0IGRvdWJs ZSB0aW1lV2l0aG91dE1vdXNlTW92ZW1lbnRCZWZvcmVIaWRpbmdDb250cm9scyA9IDM7Ci0KIHZv aWQgSFRNTE1lZGlhRWxlbWVudDo6c3RhcnRQbGF5YmFja1Byb2dyZXNzVGltZXIoKQogewogICAg IGlmIChtX3BsYXliYWNrUHJvZ3Jlc3NUaW1lci5pc0FjdGl2ZSgpKQo=