89822 2012-06-23 22:13:30 -0700 [chromium] Return has value, in function returning void 2012-06-23 22:29:47 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned abarth webkit.review.bot oldest_to_newest 656158 0 skyul 2012-06-23 22:13:30 -0700 A followup for r121091. 656159 1 149184 skyul 2012-06-23 22:17:04 -0700 Created attachment 149184 Patch 656160 2 149184 webkit.review.bot 2012-06-23 22:23:40 -0700 Comment on attachment 149184 Patch Rejecting attachment 149184 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13029798 656161 3 149184 abarth 2012-06-23 22:25:27 -0700 Comment on attachment 149184 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149184&action=review > Source/WebKit/chromium/ChangeLog:6 > + A followup for r121091. You need to leave in the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so the tools know to fill in the reviewer. 656162 4 skyul 2012-06-23 22:26:57 -0700 (In reply to comment #3) > (From update of attachment 149184 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=149184&action=review > > > Source/WebKit/chromium/ChangeLog:6 > > + A followup for r121091. > > You need to leave in the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so the tools know to fill in the reviewer. Oops. I removed the line by accident. I will commit this patch manually after adding you as a reviewer. Thanks. 656163 5 skyul 2012-06-23 22:29:47 -0700 Committed r121108: <http://trac.webkit.org/changeset/121108> 149184 2012-06-23 22:17:04 -0700 2012-06-23 22:25:27 -0700 Patch bug-89822-20120624141659.patch text/plain 3838 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDA2Y2Y3Y2U2MmFhMmQxMTIyNDNhNGQ1MTdlNDJjNGVjNDdjNTY0ZWIuLjJlZTYzZTBmNDQwNjRi NzdmZjMwZDJmYmJlZDU4MjdiNDljNTE2ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDYgKzEsMjMgQEAKIDIwMTItMDYtMjMgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KIAogICAgICAgICBbY2hyb21pdW1dIFJldHVybiBoYXMgdmFsdWUsIGluIGZ1bmN0 aW9uIHJldHVybmluZyB2b2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04OTgyMgorCisgICAgICAgIEEgZm9sbG93dXAgZm9yIHIxMjEwOTEuCisKKyAg ICAgICAgKiBzcmMvV2ViSGlzdG9yeUl0ZW0uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJIaXN0 b3J5SXRlbTo6c2V0UGFnZVNjYWxlRmFjdG9yKToKKyAgICAgICAgKiBzcmMvV2ViSW1hZ2VMYXll ci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkltYWdlTGF5ZXI6OnNldEJpdG1hcCk6CisgICAg ICAgICogc3JjL1dlYkxheWVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTGF5ZXI6OnNldE1h c2tMYXllcik6CisgICAgICAgICogc3JjL1dlYk9wdGlvbkVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJPcHRpb25FbGVtZW50OjpzZXRWYWx1ZSk6CisgICAgICAgIChXZWJLaXQ6Oldl Yk9wdGlvbkVsZW1lbnQ6OnNldERlZmF1bHRTZWxlY3RlZCk6CisKKzIwMTItMDYtMjMgIEt3YW5n IFl1bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBbY2hyb21pdW1dIFJl dHVybiBoYXMgdmFsdWUsIGluIGZ1bmN0aW9uIHJldHVybmluZyB2b2lkCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTgwNQogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJIaXN0b3J5SXRlbS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJIaXN0 b3J5SXRlbS5jcHAKaW5kZXggMjdkYmM0NGMyN2I4NGEwZWZiNTM1Zjk1ZjM2MDA5MjYxNTk5Mzlm NC4uZGIzNTMxN2FkOTgzY2RkNjlkOWQwNjU1MjY1NWYyYzFmOTk0MzY3MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSGlzdG9yeUl0ZW0uY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkhpc3RvcnlJdGVtLmNwcApAQCAtMTczLDcgKzE3Myw3 IEBAIGZsb2F0IFdlYkhpc3RvcnlJdGVtOjpwYWdlU2NhbGVGYWN0b3IoKSBjb25zdAogdm9pZCBX ZWJIaXN0b3J5SXRlbTo6c2V0UGFnZVNjYWxlRmFjdG9yKGZsb2F0IHNjYWxlKQogewogICAgIGVu c3VyZU11dGFibGUoKTsKLSAgICByZXR1cm4gbV9wcml2YXRlLT5zZXRQYWdlU2NhbGVGYWN0b3Io c2NhbGUpOworICAgIG1fcHJpdmF0ZS0+c2V0UGFnZVNjYWxlRmFjdG9yKHNjYWxlKTsKIH0KIAog Ym9vbCBXZWJIaXN0b3J5SXRlbTo6aXNUYXJnZXRJdGVtKCkgY29uc3QKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkltYWdlTGF5ZXIuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VMYXllci5jcHAKaW5kZXggOTNkYmYzOTMwYzY5MmVhMDYw ZTBkNzdmN2FhODhjMmE2Njk5N2QxNy4uZjc2MTUxNTMwZDEwNzU3ZDJjZDQ0YTc4MDMwYTk2OWY1 NmUyNDA2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VM YXllci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VMYXllci5j cHAKQEAgLTQyLDcgKzQyLDcgQEAgV2ViSW1hZ2VMYXllcjo6V2ViSW1hZ2VMYXllcihQYXNzUmVm UHRyPFdlYkNvcmU6OkltYWdlTGF5ZXJDaHJvbWl1bT4gbGF5ZXIpCiAKIHZvaWQgV2ViSW1hZ2VM YXllcjo6c2V0Qml0bWFwKFNrQml0bWFwIGJpdG1hcCkKIHsKLSAgICByZXR1cm4gdW53cmFwPFdl YkNvcmU6OkltYWdlTGF5ZXJDaHJvbWl1bT4oKS0+c2V0Qml0bWFwKGJpdG1hcCk7CisgICAgdW53 cmFwPFdlYkNvcmU6OkltYWdlTGF5ZXJDaHJvbWl1bT4oKS0+c2V0Qml0bWFwKGJpdG1hcCk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTGF5ZXIuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTGF5 ZXIuY3BwCmluZGV4IDNiMmM2MmU2ZDdhNDZkZDA0YTc0NmE1MWEwMTUxMmZmNzdhOWJhZGYuLjI1 Y2I1ODY4Y2M4N2FkZDM5MWNhNmM2MjU0ZjI5ZjI5YTNkN2EzZDUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJMYXllci5jcHAKQEAgLTE4Nyw3ICsxODcsNyBAQCBib29sIFdlYkxheWVy OjptYXNrc1RvQm91bmRzKCkgY29uc3QKIHZvaWQgV2ViTGF5ZXI6OnNldE1hc2tMYXllcihjb25z dCBXZWJMYXllciYgbWFza0xheWVyKQogewogICAgIFdlYkxheWVyIHJlZiA9IG1hc2tMYXllcjsK LSAgICByZXR1cm4gbV9wcml2YXRlLT5zZXRNYXNrTGF5ZXIocmVmLnVud3JhcDxMYXllckNocm9t aXVtPigpKTsKKyAgICBtX3ByaXZhdGUtPnNldE1hc2tMYXllcihyZWYudW53cmFwPExheWVyQ2hy b21pdW0+KCkpOwogfQogCiBXZWJMYXllciBXZWJMYXllcjo6bWFza0xheWVyKCkgY29uc3QKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk9wdGlvbkVsZW1lbnQuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViT3B0aW9uRWxlbWVudC5jcHAKaW5kZXgg YzcxZjdiNTY1Njg2ZGRjNDMxZmY4NDgwZmU5NWQzMmJjY2I4NWU3OC4uMWQ1MGEwNTNlM2QwNWFl NWU4M2Q3OGM4NDcwMzFkMTM2NmUzYThjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViT3B0aW9uRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViT3B0aW9uRWxlbWVudC5jcHAKQEAgLTQ0LDcgKzQ0LDcgQEAgbmFtZXNwYWNlIFdl YktpdCB7CiAKIHZvaWQgV2ViT3B0aW9uRWxlbWVudDo6c2V0VmFsdWUoY29uc3QgV2ViU3RyaW5n JiBuZXdWYWx1ZSkKIHsKLSAgICByZXR1cm4gdW53cmFwPEhUTUxPcHRpb25FbGVtZW50PigpLT5z ZXRWYWx1ZShuZXdWYWx1ZSk7CisgICAgdW53cmFwPEhUTUxPcHRpb25FbGVtZW50PigpLT5zZXRW YWx1ZShuZXdWYWx1ZSk7CiB9CiAKIFdlYlN0cmluZyBXZWJPcHRpb25FbGVtZW50Ojp2YWx1ZSgp IGNvbnN0CkBAIC02OSw3ICs2OSw3IEBAIGJvb2wgV2ViT3B0aW9uRWxlbWVudDo6ZGVmYXVsdFNl bGVjdGVkKCkgY29uc3QKIAogdm9pZCBXZWJPcHRpb25FbGVtZW50OjpzZXREZWZhdWx0U2VsZWN0 ZWQoYm9vbCBuZXdTZWxlY3RlZCkKIHsKLSAgICByZXR1cm4gdW53cmFwPEhUTUxPcHRpb25FbGVt ZW50PigpLT5zZXRBdHRyaWJ1dGUoc2VsZWN0ZWRBdHRyLCBuZXdTZWxlY3RlZCA/ICIiIDogMCk7 CisgICAgdW53cmFwPEhUTUxPcHRpb25FbGVtZW50PigpLT5zZXRBdHRyaWJ1dGUoc2VsZWN0ZWRB dHRyLCBuZXdTZWxlY3RlZCA/ICIiIDogMCk7CiB9CiAKIFdlYlN0cmluZyBXZWJPcHRpb25FbGVt ZW50OjpsYWJlbCgpIGNvbnN0Cg==