89811 2012-06-23 08:26:15 -0700 [Gtk] media/media-blocked-by-beforeload.html is flaky 2014-05-16 12:02:31 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 zan webkit-unassigned commit-queue eric.carlson glenn jer.noble philipj sergio oldest_to_newest 656105 0 zan 2012-06-23 08:26:15 -0700 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&revision=121086&tests=media%2Fmedia-blocked-by-beforeload.html It seems the loadedmetadata event is fired at different times, causing intermittent test failures: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/media-blocked-by-beforeload-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/media-blocked-by-beforeload-actual.txt @@ -30,11 +30,11 @@ EVENT('loadstart') +EVENT('loadedmetadata') + + EVENT('error') EXPECTED (event.target.tagName == 'SOURCE') OK EXPECTED (video.error == 'null') OK - -EVENT('loadedmetadata') - END OF TEST 1009474 1 231493 piotr.grad 2014-05-15 00:19:53 -0700 Created attachment 231493 Patch & layout test 1009520 2 231493 eric.carlson 2014-05-15 06:47:24 -0700 Comment on attachment 231493 Patch & layout test This test is about the error events so I would prefer to leave as much logging in the results about those events as possible. The problem is the order of the 'error' and 'loadedmetadata' events is nondeterministic, so wouldn't it work to just not log the arrival of the 'loadedmetadata' event (remove the "logEvent(evt)" from loadedmetadata)? 1009736 3 231564 piotr.grad 2014-05-16 02:51:37 -0700 Created attachment 231564 Patch for layout test 1009805 4 231564 eric.carlson 2014-05-16 11:52:58 -0700 Comment on attachment 231564 Patch for layout test Thank you for sticking with this! 1009806 5 231564 commit-queue 2014-05-16 12:02:26 -0700 Comment on attachment 231564 Patch for layout test Clearing flags on attachment: 231564 Committed r168973: <http://trac.webkit.org/changeset/168973> 1009807 6 commit-queue 2014-05-16 12:02:31 -0700 All reviewed patches have been landed. Closing bug. 231493 2014-05-15 00:19:53 -0700 2014-05-16 02:51:37 -0700 Patch & layout test patch3.txt text/plain 3908 piotr.grad ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MTU3ODM1Li40ZGYyZTZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDUt MTUgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0d0a10gbWVk aWEvbWVkaWEtYmxvY2tlZC1ieS1iZWZvcmVsb2FkLmh0bWwgaXMgZmxha3kuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTgxMQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb2JsZW0gaXMgdGhhdCB3ZSBj YW5ub3QgcHJlZGljdCB3aGVuICdlcnJvcicgZXZlbnQgd291bGQgYmUgY2FsbGVkLAorICAgICAg ICBiZWNhdXNlIGlzIGNhbGxlZCBhc3luYyBvbiAnc291cmNlJyBlbGVtZW50LiBTb2x1dGlvbiBp cyB0byBzaG93CisgICAgICAgIG1lc3NhZ2VzIGZyb20gJ2Vycm9yJyBldmVudCBoYW5kbGVyIG9u bHkgb24gZmFpbHVyZS4KKworICAgICAgICAqIG1lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3Jl bG9hZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvbWVkaWEtYmxvY2tlZC1ieS1iZWZv cmVsb2FkLmh0bWw6CisKIDIwMTQtMDUtMTMgIExvcmVuem8gVGlsdmUgIDxsdGlsdmVAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBVbnJldmlld2VkIEdUSyBnYXJkZW5pbmcKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1ibG9ja2VkLWJ5LWJlZm9yZWxvYWQtZXhw ZWN0ZWQudHh0CmluZGV4IGEwNmQ2ODYuLmUwZTBlNzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvbWVkaWEtYmxvY2tlZC1ieS1iZWZvcmVsb2FkLWV4cGVjdGVkLnR4dApA QCAtMTMsMTIgKzEzLDYgQEAgYmxvY2tpbmcgbG9hZCBvZiAnc3JjJwogCiBFVkVOVCgnbG9hZHN0 YXJ0JykKIAotRVZFTlQoJ2Vycm9yJykKLUVYUEVDVEVEIChldmVudC50YXJnZXQudGFnTmFtZSA9 PSAnVklERU8nKSBPSwotRVhQRUNURUQgKHZpZGVvLmVycm9yICE9ICdudWxsJykgT0sKLUVYUEVD VEVEICh2aWRlby5lcnJvci5jb2RlID09ICc0JykgT0sKLUVYUEVDVEVEICh2aWRlby5uZXR3b3Jr U3RhdGUgPT0gJzMnKSBPSwotCiAqKiogVGVzdCB1c2luZyB0aGUgPHNvdXJjZT4gZWxlbWVudCAq KioKIAogRVZFTlQoJ2JlZm9yZWxvYWQnKQpAQCAtMzEsMTAgKzI1LDYgQEAgYWxsb3dpbmcgbG9h ZCBvZiBzZWNvbmQgPHNvdXJjZT4gZWxlbWVudAogCiBFVkVOVCgnbG9hZHN0YXJ0JykKIAotRVZF TlQoJ2Vycm9yJykKLUVYUEVDVEVEIChldmVudC50YXJnZXQudGFnTmFtZSA9PSAnU09VUkNFJykg T0sKLUVYUEVDVEVEICh2aWRlby5lcnJvciA9PSAnbnVsbCcpIE9LCi0KIEVWRU5UKCdsb2FkZWRt ZXRhZGF0YScpCiAKIEVORCBPRiBURVNUCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9t ZWRpYS1ibG9ja2VkLWJ5LWJlZm9yZWxvYWQuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL21lZGlh LWJsb2NrZWQtYnktYmVmb3JlbG9hZC5odG1sCmluZGV4IDhmMmYwZmMuLjRiYjZkYWEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC5odG1s CisrKyBiL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC5odG1s CkBAIC02MCwyMiArNjAsMjcgQEAKIAogICAgICAgICBmdW5jdGlvbiBlcnJvcihldnQpCiAgICAg ICAgIHsKLSAgICAgICAgICAgIGxvZ0V2ZW50KGV2dCk7CiAgICAgICAgICAgICBzd2l0Y2ggKHRl c3QpCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgY2FzZSAxOgotICAgICAgICAgICAg ICAgICAgICB0ZXN0RXhwZWN0ZWQoImV2ZW50LnRhcmdldC50YWdOYW1lIiwgIlZJREVPIik7Ci0g ICAgICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uZXJyb3IiLCBudWxsLCAiIT0i KTsKLSAgICAgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby5lcnJvci5jb2RlIiwg TWVkaWFFcnJvci5NRURJQV9FUlJfU1JDX05PVF9TVVBQT1JURUQpOwotICAgICAgICAgICAgICAg ICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLm5ldHdvcmtTdGF0ZSIsIEhUTUxNZWRpYUVsZW1lbnQu TkVUV09SS19OT19TT1VSQ0UpOworICAgICAgICAgICAgICAgICAgICBpZiAoZXZlbnQudGFyZ2V0 LnRhZ05hbWUgIT0gIlZJREVPIikKKyAgICAgICAgICAgICAgICAgICAgICAgIGZhaWxUZXN0KCJF WFBFQ1RFRCAoZXZlbnQudGFyZ2V0LnRhZ05hbWUgPT0gJ1ZJREVPJyksIE9CU0VSVkVEICIgKyBl dmVudC50YXJnZXQudGFnTmFtZSk7CisgICAgICAgICAgICAgICAgICAgIGlmICh2aWRlby5lcnJv ciA9PSBudWxsKQorICAgICAgICAgICAgICAgICAgICAgICAgZmFpbFRlc3QoIkVYUEVDVEVEICh2 aWRlby5lcnJvciAhPSBudWxsKSwgT0JTRVJWRUQgbnVsbCIpOworICAgICAgICAgICAgICAgICAg ICBpZiAodmlkZW8uZXJyb3IuY29kZSAhPSBNZWRpYUVycm9yLk1FRElBX0VSUl9TUkNfTk9UX1NV UFBPUlRFRCkKKyAgICAgICAgICAgICAgICAgICAgICAgIGZhaWxUZXN0KCJFWFBFQ1RFRCAodmlk ZW8uZXJyb3IuY29kZSA9PSBNZWRpYUVycm9yLk1FRElBX0VSUl9TUkNfTk9UX1NVUFBPUlRFRCks IE9CU0VSVkVEIiArIHZpZGVvLmVycm9yLmNvZGUpOworICAgICAgICAgICAgICAgICAgICBpZiAo dmlkZW8ubmV0d29ya1N0YXRlICE9IEhUTUxNZWRpYUVsZW1lbnQuTkVUV09SS19OT19TT1VSQ0Up CisgICAgICAgICAgICAgICAgICAgICAgICBmYWlsVGVzdCgiRVhQRUNURUQgKHZpZGVvLm5ldHdv cmtTdGF0ZSA9PSBIVE1MTWVkaWFFbGVtZW50Lk5FVFdPUktfTk9fU09VUkNFKSwgT0JTRVJWRUQi ICsgdmlkZW8ubmV0d29ya1N0YXRlKTsKIAogICAgICAgICAgICAgICAgICAgICBzZXR1cFNvdXJj ZVRlc3QoKTsKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgY2Fz ZSAyOgogICAgICAgICAgICAgICAgICAgICAvLyBUaGUgZXJyb3Igc2hvdWxkIGhhdmUgYmVlbiBm aXJlZCBhdCB0aGUgPHNvdXJjZT4gYW5kIHRoZSBtZWRpYSBlbGVtZW50IHNob3VsZAogICAgICAg ICAgICAgICAgICAgICAvLyBub3QgYmUgaW4gYW4gZXJyb3Igc3RhdGUuCi0gICAgICAgICAgICAg ICAgICAgIHRlc3RFeHBlY3RlZCgiZXZlbnQudGFyZ2V0LnRhZ05hbWUiLCAiU09VUkNFIik7Ci0g ICAgICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uZXJyb3IiLCBudWxsKTsKKyAg ICAgICAgICAgICAgICAgICAgaWYgKGV2ZW50LnRhcmdldC50YWdOYW1lICE9ICJTT1VSQ0UiKQor ICAgICAgICAgICAgICAgICAgICAgICAgZmFpbFRlc3QoIkVYUEVDVEVEIChldmVudC50YXJnZXQu dGFnTmFtZSA9PSAnU09VUkNFJyksIE9CU0VSVkVEICIgKyBldmVudC50YXJnZXQudGFnTmFtZSk7 CisgICAgICAgICAgICAgICAgICAgIGlmICh2aWRlby5lcnJvciAhPSBudWxsKQorICAgICAgICAg ICAgICAgICAgICAgICAgZmFpbFRlc3QoIkVYUEVDVEVEICh2aWRlby5lcnJvciA9PSBudWxsKSwg T0JTRVJWRUQgIiArIHZpZGVvLmVycm9yKTsKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgICAgICAgICAgY2FzZSAzOgogICAgICAgICAgICAgICAgICAgICBmYWlsVGVzdCgiVW5l eHBlY3RlZCAnZXJyb3InIGV2ZW50IGZpcmVkISIpOwo= 231564 2014-05-16 02:51:37 -0700 2014-05-16 12:02:26 -0700 Patch for layout test patch4.txt text/plain 3181 piotr.grad ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MTU3ODM1Li4zOTJiYzllIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDUt MTUgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0d0a10gbWVk aWEvbWVkaWEtYmxvY2tlZC1ieS1iZWZvcmVsb2FkLmh0bWwgaXMgZmxha3kuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTgxMQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb2JsZW0gaXMgdGhhdCB3ZSBj YW5ub3QgcHJlZGljdCB3aGVuICdlcnJvcicgZXZlbnQgd291bGQgYmUgY2FsbGVkLAorICAgICAg ICBiZWNhdXNlIGlzIGNhbGxlZCBhc3luYyBvbiAnc291cmNlJyBlbGVtZW50LiBTb2x1dGlvbiBp cyB0byBub3QgbG9nCisgICAgICAgICdsb2FkZWRtZXRhZGF0YScgYW5kICdsb2Fkc3RhcnQnIGV2 ZW50cy4KKworICAgICAgICAqIG1lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC1leHBl Y3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvbWVkaWEtYmxvY2tlZC1ieS1iZWZvcmVsb2FkLmh0 bWw6CisKIDIwMTQtMDUtMTMgIExvcmVuem8gVGlsdmUgIDxsdGlsdmVAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBVbnJldmlld2VkIEdUSyBnYXJkZW5pbmcKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1ibG9ja2VkLWJ5LWJlZm9yZWxvYWQtZXhwZWN0ZWQudHh0 CmluZGV4IGEwNmQ2ODYuLjZhMzRjMDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL21l ZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv bWVkaWEvbWVkaWEtYmxvY2tlZC1ieS1iZWZvcmVsb2FkLWV4cGVjdGVkLnR4dApAQCAtMTEsOCAr MTEsNiBAQCBFVkVOVCgnYmVmb3JlbG9hZCcpCiBFWFBFQ1RFRCAoZXZlbnQudGFyZ2V0LnRhZ05h bWUgPT0gJ1ZJREVPJykgT0sKIGJsb2NraW5nIGxvYWQgb2YgJ3NyYycKIAotRVZFTlQoJ2xvYWRz dGFydCcpCi0KIEVWRU5UKCdlcnJvcicpCiBFWFBFQ1RFRCAoZXZlbnQudGFyZ2V0LnRhZ05hbWUg PT0gJ1ZJREVPJykgT0sKIEVYUEVDVEVEICh2aWRlby5lcnJvciAhPSAnbnVsbCcpIE9LCkBAIC0y OSwxMyArMjcsOCBAQCBFVkVOVCgnYmVmb3JlbG9hZCcpCiBFWFBFQ1RFRCAoZXZlbnQudGFyZ2V0 LnRhZ05hbWUgPT0gJ1ZJREVPJykgT0sKIGFsbG93aW5nIGxvYWQgb2Ygc2Vjb25kIDxzb3VyY2U+ IGVsZW1lbnQKIAotRVZFTlQoJ2xvYWRzdGFydCcpCi0KIEVWRU5UKCdlcnJvcicpCiBFWFBFQ1RF RCAoZXZlbnQudGFyZ2V0LnRhZ05hbWUgPT0gJ1NPVVJDRScpIE9LCiBFWFBFQ1RFRCAodmlkZW8u ZXJyb3IgPT0gJ251bGwnKSBPSwotCi1FVkVOVCgnbG9hZGVkbWV0YWRhdGEnKQotCiBFTkQgT0Yg VEVTVAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1ibG9ja2VkLWJ5LWJl Zm9yZWxvYWQuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3Jl bG9hZC5odG1sCmluZGV4IDhmMmYwZmMuLmI1N2VlMzQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC5odG1sCisrKyBiL0xheW91dFRlc3Rz L21lZGlhL21lZGlhLWJsb2NrZWQtYnktYmVmb3JlbG9hZC5odG1sCkBAIC0yMSw2ICsyMSw3IEBA CiAgICAgICAgIHZhciB0ZXN0OwogICAgICAgICB2YXIgbG9hZGVkbWV0YWRhdGFGaXJlZCA9IGZh bHNlOwogICAgICAgICB2YXIgbG9hZGVkRmlyZWQgPSBmYWxzZTsKKyAgICAgICAgdmFyIGxhc3RF cnJvckZpcmVkID0gZmFsc2U7CiAKICAgICAgICAgZnVuY3Rpb24gbG9nRXZlbnQoZXZ0KQogICAg ICAgICB7CkBAIC0yOSw4ICszMCw2IEBACiAKICAgICAgICAgZnVuY3Rpb24gbG9hZGVkbWV0YWRh dGEoZXZ0KQogICAgICAgICB7Ci0gICAgICAgICAgICBsb2dFdmVudChldnQpOwotICAgICAgICAg ICAgY29uc29sZVdyaXRlKCIiKTsKICAgICAgICAgICAgIGxvYWRlZG1ldGFkYXRhRmlyZWQgPSB0 cnVlOwogICAgICAgICAgICAgY2hlY2tFbmRUZXN0KCk7CiAgICAgICAgIH0KQEAgLTc2LDYgKzc1 LDggQEAKICAgICAgICAgICAgICAgICAgICAgLy8gbm90IGJlIGluIGFuIGVycm9yIHN0YXRlLgog ICAgICAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImV2ZW50LnRhcmdldC50YWdOYW1lIiwg IlNPVVJDRSIpOwogICAgICAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmVycm9y IiwgbnVsbCk7CisgICAgICAgICAgICAgICAgICAgIGxhc3RFcnJvckZpcmVkID0gdHJ1ZTsKKyAg ICAgICAgICAgICAgICAgICAgY2hlY2tFbmRUZXN0KCk7CiAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICAgICAgICAgIGNhc2UgMzoKICAgICAgICAgICAgICAgICAgICAgZmFpbFRl c3QoIlVuZXhwZWN0ZWQgJ2Vycm9yJyBldmVudCBmaXJlZCEiKTsKQEAgLTExMywxMyArMTE0LDEy IEBACiAKICAgICAgICAgZnVuY3Rpb24gY2hlY2tFbmRUZXN0KCkKICAgICAgICAgewotICAgICAg ICAgICAgaWYgKGxvYWRlZG1ldGFkYXRhRmlyZWQgJiYgbG9hZGVkRmlyZWQpCisgICAgICAgICAg ICBpZiAobG9hZGVkbWV0YWRhdGFGaXJlZCAmJiBsb2FkZWRGaXJlZCAmJiBsYXN0RXJyb3JGaXJl ZCkKICAgICAgICAgICAgICAgICBlbmRUZXN0KCk7CiAgICAgICAgIH07CiAKICAgICAgICAgZmlu ZE1lZGlhRWxlbWVudCgpOwogCi0gICAgICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWRz dGFydCcsIGxvZ0V2ZW50LCB0cnVlKTsKICAgICAgICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5lcign bG9hZGVkbWV0YWRhdGEnLCBsb2FkZWRtZXRhZGF0YSwgdHJ1ZSk7CiAgICAgICAgIHZpZGVvLmFk ZEV2ZW50TGlzdGVuZXIoJ2JlZm9yZWxvYWQnLCBiZWZvcmVsb2FkLCB0cnVlKTsKICAgICAgICAg dmlkZW8uYWRkRXZlbnRMaXN0ZW5lcignZXJyb3InLCBlcnJvciwgdHJ1ZSk7Cg==