89805 2012-06-23 00:03:51 -0700 [chromium] Return has value, in function returning void 2012-06-23 02:51:22 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned abarth morrita tkent webkit.review.bot oldest_to_newest 656036 0 skyul 2012-06-23 00:03:51 -0700 Make WebFrameImpl::replaceSelection not return a value because it is a function returning void. 656037 1 149168 skyul 2012-06-23 00:06:25 -0700 Created attachment 149168 Patch 656048 2 149168 webkit.review.bot 2012-06-23 02:51:16 -0700 Comment on attachment 149168 Patch Clearing flags on attachment: 149168 Committed r121091: <http://trac.webkit.org/changeset/121091> 656049 3 webkit.review.bot 2012-06-23 02:51:22 -0700 All reviewed patches have been landed. Closing bug. 149168 2012-06-23 00:06:25 -0700 2012-06-23 02:51:16 -0700 Patch bug-89805-20120623160622.patch text/plain 1529 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGExOGVjNDRlNTU4ZDdjOTgyMWYyOTA5NjI5ODE2NTEyNTI3MDg3MmYuLmE3ZTI5NWVhZDJkMDcx ZjNmNDZjNzUzMjNmZWE2NmM3ODM5MDU5OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDYtMjMgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBbY2hyb21pdW1dIFJldHVybiBoYXMgdmFsdWUsIGluIGZ1bmN0 aW9uIHJldHVybmluZyB2b2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04OTgwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1ha2UgV2ViRnJhbWVJbXBsOjpyZXBsYWNlU2VsZWN0aW9uIG5vdCByZXR1cm4g YSB2YWx1ZSBiZWNhdXNlIGl0IGlzIGEgZnVuY3Rpb24gcmV0dXJuaW5nIHZvaWQuCisKKyAgICAg ICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBs OjpyZXBsYWNlU2VsZWN0aW9uKToKKwogMjAxMi0wNi0yMiAgRGF2aWQgR3JvZ2FuICA8ZGdyb2dh bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBBdm9pZCBpbmZpbml0ZSBsb29w IGlmIHdlIHRyeSB0byBlbmNvZGUgLTEgZm9yIGxldmVsZGIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IDg4ZmQ5ZjYxZGU2NTZiYWJhOTk2ZDllNWMz ZTUyYjkzNWVmZTQxY2EuLjhjY2VjNzJiMTJiZTJhMDBlZDc2NjcyMzI4ZDdmZjM3MDU0YmYwNGEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtMTE2 Miw3ICsxMTYyLDcgQEAgdm9pZCBXZWJGcmFtZUltcGw6OnJlcGxhY2VTZWxlY3Rpb24oY29uc3Qg V2ViU3RyaW5nJiB0ZXh0KQogewogICAgIGJvb2wgc2VsZWN0UmVwbGFjZW1lbnQgPSBmYWxzZTsK ICAgICBib29sIHNtYXJ0UmVwbGFjZSA9IHRydWU7Ci0gICAgcmV0dXJuIGZyYW1lKCktPmVkaXRv cigpLT5yZXBsYWNlU2VsZWN0aW9uV2l0aFRleHQodGV4dCwgc2VsZWN0UmVwbGFjZW1lbnQsIHNt YXJ0UmVwbGFjZSk7CisgICAgZnJhbWUoKS0+ZWRpdG9yKCktPnJlcGxhY2VTZWxlY3Rpb25XaXRo VGV4dCh0ZXh0LCBzZWxlY3RSZXBsYWNlbWVudCwgc21hcnRSZXBsYWNlKTsKIH0KIAogdm9pZCBX ZWJGcmFtZUltcGw6Omluc2VydFRleHQoY29uc3QgV2ViU3RyaW5nJiB0ZXh0KQo=