89799 2012-06-22 17:58:49 -0700 Web Inspector: fix timeline window auto-sizing logic 2014-12-12 14:36:37 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 116924 1 caseq caseq apavlov bweinstein keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 655966 0 caseq 2012-06-22 17:58:49 -0700 r120891 introduced logic for automatically sizing of Timeline overview window as a matter of reducing the number of window refreshes while recording a new timeline. This doesn't work when there's a non-default window selected. 0. Open inspector, switch to Timeline panel. 1. Press record, record some events, press stop. 2. Select a window in the middle of overview. 3. Toggle "glue records" button back and forth. 4. Resize window to force a refresh EXPECTED: Window content does not change ACTUAL: Window content changes upon refresh 655968 1 149148 caseq 2012-06-22 18:06:11 -0700 Created attachment 149148 Patch 655970 2 149148 pfeldman 2012-06-22 18:13:05 -0700 Comment on attachment 149148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149148&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:674 > + recordsInWindow.length > lastVisibleLine) { poor indent. 1055239 3 burg 2014-12-12 14:36:37 -0800 Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk. 149148 2012-06-22 18:06:11 -0700 2012-06-22 18:13:05 -0700 Patch bug-89799-20120622180611.patch text/plain 3483 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTMyZmZlNmM2MjVhNGM3 NWNmY2U1OWEwZTE3Y2Q0MzQ4ZjIwNmRlNy4uN2VkODQzOTNlYWZiNDg0MjM0MGRiMTUzOWJmODY4 MjczNTI0NWY2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTIyICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogZml4IHRpbWVsaW5lIHdpbmRvdyBhdXRvLXNpemluZyBsb2dpYworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3OTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IGFwcGx5IHRpbWVsaW5lIHdpbmRv dyBzaXppbmcgbG9naWMgd2hlbiB3ZSdyZSByZWNvcmRpbmcgYSBmcmVzaCB0aW1lbGluZSAKKyAg ICAgICAgYW5kIHRoZSBsZWZ0IHdpbmRvdyBtYXJnaW4gaXMgb24gdGhlIGxlZnQuIAorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlLl90b2dnbGVUaW1lbGluZUJ1dHRvbkNs aWNrZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlLl9y ZXNldFBhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlw ZS5fcmVmcmVzaFJlY29yZHMpOgorCiAyMDEyLTA2LTIyICBKYW4gS2Vyb21uZXMgIDxqYW54QGxp bnV4LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeHRlbnNpb25QYW5lbC5vblNlYXJj aCBsaXN0ZW5lciBkb2Vzbid0IHdvcmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwppbmRleCAzNzJhYjUwYWIwZThjYjc3YjQ2NTBl NzE2NGY1OTNjYWJlMTYzNDdmLi5jZTgzZjgxNWY4ZGY3YWRkYzQ2NWNjMWRkYWY0NDg3ZTYwMDNm MTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVs aW5lUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1l bGluZVBhbmVsLmpzCkBAIC00NDgsNiArNDQ4LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFu ZWwucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy50b2dnbGVUaW1lbGluZUJ1dHRvbi50 b2dnbGVkKQogICAgICAgICAgICAgdGhpcy5fbW9kZWwuc3RvcFJlY29yZCgpOwogICAgICAgICBl bHNlIHsKKyAgICAgICAgICAgIHRoaXMuX2F1dG9tYXRpY2FsbHlTaXplV2luZG93ID0gdHJ1ZTsK ICAgICAgICAgICAgIHRoaXMuX21vZGVsLnN0YXJ0UmVjb3JkKCk7CiAgICAgICAgICAgICBXZWJJ bnNwZWN0b3IudXNlck1ldHJpY3MuVGltZWxpbmVTdGFydGVkLnJlY29yZCgpOwogICAgICAgICB9 CkBAIC01NDksNyArNTUwLDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBl ID0gewogICAgICAgICB0aGlzLl9hZGp1c3RTY3JvbGxQb3NpdGlvbigwKTsKICAgICAgICAgdGhp cy5fY2xvc2VSZWNvcmREZXRhaWxzKCk7CiAgICAgICAgIHRoaXMuX2FsbFJlY29yZHNDb3VudCA9 IDA7Ci0gICAgICAgIHRoaXMuX2F1dG9tYXRpY2FsbHlTaXplV2luZG93ID0gdHJ1ZTsKICAgICB9 LAogCiAgICAgZWxlbWVudHNUb1Jlc3RvcmVTY3JvbGxQb3NpdGlvbnNGb3I6IGZ1bmN0aW9uKCkK QEAgLTY3MCwxMyArNjcwLDE0IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlw ZSA9IHsKICAgICAgICAgdmFyIHN0YXJ0SW5kZXggPSBNYXRoLm1heCgwLCBNYXRoLm1pbihNYXRo LmZsb29yKHZpc2libGVUb3AgLyByb3dIZWlnaHQpIC0gMSwgcmVjb3Jkc0luV2luZG93Lmxlbmd0 aCAtIDEpKTsKICAgICAgICAgdmFyIGVuZEluZGV4ID0gTWF0aC5taW4ocmVjb3Jkc0luV2luZG93 Lmxlbmd0aCwgTWF0aC5jZWlsKHZpc2libGVCb3R0b20gLyByb3dIZWlnaHQpKTsKICAgICAgICAg dmFyIGxhc3RWaXNpYmxlTGluZSA9IE1hdGgubWF4KDAsIE1hdGguZmxvb3IodmlzaWJsZUJvdHRv bSAvIHJvd0hlaWdodCkgLSAxKTsKLSAgICAgICAgaWYgKHRoaXMuX2F1dG9tYXRpY2FsbHlTaXpl V2luZG93ICYmIHJlY29yZHNJbldpbmRvdy5sZW5ndGggPiBsYXN0VmlzaWJsZUxpbmUpIHsKKyAg ICAgICAgaWYgKHRoaXMuX2F1dG9tYXRpY2FsbHlTaXplV2luZG93ICYmIHRoaXMuX292ZXJ2aWV3 UGFuZS53aW5kb3dTdGFydFRpbWUoKSA9PT0gdGhpcy5fbW9kZWwubWluaW11bVJlY29yZFRpbWUo KSAmJgorICAgICAgICAgICAgcmVjb3Jkc0luV2luZG93Lmxlbmd0aCA+IGxhc3RWaXNpYmxlTGlu ZSkgewogICAgICAgICAgICAgdGhpcy5fYXV0b21hdGljYWxseVNpemVXaW5kb3cgPSBmYWxzZTsK ICAgICAgICAgICAgIC8vIElmIHdlJ3JlIGF0IHRoZSB0b3AsIGFsd2F5cyB1c2UgcmVhbCB0aW1l bGluZSBzdGFydCBhcyBhIGxlZnQgd2luZG93IGJvdW5kIHNvIHRoYXQgZXhwYW5zaW9uIGFycm93 IHBhZGRpbmcgbG9naWMgd29ya3MuCi0gICAgICAgICAgICB2YXIgd2luZG93U3RhcnRUaW1lID0g c3RhcnRJbmRleCA/IHJlY29yZHNJbldpbmRvd1tzdGFydEluZGV4XS5zdGFydFRpbWUgOiB0aGlz Ll9tb2RlbC5taW5pbXVtUmVjb3JkVGltZSgpOwotICAgICAgICAgICAgdGhpcy5fb3ZlcnZpZXdQ YW5lLnNldFdpbmRvd1RpbWVzKHdpbmRvd1N0YXJ0VGltZSwgcmVjb3Jkc0luV2luZG93W01hdGgu bWF4KDAsIGxhc3RWaXNpYmxlTGluZSAtIDEpXS5lbmRUaW1lKTsKKyAgICAgICAgICAgIHRoaXMu X292ZXJ2aWV3UGFuZS5zZXRXaW5kb3dUaW1lcyh0aGlzLl9tb2RlbC5taW5pbXVtUmVjb3JkVGlt ZSgpLCByZWNvcmRzSW5XaW5kb3dbTWF0aC5tYXgoMCwgbGFzdFZpc2libGVMaW5lIC0gMSldLmVu ZFRpbWUpOwogICAgICAgICAgICAgcmVjb3Jkc0luV2luZG93ID0gdGhpcy5fcHJlc2VudGF0aW9u TW9kZWwuZmlsdGVyZWRSZWNvcmRzKCk7Ci0gICAgICAgICAgICBlbmRJbmRleCA9IE1hdGgubWlu KHJlY29yZHNJbldpbmRvdy5sZW5ndGgsIGxhc3RWaXNpYmxlTGluZSk7CisgICAgICAgICAgICBz dGFydEluZGV4ID0gMDsKKyAgICAgICAgICAgIGVuZEluZGV4ID0gTWF0aC5taW4ocmVjb3Jkc0lu V2luZG93Lmxlbmd0aCwgTWF0aC5jZWlsKHRoaXMuX2NvbnRhaW5lckVsZW1lbnQuY2xpZW50SGVp Z2h0IC8gcm93SGVpZ2h0KSk7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBSZXNpemUgZ2FwcyBm aXJzdC4K