89793 2012-06-22 16:24:55 -0700 [chromium] Create render surfaces on main thread only for the current frame 2012-07-09 11:37:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89901 1 danakj danakj cc-bugs enne jamesr piman webkit.review.bot wjmaclean zlieber oldest_to_newest 655904 0 danakj 2012-06-22 16:24:55 -0700 [chromium] Create render surfaces on main thread only for the current frame 655914 1 149137 danakj 2012-06-22 16:31:16 -0700 Created attachment 149137 Patch 655916 2 danakj 2012-06-22 16:32:11 -0700 Once I actually make use of this feature, I'll ask for review. 663183 3 danakj 2012-07-04 15:08:58 -0700 ping on this one :) 664959 4 149137 enne 2012-07-09 10:25:45 -0700 Comment on attachment 149137 Patch R=me. 665024 5 149137 webkit.review.bot 2012-07-09 11:37:45 -0700 Comment on attachment 149137 Patch Clearing flags on attachment: 149137 Committed r122120: <http://trac.webkit.org/changeset/122120> 665025 6 webkit.review.bot 2012-07-09 11:37:50 -0700 All reviewed patches have been landed. Closing bug. 149137 2012-06-22 16:31:16 -0700 2012-07-09 11:37:44 -0700 Patch bug-89793-20120622193116.patch text/plain 7148 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODEzMjBhZjQ0N2Q3ODIw ZDZjODZkMGU0Nzk4ZGVhNzcwZWRmNjI5OC4uYzFkYTdiY2I5NGExMDY3MThlMDM0ZmJlYTg3MDJh YjQyYTkxZjg1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA2LTIyICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQ3Jl YXRlIHJlbmRlciBzdXJmYWNlcyBvbiBtYWluIHRocmVhZCBvbmx5IGZvciB0aGUgY3VycmVudCBm cmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3 OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2 aW91c2x5IHdlIHdvdWxkIGNyZWF0ZSByZW5kZXIgc3VyZmFjZXMgZm9yIGFuaW1hdGluZyBsYXll cnMKKyAgICAgICAgaW4gdGhlIG1haW4gdGhyZWFkIHNpbmNlIHRoZXNlIGxheWVycyBtaWdodCBo YXZlIGEgc3VyZmFjZSBvbiBpbXBsLAorICAgICAgICBpbiBvcmRlciB0byBhc3Npc3QgY3VsbGlu Zy4gVGhpcyBtYWtlcyBpdCB2ZXJ5IGRpZmZpY3VsdCB0byBlc3RpbWF0ZQorICAgICAgICBob3cg bXVjaCB0ZXh0dXJlIG1lbW9yeSBpcyBuZWVkZWQgZm9yIFJlbmRlclN1cmZhY2VzIG9uIHRoZSBt YWluCisgICAgICAgIHRocmVhZCwgaW4gb3JkZXIgdG8ga2VlcCBjb250ZW50cytzdXJmYWNlIG1l bW9yeSBiZWxvdyBvdXIgbGltaXQuCisKKyAgICAgICAgSGVyZSB3ZSBzdG9wIGRvaW5nIHRoaXMs IGFuZCBjcmVhdGUgUmVuZGVyU3VyZmFjZXMgb24gYm90aCB0aHJlYWRzCisgICAgICAgIHVuZGVy IHRoZSBzYW1lIGNvbmRpdGlvbnMsIHNvIG1haW4gdGhyZWFkIGhhcyBzdXJmYWNlcyBvbmx5IGlm IHRoZQorICAgICAgICBsYXllcnMgaW4gaXRzIGN1cnJlbnQgZnJhbWUgZGVtYW5kIHRoZW0uIFdo aWxlIHRoaXMgbWF5IHJlZHVjZQorICAgICAgICBwYWludCBjdWxsaW5nIHdpdGhpbiBhbiBhbmlt YXRpbmcgc3VidHJlZSwgdGhpcyBzZWVtcyBsaWtlIGFuIGVkZ2UKKyAgICAgICAgY2FzZSBhbmQg a25vd2luZyB0aGUgYW1vdW50IG9mIHN1cmZhY2UgbWVtb3J5IG5lZWRlZCBmb3IgdGhlIGZyYW1l CisgICAgICAgIGlzIGltcG9ydGFudC4KKworICAgICAgICBBbmltYXRpb24gdGVzdHMgaW4gQ0NM YXllclRyZWVIb3N0Q29tbW9uVGVzdCB1c2VkIHRvIHZlcmlmeSB0aGF0IHRoZXNlCisgICAgICAg IGxheWVycyBnb3Qgc3VyZmFjZXMsIHNvIG5vdyBubyBsb25nZXIgZG8uIENyZWF0aW9uIG9mIHN1 cmZhY2VzIHVuZGVyCisgICAgICAgIG90aGVyIGNvbmRpdGlvbnMgaXMgY292ZXJlZCBieSBvdGhl ciBDQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpzdWJ0cmVlU2hvdWxkUmVuZGVyVG9TZXBhcmF0ZVN1cmZhY2UpOgorCiAyMDEyLTA2LTIw ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IGRvbid0IHJlcG9ydCBjb250ZXh0IGlkcyBiZWZvcmUgRGlkQ29tbWl0TG9hZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA1YjVhMDQ2ZjkxY2M5MGMzNDMyZDc3ZjZjYmE0 ZmY4ZmFhMjk3Y2U3Li4xNGFhZWIzZTRjMTEzOTIwOTNkOTQyOGViZTRlMWE4YWIxYmJmNjUwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2LTIyICBE YW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Q3JlYXRlIHJlbmRlciBzdXJmYWNlcyBvbiBtYWluIHRocmVhZCBvbmx5IGZvciB0aGUgY3VycmVu dCBmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODk3OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHRlc3RzL0NDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QuY3BwOgorCiAyMDEyLTA2LTIwICBaZWV2 IExpZWJlciAgPHpsaWViZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gUmVt b3ZlIHJlZHVuZGFudCAjaW5jbHVkZXMgaW4gY29tcG9zaXRvcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0Q29t bW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND TGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAKaW5kZXggODJkNGIwZjJiNzIwNmU1ZmI0OGE0OGY0MmJk ZjVmYmZhOGQwOTJiNS4uM2RlNDI4YWZjNDE5YWUwNzFkNjg4ZDhjNmE4NDcwYjRlODJhYjAwMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NMYXllclRyZWVIb3N0Q29tbW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RDb21tb24uY3BwCkBAIC0xODgsMTkg KzE4OCw2IEBAIHN0YXRpYyBib29sIGlzU2NhbGVPclRyYW5zbGF0aW9uKGNvbnN0IFdlYlRyYW5z Zm9ybWF0aW9uTWF0cml4JiBtKQogICAgICAgICAgICAmJiBtLm00NCgpOwogfQogCi1zdGF0aWMg aW5saW5lIGJvb2wgbGF5ZXJPcGFjaXR5SXNPcGFxdWUoQ0NMYXllckltcGwqIGxheWVyKQotewot ICAgIHJldHVybiBsYXllci0+b3BhY2l0eSgpID09IDE7Ci19Ci0KLXN0YXRpYyBpbmxpbmUgYm9v bCBsYXllck9wYWNpdHlJc09wYXF1ZShMYXllckNocm9taXVtKiBsYXllcikKLXsKLSAgICAvLyBJ ZiB0aGUgb3BhY2l0eSBpcyBiZWluZyBhbmltYXRlZCB0aGVuIHRoZSBvcGFjaXR5IG9uIHRoZSBt YWluIHRocmVhZCBpcyB1bnJlbGlhYmxlCi0gICAgLy8gKHNpbmNlIHRoZSBpbXBsIHRocmVhZCBt YXkgYmUgdXNpbmcgYSBkaWZmZXJlbnQgb3BhY2l0eSksIHNvIGl0IHNob3VsZCBub3QgYmUgdHJ1 c3RlZC4KLSAgICAvLyBJbiBwYXJ0aWN1bGFyLCBpdCBzaG91bGQgbm90IGJlIHRyZWF0ZWQgYXMg b3BhcXVlLgotICAgIHJldHVybiBsYXllci0+b3BhY2l0eSgpID09IDEgJiYgIWxheWVyLT5vcGFj aXR5SXNBbmltYXRpbmcoKTsKLX0KLQogc3RhdGljIGlubGluZSBib29sIHRyYW5zZm9ybVRvUGFy ZW50SXNLbm93bihDQ0xheWVySW1wbCopCiB7CiAgICAgcmV0dXJuIHRydWU7CkBAIC0yOTYsMTYg KzI4MywxMSBAQCBzdGF0aWMgYm9vbCBzdWJ0cmVlU2hvdWxkUmVuZGVyVG9TZXBhcmF0ZVN1cmZh Y2UoTGF5ZXJUeXBlKiBsYXllciwgYm9vbCBheGlzQWxpZwogICAgICAgICByZXR1cm4gdHJ1ZTsK IAogICAgIC8vIElmIHRoZSBsYXllciBjbGlwcyBpdHMgZGVzY2VuZGFudHMgYnV0IGl0IGlzIG5v dCBheGlzLWFsaWduZWQgd2l0aCByZXNwZWN0IHRvIGl0cyBwYXJlbnQuCi0gICAgLy8gT24gdGhl IG1haW4gdGhyZWFkLCB3aGVuIHRoZSB0cmFuc2Zvcm0gaXMgYmVpbmcgYW5pbWF0ZWQsIGl0IGlz IHRyZWF0ZWQgYXMgdW5rbm93biBhbmQgd2UKLSAgICAvLyBhbHdheXMgZXJyb3Igb24gdGhlIHNp ZGUgb2YgbWFraW5nIGEgcmVuZGVyIHN1cmZhY2UsIHRvIGxldCB1cyBjb25zaWRlciBkZXNjZW5k ZW50cyBhcwotICAgIC8vIG5vdCBhbmltYXRpbmcgcmVsYXRpdmUgdG8gdGhlaXIgdGFyZ2V0IHRv IGFpZCBjdWxsaW5nLgotICAgIGlmIChsYXllci0+bWFza3NUb0JvdW5kcygpICYmICghYXhpc0Fs aWduZWRXaXRoUmVzcGVjdFRvUGFyZW50IHx8ICF0cmFuc2Zvcm1Ub1BhcmVudElzS25vd24obGF5 ZXIpKSAmJiBkZXNjZW5kYW50RHJhd3NDb250ZW50KQorICAgIGlmIChsYXllci0+bWFza3NUb0Jv dW5kcygpICYmICFheGlzQWxpZ25lZFdpdGhSZXNwZWN0VG9QYXJlbnQgJiYgZGVzY2VuZGFudERy YXdzQ29udGVudCkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICAvLyBJZiB0aGUgbGF5ZXIg aGFzIG9wYWNpdHkgIT0gMSBhbmQgZG9lcyBub3QgaGF2ZSBhIHByZXNlcnZlcy0zZCB0cmFuc2Zv cm0gc3R5bGUuCi0gICAgLy8gT24gdGhlIG1haW4gdGhyZWFkLCB3aGVuIG9wYWNpdHkgaXMgYmVp bmcgYW5pbWF0ZWQsIGl0IGlzIHRyZWF0ZWQgYXMgbmVpdGhlciAxCi0gICAgLy8gbm9yIDAuCi0g ICAgaWYgKCFsYXllck9wYWNpdHlJc09wYXF1ZShsYXllcikgJiYgIWxheWVyLT5wcmVzZXJ2ZXMz RCgpICYmIGRlc2NlbmRhbnREcmF3c0NvbnRlbnQpCisgICAgaWYgKGxheWVyLT5vcGFjaXR5KCkg IT0gMSAmJiAhbGF5ZXItPnByZXNlcnZlczNEKCkgJiYgZGVzY2VuZGFudERyYXdzQ29udGVudCkK ICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0 LmNwcAppbmRleCA4OWQyMTFlODFiM2Q1ZmIyNjc0MWFkM2ZkYmMxMDJlYmJiZWQzZmUxLi5iM2Zm ZDY1MjVmMWY2YTYzZDdiOWEyZGE4YjZiZDM2YjllNjM2ZDA1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdC5j cHAKQEAgLTIxODIsNyArMjE4MiwxMSBAQCBURVNUKENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3Qs IHZlcmlmeUFuaW1hdGlvbnNGb3JSZW5kZXJTdXJmYWNlSGllcmFyY2h5KQogICAgIGNoaWxkT2ZS UzEtPmFkZENoaWxkKGdyYW5kQ2hpbGRPZlJTMSk7CiAgICAgY2hpbGRPZlJTMi0+YWRkQ2hpbGQo Z3JhbmRDaGlsZE9mUlMyKTsKIAotICAgIC8vIEluIGNvbWJpbmF0aW9uIHdpdGggZGVzY2VuZGFu dERyYXdzQ29udGVudCwgb3BhY2l0eSAhPSAxIGZvcmNlcyB0aGUgbGF5ZXIgdG8gaGF2ZSBhIG5l dyByZW5kZXJTdXJmYWNlLgorICAgIC8vIE1ha2Ugb3VyIHJlbmRlciBzdXJmYWNlcy4KKyAgICBy ZW5kZXJTdXJmYWNlMS0+c2V0Rm9yY2VSZW5kZXJTdXJmYWNlKHRydWUpOworICAgIHJlbmRlclN1 cmZhY2UyLT5zZXRGb3JjZVJlbmRlclN1cmZhY2UodHJ1ZSk7CisKKyAgICAvLyBQdXQgYW4gYW5p bWF0ZWQgb3BhY2l0eSBvbiB0aGUgcmVuZGVyIHN1cmZhY2UuCiAgICAgYWRkT3BhY2l0eVRyYW5z aXRpb25Ub0NvbnRyb2xsZXIoKnJlbmRlclN1cmZhY2UxLT5sYXllckFuaW1hdGlvbkNvbnRyb2xs ZXIoKSwgMTAsIDEsIDAsIGZhbHNlKTsKIAogICAgIC8vIEFsc28gcHV0IGFuIGFuaW1hdGVkIG9w YWNpdHkgb24gYSBsYXllciB3aXRob3V0IGRlc2NlbmRhbnRzLgpAQCAtMjE5Myw5ICsyMTk3LDgg QEAgVEVTVChDQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LCB2ZXJpZnlBbmltYXRpb25zRm9yUmVu ZGVyU3VyZmFjZUhpZXJhcmNoeSkKICAgICBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeCBzdWJsYXll clRyYW5zZm9ybTsKICAgICBzdWJsYXllclRyYW5zZm9ybS5zY2FsZTNkKDEwLjAsIDEuMCwgMS4w KTsKIAotICAgIC8vIEluIGNvbWJpbmF0aW9uIHdpdGggZGVzY2VuZGFudERyYXdzQ29udGVudCBh bmQgbWFza3NUb0JvdW5kcywgYW4gYW5pbWF0ZWQgdHJhbnNmb3JtIGZvcmNlcyB0aGUgbGF5ZXIg dG8gaGF2ZSBhIG5ldyByZW5kZXJTdXJmYWNlLgorICAgIC8vIFB1dCBhIHRyYW5zZm9ybSBhbmlt YXRpb24gb24gdGhlIHJlbmRlciBzdXJmYWNlLgogICAgIGFkZEFuaW1hdGVkVHJhbnNmb3JtVG9D b250cm9sbGVyKCpyZW5kZXJTdXJmYWNlMi0+bGF5ZXJBbmltYXRpb25Db250cm9sbGVyKCksIDEw LCAzMCwgMCk7Ci0gICAgcmVuZGVyU3VyZmFjZTItPnNldE1hc2tzVG9Cb3VuZHModHJ1ZSk7CiAK ICAgICAvLyBBbHNvIHB1dCB0cmFuc2Zvcm0gYW5pbWF0aW9ucyBvbiBncmFuZENoaWxkT2ZSb290 LCBhbmQgZ3JhbmRDaGlsZE9mUlMyCiAgICAgYWRkQW5pbWF0ZWRUcmFuc2Zvcm1Ub0NvbnRyb2xs ZXIoKmdyYW5kQ2hpbGRPZlJvb3QtPmxheWVyQW5pbWF0aW9uQ29udHJvbGxlcigpLCAxMCwgMzAs IDApOwpAQCAtMjc5Miw5ICsyNzk1LDExIEBAIFRFU1QoQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVz dCwgdmVyaWZ5QmFja0ZhY2VDdWxsaW5nV2l0aEFuaW1hdGluZ1RyYW5zZm9ybXMpCiAgICAgYmFj a2ZhY2VNYXRyaXgucm90YXRlM2QoMCwgMSwgMCwgMTgwKTsKICAgICBiYWNrZmFjZU1hdHJpeC50 cmFuc2xhdGUoLTUwLCAtNTApOwogCi0gICAgLy8gSGF2aW5nIGEgZGVzY2VuZGFudCB0aGF0IGRy YXdzLCBtYXNrc1RvQm91bmRzLCBhbmQgYW5pbWF0aW5nIHRyYW5zZm9ybXMsIHdpbGwgbWFrZSB0 aGUgYW5pbWF0aW5nU3VyZmFjZSBvd24gYSByZW5kZXIgc3VyZmFjZS4KKyAgICAvLyBNYWtlIG91 ciByZW5kZXIgc3VyZmFjZS4KKyAgICBhbmltYXRpbmdTdXJmYWNlLT5zZXRGb3JjZVJlbmRlclN1 cmZhY2UodHJ1ZSk7CisKKyAgICAvLyBBbmltYXRlIHRoZSB0cmFuc2Zvcm0gb24gdGhlIHJlbmRl ciBzdXJmYWNlLgogICAgIGFkZEFuaW1hdGVkVHJhbnNmb3JtVG9Db250cm9sbGVyKCphbmltYXRp bmdTdXJmYWNlLT5sYXllckFuaW1hdGlvbkNvbnRyb2xsZXIoKSwgMTAsIDMwLCAwKTsKLSAgICBh bmltYXRpbmdTdXJmYWNlLT5zZXRNYXNrc1RvQm91bmRzKHRydWUpOwogICAgIC8vIFRoaXMgaXMg anVzdCBhbiBhbmltYXRpbmcgbGF5ZXIsIG5vdCBhIHN1cmZhY2UuCiAgICAgYWRkQW5pbWF0ZWRU cmFuc2Zvcm1Ub0NvbnRyb2xsZXIoKmFuaW1hdGluZ0NoaWxkLT5sYXllckFuaW1hdGlvbkNvbnRy b2xsZXIoKSwgMTAsIDMwLCAwKTsKIAo=