89785 2012-06-22 14:37:08 -0700 REGRESSION(r116446): Crash in RenderBoxModelObject::adjustedPositionRelativeToOffsetParent 2012-06-22 16:30:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 jchaffraix jchaffraix eric inferno shezbaig.wk tony webkit.review.bot oldest_to_newest 655776 0 jchaffraix 2012-06-22 14:37:08 -0700 Sample backtrace: 0x66f497aa [chrome.dll] - renderboxmodelobject.cpp:526] WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent(WebCore::FractionalLayoutPoint const &) 0x66f4965c [chrome.dll] - renderbox.cpp:3839] WebCore::RenderBox::offsetLeft() 0x67554103 [chrome.dll] - rendervideo.cpp:317] WebCore::RenderVideo::offsetLeft() 0x672321ef [chrome.dll] - element.cpp:372] WebCore::Element::offsetLeft() 0x6768aad9 [chrome.dll] - v8element.cpp:74] WebCore::ElementV8Internal::offsetLeftAttrGetter 0x66df9893 [chrome.dll] - objects.cc:203] v8::internal::JSObject::GetPropertyWithCallback(v8::internal::Object *,v8::internal::Object *,v8::internal::String *) 0x66c3e9d1 [chrome.dll] - objects.cc:633] v8::internal::Object::GetProperty(v8::internal::Object *,v8::internal::LookupResult *,v8::internal::String *,PropertyAttributes *) 0x66dba41f [chrome.dll] - ic.cc:933] v8::internal::LoadIC::Load(v8::internal::InlineCacheState,v8::internal::Handle<v8::internal::Object>,v8::internal::Handle<v8::internal::String>) I haven't been able to find out how users are hitting the bug. It's also very infrequent which makes it difficult to find a good reproduction. The bug is fairly obvious once you look at the failing line: referencePoint.move(parent()->offsetForColumns(referencePoint)); We need to NULL-check parent() as is done in offsetParent(). 655828 1 149119 jchaffraix 2012-06-22 15:20:56 -0700 Created attachment 149119 Proposed fix. NULL-check parent. 655844 2 149119 inferno 2012-06-22 15:32:41 -0700 Comment on attachment 149119 Proposed fix. NULL-check parent. View in context: https://bugs.webkit.org/attachment.cgi?id=149119&action=review > LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:16 > + if (window.testRunner) { these four lines are already provided by full-screen-test.js. no need of them here. > LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:28 > + if (window.testRunner) nit: you can just call endTest() function in full-screen-test.js > LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:37 > + if (window.eventSender) nit: you can use the runKeyDown function if you want. 655845 3 inferno 2012-06-22 15:34:01 -0700 typo it is runWithKeyDown (http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/LayoutTests/fullscreen/full-screen-test.js&exact_package=chromium&q=runWithKeyDown&type=cs&l=12) 655860 4 149119 tony 2012-06-22 15:46:11 -0700 Comment on attachment 149119 Proposed fix. NULL-check parent. View in context: https://bugs.webkit.org/attachment.cgi?id=149119&action=review > LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:5 > + font-family: ahem; > + -webkit-font-smoothing: none; > + visibility: hidden; Nit: Are these styles needed? 655873 5 149127 jchaffraix 2012-06-22 16:02:38 -0700 Created attachment 149127 Patch for landing 655878 6 149119 jchaffraix 2012-06-22 16:05:01 -0700 Comment on attachment 149119 Proposed fix. NULL-check parent. View in context: https://bugs.webkit.org/attachment.cgi?id=149119&action=review I ended up rewriting the test to use the helpers. The output should be way better. You can have a look at the new patch to tell me if you are satisfied. Thanks for the review, Abhishek and Tony! >> LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:5 >> + visibility: hidden; > > Nit: Are these styles needed? Removed. I thought they were needed but not really. 655912 7 149127 webkit.review.bot 2012-06-22 16:29:49 -0700 Comment on attachment 149127 Patch for landing Clearing flags on attachment: 149127 Committed r121072: <http://trac.webkit.org/changeset/121072> 655913 8 webkit.review.bot 2012-06-22 16:30:09 -0700 All reviewed patches have been landed. Closing bug. 149119 2012-06-22 15:20:56 -0700 2012-06-22 16:05:01 -0700 Proposed fix. NULL-check parent. bug-89785-20120622152056.patch text/plain 5031 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmIyNTg0MTBhYWQ0OTBj NWUwZmYzZWJjNzE1OWZmOTVhYjM1ZGNiMy4uOTJmOGU2NThhZDY2ZjRlNGQ1Y2EzZmIzMzEzZmUy MjM1NjdkMjgwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTIyICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjExNjQ0Nik6IENyYXNoIGluIFJlbmRlckJveE1vZGVsT2JqZWN0OjphZGp1c3RlZFBvc2l0 aW9uUmVsYXRpdmVUb09mZnNldFBhcmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODk3ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0OiBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWNyYXNoLW9mZnNl dExlZnQuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveE1vZGVsT2JqZWN0OjphZGp1c3RlZFBvc2l0 aW9uUmVsYXRpdmVUb09mZnNldFBhcmVudCk6CisgICAgICAgIEFkZGVkIGEgTlVMTC1jaGVjayBm b3IgcGFyZW50KCkgYXMgaXQgY2FuIGJlIE5VTEwgaW4gZnVsbHNjcmVlbiBtb2RlLiBBbHNvIHVw ZGF0ZWQgYSBzdGFsZQorICAgICAgICBjb21tZW50IHdoaWxlIHRvdWNoaW5nIHRoZSBjb2RlLgor CiAyMDEyLTA2LTIyICBKb2NlbHluIFR1cmNvdHRlICA8dHVyY290dGUuakBnbWFpbC5jb20+CiAK ICAgICAgICAgW1F0XSBGaXggdGhlIHJlbW90ZSBpbnNwZWN0b3IgbG9hZGluZyBwcm9ibGVtcyBv biBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2Rl bE9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmpl Y3QuY3BwCmluZGV4IDBjZDc5N2FlYWZmMmM0ZTFkZTY1MTVkMzJmZjFhYzY4NDY1YmZjZmEuLjQ4 NDVhZjI4NzUxOTA2ZjY3NDNjMzk2MjljNDlmMDg0NWU5NzgzZDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcApAQCAtNTE3LDExICs1 MTcsMTEgQEAgTGF5b3V0U2l6ZSBSZW5kZXJCb3hNb2RlbE9iamVjdDo6cmVsYXRpdmVQb3NpdGlv bk9mZnNldCgpIGNvbnN0CiAKIExheW91dFBvaW50IFJlbmRlckJveE1vZGVsT2JqZWN0OjphZGp1 c3RlZFBvc2l0aW9uUmVsYXRpdmVUb09mZnNldFBhcmVudChjb25zdCBMYXlvdXRQb2ludCYgc3Rh cnRQb2ludCkgY29uc3QKIHsKLSAgICAvLyBJZiB0aGUgZWxlbWVudCBpcyB0aGUgSFRNTCBib2R5 IGVsZW1lbnQgb3IgZG9lcyBub3QgaGF2ZSBhbiBhc3NvY2lhdGVkIGJveAorICAgIC8vIElmIHRo ZSBlbGVtZW50IGlzIHRoZSBIVE1MIGJvZHkgZWxlbWVudCBvciBkb2Vzbid0IGhhdmUgYSBwYXJl bnQKICAgICAvLyByZXR1cm4gMCBhbmQgc3RvcCB0aGlzIGFsZ29yaXRobS4KLSAgICBpZiAoaXNC b2R5KCkpCisgICAgaWYgKGlzQm9keSgpIHx8ICFwYXJlbnQoKSkKICAgICAgICAgcmV0dXJuIExh eW91dFBvaW50KCk7Ci0gICAgCisKICAgICBMYXlvdXRQb2ludCByZWZlcmVuY2VQb2ludCA9IHN0 YXJ0UG9pbnQ7CiAgICAgcmVmZXJlbmNlUG9pbnQubW92ZShwYXJlbnQoKS0+b2Zmc2V0Rm9yQ29s dW1ucyhyZWZlcmVuY2VQb2ludCkpOwogICAgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGFlZjg1MWQ3MzYzM2FmNDQ4M2Y3 ZDZjMDE3ZWEwNjE3MDhjMjg0ZWMuLjQ4NTJmYWY0ODFlN2QyNmEzMWQzMzEyZjI0M2MxZTMwZTQ3 YTFlNjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNi0yMiAgSnVsaWVuIENoYWZmcmFp eCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIxMTY0NDYp OiBDcmFzaCBpbiBSZW5kZXJCb3hNb2RlbE9iamVjdDo6YWRqdXN0ZWRQb3NpdGlvblJlbGF0aXZl VG9PZmZzZXRQYXJlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg5Nzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWNyYXNoLW9mZnNldExlZnQtZXhwZWN0ZWQu aHRtbDogQWRkZWQuCisgICAgICAgICogZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jcmFzaC1vZmZz ZXRMZWZ0Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTA2LTIyICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3Np bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTE3NzM4KTpbRm9ybXNdIHZh bGlkYXRpb25NZXNzYWdlIElETCBhdHRyaWJ1dGUgc2hvdWxkIG5vdCBoYXZlIHJhbmdlIG92ZXJm bG93IG1lc3NhZ2UgaWYgdmFsdWUgaXNuJ3QgcmFuZ2Ugb3ZlcmZsb3cKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tY3Jhc2gtb2Zmc2V0TGVmdC1leHBlY3Rl ZC5odG1sIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jcmFzaC1vZmZzZXRM ZWZ0LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDEyZDViZjkwYzdlNjE1OWVlMDE3OTM5Njhj NjIwZGYwMTM0ZjU2MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4v ZnVsbC1zY3JlZW4tY3Jhc2gtb2Zmc2V0TGVmdC1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMyBA QAorQUxFUlQ6IEJ1ZyA4OTc4NTogUkVHUkVTU0lPTihyMTE2NDQ2KTogQ3Jhc2ggaW4gUmVuZGVy Qm94TW9kZWxPYmplY3Q6OmFkanVzdGVkUG9zaXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50CitB TEVSVDogUEFTU0VELCB0aGUgcGFnZSBkaWRuJ3QgY3Jhc2guCisKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tY3Jhc2gtb2Zmc2V0TGVmdC5odG1sIGIvTGF5 b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jcmFzaC1vZmZzZXRMZWZ0Lmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uZTY5NGI3OTYwYTkwNzVjNGZmNmViOTg3YzA5ODMwNzE5OGM0MGJlOAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tY3Jhc2gtb2Zm c2V0TGVmdC5odG1sCkBAIC0wLDAgKzEsNDIgQEAKKzxzdHlsZT4KK2JvZHkgeworICAgIGZvbnQt ZmFtaWx5OiBhaGVtOworICAgIC13ZWJraXQtZm9udC1zbW9vdGhpbmc6IG5vbmU7CisgICAgdmlz aWJpbGl0eTogaGlkZGVuOworfQorPC9zdHlsZT4KKzxzY3JpcHQgc3JjPSJmdWxsLXNjcmVlbi10 ZXN0LmpzIj48L3NjcmlwdD4KKzxib2R5PgorPHZpZGVvPjwvdmlkZW8+Cis8cD48YSBocmVmPSJo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3ODUiPkJ1ZyA4OTc4NTwv YT46IFJFR1JFU1NJT04ocjExNjQ0Nik6IENyYXNoIGluIFJlbmRlckJveE1vZGVsT2JqZWN0Ojph ZGp1c3RlZFBvc2l0aW9uUmVsYXRpdmVUb09mZnNldFBhcmVudDwvcD4KKzxwPlRvIG1hbnVhbGx5 IHRlc3QgdGhpcyBwYWdlLCBzd2l0Y2ggdG8gZnVsbHNjcmVlbiwgdGhlIHBhZ2Ugc2hvdWxkbid0 IENSQVNILjwvcD4KKzwvYm9keT4KKzxzY3JpcHQ+CisgICAgaWYgKCJ3ZWJraXRSZXF1ZXN0RnVs bFNjcmVlbiIgaW4gRWxlbWVudC5wcm90b3R5cGUpIHsKKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyKSB7CisgICAgICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAg ICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgICB9CisKKyAgICAgICAgdmlk ZW8gPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgidmlkZW8iKVswXTsKKyAgICAgICAg dmFyIGZ1bGxzY3JlZW5DaGFuZ2VkID0gZnVuY3Rpb24oZXZlbnQpCisgICAgICAgIHsKKyAgICAg ICAgICAgIHZpZGVvLm9mZnNldExlZnQ7CisgICAgICAgICAgICB2aWRlby5vZmZzZXRUb3A7Cisg ICAgICAgICAgICBhbGVydCgiQnVnIDg5Nzg1OiBSRUdSRVNTSU9OKHIxMTY0NDYpOiBDcmFzaCBp biBSZW5kZXJCb3hNb2RlbE9iamVjdDo6YWRqdXN0ZWRQb3NpdGlvblJlbGF0aXZlVG9PZmZzZXRQ YXJlbnQiKTsKKyAgICAgICAgICAgIGFsZXJ0KCJQQVNTRUQsIHRoZSBwYWdlIGRpZG4ndCBjcmFz aC4iKTsKKyAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgCisgICAgICAgICAgICAg ICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisKKyAgICAgICAgfTsKKyAgICAgICAgZG9jdW1l bnQuYWRkRXZlbnRMaXN0ZW5lcignd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsIGZ1bGxzY3JlZW5D aGFuZ2VkKTsKKworICAgICAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCdrZXlkb3duJywg ZnVuY3Rpb24gKCkgeworICAgICAgICAgICAgdmlkZW8ud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4o KTsKKyAgICAgICAgfSk7CisgICAgICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpCisgICAgICAg ICAgICBldmVudFNlbmRlci5rZXlEb3duKCdhJyk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgYWxl cnQoIkZBSUxFRCwgY291bGRuJ3QgZmluZCB3ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbi4iKTsKKyAg ICB9Cis8L3NjcmlwdD4K 149127 2012-06-22 16:02:38 -0700 2012-06-22 16:29:48 -0700 Patch for landing bug-89785-20120622160237.patch text/plain 4629 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmIyNTg0MTBhYWQ0OTBj NWUwZmYzZWJjNzE1OWZmOTVhYjM1ZGNiMy4uNGU5YjIxYTE0NzVhYzM3N2I5MjZmOTRiNTcwMWZk NjJiM2FmYmMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTIyICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjExNjQ0Nik6IENyYXNoIGluIFJlbmRlckJveE1vZGVsT2JqZWN0OjphZGp1c3RlZFBvc2l0 aW9uUmVsYXRpdmVUb09mZnNldFBhcmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODk3ODUKKworICAgICAgICBSZXZpZXdlZCBieSBBYmhpc2hlayBB cnlhLgorCisgICAgICAgIFRlc3Q6IGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tY3Jhc2gtb2Zmc2V0 TGVmdC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OmFkanVzdGVkUG9zaXRp b25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50KToKKyAgICAgICAgQWRkZWQgYSBOVUxMLWNoZWNrIGZv ciBwYXJlbnQoKSBhcyBpdCBjYW4gYmUgTlVMTCBpbiBmdWxsc2NyZWVuIG1vZGUuIEFsc28gdXBk YXRlZCBhIHN0YWxlCisgICAgICAgIGNvbW1lbnQgd2hpbGUgdG91Y2hpbmcgdGhlIGNvZGUuCisK IDIwMTItMDYtMjIgIEpvY2VseW4gVHVyY290dGUgIDx0dXJjb3R0ZS5qQGdtYWlsLmNvbT4KIAog ICAgICAgICBbUXRdIEZpeCB0aGUgcmVtb3RlIGluc3BlY3RvciBsb2FkaW5nIHByb2JsZW1zIG9u IE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVs T2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVj dC5jcHAKaW5kZXggMGNkNzk3YWVhZmYyYzRlMWRlNjUxNWQzMmZmMWFjNjg0NjViZmNmYS4uNDg0 NWFmMjg3NTE5MDZmNjc0M2MzOTYyOWM0OWYwODQ1ZTk3ODNkOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCkBAIC01MTcsMTEgKzUx NywxMSBAQCBMYXlvdXRTaXplIFJlbmRlckJveE1vZGVsT2JqZWN0OjpyZWxhdGl2ZVBvc2l0aW9u T2Zmc2V0KCkgY29uc3QKIAogTGF5b3V0UG9pbnQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmFkanVz dGVkUG9zaXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50KGNvbnN0IExheW91dFBvaW50JiBzdGFy dFBvaW50KSBjb25zdAogewotICAgIC8vIElmIHRoZSBlbGVtZW50IGlzIHRoZSBIVE1MIGJvZHkg ZWxlbWVudCBvciBkb2VzIG5vdCBoYXZlIGFuIGFzc29jaWF0ZWQgYm94CisgICAgLy8gSWYgdGhl IGVsZW1lbnQgaXMgdGhlIEhUTUwgYm9keSBlbGVtZW50IG9yIGRvZXNuJ3QgaGF2ZSBhIHBhcmVu dAogICAgIC8vIHJldHVybiAwIGFuZCBzdG9wIHRoaXMgYWxnb3JpdGhtLgotICAgIGlmIChpc0Jv ZHkoKSkKKyAgICBpZiAoaXNCb2R5KCkgfHwgIXBhcmVudCgpKQogICAgICAgICByZXR1cm4gTGF5 b3V0UG9pbnQoKTsKLSAgICAKKwogICAgIExheW91dFBvaW50IHJlZmVyZW5jZVBvaW50ID0gc3Rh cnRQb2ludDsKICAgICByZWZlcmVuY2VQb2ludC5tb3ZlKHBhcmVudCgpLT5vZmZzZXRGb3JDb2x1 bW5zKHJlZmVyZW5jZVBvaW50KSk7CiAgICAgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWVmODUxZDczNjMzYWY0NDgzZjdk NmMwMTdlYTA2MTcwOGMyODRlYy4uOWM2MzM4OTM5ODg4MTI4ZjM0YWVjMjMxODhlYjQwODc0YTg2 YmJiMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA2LTIyICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjExNjQ0Nik6 IENyYXNoIGluIFJlbmRlckJveE1vZGVsT2JqZWN0OjphZGp1c3RlZFBvc2l0aW9uUmVsYXRpdmVU b09mZnNldFBhcmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODk3ODUKKworICAgICAgICBSZXZpZXdlZCBieSBBYmhpc2hlayBBcnlhLgorCisgICAg ICAgICogZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jcmFzaC1vZmZzZXRMZWZ0LWV4cGVjdGVkLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tY3Jhc2gtb2Zmc2V0 TGVmdC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNi0yMiAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjExNzczOCk6W0Zvcm1zXSB2YWxp ZGF0aW9uTWVzc2FnZSBJREwgYXR0cmlidXRlIHNob3VsZCBub3QgaGF2ZSByYW5nZSBvdmVyZmxv dyBtZXNzYWdlIGlmIHZhbHVlIGlzbid0IHJhbmdlIG92ZXJmbG93CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWNyYXNoLW9mZnNldExlZnQtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jcmFzaC1vZmZzZXRMZWZ0 LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNWQyYzM5YjgwNDIyNzdjZDQ5NzAxOTA0YzA2YWIz NGI5ZTY4MTgwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxs LXNjcmVlbi1jcmFzaC1vZmZzZXRMZWZ0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK0J1 ZyA4OTc4NTogUkVHUkVTU0lPTihyMTE2NDQ2KTogQ3Jhc2ggaW4gUmVuZGVyQm94TW9kZWxPYmpl Y3Q6OmFkanVzdGVkUG9zaXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50CisKK1BBU1NFRCwgdGhl IHBhZ2UgZGlkbid0IGNyYXNoLgorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jcmFzaC1vZmZzZXRMZWZ0Lmh0bWwgYi9MYXlvdXRU ZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWNyYXNoLW9mZnNldExlZnQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi42OWE3ZjllZmY5MDkyMjY4YjE5ZWUxMzBjNDY2NzU2YTE3YzMxYjlmCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1jcmFzaC1vZmZzZXRM ZWZ0Lmh0bWwKQEAgLTAsMCArMSwzMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5 PgorPHZpZGVvPjwvdmlkZW8+Cis8cD48YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODk3ODUiPkJ1ZyA4OTc4NTwvYT46IFJFR1JFU1NJT04ocjExNjQ0Nik6 IENyYXNoIGluIFJlbmRlckJveE1vZGVsT2JqZWN0OjphZGp1c3RlZFBvc2l0aW9uUmVsYXRpdmVU b09mZnNldFBhcmVudDwvcD4KKzxzY3JpcHQgc3JjPSJmdWxsLXNjcmVlbi10ZXN0LmpzIj48L3Nj cmlwdD4KKzxzY3JpcHQ+CisgICAgaWYgKCJ3ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbiIgaW4gRWxl bWVudC5wcm90b3R5cGUpIHsKKyAgICAgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAg ICAgICAgIGNvbnNvbGVXcml0ZSgiVG8gbWFudWFsbHkgdGVzdCB0aGlzIGJ1Zywgc3dpdGNoIHRv IGZ1bGxzY3JlZW4uIEl0IHNob3VsZG4ndCBjcmFzaC4iKTsKKworICAgICAgICB2aWRlbyA9IGRv Y3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJ2aWRlbyIpWzBdOworICAgICAgICB2YXIgZnVs bHNjcmVlbkNoYW5nZWQgPSBmdW5jdGlvbihldmVudCkKKyAgICAgICAgeworICAgICAgICAgICAg dmlkZW8ub2Zmc2V0TGVmdDsKKyAgICAgICAgICAgIHZpZGVvLm9mZnNldFRvcDsKKyAgICAgICAg ICAgIGNvbnNvbGVXcml0ZSgiUEFTU0VELCB0aGUgcGFnZSBkaWRuJ3QgY3Jhc2guIik7CisgICAg ICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgIH07CisgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50 TGlzdGVuZXIoJ3dlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UnLCBmdWxsc2NyZWVuQ2hhbmdlZCk7CisK KyAgICAgICAgcnVuV2l0aEtleURvd24oZnVuY3Rpb24gKCkgeworICAgICAgICAgICAgdmlkZW8u d2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oKTsKKyAgICAgICAgfSk7CisgICAgfSBlbHNlIHsKKyAg ICAgICAgY29uc29sZVdyaXRlKCJGQUlMRUQsIGNvdWxkbid0IGZpbmQgd2Via2l0UmVxdWVzdEZ1 bGxTY3JlZW4uIik7CisgICAgICAgIGVuZFRlc3QoKTsKKyAgICB9Cis8L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4K