89774 2012-06-22 11:29:40 -0700 [V8] Clean up visitDOMWrapper code 2012-06-22 11:55:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv abarth haraken japhet jochen webkit.review.bot oldest_to_newest 655649 0 arv 2012-06-22 11:29:40 -0700 [V8] Clean up visitDOMWrapper code 655653 1 149073 arv 2012-06-22 11:32:30 -0700 Created attachment 149073 Patch 655664 2 149073 tony 2012-06-22 11:46:04 -0700 Comment on attachment 149073 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149073&action=review > Source/WebCore/ChangeLog:8 > + This moves the check if domWrapperVisitorFunction is null into a function of the WrapperTypeInfo struct. Nit: Please explain why we're making this change (i.e., for consistency). 655673 3 arv 2012-06-22 11:55:14 -0700 Committed r121047: <http://trac.webkit.org/changeset/121047> 149073 2012-06-22 11:32:30 -0700 2012-06-22 11:46:03 -0700 Patch bug-89774-20120622113227.patch text/plain 2700 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ1MmM0NTU1ZTA1Yjc4 OWMwNGU4ZDAxYzMzNWQ1ZWMwYmJmZDg2Ny4uNGFhNjA1YTQyYTU4NDg2MThlMzlhNmE4YzI5NmIz YjJmMDQxMmZiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA2LTIyICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Y4XSBDbGVhbiB1cCB2 aXNpdERPTVdyYXBwZXIgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODk3NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIG1vdmVzIHRoZSBjaGVjayBpZiBkb21XcmFwcGVyVmlzaXRvckZ1bmN0 aW9uIGlzIG51bGwgaW50byBhIGZ1bmN0aW9uIG9mIHRoZSBXcmFwcGVyVHlwZUluZm8gc3RydWN0 LgorCisgICAgICAgIFRoaXMgaXMgYSBmb2xsb3cgdXAgY2hhbmdlIHRvIGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzEyMDg1NC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVy ZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJv bGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcm91cGVyVmlzaXRvcjo6dmlzaXRET01XcmFw cGVyKTogQ2FsbCBXcmFwcGVyVHlwZUluZm86OnZpc2l0RE9NV3JhcHBlciBpbnN0ZWFkLgorICAg ICAgICAqIGJpbmRpbmdzL3Y4L1dyYXBwZXJUeXBlSW5mby5oOgorICAgICAgICAoV3JhcHBlclR5 cGVJbmZvKToKKyAgICAgICAgKFdlYkNvcmU6OldyYXBwZXJUeXBlSW5mbzo6dmlzaXRET01XcmFw cGVyKTogSWYgZG9tV3JhcHBlclZpc2l0b3JGdW5jdGlvbiBpcyBub24gbnVsbCBjYWxsIGl0Lgor CiAyMDEyLTA2LTIyICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTIxMDI1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCmluZGV4IGZmODVmNTMwZmM1NmU3MWNmODdmYzNj YjY3MjFhNTJjN2ViYzdmZDQuLjk5MWU4OGI1YzY2ZWZiYWI4ZjJkOTEyMDk1NmIzZjg0YzRkMDg3 MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAK QEAgLTM0MSw4ICszNDEsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCB2aXNpdERPTVdyYXBwZXIoRE9N RGF0YVN0b3JlKiBzdG9yZSwgdm9pZCogb2JqZWN0LCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0 PiB3cmFwcGVyKQogICAgIHsKICAgICAgICAgV3JhcHBlclR5cGVJbmZvKiBpbmZvID0gVjhET01X cmFwcGVyOjpkb21XcmFwcGVyVHlwZSh3cmFwcGVyKTsKLSAgICAgICAgaWYgKGluZm8tPmRvbVdy YXBwZXJWaXNpdG9yRnVuY3Rpb24pCi0gICAgICAgICAgICBpbmZvLT5kb21XcmFwcGVyVmlzaXRv ckZ1bmN0aW9uKHN0b3JlLCBvYmplY3QsIHdyYXBwZXIpOworICAgICAgICBpbmZvLT52aXNpdERP TVdyYXBwZXIoc3RvcmUsIG9iamVjdCwgd3JhcHBlcik7CiAgICAgfQogCiAgICAgdm9pZCBhcHBs eUdyb3VwaW5nKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dyYXBw ZXJUeXBlSW5mby5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV3JhcHBlclR5cGVJbmZv LmgKaW5kZXggYWZjMGM4NzU1M2ZlNjM3MDQ3NTBlYzk5ZmRjOGZjOWNjNDBjMTcxMC4uNjQzYzBi YzI2MDk4YzU5OWFkYmRjY2JmMDNkOGY1MGNkOTA1NjVlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvV3JhcHBlclR5cGVJbmZvLmgKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvV3JhcHBlclR5cGVJbmZvLmgKQEAgLTk0LDcgKzk0LDEzIEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgICAgIHJldHVy biB0b0FjdGl2ZURPTU9iamVjdEZ1bmN0aW9uKG9iamVjdCk7CiAgICAgICAgIH0KLSAgICAgICAg CisKKyAgICAgICAgdm9pZCB2aXNpdERPTVdyYXBwZXIoRE9NRGF0YVN0b3JlKiBzdG9yZSwgdm9p ZCogb2JqZWN0LCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQorICAgICAgICB7 CisgICAgICAgICAgICBpZiAoZG9tV3JhcHBlclZpc2l0b3JGdW5jdGlvbikKKyAgICAgICAgICAg ICAgICBkb21XcmFwcGVyVmlzaXRvckZ1bmN0aW9uKHN0b3JlLCBvYmplY3QsIHdyYXBwZXIpOwor ICAgICAgICB9CisKICAgICAgICAgY29uc3QgR2V0VGVtcGxhdGVGdW5jdGlvbiBnZXRUZW1wbGF0 ZUZ1bmN0aW9uOwogICAgICAgICBjb25zdCBEZXJlZk9iamVjdEZ1bmN0aW9uIGRlcmVmT2JqZWN0 RnVuY3Rpb247CiAgICAgICAgIGNvbnN0IFRvQWN0aXZlRE9NT2JqZWN0RnVuY3Rpb24gdG9BY3Rp dmVET01PYmplY3RGdW5jdGlvbjsK