89772 2012-06-22 11:21:54 -0700 [BlackBerry] Tap highlight fade animations are added to overlay continuously during pinch zoom. 2012-06-22 12:17:06 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo levin+threading tonikitoo webkit.review.bot oldest_to_newest 655632 0 anlo 2012-06-22 11:21:54 -0700 When pinch zooming & setting scroll position, the UI thread calls DefaultTapHighlight::hide continuously to make sure it isn't visible. Calling hide when it is already hidden should do nothing. However calling it from the UI thread now keeps creating & adding fade animations, since the visible flag check is in the webkit thread branch only. This results in the tap highlight being visible during zoom after the first fade out. 655646 1 149072 anlo 2012-06-22 11:27:53 -0700 Created attachment 149072 Patch 655685 2 149072 webkit.review.bot 2012-06-22 12:16:48 -0700 Comment on attachment 149072 Patch Clearing flags on attachment: 149072 Committed r121049: <http://trac.webkit.org/changeset/121049> 655686 3 webkit.review.bot 2012-06-22 12:17:06 -0700 All reviewed patches have been landed. Closing bug. 149072 2012-06-22 11:27:53 -0700 2012-06-22 12:16:47 -0700 Patch bug-89772-20120622142921.patch text/plain 3892 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA1Njg5N2FhM2UyMWJmNzA3ZWMxZTlhNmRiNTM2NDAwYWNlMzg5ZTA1Li43YTNhZTI5ODQz NDA2YzY5MDQ0ZDEzMzRmYjk5NjNmNWNkOWU2NTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMi0wNi0yMiAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBUYXAgaGlnaGxpZ2h0IGZhZGUgYW5pbWF0aW9u cyBhcmUgYWRkZWQgdG8gb3ZlcmxheSBjb250aW51b3VzbHkgZHVyaW5nIHBpbmNoIHpvb20uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTc3MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gcGluY2gg em9vbWluZywgRGVmYXVsdFRhcEhpZ2hsaWdodDo6aGlkZSBpcyBjb250aW51b3VzbHkKKyAgICAg ICAgY2FsbGVkIGZyb20gdGhlIFVJIHRocmVhZC4gVGhpcyByZXN1bHRlZCBpbiBmYWRlIGFuaW1h dGlvbnMgYmVpbmcKKyAgICAgICAgY3JlYXRlZCBhbmQgYWRkZWQgdG8gdGhlIG92ZXJyaWRlIG92 ZXJsYXkgY29udGludW91c2x5LgorCisgICAgICAgIFRoaXMgcGF0Y2ggbW92ZXMgdGhlIG1fdmlz aWJsZSBjaGVjayBzbyB0aGF0IGl0IGFwcGxpZXMgZm9yIGJvdGgKKyAgICAgICAgdGhyZWFkcy4K KworICAgICAgICBJbnRlcm5hbCBQUjE2NDE4MworCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9E ZWZhdWx0VGFwSGlnaGxpZ2h0LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6RGVm YXVsdFRhcEhpZ2hsaWdodDo6ZHJhdyk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkRl ZmF1bHRUYXBIaWdobGlnaHQ6OmhpZGUpOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvRGVmYXVs dFRhcEhpZ2hsaWdodC5oOgorICAgICAgICAoRGVmYXVsdFRhcEhpZ2hsaWdodCk6CisKIDIwMTIt MDYtMTkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgQ2FsbGluZyBuYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpIGNhdXNlcyBhc3NlcnRpb24g ZmFpbHVyZTogbV92ZXJpZmllci5pc1NhZmVUb1VzZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFwSGlnaGxpZ2h0LmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RlZmF1bHRUYXBIaWdobGlnaHQu Y3BwCmluZGV4IDRjYzU2NWU2MzNjYTY1ZGY5YjE3MGYzMWYwYzdiZDJlMGUzYWUzMGQuLjc0YzFi ZmFlMzlhYTc4NDhhZmZmNTVhNThmNmYwMWQ2NTU1MGY1ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RlZmF1bHRUYXBIaWdobGlnaHQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RlZmF1bHRUYXBIaWdo bGlnaHQuY3BwCkBAIC02MSw3ICs2MSwxMCBAQCB2b2lkIERlZmF1bHRUYXBIaWdobGlnaHQ6OmRy YXcoY29uc3QgUGxhdGZvcm06OkludFJlY3RSZWdpb24mIHJlZ2lvbiwgaW50IHJlZCwgaQogICAg IGlmIChyZWN0LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV92aXNpYmxlID0g dHJ1ZTsKKyAgICB7CisgICAgICAgIE11dGV4TG9ja2VyIGxvY2sobV9tdXRleCk7CisgICAgICAg IG1fdmlzaWJsZSA9IHRydWU7CisgICAgfQogCiAgICAgaWYgKCFtX292ZXJsYXkpIHsKICAgICAg ICAgbV9vdmVybGF5ID0gYWRvcHRQdHIobmV3IFdlYk92ZXJsYXkodGhpcykpOwpAQCAtODIsMTgg Kzg1LDIyIEBAIHZvaWQgRGVmYXVsdFRhcEhpZ2hsaWdodDo6aGlkZSgpCiAgICAgaWYgKCFtX292 ZXJsYXkpCiAgICAgICAgIHJldHVybjsKIAorICAgIHsKKyAgICAgICAgTXV0ZXhMb2NrZXIgbG9j ayhtX211dGV4KTsKKyAgICAgICAgaWYgKCFtX3Zpc2libGUpCisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIG1fdmlzaWJsZSA9IGZhbHNlOworICAgIH0KKwogICAgIC8vIFNpbmNlIFdlYkFu aW1hdGlvbiBpcyBub3QgdGhyZWFkIHNhZmUsIHdlIGNyZWF0ZSBhIG5ldyBvbmUgZWFjaCB0aW1l IGluc3RlYWQgb2YgcmV1c2luZyB0aGUgc2FtZSBvYmplY3Qgb24gZGlmZmVyZW50CiAgICAgLy8g dGhyZWFkcyAodGhhdCB3b3VsZCBpbnRyb2R1Y2UgcmFjZSBjb25kaXRpb25zKS4KICAgICBXZWJB bmltYXRpb24gZmFkZUFuaW1hdGlvbiA9IFdlYkFuaW1hdGlvbjo6ZmFkZUFuaW1hdGlvbihmYWRl QW5pbWF0aW9uTmFtZSgpLCAxLjAsIDAuMCwgQWN0aXZlVGV4dEZhZGVBbmltYXRpb25EdXJhdGlv bik7CiAKICAgICAvLyBOb3JtYWxseSwgdGhpcyBtZXRob2QgaXMgY2FsbGVkIG9uIHRoZSBXZWJL aXQgdGhyZWFkLCBidXQgaXQgY2FuIGFsc28gYmUKICAgICAvLyBjYWxsZWQgZnJvbSB0aGUgY29t cG9zaXRpbmcgdGhyZWFkLgotICAgIGlmIChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6d2ViS2l0VGhy ZWFkTWVzc2FnZUNsaWVudCgpLT5pc0N1cnJlbnRUaHJlYWQoKSkgewotICAgICAgICBpZiAoIW1f dmlzaWJsZSkKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgbV92aXNpYmxlID0gZmFsc2U7 CisgICAgaWYgKEJsYWNrQmVycnk6OlBsYXRmb3JtOjp3ZWJLaXRUaHJlYWRNZXNzYWdlQ2xpZW50 KCktPmlzQ3VycmVudFRocmVhZCgpKQogICAgICAgICBtX292ZXJsYXktPmFkZEFuaW1hdGlvbihm YWRlQW5pbWF0aW9uKTsKLSAgICB9IGVsc2UgaWYgKEJsYWNrQmVycnk6OlBsYXRmb3JtOjp1c2Vy SW50ZXJmYWNlVGhyZWFkTWVzc2FnZUNsaWVudCgpLT5pc0N1cnJlbnRUaHJlYWQoKSkKKyAgICBl bHNlIGlmIChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6dXNlckludGVyZmFjZVRocmVhZE1lc3NhZ2VD bGllbnQoKS0+aXNDdXJyZW50VGhyZWFkKCkpCiAgICAgICAgIG1fb3ZlcmxheS0+b3ZlcnJpZGUo KS0+YWRkQW5pbWF0aW9uKGZhZGVBbmltYXRpb24pOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFwSGlnaGxpZ2h0LmggYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFwSGlnaGxpZ2h0 LmgKaW5kZXggZmRmNjMyYTUwZmZjMzIxYWZiYzFkMjY1MTljOWQwYWY4ZTg1YjNmNy4uNzJlYTQw MjUxMjY3ODUzMTZhYjc5YThmZDNiYWFmMmYzY2Q0ZDBjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRGVmYXVsdFRhcEhpZ2hsaWdodC5oCisrKyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RlZmF1bHRUYXBIaWdobGln aHQuaApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUludFJl Y3RSZWdpb24uaD4KICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NP d25QdHIuaD4KKyNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAKIG5hbWVzcGFjZSBCbGFja0Jl cnJ5IHsKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtNjksNiArNzAsNyBAQCBwcml2YXRlOgogICAg IFdlYkNvcmU6OkNvbG9yIG1fY29sb3I7CiAgICAgYm9vbCBtX3Zpc2libGU7CiAgICAgYm9vbCBt X3Nob3VsZEhpZGVBZnRlclNjcm9sbDsKKyAgICBNdXRleCBtX211dGV4OwogfTsKIAogfSAvLyBu YW1lc3BhY2UgV2ViS2l0Cg==