89770 2012-06-22 11:02:28 -0700 [Gtk] REGRESSION(r120918): Causes flaky DND tests 2012-06-23 22:32:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan dsd gustavo mrobinson oldest_to_newest 655604 0 zan 2012-06-22 11:02:28 -0700 r120918[1] caused some drag-and-drop tests in fast/events to start failing, however they pass when rerun and are therefor categorized as flaky. I'll not add expectations for these just yet as I'm hoping the issue will be resolved quickly. [1] - http://trac.webkit.org/changeset/120918/ 656038 1 149169 zan 2012-06-23 00:23:00 -0700 Created attachment 149169 Patch 656039 2 zan 2012-06-23 00:33:32 -0700 (In reply to comment #1) > Created an attachment (id=149169) [details] > Patch It turns out fast/events/domactivate-sets-underlying-click-event-as-handled.html was timing out because of the modal dialog being run in the previous implementation of ChromeClient::runOpenPanel. Current implementation of that method displays the dialog in a non-modal way though, but that's causing problems in drag-and-drop tests as the dialog stays around. The solution is to not show any file chooser dialog by returning TRUE in web view's run-file-chooser signal handler. 656164 3 149169 zan 2012-06-23 22:32:13 -0700 Comment on attachment 149169 Patch Clearing flags on attachment: 149169 Committed r121109: <http://trac.webkit.org/changeset/121109> 656165 4 zan 2012-06-23 22:32:20 -0700 All reviewed patches have been landed. Closing bug. 149169 2012-06-23 00:23:00 -0700 2012-06-23 22:32:13 -0700 Patch bug-89770-20120623092300.patch text/plain 3713 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjAzMzUyMjU1YzBmMWE3YjEyZDYxZjIwNDg4YTc1OTQ3 MzA0NTRmZS4uM2VlODMzMGVkZTRlNDJjYTA4NzIyNGQ1YzlkOGYzMTk1OGVjNzIyYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA2LTIzICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0d0a10gUkVHUkVTU0lPTihyMTIwOTE4KTogQ2F1c2VzIGZsYWt5IERORCB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3NzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb25uZWN0 IHRvIHRoZSBydW4tZmlsZS1jaG9vc2VyIHNpZ25hbCBvZiB0aGUgV2ViS2l0V2ViVmlldyBhbmQK KyAgICAgICAgcmV0dXJuIFRSVUUgc28gbm8gZmlsZSBjaG9vc2VyIGRpYWxvZyBpcyBydW4uIFRo aXMgcHJldmVudHMgY2VydGFpbgorICAgICAgICB0ZXN0IGZhaWx1cmVzLgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHdlYlZpZXdS dW5GaWxlQ2hvb3Nlcik6CisgICAgICAgIChjcmVhdGVXZWJWaWV3KToKKwogMjAxMi0wNi0yMiAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gRHVt cFJlbmRlclRyZWUgb24gQW5kcm9pZCBuZWVkcyB0byBjb25maWd1cmUgZm9udHMgZm9yIHRlc3Rp bmcKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5j cHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IDk3 NDBkMjc2ZmEyYzMxNTQ5YTU4N2QyNzJjNzAwOTdjNzRjMzBjMDEuLjE5Yjk2NjY5NTdjMWE0OWM5 NzFlMWI1ZTQxMTZlZTU4YzliY2MyODMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1 bXBSZW5kZXJUcmVlLmNwcApAQCAtMTI3Myw2ICsxMjczLDEzIEBAIHN0YXRpYyB2b2lkIGRpZFJ1 bkluc2VjdXJlQ29udGVudChXZWJLaXRXZWJGcmFtZSosIFdlYktpdFNlY3VyaXR5T3JpZ2luKiwg Y29uc3QKICAgICAgICAgcHJpbnRmKCJkaWRSdW5JbnNlY3VyZUNvbnRlbnRcbiIpOwogfQogCitz dGF0aWMgZ2Jvb2xlYW4gd2ViVmlld1J1bkZpbGVDaG9vc2VyKFdlYktpdFdlYlZpZXcqLCBXZWJL aXRGaWxlQ2hvb3NlclJlcXVlc3QqKQoreworICAgIC8vIFdlIHJldHVybiBUUlVFIHRvIG5vdCBw cm9wYWdhdGUgdGhlIGV2ZW50IGZ1cnRoZXIgc28gdGhlCisgICAgLy8gZGVmYXVsdCBmaWxlIGNo b29zZXIgZGlhbG9nIGlzIG5vdCBzaG93bi4KKyAgICByZXR1cm4gVFJVRTsKK30KKwogc3RhdGlj IFdlYktpdFdlYlZpZXcqIGNyZWF0ZVdlYlZpZXcoKQogewogICAgIC8vIEl0IGlzIGltcG9ydGFu dCB0byBkZWNsYXJlIERSVCBpcyBydW5uaW5nIGVhcmx5IHNvIHdoZW4gY3JlYXRpbmcKQEAgLTEz MDcsNiArMTMxNCw3IEBAIHN0YXRpYyBXZWJLaXRXZWJWaWV3KiBjcmVhdGVXZWJWaWV3KCkKICAg ICAgICAgICAgICAgICAgICAgICJzaWduYWw6OnJlc291cmNlLXJlc3BvbnNlLXJlY2VpdmVkIiwg ZGlkUmVjZWl2ZVJlc3BvbnNlLCAwLAogICAgICAgICAgICAgICAgICAgICAgInNpZ25hbDo6cmVz b3VyY2UtbG9hZC1maW5pc2hlZCIsIGRpZEZpbmlzaExvYWRpbmcsIDAsCiAgICAgICAgICAgICAg ICAgICAgICAic2lnbmFsOjpyZXNvdXJjZS1sb2FkLWZhaWxlZCIsIGRpZEZhaWxMb2FkaW5nV2l0 aEVycm9yLCAwLAorICAgICAgICAgICAgICAgICAgICAgInNpZ25hbDo6cnVuLWZpbGUtY2hvb3Nl ciIsIHdlYlZpZXdSdW5GaWxlQ2hvb3NlciwgMCwKICAgICAgICAgICAgICAgICAgICAgIE5VTEwp OwogICAgIGNvbm5lY3RFZGl0aW5nQ2FsbGJhY2tzKHZpZXcpOwogCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjA4YzMxNGEz YjM4MDllMmQ2ZWU5ZDVmZWRmOGNmNzU3MjFjNzBlNi4uNTA1ZTk3OTY5ODcwODdjZmIwMjI0MzM3 Mzk3ZTRkZTM3MmUxMTQ1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTIzICBaYW4g RG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgW0d0a10gUkVHUkVT U0lPTihyMTIwOTE4KTogQ2F1c2VzIGZsYWt5IERORCB0ZXN0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3NzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGVzdCBleHBlY3RhdGlvbnMgZm9y IGZhc3QvZXZlbnRzL2RvbWFjdGl2YXRlLXNldHMtdW5kZXJseWluZy1jbGljay1ldmVudC1hcy1o YW5kbGVkLmh0bWwKKyAgICAgICAgYXMgdGhlIHRlc3Qgbm93IHBhc3NlcyBzaW5jZSB0aGUgZmls ZSBjaG9vc2VyIGRpYWxvZyBpcyBubyBsb25nZXIgcnVuLgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMDYtMjIgIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGV4dCB3aXRoIHRleHQtb3ZlcmZsb3c6ZWxs aXBzaXMgYW5kIHRleHQtYWxpZ246cmlnaHQgaXMgbGVmdCBhbGlnbmVkCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGE3ZGJhOGY3OGViZWMxMGI0ODgwYWQz OWYxYThmZjcxMmU4OTkzMDkuLjQxYTBjMTM5YjI2ZTk1NjczNjllMWEyMjk0NjkzNTI3NjAxMDhm ZTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC00NTUs OCArNDU1LDYgQEAgQlVHV0s4NDY3NiBTS0lQIDogZmFzdC9maWxlcy9maWxlLXJlYWRlci1hYm9y dC5odG1sID0gVElNRU9VVAogQlVHV0s4NDY3NiBTS0lQIDogZmFzdC9maWxlcy9hcHBseS1ibG9i LXVybC10by14aHIuaHRtbCA9IFRJTUVPVVQKIEJVR1dLODQ2NzYgU0tJUCA6IGZhc3QvZmlsZXMv ZmlsZS1yZWFkZXItZXZlbnQtbGlzdGVuZXIuaHRtbCA9IFRJTUVPVVQKIAotQlVHV0s4NzQ2OSA6 IGZhc3QvZXZlbnRzL2RvbWFjdGl2YXRlLXNldHMtdW5kZXJseWluZy1jbGljay1ldmVudC1hcy1o YW5kbGVkLmh0bWwgPSBUSU1FT1VUCi0KIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v LwogLy8gRW5kIG9mIFRlc3RzIHRpbWluZyBvdXQKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLwo=