89766 2012-06-22 09:46:14 -0700 Web Inspector: [Elements] Right-clicking on whitespace should show the same context menu as right-clicking on the tag text 2012-06-22 11:22:57 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 655517 0 apavlov 2012-06-22 09:46:14 -0700 Patch to follow. Upstreaming http://code.google.com/p/chromium/issues/detail?id=133741 655592 1 149061 apavlov 2012-06-22 10:52:27 -0700 Created attachment 149061 Patch 655614 2 149061 vsevik 2012-06-22 11:08:37 -0700 Comment on attachment 149061 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149061&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:456 > + if (isTag && treeElement._populateTagContextMenu) { As discussed offline this regresses textNode context menu. 655625 3 149067 apavlov 2012-06-22 11:16:53 -0700 Created attachment 149067 Patch 655634 4 apavlov 2012-06-22 11:22:57 -0700 Committed r121042: <http://trac.webkit.org/changeset/121042> 149061 2012-06-22 10:52:27 -0700 2012-06-22 11:16:44 -0700 Patch bug-89766-20120622215225.patch text/plain 2155 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmIyNTg0MTBhYWQ0OTBj NWUwZmYzZWJjNzE1OWZmOTVhYjM1ZGNiMy4uNWY5ZGQ4MzczMGZmZjQ1NDkwMWJkNmUyM2RkMzM4 NWJiMzUyOWEzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTIyICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogW0VsZW1lbnRzXSBSaWdodC1jbGlja2luZyBvbiB3aGl0ZXNwYWNlIHNob3VsZCBzaG93 IHRoZSBzYW1lIGNvbnRleHQgbWVudSBhcyByaWdodC1jbGlja2luZyBvbiB0aGUgdGFnIHRleHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NzY2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwbGljaXRs eSBjaGVjayBmb3IgdGhlIFRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0J3Mgbm9kZVR5cGUo KQorICAgICAgICByYXRoZXIgdGhhbiBmb3IgdGhlIGV2ZW50IHRhcmdldCdzIGVuY2xvc2luZyBl bGVtZW50IGNsYXNzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1Ry ZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUu cHJvdG90eXBlLnBvcHVsYXRlQ29udGV4dE1lbnUpOgorCiAyMDEyLTA2LTIyICBKb2NlbHluIFR1 cmNvdHRlICA8dHVyY290dGUuakBnbWFpbC5jb20+CiAKICAgICAgICAgW1F0XSBGaXggdGhlIHJl bW90ZSBpbnNwZWN0b3IgbG9hZGluZyBwcm9ibGVtcyBvbiBNYWMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwpp bmRleCAyODNkNjFhMjQwNTZjZmFmNTFjMGU4ZWJlYTJlOTM2ZWZhYWRlMjI3Li5mYWQxNzU4Nzg3 NmQ0ZWZjYjNmNWY5MmI0MDBhYjBhODhjOGRlMmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCkBAIC00 NDksMTEgKzQ0OSwxMSBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5wcm90b3R5 cGUgPSB7CiAgICAgICAgIGlmICghdHJlZUVsZW1lbnQpCiAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAKLSAgICAgICAgdmFyIHRhZyA9IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxm V2l0aENsYXNzKCJ3ZWJraXQtaHRtbC10YWciKTsKKyAgICAgICAgdmFyIGlzVGFnID0gdHJlZUVs ZW1lbnQucmVwcmVzZW50ZWRPYmplY3Qubm9kZVR5cGUoKSA9PT0gTm9kZS5FTEVNRU5UX05PREU7 CiAgICAgICAgIHZhciB0ZXh0Tm9kZSA9IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxm V2l0aENsYXNzKCJ3ZWJraXQtaHRtbC10ZXh0LW5vZGUiKTsKICAgICAgICAgdmFyIGNvbW1lbnRO b2RlID0gZXZlbnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xhc3MoIndlYmtpdC1o dG1sLWNvbW1lbnQiKTsKICAgICAgICAgdmFyIHBvcHVsYXRlZCA9IFdlYkluc3BlY3Rvci5wb3B1 bGF0ZUhyZWZDb250ZXh0TWVudShjb250ZXh0TWVudSwgdGhpcy5zZWxlY3RlZERPTU5vZGUoKSwg ZXZlbnQpOwotICAgICAgICBpZiAodGFnICYmIHRyZWVFbGVtZW50Ll9wb3B1bGF0ZVRhZ0NvbnRl eHRNZW51KSB7CisgICAgICAgIGlmIChpc1RhZyAmJiB0cmVlRWxlbWVudC5fcG9wdWxhdGVUYWdD b250ZXh0TWVudSkgewogICAgICAgICAgICAgaWYgKHBvcHVsYXRlZCkKICAgICAgICAgICAgICAg ICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKICAgICAgICAgICAgIHRyZWVFbGVtZW50 Ll9wb3B1bGF0ZVRhZ0NvbnRleHRNZW51KGNvbnRleHRNZW51LCBldmVudCk7Cg== 149067 2012-06-22 11:16:53 -0700 2012-06-22 11:20:55 -0700 Patch bug-89766-20120622221652.patch text/plain 3621 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmIyNTg0MTBhYWQ0OTBj NWUwZmYzZWJjNzE1OWZmOTVhYjM1ZGNiMy4uOTM4YjI1N2Q0YTVkNmIyYjAzMzcxNmY4YWM2MWY5 ZGUxY2E1Mjk0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTIyICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogW0VsZW1lbnRzXSBSaWdodC1jbGlja2luZyBvbiB3aGl0ZXNwYWNlIHNob3VsZCBzaG93 IHRoZSBzYW1lIGNvbnRleHQgbWVudSBhcyByaWdodC1jbGlja2luZyBvbiB0aGUgdGFnIHRleHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NzY2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwbGljaXRs eSBjaGVjayBmb3IgdGhlIFRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0J3Mgbm9kZVR5cGUo KQorICAgICAgICByYXRoZXIgdGhhbiBmb3IgdGhlIGV2ZW50IHRhcmdldCdzIGVuY2xvc2luZyBl bGVtZW50IGNsYXNzLgorICAgICAgICBEcml2ZS1ieTogZG8gbm90IGNvbnNpZGVyIHRoZSAiY29s bGFwc2VkIG5vZGUgaGFzIGNoaWxkcmVuIiBlbGxpcHNpcyBhcyBhIHRleHQgbm9kZS4KKworICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lLnByb3RvdHlwZS5wb3B1bGF0ZUNv bnRleHRNZW51KToKKwogMjAxMi0wNi0yMiAgSm9jZWx5biBUdXJjb3R0ZSAgPHR1cmNvdHRlLmpA Z21haWwuY29tPgogCiAgICAgICAgIFtRdF0gRml4IHRoZSByZW1vdGUgaW5zcGVjdG9yIGxvYWRp bmcgcHJvYmxlbXMgb24gTWFjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKaW5kZXggMjgzZDYxYTI0MDU2Y2Zh ZjUxYzBlOGViZWEyZTkzNmVmYWFkZTIyNy4uYTFhNjQyM2NjYmE0NTYyOWU3NWMyMWZjYjQ0ZWNj OTUxZDI0MWU0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwpAQCAtNDQ5LDE5ICs0NDksMjEgQEAgV2Vi SW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUucHJvdG90eXBlID0gewogICAgICAgICBpZiAo IXRyZWVFbGVtZW50KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIHZhciB0 YWcgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcygid2Via2l0LWh0 bWwtdGFnIik7CisgICAgICAgIHZhciBpc1RhZyA9IHRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2Jq ZWN0Lm5vZGVUeXBlKCkgPT09IE5vZGUuRUxFTUVOVF9OT0RFOwogICAgICAgICB2YXIgdGV4dE5v ZGUgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcygid2Via2l0LWh0 bWwtdGV4dC1ub2RlIik7CisgICAgICAgIGlmICh0ZXh0Tm9kZSAmJiB0ZXh0Tm9kZS5oYXNTdHls ZUNsYXNzKCJib2d1cyIpKQorICAgICAgICAgICAgdGV4dE5vZGUgPSBudWxsOwogICAgICAgICB2 YXIgY29tbWVudE5vZGUgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFz cygid2Via2l0LWh0bWwtY29tbWVudCIpOwogICAgICAgICB2YXIgcG9wdWxhdGVkID0gV2ViSW5z cGVjdG9yLnBvcHVsYXRlSHJlZkNvbnRleHRNZW51KGNvbnRleHRNZW51LCB0aGlzLnNlbGVjdGVk RE9NTm9kZSgpLCBldmVudCk7Ci0gICAgICAgIGlmICh0YWcgJiYgdHJlZUVsZW1lbnQuX3BvcHVs YXRlVGFnQ29udGV4dE1lbnUpIHsKKyAgICAgICAgaWYgKHRleHROb2RlICYmIHRyZWVFbGVtZW50 Ll9wb3B1bGF0ZVRleHRDb250ZXh0TWVudSkgewogICAgICAgICAgICAgaWYgKHBvcHVsYXRlZCkK ICAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKLSAgICAgICAg ICAgIHRyZWVFbGVtZW50Ll9wb3B1bGF0ZVRhZ0NvbnRleHRNZW51KGNvbnRleHRNZW51LCBldmVu dCk7CisgICAgICAgICAgICB0cmVlRWxlbWVudC5fcG9wdWxhdGVUZXh0Q29udGV4dE1lbnUoY29u dGV4dE1lbnUsIHRleHROb2RlKTsKICAgICAgICAgICAgIHBvcHVsYXRlZCA9IHRydWU7Ci0gICAg ICAgIH0gZWxzZSBpZiAodGV4dE5vZGUgJiYgdHJlZUVsZW1lbnQuX3BvcHVsYXRlVGV4dENvbnRl eHRNZW51KSB7CisgICAgICAgIH0gZWxzZSBpZiAoaXNUYWcgJiYgdHJlZUVsZW1lbnQuX3BvcHVs YXRlVGFnQ29udGV4dE1lbnUpIHsKICAgICAgICAgICAgIGlmIChwb3B1bGF0ZWQpCiAgICAgICAg ICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7Ci0gICAgICAgICAgICB0cmVl RWxlbWVudC5fcG9wdWxhdGVUZXh0Q29udGV4dE1lbnUoY29udGV4dE1lbnUsIHRleHROb2RlKTsK KyAgICAgICAgICAgIHRyZWVFbGVtZW50Ll9wb3B1bGF0ZVRhZ0NvbnRleHRNZW51KGNvbnRleHRN ZW51LCBldmVudCk7CiAgICAgICAgICAgICBwb3B1bGF0ZWQgPSB0cnVlOwogICAgICAgICB9IGVs c2UgaWYgKGNvbW1lbnROb2RlICYmIHRyZWVFbGVtZW50Ll9wb3B1bGF0ZU5vZGVDb250ZXh0TWVu dSkgewogICAgICAgICAgICAgaWYgKHBvcHVsYXRlZCkKQEAgLTE1NjEsNyArMTU2Myw3IEBAIFdl Ykluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKIAogICAgICAgICAg ICAgICAgIGlmICghdGhpcy5leHBhbmRlZCAmJiAoIXNob3dJbmxpbmVUZXh0ICYmICh0aGlzLnRy ZWVPdXRsaW5lLmlzWE1MTWltZVR5cGUgfHwgIVdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVt ZW50LkZvcmJpZGRlbkNsb3NpbmdUYWdFbGVtZW50c1t0YWdOYW1lXSkpKSB7CiAgICAgICAgICAg ICAgICAgICAgIGlmICh0aGlzLmhhc0NoaWxkcmVuKSB7Ci0gICAgICAgICAgICAgICAgICAgICAg ICB2YXIgdGV4dE5vZGVFbGVtZW50ID0gaW5mby50aXRsZURPTS5jcmVhdGVDaGlsZCgic3BhbiIs ICJ3ZWJraXQtaHRtbC10ZXh0LW5vZGUiKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHZhciB0 ZXh0Tm9kZUVsZW1lbnQgPSBpbmZvLnRpdGxlRE9NLmNyZWF0ZUNoaWxkKCJzcGFuIiwgIndlYmtp dC1odG1sLXRleHQtbm9kZSBib2d1cyIpOwogICAgICAgICAgICAgICAgICAgICAgICAgdGV4dE5v ZGVFbGVtZW50LnRleHRDb250ZW50ID0gIlx1MjAyNiI7CiAgICAgICAgICAgICAgICAgICAgICAg ICBpbmZvLnRpdGxlRE9NLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJcdTIw MEIiKSk7CiAgICAgICAgICAgICAgICAgICAgIH0K