89761 2012-06-22 08:48:27 -0700 [Chromium/Skia] Increase the GrContext texture cache count cap to 2K 2012-06-22 11:32:53 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon bsalomon senorblanco webkit.review.bot oldest_to_newest 655480 0 bsalomon 2012-06-22 08:48:27 -0700 Increase the GrContext texture cache count cap to 2K 655483 1 149035 bsalomon 2012-06-22 08:52:12 -0700 Created attachment 149035 Patch 655484 2 bsalomon 2012-06-22 08:56:07 -0700 I had removed the count cap from Skia but it proved to be problematic. Randomly changing gradients produce many tiny textures. Managing lots of textures causes perf problems on some drivers. We have plans to change how gradient color tables work (http://code.google.com/p/skia/issues/detail?id=670) but if tons of small textures is a problem then it probably makes sense to keep the cap anyway. 655555 3 149035 senorblanco 2012-06-22 10:25:25 -0700 Comment on attachment 149035 Patch OK. r=me 655588 4 bsalomon 2012-06-22 10:50:49 -0700 Oops.. I forgot to set c? after uploading. 655651 5 149035 webkit.review.bot 2012-06-22 11:32:22 -0700 Comment on attachment 149035 Patch Clearing flags on attachment: 149035 Committed r121044: <http://trac.webkit.org/changeset/121044> 655654 6 webkit.review.bot 2012-06-22 11:32:53 -0700 All reviewed patches have been landed. Closing bug. 149035 2012-06-22 08:52:12 -0700 2012-06-22 11:32:21 -0700 Patch bug-89761-20120622115212.patch text/plain 1423 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTAyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTIyICBCcmlhbiBT YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBJbmNyZWFzZSB0aGUgR3JD b250ZXh0IHRleHR1cmUgY2FjaGUgY291bnQgY2FwIHRvIDJLCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTc2MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzOiBUaGUgY2hhbmdlIGlzIGZvciBwZXJm b3JtYW5jZS4gVGhlIGNvZGUgaXMgZXhlcmNpc2VkIGJ5IGFsbCB0aGUgY2FudmFzIDJkIGxheW91 dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvR3JhcGhpY3ND b250ZXh0M0RQcml2YXRlLmNwcDoKKwogMjAxMi0wNi0yMiAgVG9ueSBDaGFuZyAgPHRvbnlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIC13ZWJraXQtZmxleC1mbG93IHNob3VsZG4ndCBiZSBhbiBl bnVtZXJhYmxlIHByb3BlcnR5IG9mIHRoZSBjb21wdXRlZCBzdHlsZQpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL3N1cHBv cnQvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmNwcAkocmV2aXNpb24gMTIxMDI2KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9HcmFwaGljc0NvbnRleHQzRFBy aXZhdGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCw3ICs0NCw3IEBACiBuYW1lc3BhY2Ugewog CiAvLyBUaGUgbGltaXQgb2YgdGhlIG51bWJlciBvZiB0ZXh0dXJlcyB3ZSBob2xkIGluIHRoZSBH ckNvbnRleHQncyBiaXRtYXAtPnRleHR1cmUgY2FjaGUuCi1jb25zdCBpbnQgbWF4R2FuZXNoVGV4 dHVyZUNhY2hlQ291bnQgPSA1MTI7Citjb25zdCBpbnQgbWF4R2FuZXNoVGV4dHVyZUNhY2hlQ291 bnQgPSAyMDQ4OwogLy8gVGhlIGxpbWl0IG9mIHRoZSBieXRlcyBhbGxvY2F0ZWQgdG93YXJkIHRl eHR1cmVzIGluIHRoZSBHckNvbnRleHQncyBiaXRtYXAtPnRleHR1cmUgY2FjaGUuCiBjb25zdCBz aXplX3QgbWF4R2FuZXNoVGV4dHVyZUNhY2hlQnl0ZXMgPSA5NiAqIDEwMjQgKiAxMDI0OwogCg==