89743 2012-06-21 23:47:45 -0700 Web Inspector: InspectorState::updateCookie should not do JSON serialization if unsupported 2012-06-22 18:29:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 0 joepeck webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 655271 0 joepeck 2012-06-21 23:47:45 -0700 It looks like only the Chromium port implements the InspectorStateClient interface to save InspectorState cookie information. Ports that were doing nothing with this information are getting the cost of InspectorState JSON serialization. Avoid serialization if the client does not do anything with InspectorState updates. 655273 1 148969 joepeck 2012-06-21 23:53:54 -0700 Created attachment 148969 [PATCH] Proposed Fix Let the bots run first to make sure I didn't make a typo with the Chromium port, but I think this should be good. 655274 2 joepeck 2012-06-21 23:54:19 -0700 <rdar://problem/11630358> 655315 3 148969 webkit.review.bot 2012-06-22 02:14:15 -0700 Comment on attachment 148969 [PATCH] Proposed Fix Clearing flags on attachment: 148969 Committed r121013: <http://trac.webkit.org/changeset/121013> 655316 4 webkit.review.bot 2012-06-22 02:14:20 -0700 All reviewed patches have been landed. Closing bug. 655983 5 148969 pfeldman 2012-06-22 18:29:13 -0700 Comment on attachment 148969 [PATCH] Proposed Fix Looks good to me. 148969 2012-06-21 23:53:54 -0700 2012-06-22 18:29:13 -0700 [PATCH] Proposed Fix patch-1.patch text/plain 6346 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiOGQ5ZmI4Li4yYTFiZWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDYtMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3JTdGF0ZTo6dXBkYXRlQ29va2llIHNob3Vs ZCBub3QgZG8gSlNPTiBzZXJpYWxpemF0aW9uIGlmIHVuc3VwcG9ydGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTc0MworCisgICAgICAgIFNpbmNl IGFsbCBJbnNwZWN0b3JDbGllbnQncyBhcmUgSW5zcGVjdG9yU3RhdGVDbGllbnQncyBwcm92aWRl IGEKKyAgICAgICAgdmlydHVhbCBhY2Nlc3NvciB0aGF0IGRldGVybWluZXMgd2hldGhlciBvciBu b3QgSW5zcGVjdG9yQ2xpZW50IHVwZGF0ZXMKKyAgICAgICAgYXJlIHN1cHBvcnRlZCBvciBub3Qu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvSW5zcGVjdG9yU3RhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yU3Rh dGU6OnVwZGF0ZUNvb2tpZSk6CisgICAgICAgIERvbid0IHNlcmlhbGl6ZSBhbmQgbWVzc2FnZSB0 aGUgY2xpZW50IGlmIHRoZSBjbGllbnQgZG9lc24ndCBkbyBhbnl0aGluZyB3aXRoIGl0LgorCisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0YXRlQ2xpZW50Lmg6CisgICAgICAgICogaW5z cGVjdG9yL1dvcmtlckluc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SW5zcGVjdG9yU3RhdGVDbGllbnQ6OnN1cHBvcnRzSW5zcGVjdG9yU3RhdGVVcGRhdGVzKToKKyAg ICAgICAgTGV0IHRoZSBjbGllbnQgc2F5IHdoZXRoZXIgb3Igbm90IHN1cHBvcnRzIHVwZGF0ZXMg b3Igbm90LgorCiAyMDEyLTA2LTIxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlh LmNvbT4KIAogICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjEyMDc5MCk6IGJyb2tlIHZpZGVvIHJl bmRlcmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0 YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdGF0ZS5jcHAKaW5k ZXggN2UwMmViNy4uNzBhMjQzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvclN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yU3RhdGUuY3BwCkBAIC02NSw3ICs2NSw3IEBAIHZvaWQgSW5zcGVjdG9yU3RhdGU6OnVubXV0 ZSgpCiAKIHZvaWQgSW5zcGVjdG9yU3RhdGU6OnVwZGF0ZUNvb2tpZSgpCiB7Ci0gICAgaWYgKG1f Y2xpZW50ICYmICFtX2lzT25NdXRlKQorICAgIGlmIChtX2NsaWVudCAmJiAhbV9pc09uTXV0ZSAm JiBtX2NsaWVudC0+c3VwcG9ydHNJbnNwZWN0b3JTdGF0ZVVwZGF0ZXMoKSkKICAgICAgICAgbV9j bGllbnQtPnVwZGF0ZUluc3BlY3RvclN0YXRlQ29va2llKG1fcHJvcGVydGllcy0+dG9KU09OU3Ry aW5nKCkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yU3RhdGVDbGllbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdGF0 ZUNsaWVudC5oCmluZGV4IDIxNGM3MDcuLjdkNmY1NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdGF0ZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JTdGF0ZUNsaWVudC5oCkBAIC0zNyw2ICszNyw3IEBAIHB1Ymxp YzoKICAgICAvLyBOYXZpZ2F0aW9uIGNhbiBjYXVzZSBzb21lIFdlYktpdCBpbXBsZW1lbnRhdGlv bnMgdG8gY2hhbmdlIHRoZSB2aWV3IC8gcGFnZSAvIGluc3BlY3RvciBjb250cm9sbGVyIGluc3Rh bmNlLgogICAgIC8vIEhvd2V2ZXIsIHRoZXJlIGFyZSBzb21lIGluc3BlY3RvciBjb250cm9sbGVy IHN0YXRlcyB0aGF0IHNob3VsZCBzdXJ2aXZlIG5hdmlnYXRpb24gKHN1Y2ggYXMgdHJhY2tpbmcg cmVzb3VyY2VzCiAgICAgLy8gb3IgcmVjb3JkaW5nIHRpbWVsaW5lKSBhbmQgd29ya2VyIHJlc3Rh cnQuIEZvbGxvd2luZyBjYWxsYmFja3MgYWxsb3cgZW1iZWRkZXJzIHRvIHRyYWNrIHRoZXNlIHN0 YXRlcy4KKyAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNJbnNwZWN0b3JTdGF0ZVVwZGF0ZXMoKSBj b25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVJbnNwZWN0b3JT dGF0ZUNvb2tpZShjb25zdCBTdHJpbmcmKSB7IH07CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvV29ya2VySW5zcGVjdG9yQ29udHJvbGxlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvV29ya2VySW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXggNGQx NmViNi4uN2Q3YWE5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1dvcmtl ckluc3BlY3RvckNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9X b3JrZXJJbnNwZWN0b3JDb250cm9sbGVyLmNwcApAQCAtNzcsNiArNzcsNyBAQCBwdWJsaWM6CiAg ICAgdmlydHVhbCB+V29ya2VyU3RhdGVDbGllbnQoKSB7IH0KIAogcHJpdmF0ZToKKyAgICB2aXJ0 dWFsIGJvb2wgc3VwcG9ydHNJbnNwZWN0b3JTdGF0ZVVwZGF0ZXMoKSBjb25zdCB7IHJldHVybiB0 cnVlOyB9CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUluc3BlY3RvclN0YXRlQ29va2llKGNvbnN0 IFN0cmluZyYgY29va2llKQogICAgIHsKICAgICAgICAgbV93b3JrZXJDb250ZXh0LT50aHJlYWQo KS0+d29ya2VyUmVwb3J0aW5nUHJveHkoKS51cGRhdGVJbnNwZWN0b3JTdGF0ZUNvb2tpZShjb29r aWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggZjc0YjQyZi4uMmNkNDY5YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDYt MjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBJbnNwZWN0b3JTdGF0ZTo6dXBkYXRlQ29va2llIHNob3VsZCBub3QgZG8gSlNP TiBzZXJpYWxpemF0aW9uIGlmIHVuc3VwcG9ydGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTc0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50Qmxh Y2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5 Ojp1cGRhdGVJbnNwZWN0b3JTdGF0ZUNvb2tpZSk6CisKIDIwMTItMDYtMjEgIEdlbmV2aWV2ZSBN YWsgIDxnbWFrQHJpbS5jb20+CiAKICAgICAgICAgQWRkIGEgcGFyYW1ldGVyIHRvIGhhbmRsZXRU b3VjaFBvaW50IHRvIGJ5cGFzcyBGYXRGaW5nZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJyeS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50 QmxhY2tCZXJyeS5jcHAKaW5kZXggZGJiNWYwOC4uMjJlMjM2NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudEJsYWNrQmVy cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9JbnNw ZWN0b3JDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtODcsNiArODcsNyBAQCB2b2lkIEluc3BlY3Rv ckNsaWVudEJsYWNrQmVycnk6OmNsZWFyQnJvd3NlckNvb2tpZXMoKQogCiB2b2lkIEluc3BlY3Rv ckNsaWVudEJsYWNrQmVycnk6OnVwZGF0ZUluc3BlY3RvclN0YXRlQ29va2llKGNvbnN0IFN0cmlu ZyYgY29va2llKQogeworICAgIC8vIElmIHRoaXMgaXMgaW1wbGVtZW50ZWQsIHdlIHNob3VsZCBv dmVycmlkZSBhbmQgcmV0dXJuIHRydWUgaW4gSW5zcGVjdG9yU3RhdGVDbGllbnQ6OnN1cHBvcnRz SW5zcGVjdG9yU3RhdGVVcGRhdGVzKCkuCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH07CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNDZjOTgzMi4uOTM4OTI1YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNi0yMSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluc3Bl Y3RvclN0YXRlOjp1cGRhdGVDb29raWUgc2hvdWxkIG5vdCBkbyBKU09OIHNlcmlhbGl6YXRpb24g aWYgdW5zdXBwb3J0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg5NzQzCisKKyAgICAgICAgVGhlIENocm9taXVtIHBvcnQgZG9lcyB3YW50IEluc3Bl Y3RvclN0YXRlIHVwZGF0ZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBzcmMvSW5zcGVjdG9yQ2xpZW50SW1wbC5oOgorICAgICAgICAoV2ViS2l0 OjpJbnNwZWN0b3JDbGllbnRJbXBsOjpzdXBwb3J0c0luc3BlY3RvclN0YXRlVXBkYXRlcyk6Cisg ICAgICAgICogc3JjL1dlYkRldlRvb2xzQWdlbnRJbXBsLmg6CisgICAgICAgIChXZWJLaXQ6Oldl YkRldlRvb2xzQWdlbnRJbXBsOjpzdXBwb3J0c0luc3BlY3RvclN0YXRlVXBkYXRlcyk6CisKIDIw MTItMDYtMjEgIE1pbiBRaW4gIDxxaW5taW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHJlbW92 ZSBFTkFCTEVfRlVMTFNDUkVFTl9NRURJQV9DT05UUk9MIGZsYWcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL0luc3BlY3RvckNsaWVudEltcGwuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0luc3BlY3RvckNsaWVudEltcGwuaAppbmRleCA2Y2I1YzU1Li41ZWE2 YmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JbnNwZWN0b3JDbGll bnRJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSW5zcGVjdG9yQ2xpZW50 SW1wbC5oCkBAIC01OSw2ICs1OSw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgYm9vbCBzZW5k TWVzc2FnZVRvRnJvbnRlbmQoY29uc3QgV1RGOjpTdHJpbmcmKTsKIAorICAgIHZpcnR1YWwgYm9v bCBzdXBwb3J0c0luc3BlY3RvclN0YXRlVXBkYXRlcygpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0K ICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlSW5zcGVjdG9yU3RhdGVDb29raWUoY29uc3QgV1RGOjpT dHJpbmcmKTsKIAogICAgIHZpcnR1YWwgYm9vbCBjYW5DbGVhckJyb3dzZXJDYWNoZSgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNBZ2VudEltcGwu aCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRldlRvb2xzQWdlbnRJbXBsLmgKaW5k ZXggZWRiZWUxNC4uNmI1MjQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRGV2VG9vbHNBZ2VudEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJEZXZUb29sc0FnZW50SW1wbC5oCkBAIC05NCw2ICs5NCw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgYnJpbmdGcm9udGVuZFRvRnJvbnQoKTsKICAgICB2aXJ0dWFsIHZvaWQgaGln aGxpZ2h0KCk7CiAgICAgdmlydHVhbCB2b2lkIGhpZGVIaWdobGlnaHQoKTsKKyAgICB2aXJ0dWFs IGJvb2wgc3VwcG9ydHNJbnNwZWN0b3JTdGF0ZVVwZGF0ZXMoKSBjb25zdCB7IHJldHVybiB0cnVl OyB9CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUluc3BlY3RvclN0YXRlQ29va2llKGNvbnN0IFdU Rjo6U3RyaW5nJik7CiAgICAgdmlydHVhbCBib29sIHNlbmRNZXNzYWdlVG9Gcm9udGVuZChjb25z dCBXVEY6OlN0cmluZyYpOwogCg==