89734 2012-06-21 21:04:26 -0700 run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'') 2012-06-22 15:26:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ukai dpranke abarth dpranke kbr ojan webkit.review.bot oldest_to_newest 655217 0 ukai 2012-06-21 21:04:26 -0700 run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'') on Webkit Vista in chromium.webkit python.exe e:\b\build\slave\Webkit_Vista\build\src\webkit\tools\layout_tests\run_webkit_tests.py --no-show-results --no-new-test-results --verbose --full-results-html --clobber-old-results --exit-after-n-failures 5000 --exit-after-n-crashes-or-timeouts 100 --results-directory e:\b\build\slave\Webkit_Vista\build\layout-test-results --target Release --builder-name "Webkit Vista" --build-number 16253 --master-name ChromiumWebkit --build-name Webkit_Vista --build-directory e:\b\build\slave\Webkit_Vista\build\src\build --test-results-server test-results.appspot.com "" ... 20:14:16.836 4004 worker/3 raised AttributeError(''NoneType' object has no attribute 'pid''): 20:14:16.836 4004 layout_tests\controllers\manager_worker_broker.py:290 (in run) 20:14:16.836 4004 self._worker_connection.run_message_loop() 20:14:16.836 4004 layout_tests\controllers\manager_worker_broker.py:243 (in run_message_loop) 20:14:16.836 4004 self._broker.run_message_loop(self._run_topic, self._client, delay_secs) 20:14:16.836 4004 layout_tests\controllers\manager_worker_broker.py:175 (in run_message_loop) 20:14:16.836 4004 self._run_loop(topic_name, client, block=True, delay_secs=delay_secs) 20:14:16.836 4004 layout_tests\controllers\manager_worker_broker.py:189 (in _run_loop) 20:14:16.836 4004 self._dispatch_message(msg, client) 20:14:16.836 4004 layout_tests\controllers\manager_worker_broker.py:198 (in _dispatch_message) 20:14:16.836 4004 message_handler(message.src, *optargs) 20:14:16.882 4004 layout_tests\controllers\worker.py:137 (in handle_test_list) 20:14:16.882 4004 self._run_test(test_input) 20:14:16.882 4004 layout_tests\controllers\worker.py:164 (in _run_test) 20:14:16.882 4004 result = self.run_test_with_timeout(test_input, test_timeout_sec) 20:14:16.882 4004 layout_tests\controllers\worker.py:209 (in run_test_with_timeout) 20:14:16.882 4004 return self._run_test_in_this_thread(test_input) 20:14:16.882 4004 layout_tests\controllers\worker.py:294 (in _run_test_in_this_thread) 20:14:16.882 4004 return self.run_single_test(self._driver, test_input) 20:14:16.882 4004 layout_tests\controllers\worker.py:298 (in run_single_test) 20:14:16.882 4004 test_input, driver, self._name) 20:14:16.882 4004 layout_tests\controllers\single_test_runner.py:46 (in run_single_test) 20:14:16.882 4004 return runner.run() 20:14:16.882 4004 layout_tests\controllers\single_test_runner.py:105 (in run) 20:14:16.882 4004 return self._run_compare_test() 20:14:16.882 4004 layout_tests\controllers\single_test_runner.py:108 (in _run_compare_test) 20:14:16.882 4004 driver_output = self._driver.run_test(self._driver_input()) 20:14:16.882 4004 layout_tests\port\driver.py:220 (in run_test) 20:14:16.882 4004 return self._running_drivers[cmd_line_key].run_test(driver_input) 20:14:16.882 4004 layout_tests\port\chromium.py:550 (in run_test) 20:14:16.882 4004 return super(ChromiumDriver, self).run_test(driver_input) 20:14:16.882 4004 layout_tests\port\webkit.py:566 (in run_test) 20:14:16.882 4004 text, audio = self._read_first_block(deadline) # First block is either text or audio 20:14:16.882 4004 layout_tests\port\webkit.py:544 (in _read_first_block) 20:14:16.882 4004 block = self._read_block(deadline) 20:14:16.882 4004 layout_tests\port\webkit.py:627 (in _read_block) 20:14:16.882 4004 while not self.has_crashed(): 20:14:16.882 4004 layout_tests\port\chromium.py:490 (in has_crashed) 20:14:16.882 4004 return super(ChromiumDriver, self).has_crashed() 20:14:16.882 4004 layout_tests\port\webkit.py:500 (in has_crashed) 20:14:16.882 4004 self._crashed_pid = self._server_process.pid() 20:14:16.882 4004 layout_tests\port\server_process.py:80 (in pid) 20:14:16.882 4004 return self._proc.pid Traceback (most recent call last): File "e:\b\depot_tools\python_bin\lib\multiprocessing\queues.py", line 238, in _feed send(obj) IOError: [Errno 109] The pipe has been ended 20:14:16.898 4004 Stopping HTTP server ... 20:14:16.898 4004 Attempting to shut down lighttpd server at pid 464 20:14:17.007 4004 "taskkill.exe /f /pid 464" took 0.09s 20:14:17.007 4004 Waiting for action: <bound method Lighttpd._check_and_kill of <webkitpy.layout_tests.servers.http_server.Lighttpd object at 0x05DA92F0>> 20:14:18.007 4004 lighttpd server at pid 464 stopped 20:14:18.007 4004 Stopping WebSocket server ... 20:14:18.007 4004 Attempting to shut down pywebsocket server at pid 2772 20:14:18.101 4004 "taskkill.exe /f /pid 2772" took 0.09s 20:14:18.101 4004 Waiting for action: <bound method PyWebSocket._check_and_kill of <webkitpy.layout_tests.servers.websocket_server.PyWebSocket object at 0x05DA91F0>> 20:14:19.101 4004 pywebsocket server at pid 2772 stopped 20:14:19.101 4004 Releasing server lock ... 20:14:19.101 4004 Removing lock file: c:\users\chrome~2\appdata\local\temp\WebKitHttpd.lock.0 program finished with exit code 254 elapsedTime=434.486000 http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/16253 http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/16253/steps/webkit_tests/logs/stdio 655226 1 ukai 2012-06-21 21:24:48 -0700 Also failed on Win7 python.exe e:\b\build\slave\Webkit_Win7\build\src\webkit\tools\layout_tests\run_webkit_tests.py --no-show-results --no-new-test-results --verbose --full-results-html --clobber-old-results --exit-after-n-failures 5000 --exit-after-n-crashes-or-timeouts 100 --results-directory e:\b\build\slave\Webkit_Win7\build\layout-test-results --target Release --builder-name "Webkit Win7" --build-number 17860 --master-name ChromiumWebkit --build-name Webkit_Win7 --build-directory e:\b\build\slave\Webkit_Win7\build\src\build --test-results-server test-results.appspot.com "" ... 20:50:04.970 1920 worker/1 raised AttributeError(''NoneType' object has no attribute 'pid''): 20:50:04.970 1920 layout_tests\controllers\manager_worker_broker.py:290 (in run) 20:50:04.970 1920 self._worker_connection.run_message_loop() 20:50:04.970 1920 layout_tests\controllers\manager_worker_broker.py:243 (in run_message_loop) 20:50:04.970 1920 self._broker.run_message_loop(self._run_topic, self._client, delay_secs) 20:50:04.970 1920 layout_tests\controllers\manager_worker_broker.py:175 (in run_message_loop) 20:50:04.970 1920 self._run_loop(topic_name, client, block=True, delay_secs=delay_secs) 20:50:04.970 1920 layout_tests\controllers\manager_worker_broker.py:189 (in _run_loop) 20:50:04.970 1920 self._dispatch_message(msg, client) 20:50:04.970 1920 layout_tests\controllers\manager_worker_broker.py:198 (in _dispatch_message) 20:50:04.970 1920 message_handler(message.src, *optargs) 20:50:04.970 1920 layout_tests\controllers\worker.py:137 (in handle_test_list) 20:50:04.970 1920 self._run_test(test_input) 20:50:04.970 1920 layout_tests\controllers\worker.py:164 (in _run_test) 20:50:05.064 1920 result = self.run_test_with_timeout(test_input, test_timeout_sec) 20:50:05.064 1920 layout_tests\controllers\worker.py:209 (in run_test_with_timeout) 20:50:05.064 1920 return self._run_test_in_this_thread(test_input) 20:50:05.064 1920 layout_tests\controllers\worker.py:294 (in _run_test_in_this_thread) 20:50:05.064 1920 return self.run_single_test(self._driver, test_input) 20:50:05.064 1920 layout_tests\controllers\worker.py:298 (in run_single_test) 20:50:05.064 1920 test_input, driver, self._name) 20:50:05.064 1920 layout_tests\controllers\single_test_runner.py:46 (in run_single_test) 20:50:05.064 1920 return runner.run() 20:50:05.064 1920 layout_tests\controllers\single_test_runner.py:105 (in run) 20:50:05.064 1920 return self._run_compare_test() 20:50:05.064 1920 layout_tests\controllers\single_test_runner.py:108 (in _run_compare_test) 20:50:05.064 1920 driver_output = self._driver.run_test(self._driver_input()) 20:50:05.064 1920 layout_tests\port\driver.py:220 (in run_test) 20:50:05.064 1920 return self._running_drivers[cmd_line_key].run_test(driver_input) 20:50:05.064 1920 layout_tests\port\chromium.py:550 (in run_test) 20:50:05.064 1920 return super(ChromiumDriver, self).run_test(driver_input) http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win7/builds/17860 http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win7/builds/17860/steps/webkit_tests/logs/stdio 655243 2 ukai 2012-06-21 22:42:08 -0700 in webkitpy/layout_tests/ports/server_process.py if write failed -> stop() -> _reset() -> _proc = None -> _crashed = True so, has_crashed() will return True. but calling pid() would fail to access pid of None. we should save pid before calling _reset(), so that pid() returns that value if _proc is None or new crashed_pid() method returns that value ? 655827 3 149118 dpranke 2012-06-22 15:18:59 -0700 Created attachment 149118 Patch 655835 4 149118 dpranke 2012-06-22 15:26:08 -0700 Comment on attachment 149118 Patch Clearing flags on attachment: 149118 Committed r121061: <http://trac.webkit.org/changeset/121061> 655836 5 dpranke 2012-06-22 15:26:19 -0700 All reviewed patches have been landed. Closing bug. 149118 2012-06-22 15:18:59 -0700 2012-06-22 15:26:06 -0700 Patch bug-89734-20120622151901.patch text/plain 3828 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODQ2NGM3MWE4NTBkOTNhZjQyOWFkYTFjOWQwYWVjOGQz MGE5MWU2Yy4uYzJiZTdlMTcxZjhhNDMxZTIxNTIyNjk3OWNmMzQwMGQ4MjkyMjY1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA2LTIyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHJ1bl93ZWJraXRfdGVzdHMucHkgZmFpbGVkIHdpdGggQXR0cmlidXRlRXJyb3IoJydO b25lVHlwZScgb2JqZWN0IGhhcyBubyBhdHRyaWJ1dGUgJ3BpZCcnKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3MzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBjcmFzaCBpbiBTZXJ2ZXJQcm9j ZXNzIGlmIHlvdSBjYWxsZWQgLnBpZCgpIGFmdGVyIGl0CisgICAgICAgIGNyYXNoZWQgZHVyaW5n IGEgd3JpdGUoKS4gV2UgaGFkIGEgdGVzdCBmb3IgdGhpcyBjYXNlIGJ1dCB0aGUKKyAgICAgICAg dGVzdCB3YXNuJ3QgY2FsbGluZyBwaWQoKSwganVzdCBoYXNfY3Jhc2hlZCgpLiBGaXhlZCB0aGUg cHJvYmxlbQorICAgICAgICBhbmQgdGhlIHRlc3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorICAgICAgICAoU2VydmVy UHJvY2Vzcy5fX2luaXRfXyk6CisgICAgICAgIChTZXJ2ZXJQcm9jZXNzLnBpZCk6CisgICAgICAg IChTZXJ2ZXJQcm9jZXNzLl9zdGFydCk6CisgICAgICAgIChTZXJ2ZXJQcm9jZXNzLnN0b3ApOgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nl c3NfdW5pdHRlc3QucHk6CisgICAgICAgIChGYWtlU2VydmVyUHJvY2Vzcy5fc3RhcnQpOgorICAg ICAgICAoVGVzdFNlcnZlclByb2Nlc3MudGVzdF9icm9rZW5fcGlwZSk6CisKIDIwMTItMDYtMjIg IFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1 bV0gRGlzYWJsZSBjKysweCBjb21wYXRpYmlsaXR5IHdhcm5pbmdzIGluIEphdmFTY3JpcHRDb3Jl Lmd5cCB3aGVuIGJ1aWxkaW5nIGZvciBBbmRyb2lkCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQppbmRleCAx MDhjYzVkYmQ5NjEyOWFiNWFhZDE3OGE0OTdiZDZkZTIwNzA3ZDIyLi43ZTQ2N2RjMTI3NjAwNTBh MzQ0MGNmZjMxZjRiNTk2MGVhOWEwNjIyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKQEAgLTY3LDYg KzY3LDcgQEAgY2xhc3MgU2VydmVyUHJvY2VzcyhvYmplY3QpOgogICAgICAgICBzZWxmLl9jbWQg PSBjbWQKICAgICAgICAgc2VsZi5fZW52ID0gZW52CiAgICAgICAgIHNlbGYuX2hvc3QgPSBzZWxm Ll9wb3J0Lmhvc3QKKyAgICAgICAgc2VsZi5fcGlkID0gTm9uZQogICAgICAgICBzZWxmLl9yZXNl dCgpCiAKICAgICAgICAgIyBTZWUgY29tbWVudCBpbiBpbXBvcnRzIGZvciB3aHkgd2UgbmVlZCB0 aGUgd2luMzIgQVBJcyBhbmQgY2FuJ3QganVzdCB1c2Ugc2VsZWN0LgpAQCAtNzcsNyArNzgsNyBA QCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiAgICAgICAgIHJldHVybiBzZWxmLl9uYW1l CiAKICAgICBkZWYgcGlkKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi5fcHJvYy5waWQKKyAg ICAgICAgcmV0dXJuIHNlbGYuX3BpZAogCiAgICAgZGVmIF9yZXNldChzZWxmKToKICAgICAgICAg c2VsZi5fcHJvYyA9IE5vbmUKQEAgLTEwMCw2ICsxMDEsNyBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNz KG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZGVycj1z dWJwcm9jZXNzLlBJUEUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNs b3NlX2Zkcz1jbG9zZV9mZHMsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGVudj1zZWxmLl9lbnYpCisgICAgICAgIHNlbGYuX3BpZCA9IHNlbGYuX3Byb2MucGlkCiAgICAg ICAgIGZkID0gc2VsZi5fcHJvYy5zdGRvdXQuZmlsZW5vKCkKICAgICAgICAgaWYgbm90IHNlbGYu X3VzZV93aW4zMl9hcGlzOgogICAgICAgICAgICAgZmwgPSBmY250bC5mY250bChmZCwgZmNudGwu Rl9HRVRGTCkKQEAgLTMwMSw3ICszMDMsNiBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6 CiAgICAgICAgIGlmIHNlbGYucG9sbCgpIGlzIE5vbmU6CiAgICAgICAgICAgICBzZWxmLl9wb3J0 LmNoZWNrX2Zvcl9sZWFrcyhzZWxmLm5hbWUoKSwgc2VsZi5waWQoKSkKIAotICAgICAgICBwaWQg PSBzZWxmLl9wcm9jLnBpZAogICAgICAgICBzZWxmLl9wcm9jLnN0ZGluLmNsb3NlKCkKICAgICAg ICAgc2VsZi5fcHJvYy5zdGRvdXQuY2xvc2UoKQogICAgICAgICBpZiBzZWxmLl9wcm9jLnN0ZGVy cjoKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv c2VydmVyX3Byb2Nlc3NfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzX3VuaXR0ZXN0LnB5CmluZGV4IGI1Y2UwNTM5MTBj OGJlYjcxNjA0YTg1MDA1NjIzN2EzNmM1MThlZmMuLmMwNDI2YzFjZjNhZmMwMDI0ZmFlNDZiNjhk ZjgwZjQ0YTA2OGE0ZGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3NfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzc191bml0dGVzdC5weQpA QCAtNzksNiArNzksNyBAQCBjbGFzcyBGYWtlU2VydmVyUHJvY2VzcyhzZXJ2ZXJfcHJvY2Vzcy5T ZXJ2ZXJQcm9jZXNzKToKICAgICBkZWYgX3N0YXJ0KHNlbGYpOgogICAgICAgICBzZWxmLl9wcm9j ID0gTW9ja1Byb2Moc2VsZikKICAgICAgICAgc2VsZi5zdGRpbiA9IHNlbGYuX3Byb2Muc3RkaW4K KyAgICAgICAgc2VsZi5fcGlkID0gc2VsZi5fcHJvYy5waWQKICAgICAgICAgc2VsZi5icm9rZW5f cGlwZXMgPSBbXQogCiAKQEAgLTExOSw2ICsxMjAsNyBAQCBjbGFzcyBUZXN0U2VydmVyUHJvY2Vz cyh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHNlcnZlcl9wcm9jZXNzID0gRmFrZVNlcnZl clByb2Nlc3MocG9ydF9vYmo9cG9ydF9vYmosIG5hbWU9InRlc3QiLCBjbWQ9WyJ0ZXN0Il0pCiAg ICAgICAgIHNlcnZlcl9wcm9jZXNzLndyaXRlKCJzaG91bGQgYnJlYWsiKQogICAgICAgICBzZWxm LmFzc2VydFRydWUoc2VydmVyX3Byb2Nlc3MuaGFzX2NyYXNoZWQoKSkKKyAgICAgICAgc2VsZi5h c3NlcnROb3RFcXVhbHMoc2VydmVyX3Byb2Nlc3MucGlkKCksIE5vbmUpCiAgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWxzKHNlcnZlcl9wcm9jZXNzLl9wcm9jLCBOb25lKQogICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhzZXJ2ZXJfcHJvY2Vzcy5icm9rZW5fcGlwZXMsIFtzZXJ2ZXJfcHJvY2Vzcy5z dGRpbl0pCiAK