89727 2012-06-21 18:26:07 -0700 Web Inspector: only increase length for timeline bars below minimal width 2012-06-22 09:56:26 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 655116 0 caseq 2012-06-21 18:26:07 -0700 We used to add a fixed "minimal width" of 5px to all timeline bars, which often produces confusingly overlapping bars. Let's only increase small one and center them around the start time to minimize the overlap. 655131 1 148937 caseq 2012-06-21 18:36:12 -0700 Created attachment 148937 Patch 655195 2 pfeldman 2012-06-21 20:18:48 -0700 Could you provide a screenshot? 655527 3 caseq 2012-06-22 09:56:26 -0700 Committed r121033: <http://trac.webkit.org/changeset/121033> 148937 2012-06-21 18:36:12 -0700 2012-06-21 20:37:55 -0700 Patch bug-89727-20120621183611.patch text/plain 4104 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFmNGYyMmE5MGQxNDlk ZDhjZDY2YjYwYmExODcwNzI4M2IzMWY3My4uYWI2MjJhMjlmOGEyZmNmMzQ4NTJiOWQ0MzAwYTdh OGNjN2YzZjMxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTIxICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogb25seSBpbmNyZWFzZSBsZW5ndGggZm9yIHRpbWVsaW5lIGJhcnMgYmVsb3cgbWluaW1hbCB3 aWR0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3 MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UaW1lbGluZUNhbGN1bGF0b3IucHJvdG90eXBlLmNvbXB1dGVCYXJHcmFwaFdpbmRvd1Bvc2l0 aW9uKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZUNhbGN1bGF0b3IucHJvdG90eXBl LnNldERpc3BsYXlXaW5kb3cpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3Jk R3JhcGhSb3cucHJvdG90eXBlLnVwZGF0ZSk6CisKIDIwMTItMDYtMjEgIE9saSBMYW4gIDxvbGls YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBtZXRob2RzIHRvIHNlbGVjdCBiZXR3ZWVu IG9mZnNldHMgaW4gYW4gZWRpdGFibGUgZmllbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggNDI1MTgxY2E4MWIxZjA3 Mzk5N2U5NDc5ZTI4OTVjODU3ZGIyNDA2MC4uYmMxOThhZDMzZTNjNmFmOTcxZGQ5ZjliOTFmMTg5 ZWI1NGQ4OGRjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9UaW1lbGluZVBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGltZWxpbmVQYW5lbC5qcwpAQCAtODI3LDcgKzgyNyw2IEBAIFdlYkluc3BlY3Rvci5UaW1l bGluZUNhbGN1bGF0b3IgPSBmdW5jdGlvbihtb2RlbCkKIH0KIAogV2ViSW5zcGVjdG9yLlRpbWVs aW5lQ2FsY3VsYXRvci5fbWluV2lkdGggPSA1OwotV2ViSW5zcGVjdG9yLlRpbWVsaW5lQ2FsY3Vs YXRvci5fYm9yZGVyV2lkdGggPSA0OwogCiBXZWJJbnNwZWN0b3IuVGltZWxpbmVDYWxjdWxhdG9y LnByb3RvdHlwZSA9IHsKICAgICAvKioKQEAgLTg1MCwxMyArODQ5LDE5IEBAIFdlYkluc3BlY3Rv ci5UaW1lbGluZUNhbGN1bGF0b3IucHJvdG90eXBlID0gewogICAgIGNvbXB1dGVCYXJHcmFwaFdp bmRvd1Bvc2l0aW9uOiBmdW5jdGlvbihyZWNvcmQpCiAgICAgewogICAgICAgICB2YXIgcGVyY2Vu dGFnZXMgPSB0aGlzLmNvbXB1dGVCYXJHcmFwaFBlcmNlbnRhZ2VzKHJlY29yZCk7CisgICAgICAg IHZhciB3aWR0aEFkanVzdG1lbnQgPSAwOwogCiAgICAgICAgIHZhciBsZWZ0ID0gdGhpcy5jb21w dXRlUG9zaXRpb24ocmVjb3JkLnN0YXJ0VGltZSk7Ci0gICAgICAgIHZhciB3aWR0aCA9IChwZXJj ZW50YWdlcy5lbmQgLSBwZXJjZW50YWdlcy5zdGFydCkgLyAxMDAgKiB0aGlzLl93b3JraW5nQXJl YSArIFdlYkluc3BlY3Rvci5UaW1lbGluZUNhbGN1bGF0b3IuX21pbldpZHRoOwotICAgICAgICB2 YXIgd2lkdGhXaXRoQ2hpbGRyZW4gPSAgKHBlcmNlbnRhZ2VzLmVuZFdpdGhDaGlsZHJlbiAtIHBl cmNlbnRhZ2VzLnN0YXJ0KSAvIDEwMCAqIHRoaXMuX3dvcmtpbmdBcmVhOwotICAgICAgICB2YXIg Y3B1V2lkdGggPSBwZXJjZW50YWdlcy5jcHVXaWR0aCAvIDEwMCAqIHRoaXMuX3dvcmtpbmdBcmVh ICsgV2ViSW5zcGVjdG9yLlRpbWVsaW5lQ2FsY3VsYXRvci5fbWluV2lkdGg7CisgICAgICAgIHZh ciB3aWR0aCA9IChwZXJjZW50YWdlcy5lbmQgLSBwZXJjZW50YWdlcy5zdGFydCkgLyAxMDAgKiB0 aGlzLl93b3JraW5nQXJlYTsKKyAgICAgICAgaWYgKHdpZHRoIDwgV2ViSW5zcGVjdG9yLlRpbWVs aW5lQ2FsY3VsYXRvci5fbWluV2lkdGgpIHsKKyAgICAgICAgICAgIHdpZHRoQWRqdXN0bWVudCA9 IFdlYkluc3BlY3Rvci5UaW1lbGluZUNhbGN1bGF0b3IuX21pbldpZHRoIC0gd2lkdGg7CisgICAg ICAgICAgICBsZWZ0IC09IHdpZHRoQWRqdXN0bWVudCAvIDI7CisgICAgICAgICAgICB3aWR0aCAr PSB3aWR0aEFkanVzdG1lbnQ7CisgICAgICAgIH0KKyAgICAgICAgdmFyIHdpZHRoV2l0aENoaWxk cmVuID0gKHBlcmNlbnRhZ2VzLmVuZFdpdGhDaGlsZHJlbiAtIHBlcmNlbnRhZ2VzLnN0YXJ0KSAv IDEwMCAqIHRoaXMuX3dvcmtpbmdBcmVhICsgd2lkdGhBZGp1c3RtZW50OworICAgICAgICB2YXIg Y3B1V2lkdGggPSBwZXJjZW50YWdlcy5jcHVXaWR0aCAvIDEwMCAqIHRoaXMuX3dvcmtpbmdBcmVh ICsgd2lkdGhBZGp1c3RtZW50OwogICAgICAgICBpZiAocGVyY2VudGFnZXMuZW5kV2l0aENoaWxk cmVuID4gcGVyY2VudGFnZXMuZW5kKQotICAgICAgICAgICAgd2lkdGhXaXRoQ2hpbGRyZW4gKz0g V2ViSW5zcGVjdG9yLlRpbWVsaW5lQ2FsY3VsYXRvci5fYm9yZGVyV2lkdGggKyBXZWJJbnNwZWN0 b3IuVGltZWxpbmVDYWxjdWxhdG9yLl9taW5XaWR0aDsKKyAgICAgICAgICAgIHdpZHRoV2l0aENo aWxkcmVuICs9IHdpZHRoQWRqdXN0bWVudDsKICAgICAgICAgcmV0dXJuIHtsZWZ0OiBsZWZ0LCB3 aWR0aDogd2lkdGgsIHdpZHRoV2l0aENoaWxkcmVuOiB3aWR0aFdpdGhDaGlsZHJlbiwgY3B1V2lk dGg6IGNwdVdpZHRofTsKICAgICB9LAogCkBAIC04NzMsNyArODc4LDcgQEAgV2ViSW5zcGVjdG9y LlRpbWVsaW5lQ2FsY3VsYXRvci5wcm90b3R5cGUgPSB7CiAgICAgICovCiAgICAgc2V0RGlzcGxh eVdpbmRvdzogZnVuY3Rpb24ocGFkZGluZ0xlZnQsIGNsaWVudFdpZHRoKQogICAgIHsKLSAgICAg ICAgdGhpcy5fd29ya2luZ0FyZWEgPSBjbGllbnRXaWR0aCAtIFdlYkluc3BlY3Rvci5UaW1lbGlu ZUNhbGN1bGF0b3IuX21pbldpZHRoIC0gV2ViSW5zcGVjdG9yLlRpbWVsaW5lQ2FsY3VsYXRvci5f Ym9yZGVyV2lkdGggLSBwYWRkaW5nTGVmdDsKKyAgICAgICAgdGhpcy5fd29ya2luZ0FyZWEgPSBj bGllbnRXaWR0aCAtIFdlYkluc3BlY3Rvci5UaW1lbGluZUNhbGN1bGF0b3IuX21pbldpZHRoIC0g cGFkZGluZ0xlZnQ7CiAgICAgICAgIHRoaXMucGFkZGluZ0xlZnQgPSBwYWRkaW5nTGVmdDsKICAg ICB9LAogCkBAIC05ODEsNyArOTg2LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkR3Jh cGhSb3cucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9iYXJXaXRoQ2hpbGRyZW5FbGVtZW50 LnN0eWxlLmxlZnQgPSBiYXJQb3NpdGlvbi5sZWZ0ICsgInB4IjsKICAgICAgICAgdGhpcy5fYmFy V2l0aENoaWxkcmVuRWxlbWVudC5zdHlsZS53aWR0aCA9IGJhclBvc2l0aW9uLndpZHRoV2l0aENo aWxkcmVuICsgInB4IjsKICAgICAgICAgdGhpcy5fYmFyRWxlbWVudC5zdHlsZS5sZWZ0ID0gYmFy UG9zaXRpb24ubGVmdCArICJweCI7Ci0gICAgICAgIHRoaXMuX2JhckVsZW1lbnQuc3R5bGUud2lk dGggPSAgYmFyUG9zaXRpb24ud2lkdGggKyAicHgiOworICAgICAgICB0aGlzLl9iYXJFbGVtZW50 LnN0eWxlLndpZHRoID0gYmFyUG9zaXRpb24ud2lkdGggKyAicHgiOwogICAgICAgICB0aGlzLl9i YXJDcHVFbGVtZW50LnN0eWxlLmxlZnQgPSBiYXJQb3NpdGlvbi5sZWZ0ICsgInB4IjsKICAgICAg ICAgdGhpcy5fYmFyQ3B1RWxlbWVudC5zdHlsZS53aWR0aCA9IGJhclBvc2l0aW9uLmNwdVdpZHRo ICsgInB4IjsKICAgICAgICAgdGhpcy5fZXhwYW5kRWxlbWVudC5fdXBkYXRlKHJlY29yZCwgaW5k ZXgsIGJhclBvc2l0aW9uLmxlZnQgLSBleHBhbmRPZmZzZXQsIGJhclBvc2l0aW9uLndpZHRoKTsK