89724 2012-06-21 18:03:36 -0700 Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScriptingPermission) private. 2012-06-21 19:50:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned oldest_to_newest 655092 0 skyul 2012-06-21 18:03:36 -0700 Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScriptingPermission) private. It is used only by HTMLDocumentParser::parseDocumentFragment. 655099 1 148932 skyul 2012-06-21 18:08:49 -0700 Created attachment 148932 Patch 655158 2 148932 darin 2012-06-21 19:28:21 -0700 Comment on attachment 148932 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review > Source/WebCore/html/parser/HTMLDocumentParser.h:93 > + // Used by parseDocumentFragment Normally we don’t write comments like this. We can learn the same thing by searching the code. And this could easily get out of date. Also, there is a missing period here, since we use sentence style for comments. 655174 3 skyul 2012-06-21 19:50:17 -0700 (In reply to comment #2) > (From update of attachment 148932 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review > > > Source/WebCore/html/parser/HTMLDocumentParser.h:93 > > + // Used by parseDocumentFragment > > Normally we don’t write comments like this. We can learn the same thing by searching the code. And this could easily get out of date. > > Also, there is a missing period here, since we use sentence style for comments. I removed the comment and landed the patch manually. Thanks. http://trac.webkit.org/changeset/120997 148932 2012-06-21 18:08:49 -0700 2012-06-21 19:50:45 -0700 Patch bug-89724-20120622100846.patch text/plain 2107 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwOTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFmNGYyMmE5MGQxNDlk ZDhjZDY2YjYwYmExODcwNzI4M2IzMWY3My4uNDdjNWM1NzllMmFhNDdlYmJjOGIxZDIwNjI2MDQ5 MTY1M2M2MGY3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTIxICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgTWFrZSBIVE1MRG9j dW1lbnRQYXJzZXI6OmNyZWF0ZShEb2N1bWVudEZyYWdtZW50KixFbGVtZW50KiwgRnJhZ21lbnRT Y3JpcHRpbmdQZXJtaXNzaW9uKSBwcml2YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJdCBpcyB1c2VkIG9ubHkgYnkgSFRNTERvY3VtZW50UGFyc2Vy OjpwYXJzZURvY3VtZW50RnJhZ21lbnQuIE5vIGJlaGF2aW9yYWwgY2hhbmdlcy4KKworICAgICAg ICAqIGh0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5oOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTERvY3VtZW50UGFyc2VyOjpjcmVhdGUpOgorICAgICAgICAoSFRNTERvY3VtZW50UGFyc2Vy KToKKwogMjAxMi0wNi0yMSAgT2xpIExhbiAgPG9saWxhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgQWRkIG1ldGhvZHMgdG8gc2VsZWN0IGJldHdlZW4gb2Zmc2V0cyBpbiBhbiBlZGl0YWJsZSBm aWVsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVu dFBhcnNlci5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2Vy LmgKaW5kZXggMmY0OTFlMmQ5N2ZiYTAxNTJhM2NjM2ViYzFhYmQ0NzU1M2UyNzM4MS4uMzNlYTg3 YWY2ZjBkMjgyYzZjODRhNTA2ODRmYjdmMGM0OTJlOTU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmgKQEAgLTYwLDExICs2MCw2IEBAIHB1 YmxpYzoKICAgICB7CiAgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgSFRNTERvY3VtZW50UGFy c2VyKGRvY3VtZW50LCByZXBvcnRFcnJvcnMpKTsKICAgICB9Ci0gICAgc3RhdGljIFBhc3NSZWZQ dHI8SFRNTERvY3VtZW50UGFyc2VyPiBjcmVhdGUoRG9jdW1lbnRGcmFnbWVudCogZnJhZ21lbnQs IEVsZW1lbnQqIGNvbnRleHRFbGVtZW50LCBGcmFnbWVudFNjcmlwdGluZ1Blcm1pc3Npb24gcGVy bWlzc2lvbikKLSAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgSFRNTERvY3VtZW50 UGFyc2VyKGZyYWdtZW50LCBjb250ZXh0RWxlbWVudCwgcGVybWlzc2lvbikpOwotICAgIH0KLQog ICAgIHZpcnR1YWwgfkhUTUxEb2N1bWVudFBhcnNlcigpOwogCiAgICAgLy8gRXhwb3NlZCBmb3Ig SFRNTFBhcnNlclNjaGVkdWxlcgpAQCAtOTUsNiArOTAsMTIgQEAgcHJvdGVjdGVkOgogICAgIEhU TUxUcmVlQnVpbGRlciogdHJlZUJ1aWxkZXIoKSBjb25zdCB7IHJldHVybiBtX3RyZWVCdWlsZGVy LmdldCgpOyB9CiAKIHByaXZhdGU6CisgICAgLy8gVXNlZCBieSBwYXJzZURvY3VtZW50RnJhZ21l bnQKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxIVE1MRG9jdW1lbnRQYXJzZXI+IGNyZWF0ZShEb2N1 bWVudEZyYWdtZW50KiBmcmFnbWVudCwgRWxlbWVudCogY29udGV4dEVsZW1lbnQsIEZyYWdtZW50 U2NyaXB0aW5nUGVybWlzc2lvbiBwZXJtaXNzaW9uKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGFk b3B0UmVmKG5ldyBIVE1MRG9jdW1lbnRQYXJzZXIoZnJhZ21lbnQsIGNvbnRleHRFbGVtZW50LCBw ZXJtaXNzaW9uKSk7CisgICAgfQorCiAgICAgLy8gRG9jdW1lbnRQYXJzZXIKICAgICB2aXJ0dWFs IHZvaWQgZGV0YWNoKCk7CiAgICAgdmlydHVhbCBib29sIGhhc0luc2VydGlvblBvaW50KCk7Cg==