89723 2012-06-21 18:02:41 -0700 Add a perf-test for innerHTML setter for a large DOM tree 2012-06-21 19:51:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 655091 0 haraken 2012-06-21 18:02:41 -0700 We want a benchmark for innerHTML setter for the following reason: - innerHTML setter is widely used in the real world. - I am planning to optimize innerHTML setter in the near future. - I want to use the innerHTML setter benchmark for the patch of bug 88834. 655096 1 148930 haraken 2012-06-21 18:04:44 -0700 Created attachment 148930 Patch 655160 2 148930 darin 2012-06-21 19:30:23 -0700 Comment on attachment 148930 Patch I’d like to see some tests in LayoutTests/perf for this that checks how the performance changes as the markup in innerHTML grows longer and more complex. 655176 3 148930 webkit.review.bot 2012-06-21 19:51:08 -0700 Comment on attachment 148930 Patch Clearing flags on attachment: 148930 Committed r120998: <http://trac.webkit.org/changeset/120998> 655177 4 webkit.review.bot 2012-06-21 19:51:14 -0700 All reviewed patches have been landed. Closing bug. 148930 2012-06-21 18:04:44 -0700 2012-06-21 19:51:08 -0700 Patch bug-89723-20120622100443.patch text/plain 2818 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwOTgzCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJlYTBjZDVhZTVk MzZlZWFkNGE0NjQ5MjMzMGIxY2JlMzQ2N2NhZTAuLjgxZmQ2YWJmZjMxOGEzYmU1NmNjZjliZWI4 ODJkMGViY2RiYmVlNzQgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzUgQEAKKzIwMTItMDYt MjEgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBh IHBlcmYtdGVzdCBmb3IgaW5uZXJIVE1MIHNldHRlciBmb3IgYSBsYXJnZSBET00gdHJlZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk3MjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3YW50IGEgYmVu Y2htYXJrIGZvciBpbm5lckhUTUwgc2V0dGVyIGZvciB0aGUgZm9sbG93aW5nIHJlYXNvbjoKKwor ICAgICAgICAtIGlubmVySFRNTCBzZXR0ZXIgaXMgd2lkZWx5IHVzZWQgaW4gdGhlIHJlYWwgd29y bGQuCisgICAgICAgIC0gSSBhbSBwbGFubmluZyB0byBvcHRpbWl6ZSBpbm5lckhUTUwgc2V0dGVy IGluIHRoZSBuZWFyIGZ1dHVyZS4KKyAgICAgICAgLSBJIHdhbnQgdG8gdXNlIHRoZSBpbm5lckhU TUwgc2V0dGVyIGJlbmNobWFyayBmb3IgdGhlIHBhdGNoIG9mIGJ1ZyA4ODgzNC4KKworICAgICAg ICBQZXJmb3JtYW5jZSByZXN1bHRzIGluIG15IExpbnV4IGRlc2t0b3A6CisKKyAgICAgICAgUkVT VUxUIFBhcnNlcjogaW5uZXJIVE1MLXNldHRlcj0gMjg5Ljc4MjY0OTk5NSBydW5zL3MKKyAgICAg ICAgbWVkaWFuPSAyOTAuMDQ2MjY5NzQxIHJ1bnMvcywgc3RkZXY9IDEuMDY1NzUxMTIyMjQgcnVu cy9zLCBtaW49IDI4Ni44MzE4MTIyNTYgcnVucy9zLCBtYXg9IDI5MS4wMDUyOTEwMDUgcnVucy9z CisKKyAgICAgICAgUkVTVUxUIFBhcnNlcjogaW5uZXJIVE1MLXNldHRlcj0gMjg5LjAyMDcwNjEz MiBydW5zL3MKKyAgICAgICAgbWVkaWFuPSAyODkuMDkzMjk4MjkyIHJ1bnMvcywgc3RkZXY9IDAu OTg1MjAzMzEzMDkzIHJ1bnMvcywgbWluPSAyODYuODMxODEyMjU2IHJ1bnMvcywgbWF4PSAyOTAu NjIwODcxODYzIHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBQYXJzZXI6IGlubmVySFRNTC1zZXR0 ZXI9IDI4OC45MTIwNTE3MDEgcnVucy9zCisgICAgICAgIG1lZGlhbj0gMjkxLjAwNTI5MTAwNSBy dW5zL3MsIHN0ZGV2PSAzLjY1MjQxMzI1NTg4IHJ1bnMvcywgbWluPSAyODMuNTA1MTU0NjM5IHJ1 bnMvcywgbWF4PSAyOTIuNTUzMTkxNDg5IHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBQYXJzZXI6 IGlubmVySFRNTC1zZXR0ZXI9IDI4OC42NDQxODY2NjYgcnVucy9zCisgICAgICAgIG1lZGlhbj0g Mjg4LjcxMzkxMDc2MSBydW5zL3MsIHN0ZGV2PSAxLjMxODg5MDUzNzE3IHJ1bnMvcywgbWluPSAy ODYuMDg1ODI1NzQ4IHJ1bnMvcywgbWF4PSAyOTAuNjIwODcxODYzIHJ1bnMvcworCisgICAgICAg IFJFU1VMVCBQYXJzZXI6IGlubmVySFRNTC1zZXR0ZXI9IDI4OC42OTg3MTQ1NzcgcnVucy9zCisg ICAgICAgIG1lZGlhbj0gMjg4LjcxMzkxMDc2MSBydW5zL3MsIHN0ZGV2PSAxLjAzOTM4MTk4MjAy IHJ1bnMvcywgbWluPSAyODYuNDU4MzMzMzMzIHJ1bnMvcywgbWF4PSAyOTAuMjM3NDY3MDE4IHJ1 bnMvcworCisgICAgICAgICogUGFyc2VyL2lubmVySFRNTC1zZXR0ZXIuaHRtbDogQWRkZWQuCisK IDIwMTItMDYtMjAgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBB ZGQgYSBwZXJmb3JtYW5jZSB0ZXN0IGZvciBwYXRocyBpbiBTVkcKZGlmZiAtLWdpdCBhL1BlcmZv cm1hbmNlVGVzdHMvUGFyc2VyL2lubmVySFRNTC1zZXR0ZXIuaHRtbCBiL1BlcmZvcm1hbmNlVGVz dHMvUGFyc2VyL2lubmVySFRNTC1zZXR0ZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lYzBmYTIwODI1YjE4 NTk0YmU3ZTI1OWZjNzAyMGI5MzRhZmNlNWYzCi0tLSAvZGV2L251bGwKKysrIGIvUGVyZm9ybWFu Y2VUZXN0cy9QYXJzZXIvaW5uZXJIVE1MLXNldHRlci5odG1sCkBAIC0wLDAgKzEsMjIgQEAKKzwh RE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMv cnVubmVyLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBnZW5lcmF0ZUJpbkRPTVRy ZWUoZGVwdGgpIHsKKyAgcmV0dXJuIGRlcHRoID09IDAgPyAidGV4dCIgOiAoIjxkaXY+IiArIGdl bmVyYXRlQmluRE9NVHJlZShkZXB0aCAtIDEpICsgZ2VuZXJhdGVCaW5ET01UcmVlKGRlcHRoIC0g MSkgKyAiPC9kaXY+Iik7Cit9CisKK3ZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJk aXYiKTsKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZGl2KTsKK3ZhciB0cmVlID0gZ2VuZXJh dGVCaW5ET01UcmVlKDEwKTsKKworUGVyZlRlc3RSdW5uZXIucnVuUGVyU2Vjb25kKHsKKyAgICBk ZXNjcmlwdGlvbjogIlRoaXMgYmVuY2htYXJrIHRlc3RzIGlubmVySFRNTCBzZXR0ZXIgZm9yIGEg bGFyZ2UgRE9NIHRyZWUiLAorICAgIHJ1bjogZnVuY3Rpb24oKSB7CisgICAgICAgIGRpdi5pbm5l ckhUTUwgPSB0cmVlOworICAgICAgICBkaXYuaW5uZXJIVE1MID0gIiI7CisgICAgfX0pOworPC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==