89720 2012-06-21 17:31:58 -0700 [Chromium] Release media resources after each LayoutTest on Android 2012-06-24 09:29:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth japhet peter tkent tony webkit.review.bot zhenghao oldest_to_newest 655068 0 abarth 2012-06-21 17:31:58 -0700 [Chromium] Release media resources after each LayoutTest on Android 655070 1 148922 abarth 2012-06-21 17:33:45 -0700 Created attachment 148922 Patch 655128 2 148922 tkent 2012-06-21 18:34:44 -0700 Comment on attachment 148922 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 > + webkit_support::ReleaseMediaResources(); I couldn't find ReleaseMediaResources() in webkit_support.h r142549. 655550 3 abarth 2012-06-22 10:17:28 -0700 (In reply to comment #2) > (From update of attachment 148922 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review > > > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 > > + webkit_support::ReleaseMediaResources(); > > I couldn't find ReleaseMediaResources() in webkit_support.h r142549. We might need to upstream some patches from the chromium-android branch to Chromium first. /me will investigate. 655619 4 abarth 2012-06-22 11:11:41 -0700 @tkent: You're totally right. I'm going to figure out how big that iceberg is. 655863 5 abarth 2012-06-22 15:53:03 -0700 Chromium CL: https://chromiumcodereview.appspot.com/10664003/ 655869 6 148922 tony 2012-06-22 15:59:42 -0700 Comment on attachment 148922 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review >>> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 >>> + webkit_support::ReleaseMediaResources(); >> >> I couldn't find ReleaseMediaResources() in webkit_support.h r142549. > > We might need to upstream some patches from the chromium-android branch to Chromium first. /me will investigate. Should we move this to resetTestController? 655872 7 148922 abarth 2012-06-22 16:02:06 -0700 Comment on attachment 148922 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review >>>> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 >>>> + webkit_support::ReleaseMediaResources(); >>> >>> I couldn't find ReleaseMediaResources() in webkit_support.h r142549. >> >> We might need to upstream some patches from the chromium-android branch to Chromium first. /me will investigate. > > Should we move this to resetTestController? Sure. 655985 8 149153 abarth 2012-06-22 18:34:48 -0700 Created attachment 149153 Patch 655986 9 abarth 2012-06-22 18:35:14 -0700 This should be ready to land once Bug 89800 lands. 656176 10 abarth 2012-06-24 00:59:51 -0700 *** Bug 66230 has been marked as a duplicate of this bug. *** 656189 11 149153 abarth 2012-06-24 01:59:18 -0700 Comment on attachment 149153 Patch Bug 89800 has landed. This patch is ready for review/landing. 656211 12 149153 webkit.review.bot 2012-06-24 09:29:43 -0700 Comment on attachment 149153 Patch Clearing flags on attachment: 149153 Committed r121118: <http://trac.webkit.org/changeset/121118> 656212 13 webkit.review.bot 2012-06-24 09:29:48 -0700 All reviewed patches have been landed. Closing bug. 148922 2012-06-21 17:33:45 -0700 2012-06-22 18:34:42 -0700 Patch bug-89720-20120621173345.patch text/plain 1494 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyMDk4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDEyLTA2LTIxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBSZWxlYXNlIG1lZGlhIHJlc291cmNlcyBhZnRlciBlYWNoIExh eW91dFRlc3Qgb24gQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODk3MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgTGF5b3V0VGVzdHMgY2FuIGhhbmcgd2hlbiBydW4gb24gQW5kcm9pZCBi ZWNhdXNlIHdlIHNvbWV0aW1lcyBydW4KKyAgICAgICAgb3V0IG9mIG1lZGlhIHJlc291cmNlcy4g VGhpcyBwYXRjaCBjYXVzZXMgdXMgdG8gcmVsZWFzZSBvdXIgbWVkaWEKKyAgICAgICAgcmVzb3Vy Y2VzIGFmdGVyIGVhY2ggdGVzdCBpbiBvcmRlciB0byBhdm9pZCBydW5uaW5nIG91dCBvZiB0aGlz CisgICAgICAgIHJlc291cmNlLiBJbiBwcm9kdWN0aW9uLCB0aGVyZSBhcmUgb3RoZXIgbWVjaGFu aXNtcyB0aGF0IG1hbmFnZSB0aGlzCisgICAgICAgIHJlc291cmNlLgorCisgICAgICAgICogRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocnVuVGVz dCk6CisKIDIwMTItMDYtMjEgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgRFJUL1dUUiBweXRob24gaW50ZXJmYWNlIGhhbmRsZXMgYWJvdXQ6YmxhbmsgaW5j b3JyZWN0bHkKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJU cmVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1w UmVuZGVyVHJlZS5jcHAJKHJldmlzaW9uIDEyMDk3OCkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI2LDYgKzEy NiwxMCBAQCBzdGF0aWMgdm9pZCBydW5UZXN0KFRlc3RTaGVsbCYgc2hlbGwsIFRlCiAgICAgICBz aGVsbC5ydW5GaWxlVGVzdChwYXJhbXMpOwogICAgIH0KICAgICBzaGVsbC5zZXRMYXlvdXRUZXN0 VGltZW91dChvbGRUaW1lb3V0TXNlYyk7CisjaWYgT1MoQU5EUk9JRCkKKyAgICAvLyBNZWRpYSBy ZXNvdXJjZXMgYXJlIGxpbWl0ZWQgb24gQW5kcm9pZC4KKyAgICB3ZWJraXRfc3VwcG9ydDo6UmVs ZWFzZU1lZGlhUmVzb3VyY2VzKCk7CisjZW5kaWYKIH0KIAogaW50IG1haW4oaW50IGFyZ2MsIGNo YXIqIGFyZ3ZbXSkK 149153 2012-06-22 18:34:48 -0700 2012-06-24 09:29:43 -0700 Patch bug-89720-20120622183450.patch text/plain 1646 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTZhMTQyMzAzYjRhNzVlMDk1OTM2NzRiZjgzMDAwN2Rm OWNlYmJiOC4uZGEwMjA5ODMzZjcxZTUyOTM0ODg0ZTBkMGVkYzkxYjRiNWVhNGEzMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA2LTIyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBSZWxlYXNlIG1lZGlhIHJlc291cmNlcyBhZnRlciBlYWNoIExheW91dFRl c3Qgb24gQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODk3MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgTGF5b3V0VGVzdHMgY2FuIGhhbmcgd2hlbiBydW4gb24gQW5kcm9pZCBiZWNhdXNl IHdlIHNvbWV0aW1lcyBydW4KKyAgICAgICAgb3V0IG9mIG1lZGlhIHJlc291cmNlcy4gVGhpcyBw YXRjaCBjYXVzZXMgdXMgdG8gcmVsZWFzZSBvdXIgbWVkaWEKKyAgICAgICAgcmVzb3VyY2VzIGFm dGVyIGVhY2ggdGVzdCBpbiBvcmRlciB0byBhdm9pZCBydW5uaW5nIG91dCBvZiB0aGlzCisgICAg ICAgIHJlc291cmNlLiBJbiBwcm9kdWN0aW9uLCB0aGVyZSBhcmUgb3RoZXIgbWVjaGFuaXNtcyB0 aGF0IG1hbmFnZSB0aGlzCisgICAgICAgIHJlc291cmNlLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcDoKKyAgICAgICAgKFRlc3RTaGVsbDo6cmVzZXRU ZXN0Q29udHJvbGxlcik6CisKIDIwMTItMDYtMjIgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hp Y3VAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgU2hhZGVyc10gUmUtZW5hYmxlIHRoZSBDU1Mg U2hhZGVycyBjb21waWxlIHRpbWUgZmxhZyBvbiBTYWZhcmkgTWFjCmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcAppbmRleCBiODMyM2EzOWIxMzk0ZmFjMjY0ZDMz YWE5ZjQ2MWRmZGNhZGJjNjRhLi40NmJkZTJhOTA1MjQxN2NmMjdlNjVhMmJiZmQyNmI4MmUwZjE2 YjllIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwu Y3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKQEAg LTMwMyw2ICszMDMsOSBAQCB2b2lkIFRlc3RTaGVsbDo6cmVzZXRUZXN0Q29udHJvbGxlcigpCiAj aWYgRU5BQkxFKE5PVElGSUNBVElPTlMpIHx8IEVOQUJMRShMRUdBQ1lfTk9USUZJQ0FUSU9OUykK ICAgICBtX25vdGlmaWNhdGlvblByZXNlbnRlci0+cmVzZXQoKTsKICNlbmRpZgorI2lmIE9TKEFO RFJPSUQpCisgICAgd2Via2l0X3N1cHBvcnQ6OlJlbGVhc2VNZWRpYVJlc291cmNlcygpOworI2Vu ZGlmCiAgICAgbV9kcnREZXZUb29sc0FnZW50LT5yZXNldCgpOwogICAgIGlmIChtX2RydERldlRv b2xzQ2xpZW50KQogICAgICAgICBtX2RydERldlRvb2xzQ2xpZW50LT5yZXNldCgpOwo=