89716 2012-06-21 17:21:43 -0700 Web Inspector: exception in TimelinePresentationModel when recording timeline 2012-06-21 18:30:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 655054 0 caseq 2012-06-21 17:21:43 -0700 0. Open WebInspector 1. Switch to Timeline panel 2. Press record 3. Reload 4. Observe JS exception in TimelinePresentationModel.filterRecords This is a regression introduced by r120891 655057 1 148918 caseq 2012-06-21 17:23:11 -0700 Created attachment 148918 Patch 655082 2 148918 pfeldman 2012-06-21 17:50:05 -0700 Comment on attachment 148918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148918&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:499 > + var haveVisibleRecords = false; hasVisibleRecords 655119 3 caseq 2012-06-21 18:30:37 -0700 Committed r120988: <http://trac.webkit.org/changeset/120988> 148918 2012-06-21 17:23:11 -0700 2012-06-21 17:50:04 -0700 Patch bug-89716-20120621172311.patch text/plain 4903 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwOTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQyNjQyY2Q4NmNlNmU4 NDQ1NjZjYWM0ZjRjY2E0Nzg1NmFkMDhjYi4uNjZhYmMwOTBlNzIxYjgzOWM2ZDQ4NGQ3ZWRlMTUy OTExZWVkOWRiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTIxICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogZXhjZXB0aW9uIGluIFRpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwgd2hlbiByZWNvcmRpbmcg dGltZWxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg5NzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUuX2lubmVyQWRkUmVjb3JkVG9UaW1lbGluZS5w cm9jZXNzUmVjb3JkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3Rv dHlwZS5faW5uZXJBZGRSZWNvcmRUb1RpbWVsaW5lKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbC5wcm90b3R5cGUuZmlsdGVyZWRSZWNvcmRzKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVByZXNlbnRhdGlvbk1vZGVsLnByb3RvdHlw ZS5pc1Zpc2libGUpOgorCiAyMDEyLTA2LTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFNocmluayBOb2RlTGlzdHNOb2RlRGF0YQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzCmluZGV4IDQyNTE4 MWNhODFiMWYwNzM5OTdlOTQ3OWUyODk1Yzg1N2RiMjQwNjAuLmU4YTUxYjZlYzNkN2VjNTc4OWE5 NTg0OGRlNmE0MjFlNDRlYjQ2NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTQ5NiwxNCArNDk2LDE4IEBAIFdlYklu c3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgKyt0aGlzLl9hbGxS ZWNvcmRzQ291bnQ7CiAgICAgICAgIHZhciByZWNvcmRUeXBlcyA9IFdlYkluc3BlY3Rvci5UaW1l bGluZU1vZGVsLlJlY29yZFR5cGU7CiAgICAgICAgIHZhciB0aW1lU3RhbXBSZWNvcmRzID0gdGhp cy5fdGltZVN0YW1wUmVjb3JkczsKLSAgICAgICAgZnVuY3Rpb24gYWRkVGltZXN0YW1wUmVjb3Jk cyhyZWNvcmQpCisgICAgICAgIHZhciBoYXZlVmlzaWJsZVJlY29yZHMgPSBmYWxzZTsKKyAgICAg ICAgdmFyIHByZXNlbnRhdGlvbk1vZGVsID0gdGhpcy5fcHJlc2VudGF0aW9uTW9kZWw7CisgICAg ICAgIGZ1bmN0aW9uIHByb2Nlc3NSZWNvcmQocmVjb3JkKQogICAgICAgICB7CiAgICAgICAgICAg ICBpZiAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwuaXNFdmVudERpdmlk ZXIocmVjb3JkKSkKICAgICAgICAgICAgICAgICB0aW1lU3RhbXBSZWNvcmRzLnB1c2gocmVjb3Jk KTsKKyAgICAgICAgICAgIGhhdmVWaXNpYmxlUmVjb3JkcyB8PSBwcmVzZW50YXRpb25Nb2RlbC5p c1Zpc2libGUocmVjb3JkKTsKICAgICAgICAgfQogICAgICAgICB2YXIgcmVjb3JkcyA9IFsgZm9y bWF0dGVkUmVjb3JkIF07Ci0gICAgICAgIFdlYkluc3BlY3Rvci5UaW1lbGluZVByZXNlbnRhdGlv bk1vZGVsLmZvckFsbFJlY29yZHMocmVjb3JkcywgYWRkVGltZXN0YW1wUmVjb3Jkcyk7Ci0gICAg ICAgIHJldHVybiAhIXRoaXMuX3ByZXNlbnRhdGlvbk1vZGVsLmZpbHRlclJlY29yZHMocmVjb3Jk cykubGVuZ3RoIHx8IGZvcm1hdHRlZFJlY29yZC5wYXJlbnQgIT09IHRoaXMuX3ByZXNlbnRhdGlv bk1vZGVsLnJvb3RSZWNvcmQ7CisgICAgICAgIFdlYkluc3BlY3Rvci5UaW1lbGluZVByZXNlbnRh dGlvbk1vZGVsLmZvckFsbFJlY29yZHMocmVjb3JkcywgcHJvY2Vzc1JlY29yZCk7CisgICAgICAg IC8vIFRlbGwgY2FsbGVyIHVwZGF0ZSBpcyBuZWNlc3NhcnkgZWl0aGVyIGlmIHdlIGFkZGVkIGEg dmlzaWJsZSByZWNvcmQgb3IgaWYgd2UgcmUtcGFyZW50ZWQgYSByZWNvcmQuCisgICAgICAgIHJl dHVybiBoYXZlVmlzaWJsZVJlY29yZHMgfHwgZm9ybWF0dGVkUmVjb3JkLnBhcmVudCAhPT0gdGhp cy5fcHJlc2VudGF0aW9uTW9kZWwucm9vdFJlY29yZDsKICAgICB9LAogCiAgICAgc2lkZWJhclJl c2l6ZWQ6IGZ1bmN0aW9uKGV2ZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9UaW1lbGluZVByZXNlbnRhdGlvbk1vZGVsLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVByZXNlbnRhdGlvbk1vZGVsLmpzCmluZGV4 IGViOTFhMDY0YjA2N2JmNjYxMTI2ZDA4ZTQ5MTBiMzJjNjc4MGQ0YjUuLjdlZGFmNjViNGY5YmE0 MGE1Zjg2YWM2MTQ5NDllMzEyODdjZjlkYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbC5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwu anMKQEAgLTI5NSwzMSArMjk1LDkgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUHJlc2VudGF0aW9u TW9kZWwucHJvdG90eXBlID0gewogCiAgICAgZmlsdGVyZWRSZWNvcmRzOiBmdW5jdGlvbigpCiAg ICAgewotICAgICAgICByZXR1cm4gdGhpcy5maWx0ZXJSZWNvcmRzKHRoaXMuX3Jvb3RSZWNvcmQu Y2hpbGRyZW4pOwotICAgIH0sCi0KLSAgICBmaWx0ZXJSZWNvcmRzOiBmdW5jdGlvbihyZWNvcmRz KQotICAgIHsKLSAgICAgICAgZnVuY3Rpb24gZmlsdGVyKHJlY29yZCkKLSAgICAgICAgewotICAg ICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLl9maWx0ZXJzLmxlbmd0aDsgKytpKSB7 Ci0gICAgICAgICAgICAgICAgaWYgKCF0aGlzLl9maWx0ZXJzW2ldLmFjY2VwdChyZWNvcmQpKQot ICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICB9Ci0gICAgICAg ICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgfQotICAgICAgICByZXR1cm4gdGhpcy5faW5uZXJG aWx0ZXJSZWNvcmRzKGZpbHRlci5iaW5kKHRoaXMpLCByZWNvcmRzKTsKLSAgICB9LAotCi0gICAg LyoqCi0gICAgICogQHBhcmFtIHtmdW5jdGlvbihXZWJJbnNwZWN0b3IuVGltZWxpbmVQcmVzZW50 YXRpb25Nb2RlbC5SZWNvcmQpOmJvb2xlYW59IGZpbHRlcgotICAgICAqIEBwYXJhbSB7QXJyYXku PFdlYkluc3BlY3Rvci5UaW1lbGluZVByZXNlbnRhdGlvbk1vZGVsLlJlY29yZD59IGlucHV0UmVj b3JkcwotICAgICAqLwotICAgIF9pbm5lckZpbHRlclJlY29yZHM6IGZ1bmN0aW9uKGZpbHRlciwg aW5wdXRSZWNvcmRzKQotICAgIHsKICAgICAgICAgdmFyIHJlY29yZHNJbldpbmRvdyA9IFtdOwog Ci0gICAgICAgIHZhciBzdGFjayA9IFt7Y2hpbGRyZW46IGlucHV0UmVjb3JkcywgaW5kZXg6IDAs IHBhcmVudElzQ29sbGFwc2VkOiBmYWxzZX1dOworICAgICAgICB2YXIgc3RhY2sgPSBbe2NoaWxk cmVuOiB0aGlzLl9yb290UmVjb3JkLmNoaWxkcmVuLCBpbmRleDogMCwgcGFyZW50SXNDb2xsYXBz ZWQ6IGZhbHNlfV07CiAgICAgICAgIHdoaWxlIChzdGFjay5sZW5ndGgpIHsKICAgICAgICAgICAg IHZhciBlbnRyeSA9IHN0YWNrW3N0YWNrLmxlbmd0aCAtIDFdOwogICAgICAgICAgICAgdmFyIHJl Y29yZHMgPSBlbnRyeS5jaGlsZHJlbjsKQEAgLTMyNyw3ICszMDUsNyBAQCBXZWJJbnNwZWN0b3Iu VGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAg IHZhciByZWNvcmQgPSByZWNvcmRzW2VudHJ5LmluZGV4XTsKICAgICAgICAgICAgICAgICAgKytl bnRyeS5pbmRleDsKIAotICAgICAgICAgICAgICAgICBpZiAoZmlsdGVyKHJlY29yZCkpIHsKKyAg ICAgICAgICAgICAgICAgaWYgKHRoaXMuaXNWaXNpYmxlKHJlY29yZCkpIHsKICAgICAgICAgICAg ICAgICAgICAgICsrcmVjb3JkLnBhcmVudC5faW52aXNpYmxlQ2hpbGRyZW5Db3VudDsKICAgICAg ICAgICAgICAgICAgICAgIGlmICghZW50cnkucGFyZW50SXNDb2xsYXBzZWQpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgcmVjb3Jkc0luV2luZG93LnB1c2gocmVjb3JkKTsKQEAgLTM0OCw2ICsz MjYsMTUgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwucHJvdG90eXBl ID0gewogICAgICAgICB9CiAKICAgICAgICAgcmV0dXJuIHJlY29yZHNJbldpbmRvdzsKKyAgICB9 LAorCisgICAgaXNWaXNpYmxlOiBmdW5jdGlvbihyZWNvcmQpCisgICAgeworICAgICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IHRoaXMuX2ZpbHRlcnMubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAg IGlmICghdGhpcy5fZmlsdGVyc1tpXS5hY2NlcHQocmVjb3JkKSkKKyAgICAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogfQog Cg==