89672 2012-06-21 09:50:47 -0700 Remove two more member variables found by clang's Wunused-private-field 2012-06-21 10:19:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 654615 0 thakis 2012-06-21 09:50:47 -0700 Remove two more member variables found by clang's Wunused-private-field 654616 1 148822 thakis 2012-06-21 09:51:10 -0700 Created attachment 148822 Patch 654617 2 148823 thakis 2012-06-21 09:52:11 -0700 Created attachment 148823 Patch 654651 3 148823 webkit.review.bot 2012-06-21 10:19:34 -0700 Comment on attachment 148823 Patch Clearing flags on attachment: 148823 Committed r120935: <http://trac.webkit.org/changeset/120935> 654652 4 webkit.review.bot 2012-06-21 10:19:43 -0700 All reviewed patches have been landed. Closing bug. 148822 2012-06-21 09:51:10 -0700 2012-06-21 09:52:08 -0700 Patch bug-89672-20120621095109.patch text/plain 2849 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjcwYThiNmUyYTQwZmFm OGEzYjU0YWI5Zjg4YWNkNTU2ZDM0Y2Y1OC4uMmQ4YzRiZmEwOTczODg5YTZiYmNkMzUxMTk0MjZm NTVlYjI4MDkwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTIxICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdHdvIG1vcmUg bWVtYmVyIHZhcmlhYmxlcyBmb3VuZCBieSBjbGFuZydzIFd1bnVzZWQtcHJpdmF0ZS1maWVsZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk2NzIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvc2hh ZG93L01lZGlhQ29udHJvbFJvb3RFbGVtZW50Q2hyb21pdW0uaDoKKyAgICAgICAgKE1lZGlhQ29u dHJvbFJvb3RFbGVtZW50Q2hyb21pdW0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRkVDdXN0b21GaWx0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RkVDdXN0b21GaWx0 ZXI6OkZFQ3VzdG9tRmlsdGVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJz L0ZFQ3VzdG9tRmlsdGVyLmg6CisgICAgICAgIChGRUN1c3RvbUZpbHRlcik6CisKIDIwMTItMDYt MTkgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFzc2VydGlv biBmb3IgZXZlbnQncyB0YXJnZXQgaXMgd3JvbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xSb290RWxlbWVudENocm9taXVtLmggYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xSb290RWxlbWVudENocm9taXVtLmgKaW5k ZXggZjEwYjcyOGU4MGUyMWRhNTY5ZDQ1ODM0MDVmZjY4MTQyNjU3YTQ5MC4uOTA0ZjA0YzhhZjg5 NmNkYTk3MjY0ODMzNDQ3NzY2NjcyMmI1NWYxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9zaGFkb3cvTWVkaWFDb250cm9sUm9vdEVsZW1lbnRDaHJvbWl1bS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbFJvb3RFbGVtZW50Q2hyb21pdW0uaApA QCAtMTQwLDcgKzE0MCw2IEBAIHByaXZhdGU6CiAgICAgTWVkaWFDb250cm9sQ3VycmVudFRpbWVE aXNwbGF5RWxlbWVudCogbV9jdXJyZW50VGltZURpc3BsYXk7CiAgICAgTWVkaWFDb250cm9sVGlt ZVJlbWFpbmluZ0Rpc3BsYXlFbGVtZW50KiBtX2R1cmF0aW9uRGlzcGxheTsKICAgICBNZWRpYUNv bnRyb2xUaW1lbGluZUVsZW1lbnQqIG1fdGltZWxpbmU7Ci0gICAgTWVkaWFDb250cm9sVGltZWxp bmVDb250YWluZXJFbGVtZW50KiBtX3RpbWVsaW5lQ29udGFpbmVyOwogICAgIE1lZGlhQ29udHJv bFBhbmVsTXV0ZUJ1dHRvbkVsZW1lbnQqIG1fcGFuZWxNdXRlQnV0dG9uOwogICAgIE1lZGlhQ29u dHJvbFZvbHVtZVNsaWRlckVsZW1lbnQqIG1fdm9sdW1lU2xpZGVyOwogI2lmIEVOQUJMRShGVUxM U0NSRUVOX01FRElBX0NPTlRST0xTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcAppbmRleCA0OWY4Y2M2 YmE4MGIyNjZhMTczYWE4N2M1YjZkNGY0NTc5OWQ3OTM4Li4wNDk5ZTljMDFmOWRhODczYTU0NGM5 NzA5NzZlMDI1MDU0NzJkOTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcApAQCAtODUsNyArODUs NiBAQCBGRUN1c3RvbUZpbHRlcjo6RkVDdXN0b21GaWx0ZXIoRmlsdGVyKiBmaWx0ZXIsIEN1c3Rv bUZpbHRlckdsb2JhbENvbnRleHQqIGN1c3RvbQogICAgICwgbV9wYXJhbWV0ZXJzKHBhcmFtZXRl cnMpCiAgICAgLCBtX21lc2hSb3dzKG1lc2hSb3dzKQogICAgICwgbV9tZXNoQ29sdW1ucyhtZXNo Q29sdW1ucykKLSAgICAsIG1fbWVzaEJveFR5cGUobWVzaEJveFR5cGUpCiAgICAgLCBtX21lc2hU eXBlKG1lc2hUeXBlKQogewogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5oCmluZGV4IDAzYjlmODAxYWJkNzRj MjA0YzVkMDE5YzBlY2QzZThhNDE2OGU3NjcuLjM4OTc1ZGFlMGFiYWQxM2JhMjU2YTZlZWY1YzI5 MWFkYWNmNzMyODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRkVDdXN0b21GaWx0ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmgKQEAgLTk4LDcgKzk4LDYgQEAgcHJpdmF0 ZToKIAogICAgIHVuc2lnbmVkIG1fbWVzaFJvd3M7CiAgICAgdW5zaWduZWQgbV9tZXNoQ29sdW1u czsKLSAgICBDdXN0b21GaWx0ZXJPcGVyYXRpb246Ok1lc2hCb3hUeXBlIG1fbWVzaEJveFR5cGU7 CiAgICAgQ3VzdG9tRmlsdGVyT3BlcmF0aW9uOjpNZXNoVHlwZSBtX21lc2hUeXBlOwogfTsKIAo= 148823 2012-06-21 09:52:11 -0700 2012-06-21 10:19:33 -0700 Patch bug-89672-20120621095210.patch text/plain 3523 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjcwYThiNmUyYTQwZmFm OGEzYjU0YWI5Zjg4YWNkNTU2ZDM0Y2Y1OC4uMmQ4YzRiZmEwOTczODg5YTZiYmNkMzUxMTk0MjZm NTVlYjI4MDkwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTIxICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdHdvIG1vcmUg bWVtYmVyIHZhcmlhYmxlcyBmb3VuZCBieSBjbGFuZydzIFd1bnVzZWQtcHJpdmF0ZS1maWVsZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk2NzIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvc2hh ZG93L01lZGlhQ29udHJvbFJvb3RFbGVtZW50Q2hyb21pdW0uaDoKKyAgICAgICAgKE1lZGlhQ29u dHJvbFJvb3RFbGVtZW50Q2hyb21pdW0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRkVDdXN0b21GaWx0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RkVDdXN0b21GaWx0 ZXI6OkZFQ3VzdG9tRmlsdGVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJz L0ZFQ3VzdG9tRmlsdGVyLmg6CisgICAgICAgIChGRUN1c3RvbUZpbHRlcik6CisKIDIwMTItMDYt MTkgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFzc2VydGlv biBmb3IgZXZlbnQncyB0YXJnZXQgaXMgd3JvbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xSb290RWxlbWVudENocm9taXVtLmggYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xSb290RWxlbWVudENocm9taXVtLmgKaW5k ZXggZjEwYjcyOGU4MGUyMWRhNTY5ZDQ1ODM0MDVmZjY4MTQyNjU3YTQ5MC4uOTA0ZjA0YzhhZjg5 NmNkYTk3MjY0ODMzNDQ3NzY2NjcyMmI1NWYxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9zaGFkb3cvTWVkaWFDb250cm9sUm9vdEVsZW1lbnRDaHJvbWl1bS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbFJvb3RFbGVtZW50Q2hyb21pdW0uaApA QCAtMTQwLDcgKzE0MCw2IEBAIHByaXZhdGU6CiAgICAgTWVkaWFDb250cm9sQ3VycmVudFRpbWVE aXNwbGF5RWxlbWVudCogbV9jdXJyZW50VGltZURpc3BsYXk7CiAgICAgTWVkaWFDb250cm9sVGlt ZVJlbWFpbmluZ0Rpc3BsYXlFbGVtZW50KiBtX2R1cmF0aW9uRGlzcGxheTsKICAgICBNZWRpYUNv bnRyb2xUaW1lbGluZUVsZW1lbnQqIG1fdGltZWxpbmU7Ci0gICAgTWVkaWFDb250cm9sVGltZWxp bmVDb250YWluZXJFbGVtZW50KiBtX3RpbWVsaW5lQ29udGFpbmVyOwogICAgIE1lZGlhQ29udHJv bFBhbmVsTXV0ZUJ1dHRvbkVsZW1lbnQqIG1fcGFuZWxNdXRlQnV0dG9uOwogICAgIE1lZGlhQ29u dHJvbFZvbHVtZVNsaWRlckVsZW1lbnQqIG1fdm9sdW1lU2xpZGVyOwogI2lmIEVOQUJMRShGVUxM U0NSRUVOX01FRElBX0NPTlRST0xTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcAppbmRleCA0OWY4Y2M2 YmE4MGIyNjZhMTczYWE4N2M1YjZkNGY0NTc5OWQ3OTM4Li5jMjE0MjI2OTMxMTEyY2VlNWJjNGM2 MGNlNDgyNWZmYTRiODhjNGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcApAQCAtNzQsNyArNzQs NyBAQCBzdGF0aWMgdm9pZCBvcnRob2dvbmFsUHJvamVjdGlvbk1hdHJpeChUcmFuc2Zvcm1hdGlv bk1hdHJpeCYgbWF0cml4LCBmbG9hdCBsZWZ0LAogfQogCiBGRUN1c3RvbUZpbHRlcjo6RkVDdXN0 b21GaWx0ZXIoRmlsdGVyKiBmaWx0ZXIsIEN1c3RvbUZpbHRlckdsb2JhbENvbnRleHQqIGN1c3Rv bUZpbHRlckdsb2JhbENvbnRleHQsIFBhc3NSZWZQdHI8Q3VzdG9tRmlsdGVyUHJvZ3JhbT4gcHJv Z3JhbSwgY29uc3QgQ3VzdG9tRmlsdGVyUGFyYW1ldGVyTGlzdCYgcGFyYW1ldGVycywKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBtZXNoUm93cywgdW5zaWduZWQgbWVz aENvbHVtbnMsIEN1c3RvbUZpbHRlck9wZXJhdGlvbjo6TWVzaEJveFR5cGUgbWVzaEJveFR5cGUs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbWVzaFJvd3MsIHVuc2ln bmVkIG1lc2hDb2x1bW5zLCBDdXN0b21GaWx0ZXJPcGVyYXRpb246Ok1lc2hCb3hUeXBlLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEN1c3RvbUZpbHRlck9wZXJhdGlvbjo6TWVzaFR5 cGUgbWVzaFR5cGUpCiAgICAgOiBGaWx0ZXJFZmZlY3QoZmlsdGVyKQogICAgICwgbV9nbG9iYWxD b250ZXh0KGN1c3RvbUZpbHRlckdsb2JhbENvbnRleHQpCkBAIC04NSw3ICs4NSw2IEBAIEZFQ3Vz dG9tRmlsdGVyOjpGRUN1c3RvbUZpbHRlcihGaWx0ZXIqIGZpbHRlciwgQ3VzdG9tRmlsdGVyR2xv YmFsQ29udGV4dCogY3VzdG9tCiAgICAgLCBtX3BhcmFtZXRlcnMocGFyYW1ldGVycykKICAgICAs IG1fbWVzaFJvd3MobWVzaFJvd3MpCiAgICAgLCBtX21lc2hDb2x1bW5zKG1lc2hDb2x1bW5zKQot ICAgICwgbV9tZXNoQm94VHlwZShtZXNoQm94VHlwZSkKICAgICAsIG1fbWVzaFR5cGUobWVzaFR5 cGUpCiB7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9m aWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmgKaW5kZXggMDNiOWY4MDFhYmQ3NGMyMDRjNWQwMTlj MGVjZDNlOGE0MTY4ZTc2Ny4uMzg5NzVkYWUwYWJhZDEzYmEyNTZhNmVlZjVjMjkxYWRhY2Y3MzI4 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9G RUN1c3RvbUZpbHRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRkVDdXN0b21GaWx0ZXIuaApAQCAtOTgsNyArOTgsNiBAQCBwcml2YXRlOgogCiAgICAg dW5zaWduZWQgbV9tZXNoUm93czsKICAgICB1bnNpZ25lZCBtX21lc2hDb2x1bW5zOwotICAgIEN1 c3RvbUZpbHRlck9wZXJhdGlvbjo6TWVzaEJveFR5cGUgbV9tZXNoQm94VHlwZTsKICAgICBDdXN0 b21GaWx0ZXJPcGVyYXRpb246Ok1lc2hUeXBlIG1fbWVzaFR5cGU7CiB9OwogCg==