89660 2012-06-21 07:14:18 -0700 [GTK] Add support for graphviz debug output for the gstreamer video pipeline 2012-06-25 10:48:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Enhancement --- 0 allan.xavier webkit-unassigned eric.carlson feature-media-reviews gustavo menard mrobinson pnormand webkit.review.bot oldest_to_newest 654481 0 allan.xavier 2012-06-21 07:14:18 -0700 GStreamer has a useful debugging feature where it can output a given pipeline to a Graphviz dot file. Having this feature enabled in WebKit would be helpful for debugging development/end user problems with the video pipeline. Some more information on this feature (along with an example) can be found in the GStreamer SDK documentation http://docs.gstreamer.com/display/GstSDK/Basic+tutorial+11%3A+Debugging+tools The following patch will output a dot file for errors and state changes in the video pipeline when the environment variable GST_DEBUG_DUMP_DOT_DIR is set. This is similar to how gst-launch implements the same functionality. 654482 1 148794 allan.xavier 2012-06-21 07:17:09 -0700 Created attachment 148794 Patch for supporting graphviz debug output 654558 2 pnormand 2012-06-21 08:34:41 -0700 Let me know if you need the commit-queue to land this patch. 654565 3 148794 mrobinson 2012-06-21 08:39:37 -0700 Comment on attachment 148794 Patch for supporting graphviz debug output View in context: https://bugs.webkit.org/attachment.cgi?id=148794&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:799 > + // Construct a filename for the graphviz dot file output Nit: You're missing a period at the end of this sentence. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:801 > + dotFileName = g_strdup_printf("webkit-video.%s_%s", gst_element_state_get_name(oldState), gst_element_state_get_name(newState)); It's probably better to use CString dotFileName = String::format("webkit-video.%s_%s", gst_element_state_get_name(oldState), gst_element_state_get_name(newState)).utf8(); > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:803 > + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_playBin), GST_DEBUG_GRAPH_SHOW_ALL, dotFileName); This would become: GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_playBin), GST_DEBUG_GRAPH_SHOW_ALL, dotFileName.data()); 654709 4 148844 allan.xavier 2012-06-21 11:05:46 -0700 Created attachment 148844 Patch for supporting graphviz debug output This revised patch has the following changes: * The improvements recommended by Martin in comment #3. * The string formatting call is now split onto multiple lines for better readability. * The pendingState variable has been removed (gst_message_parse_state_changed can handle null arguments). 656703 5 148844 webkit.review.bot 2012-06-25 10:48:00 -0700 Comment on attachment 148844 Patch for supporting graphviz debug output Clearing flags on attachment: 148844 Committed r121169: <http://trac.webkit.org/changeset/121169> 656704 6 webkit.review.bot 2012-06-25 10:48:06 -0700 All reviewed patches have been landed. Closing bug. 148794 2012-06-21 07:17:09 -0700 2012-06-21 11:05:46 -0700 Patch for supporting graphviz debug output 0001-GTK-Add-graphviz-debug-output-for-gstreamer-pipeline.patch text/plain 3230 allan.xavier RnJvbSAzM2U3YzI0YTEyZDc1YWM3ZWVhMTNmNjcyZTc1ZTk0MDEzNThlYjk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxhbiBYYXZpZXIgPGFsbGFuLnhhdmllckB1bmRlZmluZWRs dGQuY28udWs+CkRhdGU6IFRodSwgMjEgSnVuIDIwMTIgMTU6MTU6MTMgKzAxMDAKU3ViamVjdDog W1BBVENIXSBbR1RLXSBBZGQgZ3JhcGh2aXogZGVidWcgb3V0cHV0IGZvciBnc3RyZWFtZXIgcGlw ZWxpbmUuCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIC4uLi9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcCAgICAgIHwgICAxNiArKysrKysrKysrKysrKystCiAyIGZpbGVz IGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODEzMjBhZi4uMWUxNzg5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTIx ICBBbGxhbiBYYXZpZXIgIDxhbGxhbi54YXZpZXJAdW5kZWZpbmVkbHRkLmNvLnVrPgorCisgICAg ICAgIFtHVEtdIEFkZCBncmFwaHZpeiBkZWJ1ZyBvdXRwdXQgZm9yIGdzdHJlYW1lciB2aWRlbyBw aXBlbGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg5NjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RHVtcCB0aGUgY3VycmVudCB2aWRlbyBwaXBlbGluZSBhcyBhIGdyYXBodml6IERPVCBmaWxlIHdo ZW4gdGhlCisgICAgICAgIHBpcGVsaW5lIHN0YXRlIGNoYW5nZXMgb3Igd2hlbiBhbiBlcnJvciBv Y2NvdXJzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGUgY2hhbmdlIGlzIG9ubHkgdXNl ZnVsIGZvciBkZWJ1Z2dpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZSk6CisKIDIwMTItMDYtMjAg IFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogZG9uJ3QgcmVwb3J0IGNvbnRleHQgaWRzIGJlZm9yZSBEaWRDb21taXRMb2FkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDA1 Yjc4YjAuLmIxM2IzOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwCkBAIC03NDksNiArNzQ5LDggQEAgZ2Jvb2xlYW4gTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyOjpoYW5kbGVNZXNzYWdlKEdzdE1lc3NhZ2UqIG1lc3NhZ2UpCiAgICAgICAg IGdzdF9tZXNzYWdlX3BhcnNlX2Vycm9yKG1lc3NhZ2UsICZlcnIub3V0UHRyKCksICZkZWJ1Zy5v dXRQdHIoKSk7CiAgICAgICAgIExPR19WRVJCT1NFKE1lZGlhLCAiRXJyb3I6ICVkLCAlcyIsIGVy ci0+Y29kZSwgIGVyci0+bWVzc2FnZSk7CiAKKyAgICAgICAgR1NUX0RFQlVHX0JJTl9UT19ET1Rf RklMRV9XSVRIX1RTKEdTVF9CSU4obV9wbGF5QmluKSwgR1NUX0RFQlVHX0dSQVBIX1NIT1dfQUxM LCAid2Via2l0LXZpZGVvLmVycm9yIik7CisKICAgICAgICAgZXJyb3IgPSBNZWRpYVBsYXllcjo6 RW1wdHk7CiAgICAgICAgIGlmIChlcnItPmNvZGUgPT0gR1NUX1NUUkVBTV9FUlJPUl9DT0RFQ19O T1RfRk9VTkQKICAgICAgICAgICAgIHx8IGVyci0+Y29kZSA9PSBHU1RfU1RSRUFNX0VSUk9SX1dS T05HX1RZUEUKQEAgLTc4OCw4ICs3OTAsMjAgQEAgZ2Jvb2xlYW4gTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyOjpoYW5kbGVNZXNzYWdlKEdzdE1lc3NhZ2UqIG1lc3NhZ2UpCiAKICAgICAgICAg Ly8gSWdub3JlIHN0YXRlIGNoYW5nZXMgZnJvbSBpbnRlcm5hbCBlbGVtZW50cy4gVGhleSBhcmUK ICAgICAgICAgLy8gZm9yd2FyZGVkIHRvIHBsYXliaW4yIGFueXdheS4KLSAgICAgICAgaWYgKEdT VF9NRVNTQUdFX1NSQyhtZXNzYWdlKSA9PSByZWludGVycHJldF9jYXN0PEdzdE9iamVjdCo+KG1f cGxheUJpbikpCisgICAgICAgIGlmIChHU1RfTUVTU0FHRV9TUkMobWVzc2FnZSkgPT0gcmVpbnRl cnByZXRfY2FzdDxHc3RPYmplY3QqPihtX3BsYXlCaW4pKSB7CiAgICAgICAgICAgICB1cGRhdGVT dGF0ZXMoKTsKKworICAgICAgICAgICAgR3N0U3RhdGUgb2xkU3RhdGUsIG5ld1N0YXRlLCBwZW5k aW5nU3RhdGU7CisgICAgICAgICAgICBnY2hhciogZG90RmlsZU5hbWU7CisKKyAgICAgICAgICAg IC8vIENvbnN0cnVjdCBhIGZpbGVuYW1lIGZvciB0aGUgZ3JhcGh2aXogZG90IGZpbGUgb3V0cHV0 CisgICAgICAgICAgICBnc3RfbWVzc2FnZV9wYXJzZV9zdGF0ZV9jaGFuZ2VkKG1lc3NhZ2UsICZv bGRTdGF0ZSwgJm5ld1N0YXRlLCAmcGVuZGluZ1N0YXRlKTsKKyAgICAgICAgICAgIGRvdEZpbGVO YW1lID0gZ19zdHJkdXBfcHJpbnRmKCJ3ZWJraXQtdmlkZW8uJXNfJXMiLCBnc3RfZWxlbWVudF9z dGF0ZV9nZXRfbmFtZShvbGRTdGF0ZSksIGdzdF9lbGVtZW50X3N0YXRlX2dldF9uYW1lKG5ld1N0 YXRlKSk7CisKKyAgICAgICAgICAgIEdTVF9ERUJVR19CSU5fVE9fRE9UX0ZJTEVfV0lUSF9UUyhH U1RfQklOKG1fcGxheUJpbiksIEdTVF9ERUJVR19HUkFQSF9TSE9XX0FMTCwgZG90RmlsZU5hbWUp OworCisgICAgICAgICAgICBnX2ZyZWUoZG90RmlsZU5hbWUpOworICAgICAgICB9CiAgICAgICAg IGJyZWFrOwogICAgIGNhc2UgR1NUX01FU1NBR0VfQlVGRkVSSU5HOgogICAgICAgICBwcm9jZXNz QnVmZmVyaW5nU3RhdHMobWVzc2FnZSk7Ci0tIAoxLjcuOS41Cgo= 148844 2012-06-21 11:05:46 -0700 2012-06-25 10:48:00 -0700 Patch for supporting graphviz debug output 0001-GTK-Add-graphviz-debug-output-for-gstreamer-pipeline.patch text/plain 3267 allan.xavier RnJvbSA0ZTY1OGJlYTc4NWY1MjQyMzdmMDU5M2I1Yzc5ZDlkZjU4ZGFjY2NmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxhbiBYYXZpZXIgPGFsbGFuLnhhdmllckB1bmRlZmluZWRs dGQuY28udWs+CkRhdGU6IFRodSwgMjEgSnVuIDIwMTIgMTg6NDA6MTEgKzAxMDAKU3ViamVjdDog W1BBVENIXSBbR1RLXSBBZGQgZ3JhcGh2aXogZGVidWcgb3V0cHV0IGZvciBnc3RyZWFtZXIgcGlw ZWxpbmUuCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIC4uLi9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcCAgICAgIHwgICAxNSArKysrKysrKysrKysrKy0KIDIgZmlsZXMg Y2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBm MmM2MjgxLi43Njg0M2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDYtMjEg IEFsbGFuIFhhdmllciAgPGFsbGFuLnhhdmllckB1bmRlZmluZWRsdGQuY28udWs+CisKKyAgICAg ICAgW0dUS10gQWRkIGdyYXBodml6IGRlYnVnIG91dHB1dCBmb3IgdGhlIGdzdHJlYW1lciB2aWRl byBwaXBlbGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg5NjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRHVtcCB0aGUgY3VycmVudCB2aWRlbyBwaXBlbGluZSBhcyBhIGdyYXBodml6IERPVCBmaWxl IHdoZW4gdGhlCisgICAgICAgIHBpcGVsaW5lIHN0YXRlIGNoYW5nZXMgb3Igd2hlbiBhbiBlcnJv ciBvY2NvdXJzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGUgY2hhbmdlIGlzIG9ubHkg dXNlZnVsIGZvciBkZWJ1Z2dpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZSk6CisKIDIwMTItMDYt MjEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogZG8gbm90IGFkZCBzZXBhcmF0b3IgdG8gdGhlIGVuZCBvZiB0aGUgY29udGV4 dCBtZW51LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cAppbmRleCAwNWI3OGIwLi43MDA4OGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtNzQ5LDYgKzc0OSw4IEBAIGdib29sZWFuIE1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZShHc3RNZXNzYWdlKiBtZXNzYWdl KQogICAgICAgICBnc3RfbWVzc2FnZV9wYXJzZV9lcnJvcihtZXNzYWdlLCAmZXJyLm91dFB0cigp LCAmZGVidWcub3V0UHRyKCkpOwogICAgICAgICBMT0dfVkVSQk9TRShNZWRpYSwgIkVycm9yOiAl ZCwgJXMiLCBlcnItPmNvZGUsICBlcnItPm1lc3NhZ2UpOwogCisgICAgICAgIEdTVF9ERUJVR19C SU5fVE9fRE9UX0ZJTEVfV0lUSF9UUyhHU1RfQklOKG1fcGxheUJpbiksIEdTVF9ERUJVR19HUkFQ SF9TSE9XX0FMTCwgIndlYmtpdC12aWRlby5lcnJvciIpOworCiAgICAgICAgIGVycm9yID0gTWVk aWFQbGF5ZXI6OkVtcHR5OwogICAgICAgICBpZiAoZXJyLT5jb2RlID09IEdTVF9TVFJFQU1fRVJS T1JfQ09ERUNfTk9UX0ZPVU5ECiAgICAgICAgICAgICB8fCBlcnItPmNvZGUgPT0gR1NUX1NUUkVB TV9FUlJPUl9XUk9OR19UWVBFCkBAIC03ODgsOCArNzkwLDE5IEBAIGdib29sZWFuIE1lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZShHc3RNZXNzYWdlKiBtZXNzYWdlKQog CiAgICAgICAgIC8vIElnbm9yZSBzdGF0ZSBjaGFuZ2VzIGZyb20gaW50ZXJuYWwgZWxlbWVudHMu IFRoZXkgYXJlCiAgICAgICAgIC8vIGZvcndhcmRlZCB0byBwbGF5YmluMiBhbnl3YXkuCi0gICAg ICAgIGlmIChHU1RfTUVTU0FHRV9TUkMobWVzc2FnZSkgPT0gcmVpbnRlcnByZXRfY2FzdDxHc3RP YmplY3QqPihtX3BsYXlCaW4pKQorICAgICAgICBpZiAoR1NUX01FU1NBR0VfU1JDKG1lc3NhZ2Up ID09IHJlaW50ZXJwcmV0X2Nhc3Q8R3N0T2JqZWN0Kj4obV9wbGF5QmluKSkgewogICAgICAgICAg ICAgdXBkYXRlU3RhdGVzKCk7CisKKyAgICAgICAgICAgIC8vIENvbnN0cnVjdCBhIGZpbGVuYW1l IGZvciB0aGUgZ3JhcGh2aXogZG90IGZpbGUgb3V0cHV0LgorICAgICAgICAgICAgR3N0U3RhdGUg b2xkU3RhdGUsIG5ld1N0YXRlOworICAgICAgICAgICAgZ3N0X21lc3NhZ2VfcGFyc2Vfc3RhdGVf Y2hhbmdlZChtZXNzYWdlLCAmb2xkU3RhdGUsICZuZXdTdGF0ZSwgMCk7CisKKyAgICAgICAgICAg IENTdHJpbmcgZG90RmlsZU5hbWUgPSBTdHJpbmc6OmZvcm1hdCgid2Via2l0LXZpZGVvLiVzXyVz IiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnc3Rf ZWxlbWVudF9zdGF0ZV9nZXRfbmFtZShvbGRTdGF0ZSksCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3N0X2VsZW1lbnRfc3RhdGVfZ2V0X25hbWUobmV3 U3RhdGUpKS51dGY4KCk7CisKKyAgICAgICAgICAgIEdTVF9ERUJVR19CSU5fVE9fRE9UX0ZJTEVf V0lUSF9UUyhHU1RfQklOKG1fcGxheUJpbiksIEdTVF9ERUJVR19HUkFQSF9TSE9XX0FMTCwgZG90 RmlsZU5hbWUuZGF0YSgpKTsKKyAgICAgICAgfQogICAgICAgICBicmVhazsKICAgICBjYXNlIEdT VF9NRVNTQUdFX0JVRkZFUklORzoKICAgICAgICAgcHJvY2Vzc0J1ZmZlcmluZ1N0YXRzKG1lc3Nh Z2UpOwotLSAKMS43LjkuNQoK